From affacf2f37db767ab8df7f2db6cd9e0e9b0a2b8a Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Sun, 28 Dec 2014 16:20:31 -0800 Subject: [PATCH] [ft] Open blob in READONLY mode HB_MEMORY_MODE_READONLY_MAY_MAKE_WRITABLE is deprecated and fairly useless now. --- src/hb-ft.cc | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/hb-ft.cc b/src/hb-ft.cc index c42d484c4..c3b58f8ff 100644 --- a/src/hb-ft.cc +++ b/src/hb-ft.cc @@ -340,11 +340,7 @@ hb_ft_face_create (FT_Face ft_face, blob = hb_blob_create ((const char *) ft_face->stream->base, (unsigned int) ft_face->stream->size, - /* TODO: We assume that it's mmap()'ed, but FreeType code - * suggests that there are cases we reach here but font is - * not mmapped. For example, when mmap() fails. No idea - * how to deal with it better here. */ - HB_MEMORY_MODE_READONLY_MAY_MAKE_WRITABLE, + HB_MEMORY_MODE_READONLY, ft_face, destroy); face = hb_face_create (blob, ft_face->face_index); hb_blob_destroy (blob);