diff --git a/src/Makefile.am b/src/Makefile.am index 9b583fdbc..fb7f79161 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -87,6 +87,8 @@ HBSOURCES += \ hb-ot-shape-complex-private.hh \ hb-ot-shape-normalize-private.hh \ hb-ot-shape-normalize.cc \ + hb-ot-shape-position-fallback-private.hh \ + hb-ot-shape-position-fallback.cc \ hb-ot-shape-private.hh \ $(NULL) HBHEADERS += \ diff --git a/src/hb-ot-shape-position-fallback-private.hh b/src/hb-ot-shape-position-fallback-private.hh new file mode 100644 index 000000000..f84752eb8 --- /dev/null +++ b/src/hb-ot-shape-position-fallback-private.hh @@ -0,0 +1,39 @@ +/* + * Copyright © 2012 Google, Inc. + * + * This is part of HarfBuzz, a text shaping library. + * + * Permission is hereby granted, without written agreement and without + * license or royalty fees, to use, copy, modify, and distribute this + * software and its documentation for any purpose, provided that the + * above copyright notice and the following two paragraphs appear in + * all copies of this software. + * + * IN NO EVENT SHALL THE COPYRIGHT HOLDER BE LIABLE TO ANY PARTY FOR + * DIRECT, INDIRECT, SPECIAL, INCIDENTAL, OR CONSEQUENTIAL DAMAGES + * ARISING OUT OF THE USE OF THIS SOFTWARE AND ITS DOCUMENTATION, EVEN + * IF THE COPYRIGHT HOLDER HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH + * DAMAGE. + * + * THE COPYRIGHT HOLDER SPECIFICALLY DISCLAIMS ANY WARRANTIES, INCLUDING, + * BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND + * FITNESS FOR A PARTICULAR PURPOSE. THE SOFTWARE PROVIDED HEREUNDER IS + * ON AN "AS IS" BASIS, AND THE COPYRIGHT HOLDER HAS NO OBLIGATION TO + * PROVIDE MAINTENANCE, SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS. + * + * Google Author(s): Behdad Esfahbod + */ + +#ifndef HB_OT_POSITION_FALLBACK_PRIVATE_HH +#define HB_OT_POSITION_FALLBACK_PRIVATE_HH + +#include "hb-private.hh" + +#include "hb-ot-shape-private.hh" + + +HB_INTERNAL void _hb_ot_shape_position_fallback (const hb_ot_shape_plan_t *plan, + hb_font_t *font, + hb_buffer_t *buffer); + +#endif /* HB_OT_POSITION_FALLBACK_PRIVATE_HH */ diff --git a/src/hb-ot-shape-position-fallback.cc b/src/hb-ot-shape-position-fallback.cc new file mode 100644 index 000000000..13cebe7f2 --- /dev/null +++ b/src/hb-ot-shape-position-fallback.cc @@ -0,0 +1,47 @@ +/* + * Copyright © 2011,2012 Google, Inc. + * + * This is part of HarfBuzz, a text shaping library. + * + * Permission is hereby granted, without written agreement and without + * license or royalty fees, to use, copy, modify, and distribute this + * software and its documentation for any purpose, provided that the + * above copyright notice and the following two paragraphs appear in + * all copies of this software. + * + * IN NO EVENT SHALL THE COPYRIGHT HOLDER BE LIABLE TO ANY PARTY FOR + * DIRECT, INDIRECT, SPECIAL, INCIDENTAL, OR CONSEQUENTIAL DAMAGES + * ARISING OUT OF THE USE OF THIS SOFTWARE AND ITS DOCUMENTATION, EVEN + * IF THE COPYRIGHT HOLDER HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH + * DAMAGE. + * + * THE COPYRIGHT HOLDER SPECIFICALLY DISCLAIMS ANY WARRANTIES, INCLUDING, + * BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND + * FITNESS FOR A PARTICULAR PURPOSE. THE SOFTWARE PROVIDED HEREUNDER IS + * ON AN "AS IS" BASIS, AND THE COPYRIGHT HOLDER HAS NO OBLIGATION TO + * PROVIDE MAINTENANCE, SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS. + * + * Google Author(s): Behdad Esfahbod + */ + +#include "hb-ot-shape-position-fallback-private.hh" + +static void +hb_zero_mark_advances (hb_buffer_t *buffer) +{ + unsigned int count = buffer->len; + for (unsigned int i = 0; i < count; i++) + if (_hb_glyph_info_get_general_category (&buffer->info[i]) == HB_UNICODE_GENERAL_CATEGORY_NON_SPACING_MARK) + { + buffer->pos[i].x_advance = 0; + buffer->pos[i].y_advance = 0; + } +} + +void +_hb_ot_shape_position_fallback (const hb_ot_shape_plan_t *plan, + hb_font_t *font, + hb_buffer_t *buffer) +{ + hb_zero_mark_advances (buffer); +} diff --git a/src/hb-ot-shape.cc b/src/hb-ot-shape.cc index 4abb76fdb..6ec17c545 100644 --- a/src/hb-ot-shape.cc +++ b/src/hb-ot-shape.cc @@ -32,8 +32,9 @@ #include "hb-shaper-impl-private.hh" #include "hb-ot-shape-private.hh" -#include "hb-ot-shape-normalize-private.hh" #include "hb-ot-shape-complex-private.hh" +#include "hb-ot-shape-normalize-private.hh" +#include "hb-ot-shape-position-fallback-private.hh" #include "hb-ot-layout-private.hh" #include "hb-set-private.hh" @@ -207,7 +208,6 @@ _hb_ot_shaper_shape_plan_data_destroy (hb_ot_shaper_shape_plan_data_t *plan) struct hb_ot_shape_context_t { - /* Input to hb_ot_shape_internal() */ hb_ot_shape_plan_t *plan; hb_font_t *font; hb_face_t *face; @@ -391,18 +391,6 @@ hb_position_default (hb_ot_shape_context_t *c) } } -static void -hb_zero_mark_advances (hb_ot_shape_context_t *c) -{ - unsigned int count = c->buffer->len; - for (unsigned int i = 0; i < count; i++) - if (_hb_glyph_info_get_general_category (&c->buffer->info[i]) == HB_UNICODE_GENERAL_CATEGORY_NON_SPACING_MARK) - { - c->buffer->pos[i].x_advance = 0; - c->buffer->pos[i].y_advance = 0; - } -} - static void hb_ot_position_complex (hb_ot_shape_context_t *c) { @@ -429,8 +417,7 @@ hb_ot_position_complex (hb_ot_shape_context_t *c) } c->applied_position_complex = true; - } else - hb_zero_mark_advances (c); + } hb_ot_layout_position_finish (c->font, c->buffer, c->plan->shaper->zero_width_attached_marks); @@ -438,9 +425,9 @@ hb_ot_position_complex (hb_ot_shape_context_t *c) } static void -hb_position_complex_fallback (hb_ot_shape_context_t *c HB_UNUSED) +hb_position_complex_fallback (hb_ot_shape_context_t *c) { - /* TODO Mark pos */ + _hb_ot_shape_position_fallback (c->plan, c->font, c->buffer); } static void