From b77baa31c36d4b8375ebb3fe97a7bbe36b71b463 Mon Sep 17 00:00:00 2001
From: Behdad Esfahbod <behdad@behdad.org>
Date: Fri, 20 Jan 2023 10:13:21 -0700
Subject: [PATCH] [hb-info] Show whether --get-metric value is fallback

---
 util/hb-info.cc | 26 +++++++++++++++++++-------
 1 file changed, 19 insertions(+), 7 deletions(-)

diff --git a/util/hb-info.cc b/util/hb-info.cc
index 42116e91b..e1c45b01a 100644
--- a/util/hb-info.cc
+++ b/util/hb-info.cc
@@ -326,16 +326,28 @@ struct info_t
 
   void _get_metric ()
   {
+    bool fallback = false;
     for (char **p = get_metric; *p; p++)
     {
-      hb_tag_t tag = hb_tag_from_string (*p, -1);
+      hb_ot_metrics_tag_t tag = (hb_ot_metrics_tag_t) hb_tag_from_string (*p, -1);
       hb_position_t position;
-      hb_ot_metrics_get_position_with_fallback (font,
-						(hb_ot_metrics_tag_t) tag,
-						&position);
+
       if (verbose)
 	printf ("%c%c%c%c: ", HB_UNTAG (tag));
-      printf ("%d\n", position);
+
+      if (hb_ot_metrics_get_position (font, tag, &position))
+	printf ("%d\n", position);
+      else
+      {
+	hb_ot_metrics_get_position_with_fallback (font, tag, &position);
+	printf ("%d	*\n", position);
+	fallback = true;
+      }
+    }
+
+    if (verbose && fallback)
+    {
+      printf ("\n[*] Fallback value\n");
     }
   }
 
@@ -779,7 +791,7 @@ struct info_t
 	      name);
     }
     if (verbose && has_hidden)
-      printf ("\n[*] Hidden axis\n\n");
+      printf ("\n[*] Hidden axis\n");
 
     free (axes);
     axes = nullptr;
@@ -789,7 +801,7 @@ struct info_t
     {
       if (verbose)
       {
-	printf ("\nNamed instances:\n\n");
+	printf ("\n\nNamed instances:\n\n");
       printf ("Index	Name				Position\n------------------------------------------------\n");
       }