From b92e4cc0091e093f6941019e1a53cc04a137017a Mon Sep 17 00:00:00 2001
From: Qunxin Liu <qxliu@google.com>
Date: Mon, 14 Nov 2022 08:54:24 -0800
Subject: [PATCH] Avoid use values () in hb-hashmap if value_t has an overriden
 operator &

---
 src/hb-subset-input.cc | 7 ++++---
 src/hb-subset-plan.cc  | 7 ++++---
 src/hb-subset-plan.hh  | 6 ++++--
 3 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/src/hb-subset-input.cc b/src/hb-subset-input.cc
index 10ec5c38a..6b619f948 100644
--- a/src/hb-subset-input.cc
+++ b/src/hb-subset-input.cc
@@ -249,12 +249,13 @@ hb_subset_input_destroy (hb_subset_input_t *input)
 
   hb_hashmap_destroy (input->axes_location);
 
+#ifdef HB_EXPERIMENTAL_API
   if (input->name_table_overrides)
   {
-    for (auto _ : input->name_table_overrides->values ())
-      _.fini ();
+    for (auto _ : *input->name_table_overrides)
+      _.second.fini ();
   }
-
+#endif
   hb_hashmap_destroy (input->name_table_overrides);
 
   hb_free (input);
diff --git a/src/hb-subset-plan.cc b/src/hb-subset-plan.cc
index 3a06c5eaa..6a6876630 100644
--- a/src/hb-subset-plan.cc
+++ b/src/hb-subset-plan.cc
@@ -849,6 +849,7 @@ hb_subset_plan_create_or_fail (hb_face_t	 *face,
   plan->check_success (plan->hmtx_map = hb_hashmap_create<unsigned, hb_pair_t<unsigned, int>> ());
 
   plan->check_success (plan->name_table_overrides = hb_hashmap_create<unsigned, hb_bytes_t> ());
+#ifdef HB_EXPERIMENTAL_API
   if (plan->name_table_overrides && input->name_table_overrides)
   {
     for (auto _ : *input->name_table_overrides)
@@ -860,8 +861,8 @@ hb_subset_plan_create_or_fail (hb_face_t	 *face,
       char *name_str = (char *) hb_malloc (len);
       if (unlikely (!plan->check_success (name_str)))
       {
-        for (auto bytes : plan->name_table_overrides->values ())
-          bytes.fini ();
+        for (auto pair : *plan->name_table_overrides)
+          pair.second.fini ();
         break;
       }
 
@@ -869,7 +870,7 @@ hb_subset_plan_create_or_fail (hb_face_t	 *face,
       plan->name_table_overrides->set (name_id, hb_bytes_t (name_str, len));
     }
   }
-
+#endif
 
   void* accel = hb_face_get_user_data(face, hb_subset_accelerator_t::user_data_key());
 
diff --git a/src/hb-subset-plan.hh b/src/hb-subset-plan.hh
index 2e1997a18..8fb27ad0c 100644
--- a/src/hb-subset-plan.hh
+++ b/src/hb-subset-plan.hh
@@ -87,11 +87,13 @@ struct hb_subset_plan_t
     hb_hashmap_destroy (vmtx_map);
     hb_hashmap_destroy (layout_variation_idx_delta_map);
 
+#ifdef HB_EXPERIMENTAL_API
     if (name_table_overrides)
     {
-      for (auto _ : name_table_overrides->values ())
-        _.fini ();
+      for (auto _ : *name_table_overrides)
+        _.second.fini ();
     }
+#endif
     hb_hashmap_destroy (name_table_overrides);
 
     if (user_axes_location)