[bit-set-invertible] Implement set algebra

src/hb-algs.hh

@@ -1178,11 +1178,35 @@ struct
 }
 HB_FUNCOBJ (hb_bitwise_xor);
 struct
+{ HB_PARTIALIZE(2);
+  template <typename T> constexpr auto
+  operator () (const T &a, const T &b) const HB_AUTO_RETURN (~a & b)
+}
+HB_FUNCOBJ (hb_bitwise_lt);
+struct
 { HB_PARTIALIZE(2);
   template <typename T> constexpr auto
   operator () (const T &a, const T &b) const HB_AUTO_RETURN (a & ~b)
 }
-HB_FUNCOBJ (hb_bitwise_sub);
+HB_FUNCOBJ (hb_bitwise_gt); // aka sub
+struct
+{ HB_PARTIALIZE(2);
+  template <typename T> constexpr auto
+  operator () (const T &a, const T &b) const HB_AUTO_RETURN (~a & ~b)
+}
+HB_FUNCOBJ (hb_bitwise_non);
+struct
+{ HB_PARTIALIZE(2);
+  template <typename T> constexpr auto
+  operator () (const T &a, const T &b) const HB_AUTO_RETURN (~a | b)
+}
+HB_FUNCOBJ (hb_bitwise_le);
+struct
+{ HB_PARTIALIZE(2);
+  template <typename T> constexpr auto
+  operator () (const T &a, const T &b) const HB_AUTO_RETURN (a | ~b)
+}
+HB_FUNCOBJ (hb_bitwise_ge);
 struct
 {
   template <typename T> constexpr auto
@@ -1203,6 +1227,12 @@ struct
 }
 HB_FUNCOBJ (hb_sub);
 struct
+{ HB_PARTIALIZE(2);
+  template <typename T, typename T2> constexpr auto
+  operator () (const T &a, const T2 &b) const HB_AUTO_RETURN (b - a)
+}
+HB_FUNCOBJ (hb_rsub);
+struct
 { HB_PARTIALIZE(2);
   template <typename T, typename T2> constexpr auto
   operator () (const T &a, const T2 &b) const HB_AUTO_RETURN (a * b)

src/hb-bit-set-invertible.hh

@@ -108,18 +108,69 @@ struct hb_bit_set_invertible_t
     return inverted ? larger_set.s.is_subset (s) : s.is_subset (larger_set.s);
   }
 
+  protected:
   template <typename Op>
   void process (const Op& op, const hb_bit_set_invertible_t &other)
-  { s.process (op, other.s); }
+  {
-
+    s.process (op, other.s);
-  /*XXX(inverted)*/
+    inverted = bool (op (int (inverted), int (other.inverted)));
-  void union_ (const hb_bit_set_invertible_t &other) { process (hb_bitwise_or, other); }
+  }
-  /*XXX(inverted)*/
+  public:
-  void intersect (const hb_bit_set_invertible_t &other) { process (hb_bitwise_and, other); }
+  void union_ (const hb_bit_set_invertible_t &other)
-  /*XXX(inverted)*/
+  {
-  void subtract (const hb_bit_set_invertible_t &other) { process (hb_bitwise_sub, other); }
+    if (inverted == other.inverted)
-  /*XXX(inverted)*/
+    {
-  void symmetric_difference (const hb_bit_set_invertible_t &other) { process (hb_bitwise_xor, other); }
+      if (inverted)
+	process (hb_bitwise_and, other);
+      else
+	process (hb_bitwise_or, other); /* Main branch. */
+    }
+    else
+    {
+      if (inverted)
+	process (hb_bitwise_gt, other);
+      else
+	process (hb_bitwise_lt, other);
+    }
+  }
+  void intersect (const hb_bit_set_invertible_t &other)
+  {
+    if (inverted == other.inverted)
+    {
+      if (inverted)
+	process (hb_bitwise_or, other);
+      else
+	process (hb_bitwise_and, other); /* Main branch. */
+    }
+    else
+    {
+      if (inverted)
+	process (hb_bitwise_ge, other);
+      else
+	process (hb_bitwise_le, other);
+    }
+  }
+  void subtract (const hb_bit_set_invertible_t &other)
+  {
+    if (inverted == other.inverted)
+    {
+      if (inverted)
+	process (hb_bitwise_lt, other);
+      else
+	process (hb_bitwise_gt, other); /* Main branch. */
+    }
+    else
+    {
+      if (inverted)
+	process (hb_bitwise_non, other);
+      else
+	process (hb_bitwise_and, other);
+    }
+  }
+  void symmetric_difference (const hb_bit_set_invertible_t &other)
+  {
+    process (hb_bitwise_xor, other);
+  }
 
   bool next (hb_codepoint_t *codepoint) const
   {

src/hb-bit-set.hh

@@ -577,7 +577,7 @@ struct hb_bit_set_t
 
   void union_ (const hb_bit_set_t &other) { process (hb_bitwise_or, other); }
   void intersect (const hb_bit_set_t &other) { process (hb_bitwise_and, other); }
-  void subtract (const hb_bit_set_t &other) { process (hb_bitwise_sub, other); }
+  void subtract (const hb_bit_set_t &other) { process (hb_bitwise_gt, other); }
   void symmetric_difference (const hb_bit_set_t &other) { process (hb_bitwise_xor, other); }
 
   bool next (hb_codepoint_t *codepoint) const