From c0b3b9b2584c6dcb5fc37e3b49e26fba718d0e6c Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Mon, 15 Mar 2021 16:46:13 -0600 Subject: [PATCH] [ci] Don't test C++2a build One of the bots is unhappy when HB_NODISCARD comes after HB_INTERNAL. No idea why. But, again, we're testing HarfBuzz, not C++, not clang. Ugh. In file included from src/harfbuzz.cc:1: In file included from src/hb-aat-layout.cc:30: In file included from src/hb-aat-layout.hh:32: In file included from src/hb-ot-shape.hh:32: In file included from src/hb-ot-map.hh:32: src/hb-buffer.hh:335:15: error: an attribute list cannot appear here HB_INTERNAL HB_NODISCARD bool move_to (unsigned int i); /* i is output-buffer index. */ ^~~~~~~~~~~~ https://app.circleci.com/pipelines/github/harfbuzz/harfbuzz/1693/workflows/77459205-a189-45d3-bc58-52a8fd952c3f/jobs/155912/parallel-runs/0/steps/0-110?invite=true --- .circleci/config.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index d5e7de213..d6bfa38e0 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -132,9 +132,7 @@ jobs: # msan, needs --force-fallback-for=glib,freetype2 also which doesn't work yet but runs fuzzer cases at least - run: rm -rf build && meson build --default-library=static -Db_sanitize=memory --buildtype=debugoptimized --wrap-mode=nodownload -Dauto_features=disabled -Dtests=enabled -Dexperimental_api=true - run: ninja -Cbuild -j8 && meson test -Cbuild --print-errorlogs | asan_symbolize | c++filt - # test -std=c++2a and -Weverything of nightly clang builds - - run: clang -c src/harfbuzz.cc src/hb-subset*.cc -DHB_NO_MT -Werror -std=c++2a - - run: clang -c src/hb-*.cc -DHB_NO_MT -Werror -Weverything -Wno-old-style-cast -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-cast-qual -Wno-c++98-compat-pedantic -Wno-sign-conversion -Wno-padded -Wno-shorten-64-to-32 -Wno-reserved-id-macro -Wno-float-conversion -Wno-format-pedantic -Wno-shadow -Wno-conversion -Wno-zero-as-null-pointer-constant -Wno-missing-field-initializers -Wno-used-but-marked-unused -Wno-unused-macros -Wno-comma -Wno-float-equal -Wno-disabled-macro-expansion -Wno-weak-vtables -Wno-unused-parameter -Wno-covered-switch-default -Wno-unreachable-code -Wno-unused-template -DHB_WITH_WIN1256 + - run: clang -c src/harfbuzz.cc src/hb-subset*.cc -DHB_NO_MT -Werror -std=c++17 crossbuild-win32: executor: win32-executor