walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[base] Add TODO items

This commit is contained in:
Behdad Esfahbod 2018-11-15 02:48:50 -05:00
parent 3bf1ce748f
commit cabe433fbb
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/hb-ot-layout-base-table.hh
View File

@ -198,6 +198,7 @@ struct MinMax
const BaseCoord **min, const BaseCoord **min,
const BaseCoord **max) const const BaseCoord **max) const
{ {
/* TODO Replace hb_bsearch() with .bsearch(). */
const FeatMinMaxRecord *minMaxCoord = (const FeatMinMaxRecord *) const FeatMinMaxRecord *minMaxCoord = (const FeatMinMaxRecord *)
hb_bsearch (&feature_tag, featMinMaxRecords.arrayZ, hb_bsearch (&feature_tag, featMinMaxRecords.arrayZ,
featMinMaxRecords.len, featMinMaxRecords.len,
@ -230,7 +231,7 @@ struct MinMax
maxCoord; /* Offset to BaseCoord table that defines maxCoord; /* Offset to BaseCoord table that defines
* maximum extent value, from the beginning * maximum extent value, from the beginning
* of MinMax table (may be NULL) */ * of MinMax table (may be NULL) */
ArrayOf<FeatMinMaxRecord> SortedArrayOf<FeatMinMaxRecord>
featMinMaxRecords; featMinMaxRecords;
/* Array of FeatMinMaxRecords, in alphabetical /* Array of FeatMinMaxRecords, in alphabetical
* order by featureTableTag */ * order by featureTableTag */
@ -302,6 +303,7 @@ struct BaseScript
{ {
inline const MinMax &get_min_max (hb_tag_t language_tag) const inline const MinMax &get_min_max (hb_tag_t language_tag) const
{ {
/* TODO Replace hb_bsearch() with .bsearch(). */
const BaseLangSysRecord* record = (const BaseLangSysRecord *) const BaseLangSysRecord* record = (const BaseLangSysRecord *)
hb_bsearch (&language_tag, baseLangSysRecords.arrayZ, hb_bsearch (&language_tag, baseLangSysRecords.arrayZ,
baseLangSysRecords.len, baseLangSysRecords.len,
@ -332,7 +334,7 @@ struct BaseScript
OffsetTo<MinMax> OffsetTo<MinMax>
defaultMinMax; /* Offset to MinMax table, from beginning of defaultMinMax; /* Offset to MinMax table, from beginning of
* BaseScript table (may be NULL) */ * BaseScript table (may be NULL) */
ArrayOf<BaseLangSysRecord> SortedArrayOf<BaseLangSysRecord>
baseLangSysRecords; baseLangSysRecords;
/* Number of BaseLangSysRecords /* Number of BaseLangSysRecords
* defined — may be zero (0) */ * defined — may be zero (0) */
@ -377,6 +379,7 @@ struct BaseScriptList
{ {
inline const BaseScriptRecord *find_record (hb_tag_t script) const inline const BaseScriptRecord *find_record (hb_tag_t script) const
{ {
/* TODO Replace hb_bsearch() with .bsearch(). */
return (const BaseScriptRecord *) hb_bsearch (&script, baseScriptRecords.arrayZ, return (const BaseScriptRecord *) hb_bsearch (&script, baseScriptRecords.arrayZ,
baseScriptRecords.len, baseScriptRecords.len,
BaseScriptRecord::static_size, BaseScriptRecord::static_size,
@ -400,7 +403,7 @@ struct BaseScriptList
} }
protected: protected:
ArrayOf<BaseScriptRecord> SortedArrayOf<BaseScriptRecord>
baseScriptRecords; baseScriptRecords;
public: public: