From cb5011d364904452a625cfc0485f5a713f472d07 Mon Sep 17 00:00:00 2001
From: Behdad Esfahbod <behdad@behdad.org>
Date: Fri, 4 Jan 2019 11:22:32 -0500
Subject: [PATCH] Revert "[iter] Add hb_iter_of_t<>"

This reverts commit d6cbe96e2fc7bc8f1c10e631b52b1ef31ff9a6f5.

Isn't useful, as duplicate inheritance of same type results in ambiguity
errors...
---
 src/hb-iter.hh | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/hb-iter.hh b/src/hb-iter.hh
index 215b19023..7b975e6b6 100644
--- a/src/hb-iter.hh
+++ b/src/hb-iter.hh
@@ -48,11 +48,9 @@
  * Base classes for iterators.
  */
 
-template <typename Item> struct hb_iter_of_t {};
-
 /* Base class for all iterators. */
 template <typename Iter, typename Item = typename Iter::__item_type__>
-struct hb_iter_t : hb_iter_of_t<Item>
+struct hb_iter_t
 {
   typedef Iter iter_t;
   typedef Item item_t;
@@ -163,11 +161,11 @@ struct hb_is_iterable { enum { value = _hb_is_iterable<T, hb_true_t>::value }; }
 
 /* hb_is_iterator() / hb_is_sorted_iterator() */
 
-template<typename Item = void> char _hb_is_iterator (...) { return 0; };
-template<typename Item> int _hb_is_iterator (hb_iter_of_t<Item> *) { return 0; };
-template<typename Item> int _hb_is_iterator (hb_iter_of_t<const Item> *) { return 0; };
-template<typename Item> int _hb_is_iterator (hb_iter_of_t<Item&> *) { return 0; };
-template<typename Item> int _hb_is_iterator (hb_iter_of_t<const Item&> *) { return 0; };
+template<typename Iter = void, typename Item = void> char _hb_is_iterator (...) { return 0; };
+template<typename Iter, typename Item> int _hb_is_iterator (hb_iter_t<Iter, Item> *) { return 0; };
+template<typename Iter, typename Item> int _hb_is_iterator (hb_iter_t<Iter, const Item> *) { return 0; };
+template<typename Iter, typename Item> int _hb_is_iterator (hb_iter_t<Iter, Item&> *) { return 0; };
+template<typename Iter, typename Item> int _hb_is_iterator (hb_iter_t<Iter, const Item&> *) { return 0; };
 static_assert (sizeof (char) != sizeof (int), "");
 template<typename Iter, typename Item>
 struct hb_is_iterator { enum {