From cc7b3a1abd24aebabd812a151e0c206bf6f09635 Mon Sep 17 00:00:00 2001 From: Khaled Hosny Date: Sat, 26 Sep 2020 10:22:39 +0200 Subject: [PATCH] [Docs] Address review comments --- src/hb-face.cc | 11 ++++++----- src/hb-face.h | 2 -- src/hb-unicode.cc | 5 +++++ 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/src/hb-face.cc b/src/hb-face.cc index 54abac007..848c4ff9c 100644 --- a/src/hb-face.cc +++ b/src/hb-face.cc @@ -102,9 +102,10 @@ DEFINE_NULL_INSTANCE (hb_face_t) = * @user_data: A pointer to the user data * @destroy: (optional): A callback to call when @data is not needed anymore * - * Variant of hb_face_create(), built for those cases where - * client programs are primarily concerned with querying the - * font tables, rather than with full shaping. + * Variant of hb_face_create(), built for those cases where it is more + * convenient to provide data for individual tables instead of the whole font + * data. With the caveat that hb_face_get_table_tags() does not currently work + * with faces created this way. * * Creates a new face object from the specified @user_data and @reference_table_func, * with the @destroy callback. @@ -397,8 +398,8 @@ hb_face_reference_table (const hb_face_t *face, * @face: A face object * * Fetches a pointer to the binary blob that contains the - * specified face. Can only be used on faces created with - * hb_face_builder_create(). + * specified face. Returns an empty blob if referencing face data is not + * possible. * * Return value: (transfer full): A pointer to the blob for @face * diff --git a/src/hb-face.h b/src/hb-face.h index d88285a50..3b18f7eef 100644 --- a/src/hb-face.h +++ b/src/hb-face.h @@ -48,8 +48,6 @@ hb_face_count (hb_blob_t *blob); /** * hb_face_t: - * @blob: A pointer to the #hb_blob_t that contains the binary blob of a font file - * @index: The index (zero-based) into the font file that points to the face * * Data type for holding font faces. * diff --git a/src/hb-unicode.cc b/src/hb-unicode.cc index 9621a2256..71de71549 100644 --- a/src/hb-unicode.cc +++ b/src/hb-unicode.cc @@ -139,9 +139,14 @@ hb_unicode_decompose_compatibility_nil (hb_unicode_funcs_t *ufuncs HB_UNUSED #endif /** + * hb_unicode_funcs_get_default: * + * Fetches a pointer to the default Unicode-functions structure that is used + * when no functions are explicitly set on #hb_buffer_t. * + * Return value: (transfer none): a pointer to the #hb_unicode_funcs_t Unicode-functions structure * + * Since: 0.9.2 **/ hb_unicode_funcs_t * hb_unicode_funcs_get_default ()