walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[HB] Cleanup TODOs

This commit is contained in:
Behdad Esfahbod 2009-05-18 04:25:22 -04:00
parent 122f21fb9a
commit d6aae5f5ca
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/hb-ot-layout-gsub-private.h
View File

@ -254,10 +254,10 @@ struct AlternateSubstFormat1 {
unsigned int alt_index = 0;
/* XXX callback to user to choose alternate
if ( gsub->altfunc )
alt_index = (gsub->altfunc)( buffer->out_pos, glyph_id,
aset.GlyphCount, aset.Alternate,
gsub->data );
if (layout->altfunc)
alt_index = (layout->altfunc)(layout, buffer,
buffer->out_pos, glyph_id,
alt_set.len, alt_set.array);
*/
if (HB_UNLIKELY (alt_index >= alt_set.len))
@ -370,7 +370,7 @@ struct Ligature {
(buffer->in_pos)++;
}
/* XXX We should possibly reassign lig_id and component for any
/* TODO We should possibly reassign lig_id and component for any
* components of a previous ligature that s now being removed as part of
* this ligature. */
}
@ -773,7 +773,7 @@ ASSERT_SIZE (GSUB, 10);
inline bool ExtensionSubstFormat1::substitute (LOOKUP_ARGS_DEF) const {
unsigned int lookup_type = get_type ();
/* TODO: belongs to sanitize() */
/* TODO belongs to sanitize() */
if (HB_UNLIKELY (lookup_type == GSUB_ReverseChainSingle))
return false;

2
src/hb-ot-layout-open-private.h
View File

@ -203,7 +203,7 @@ struct Null <Type> { \
* Int types
*/
/* XXX define these as structs of chars on machines that do not allow
/* TODO define these as structs of chars on machines that do not allow
* unaligned access (using templates?). */
#define DEFINE_INT_TYPE1(NAME, TYPE, BIG_ENDIAN) \
inline NAME& operator = (TYPE i) { v = BIG_ENDIAN(i); return *this; } \

4
src/hb-ot-layout.cc
View File

@ -85,7 +85,7 @@ hb_ot_layout_destroy (hb_ot_layout_t *layout)
* GDEF
*/
/* XXX the public class_t is a mess */
/* TODO the public class_t is a mess */
hb_bool_t
hb_ot_layout_has_font_glyph_classes (hb_ot_layout_t *layout)
@ -532,7 +532,7 @@ hb_ot_layout_substitute_lookup (hb_ot_layout_t *layout,
/* XXX dupped, until he old code can be removed */
/* TODO dupped, until he old code can be removed */
static HB_Error
hb_buffer_duplicate_out_buffer( HB_Buffer buffer )