From dbbb8e8006ea71519546105f229ce635105bf855 Mon Sep 17 00:00:00 2001
From: Behdad Esfahbod <behdad@behdad.org>
Date: Sun, 4 Dec 2022 11:13:39 -0700
Subject: [PATCH] Revert "[map] Add hb_map_filter_invalid"

This reverts commit 8d7e92111786b21906157127c24b72b1e444e6e7.

Surprisingly this slowed NotoNastaliqUrdu benchmark down by a couple
percent instead of speeding it up.
---
 src/OT/Layout/Common/Coverage.hh | 2 +-
 src/hb-map.hh                    | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/OT/Layout/Common/Coverage.hh b/src/OT/Layout/Common/Coverage.hh
index 862767191..fbd7c642a 100644
--- a/src/OT/Layout/Common/Coverage.hh
+++ b/src/OT/Layout/Common/Coverage.hh
@@ -147,8 +147,8 @@ struct Coverage
     TRACE_SUBSET (this);
     auto it =
     + iter ()
+    | hb_filter (c->plan->glyph_map_gsub)
     | hb_map_retains_sorting (c->plan->glyph_map_gsub)
-    | hb_filter (hb_map_filter_invalid)
     ;
 
     // Cache the iterator result as it will be iterated multiple times
diff --git a/src/hb-map.hh b/src/hb-map.hh
index f5f180e9b..bfb1b3f76 100644
--- a/src/hb-map.hh
+++ b/src/hb-map.hh
@@ -451,8 +451,6 @@ struct hb_map_t : hb_hashmap_t<hb_codepoint_t,
   hb_map_t (const Iterable &o) : hashmap (o) {}
 };
 
-static inline bool hb_map_filter_invalid (hb_codepoint_t _) { return _ != HB_MAP_VALUE_INVALID; }
-
 template <typename K, typename V>
 static inline
 hb_hashmap_t<K, V>* hb_hashmap_create ()