walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add TODO

This commit is contained in:
Behdad Esfahbod 2010-04-23 15:19:50 -04:00
parent 33d4d4325e
commit f1aaa2a436
5 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/hb-ft.c
View File

@ -177,7 +177,6 @@ hb_ft_face_create (FT_Face ft_face,
{
hb_face_t *face;
/* TODO: Handle NULL ft_face (in other places too) */
if (ft_face->stream->read == NULL) {
hb_blob_t *blob;
@ -204,7 +203,6 @@ hb_ft_face_finalize (FT_Face ft_face)
hb_face_t *
hb_ft_face_create_cached (FT_Face ft_face)
{
/* TODO: Not thread-safe */
if (HB_UNLIKELY (!ft_face->generic.data || ft_face->generic.finalizer != (FT_Generic_Finalizer) hb_ft_face_finalize))
{
if (ft_face->generic.finalizer)

1
src/hb-ft.h
View File

@ -43,6 +43,7 @@ hb_face_t *
hb_ft_face_create (FT_Face ft_face,
hb_destroy_func_t destroy);
/* Note: This function is not thread-safe */
hb_face_t *
hb_ft_face_create_cached (FT_Face ft_face);

2
src/hb-open-file-private.hh
View File

@ -84,7 +84,7 @@ typedef struct OffsetTable
{
Tag t;
t.set (tag);
// TODO: bsearch (need to sort in sanitize)
/* TODO: bsearch (need to sort in sanitize) */
unsigned int count = numTables;
for (unsigned int i = 0; i < count; i++)
{

2
src/hb-open-type-private.hh
View File

@ -366,6 +366,8 @@ struct Sanitizer
template <typename Type, int Bytes> class BEInt;
/* LONGTERMTODO: On machines allowing unaligned access, we can make the
* following tighter by using byteswap instructions on ints directly. */
template <typename Type>
class BEInt<Type, 2>
{

12
src/hb-ot-layout-common-private.hh
View File

@ -87,7 +87,7 @@ struct RecordArrayOf : ArrayOf<Record<Type> > {
{
Tag t;
t.set (tag);
// TODO: bsearch (need to sort in sanitize)
/* TODO: bsearch (need to sort in sanitize) */
const Record<Type> *a = this->array();
unsigned int count = this->len;
for (unsigned int i = 0; i < count; i++)
@ -235,8 +235,8 @@ struct Feature
return SANITIZE_SELF () && SANITIZE (lookupIndex);
}
/* TODO: implement get_feature_parameters() */
/* TODO: implement FeatureSize and other special features? */
/* LONGTERMTODO: implement get_feature_parameters() */
/* LONGTERMTODO: implement FeatureSize and other special features? */
Offset featureParams; /* Offset to Feature Parameters table (if one
* has been defined for the feature), relative
* to the beginning of the Feature Table; = Null
@ -321,7 +321,7 @@ struct CoverageFormat1
return NOT_COVERED;
GlyphID gid;
gid.set (glyph_id);
// TODO: bsearch (need to sort in sanitize)
/* TODO: bsearch (need to sort in sanitize) */
unsigned int num_glyphs = glyphArray.len;
for (unsigned int i = 0; i < num_glyphs; i++)
if (gid == glyphArray[i])
@ -377,7 +377,7 @@ struct CoverageFormat2
private:
inline unsigned int get_coverage (hb_codepoint_t glyph_id) const
{
// TODO: bsearch (need to sort in sanitize)
/* TODO: bsearch (need to sort in sanitize) */
unsigned int count = rangeRecord.len;
for (unsigned int i = 0; i < count; i++)
{
@ -497,7 +497,7 @@ struct ClassDefFormat2
private:
inline hb_ot_layout_class_t get_class (hb_codepoint_t glyph_id) const
{
// TODO: bsearch (need to sort in sanitize)
/* TODO: bsearch (need to sort in sanitize) */
unsigned int count = rangeRecord.len;
for (unsigned int i = 0; i < count; i++)
{