From f2eb3fa9dca8d21fae20c9b9dddad3245df74a05 Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Tue, 25 Sep 2012 21:35:35 -0400 Subject: [PATCH] [OT] Only insert dottedcircle if at the beginning of paragraph If the first char in the run is a combining mark, but there is text before the run, don't insert dottedcircle. Part of addressing: https://bugzilla.redhat.com/show_bug.cgi?id=858736 --- src/hb-ot-shape.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/hb-ot-shape.cc b/src/hb-ot-shape.cc index 9e44c5db2..3f72fd092 100644 --- a/src/hb-ot-shape.cc +++ b/src/hb-ot-shape.cc @@ -237,10 +237,8 @@ hb_set_unicode_props (hb_buffer_t *buffer) static void hb_insert_dotted_circle (hb_buffer_t *buffer, hb_font_t *font) { - /* TODO One day, when we keep _before_ text for the buffer, take - * that into consideration. For now, insert dotted-circle if the - * very first character is a non-spacing mark. */ - if (_hb_glyph_info_get_general_category (&buffer->info[0]) != + if (buffer->context_len[0] || + _hb_glyph_info_get_general_category (&buffer->info[0]) != HB_UNICODE_GENERAL_CATEGORY_NON_SPACING_MARK) return;