walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[atomic] Add XXX items around Solaris ops 

Since add_int and cas are both read-modify-write, I wonder if we
also need a barrier after them.
This commit is contained in:
Behdad Esfahbod 2018-07-31 23:00:15 -07:00
parent 896ff15ae6
commit fd638d215f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/hb-atomic-private.hh
View File

@ -122,11 +122,11 @@ static inline void _hb_memory_barrier (void) { __sync_synchronize (); }
#include <mbarrier.h>
typedef unsigned int hb_atomic_int_impl_t;
#define hb_atomic_int_impl_add(AI, V) ( ({__machine_rw_barrier ();}), atomic_add_int_nv ((AI), (V)) - (V))
#define hb_atomic_int_impl_add(AI, V) ( ({__machine_rw_barrier ();}), atomic_add_int_nv ((AI), (V)) - (V) /* XXX barrier again? */)
static inline void _hb_memory_barrier (void) { __machine_rw_barrier (); }
#define hb_atomic_ptr_impl_cmpexch(P,O,N) ( ({__machine_rw_barrier ();}), atomic_cas_ptr ((void **) (P), (void *) (O), (void *) (N)) == (void *) (O) ? true : false)
#define hb_atomic_ptr_impl_cmpexch(P,O,N) ( ({__machine_rw_barrier ();}), atomic_cas_ptr ((void **) (P), (void *) (O), (void *) (N)) == (void *) (O) ? true : false /* XXX barrier again? */)
#elif !defined(HB_NO_MT) && defined(__APPLE__)