f83496a910
[use] Remove workaround for reserved code points
...
See <https://github.com/microsoft/font-tools/issues/12 >.
2020-11-20 15:37:37 -07:00
17da41bd06
Update language system tag registry to OT 1.8.4
2020-11-18 11:13:35 -08:00
fd8f4ffcc6
Trace reorder, not normalize
2020-11-17 09:05:40 +00:00
2e0193d741
Add more cast spaces
2020-11-17 09:05:40 +00:00
4bb6d54e3b
Missing cast
2020-11-17 09:05:40 +00:00
8e1bedc50b
Keep phase names
2020-11-17 09:05:40 +00:00
428c111f13
Fix spacing around casts
2020-11-17 09:05:40 +00:00
f19018da41
Smaller issues from review
2020-11-17 09:05:40 +00:00
8b3b835a0a
Trace normalization and preprocessing stages
2020-11-17 09:05:40 +00:00
b50099bff2
Trace reordering in pause functions
2020-11-17 09:05:40 +00:00
0c3dcfae19
Merge remote-tracking branch 'upstream/master'
2020-11-17 07:31:07 +01:00
3bd43bd023
Map more ISO 15924 variants to `hb_script_t`s
2020-11-16 22:18:15 -08:00
27170e058d
Fix names for language tag in gen-tag-table.py
...
A BCP 47 language tag with both a script subtag and a region subtag
would be printed as a human-readable name in hb-ot-tag-table.hh as if it
only had its language subtag.
2020-11-16 10:59:07 -08:00
49ebb9ebdd
[use] Remove redundant O entries from the table
2020-10-17 22:07:34 +02:00
79fd5ce22e
[use] Merge IND and Rsv classes into O
2020-10-17 22:07:34 +02:00
cde2cf84c0
[use] Minor clean-up of unused categories
2020-10-17 11:22:19 -04:00
0792690b73
[use] Skip WJ and ZWJ when clustering
2020-10-16 22:39:46 -07:00
3fcf466b7b
[hb-shape-fallback] Use signed int for correction
2020-10-16 17:57:38 -07:00
77e704d1db
[buffer] Add assert_unicode()/assert_glyphs() and use internally
2020-10-15 02:02:04 -06:00
5ef0613909
[buffer] Add ensure_glyphs()/ensure_unicode()
...
Use in deserialize. To be used more.
2020-10-15 01:54:28 -06:00
3232e6f2a9
[buffer] Add hb_buffer_has_positions()
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/2716
2020-10-15 00:20:17 -06:00
dec52006d9
Map BCP 47 tags to all macrolanguages
...
The general rule is that if a BCP 47 macrolanguage maps to an OpenType
language system tag, all its individual languages map to it too.
Previously, a tag like "prs" (Dari) would not map to the language system
tag ('FAR ') of its macrolanguage ("fa") because "prs" already has its
own language system tag ('DRI '). That exception has been removed: now
"prs" maps to 'DRI ' and falls back to 'FAR '.
2020-10-11 11:38:40 -07:00
1d53268dfe
Fix two-way mapping of "man" and 'MNK '
2020-10-11 11:38:40 -07:00
ab38cf6746
Map hy-arevmda to 'HYE ' instead of HYE0
2020-10-11 11:38:40 -07:00
916c5a9007
Consistently emit BCP 47 subtag scope suffixes
2020-10-11 11:38:40 -07:00
1c05f6789b
[buffer] Increase work limits
...
Our previous limits of 64 per input character was already hit
by David Corbett's under-development Duployan font.
Increase work limits by factor of 16, and number of glyphs by factor of 2.
Fixes https://github.com/harfbuzz/harfbuzz/issues/2707
2020-10-11 12:28:25 -06:00
b37edebfcb
[buffer/deserialize] Do not clear() buffer upon content type mismatch
...
We return false. I don't see reason to clear buffer.
2020-10-09 22:27:56 -06:00
c396e1600f
[buffer/deserialize] Accept arbitrary glyph names
...
Accepts escapes. Added TODO items for matching escaping in serialize().
2020-10-09 22:27:56 -06:00
4a4eebcf86
[buffer/serialize] Minor renames in Ragel machines
...
As per my previous review on:
https://github.com/harfbuzz/harfbuzz/pull/2687
2020-10-09 22:27:56 -06:00
78fb6a11af
Whitespace
2020-10-09 22:27:55 -06:00
140552cec9
[buffer/serialize] Only serialize empty buffers of CONTENT_TYPE_INVALID
2020-10-09 22:27:55 -06:00
8f5d8b155c
[buffer] Buffer start <= end <= len requirement in (de-)serialize
2020-10-09 22:27:55 -06:00
3b64122a7f
[buffer] Fix immutable case with end_ptr==nullptr
2020-10-09 22:27:55 -06:00
7c0bc0bb92
Serialize invalid buffer to !! (text) or [] (json)
...
There is no generic deserialize - you have to choose glyphs or unicode - so there is no way to deserialize this buffer.
2020-10-09 22:27:55 -06:00
5bb88c4f45
Oops debug print
2020-10-09 22:27:55 -06:00
f56eb402f0
Immutable buffer fix
2020-10-09 22:27:55 -06:00
150f391438
Prohibit mixed glyphs/unicode buffers in deserialization
2020-10-09 22:27:55 -06:00
6b1726b6ef
Typos
2020-10-09 22:27:55 -06:00
3d3c87e7e7
Put the flags back in and serialize clusters.
...
Note that now JSON glyph buffers and Unicode buffers look very similar, except for the g/u property difference.
2020-10-09 22:27:55 -06:00
c03a2001b2
Deserialization routines for Unicode buffers
2020-10-09 22:27:55 -06:00
c0716bb5dc
Move delimiter addition into hb-buffer-serialize
2020-10-09 22:27:55 -06:00
36ede56962
Fix docs
...
Note the delimiters stuff isn’t true yet, will be working on that
2020-10-09 22:27:55 -06:00
bb7b634cd0
Simplify JSON unicode serialization
...
It’s just an array of codepoints; no need to turn them into objects
2020-10-09 22:27:55 -06:00
57a528ab2c
Convert tabs to spaces
2020-10-09 22:27:55 -06:00
aff6a36266
Use auxbuffer for serialize_unicode_text
2020-10-09 22:27:55 -06:00
58bcc1cedd
Serialize Unicode buffers
2020-10-09 22:27:55 -06:00
c39ab82c90
Fix usage text of gen-use-table.py
2020-10-06 16:51:40 -04:00
aace09a3ad
[subset] Use glyphset gsub for layout variation indices collection.
2020-10-06 10:26:17 -07:00
1d9801e012
[subset] In AnchorMatrix::subset eliminate the use of dynamically allocated vector.
2020-10-05 14:43:29 -07:00
093909b2ff
[subset] Fix wrong offset base for subsetting LigatureArray.
...
Offsets from LigatureArray must be relative to the beginning of the LigatureArray table. For the serialization mechanism to use the correct beginning point the LigatureArray must be created using the push()/pop() mechanism. So convert LigatureArray subsetting to use serialize_subset() instead of a manually called serialize and subset.
2020-10-05 13:14:53 -07:00
147e93b910
[subset] Fixes to get GPOS 5 subsetting code compiling.
2020-10-01 16:45:57 -07:00
3a0b05faf1
[subset] GPOS 5 MarkToLigature subsetting support
2020-10-01 15:59:16 -07:00
718bf5aab3
[subset] only keep features reachable from script in the final subset.
...
Matches fontTools behaviour.
2020-09-29 13:16:01 -07:00
e583505334
[subset] Use plan->glyphset_gsub instead of plan->glyphset for GSUB/GPOS
...
This matches fontTools behaviour. glyphset_gsub does not contain gids added from closing over composite glyphs in glyf, since these cannot particpate in GSUB/GPOS processing.
2020-09-29 11:16:15 -07:00
a99e8721bf
[use] Fix tests with MSVC
2020-09-29 09:54:33 -04:00
940e1c6f98
[subset] ChainContextFormat3 - don't subset glyph sequences.
...
The backtrack, input, and lookahead sequence must be matched in their entirety so these sequences should not be subset. If any of the coverage tables in a sequence subsets to empty then the whole subtable should be dropped since it's not possible for this lookup to be activated.
2020-09-28 17:22:01 -07:00
e31c2690f8
[subset] remove unnecessary returns.
2020-09-28 16:51:25 -07:00
ad241f9917
[subset] check that sub rules in ChainContextFormat 1 and 2 intersect the glyphs set before recursing during closure lookups.
2020-09-28 15:26:13 -07:00
9fad540245
[subset] check that sub rules in ContextFormat 1 and 2 intersect the glyphs set before recursing during closure lookups.
2020-09-28 13:24:25 -07:00
7e6070a47f
Set *coord to nullptr
2020-09-28 08:36:41 -06:00
4e0bddb7fe
get_baseline
2020-09-28 08:36:41 -06:00
cc7b3a1abd
[Docs] Address review comments
2020-09-26 10:22:39 +02:00
41b46a3cb2
Update hb-face.cc
2020-09-26 09:47:27 +02:00
726e320ece
Update inline doc for hb_face_create: explain index
2020-09-26 09:47:27 +02:00
70331ca485
[Docs] Minor
...
update GTK-Doc comments in hb-ot-layout.
2020-09-26 09:47:13 +02:00
eb10ef46aa
[Docs] Add GTK-Doc comments for hb-ot-font and hb-ot-shape.
2020-09-26 09:46:15 +02:00
3e72febde0
[Docs] Add GTK-Doc comments for hb-face.
2020-09-26 09:46:15 +02:00
88cdea60e0
[Docs] Add GTK-Doc comments to hb-shape-plan.
2020-09-26 09:46:10 +02:00
5b43eb5a4c
[Docs] Add GTK-Dod comments to hb-unicode.
2020-09-26 09:42:22 +02:00
a5c0ec7516
[subset] For [Chain]ContextFormat3 make sure the sub table intersects the retained glyphset before recursing to its lookups.
...
Otherwise the lookup closure will potentially pull in lookups which cannot be accessed via the retained glyph set.
2020-09-25 14:57:20 -07:00
dc375559fd
[subset] shrink the serialize buffer when pruning empty offsets in ChainContextFormat2.
...
Currently the code reduces the array length, but does not trim back the space allocated in the serializer for those empty offsets.
2020-09-25 13:08:46 -07:00
90eb1a40eb
[subset] In ChainContextFormat3 don't skip subsetting if backtrack or lookahead are empty.
...
It's valid to have a ChainContextFormat3 with either an empty backtrack or lookahead. Only drop the lookup if the input sequence is empty.
2020-09-25 12:36:32 -07:00
2604201ae0
src/meson.build: allow introspection when cross-compiling
...
introspection can be enabled when cross-compiling on certains conditions
(for example it is supported by buildroot) so, as suggested by
Tim-Philipp Müller, disable it by default for cross builds unless the
option was explicitly enabled by the user
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
2020-09-25 18:40:43 +02:00
df00f45e26
Fix annotation in previous commits
2020-09-24 11:57:46 +02:00
5a695a79a0
Swap # for () in gtk-doc function mention.
2020-09-24 11:57:46 +02:00
379be7b7c8
Update src/hb-ot-var.cc
...
Co-Authored-By: Khaled Hosny <khaledhosny@eglug.org>
2020-09-24 11:57:46 +02:00
938add712a
Add GTK-Doc comments for hb-ot-var.
2020-09-24 11:55:09 +02:00
9a1be3fed5
Fix enum documentation syntax
2020-09-22 16:46:03 +02:00
3c9244e662
Update src/hb-aat-layout.cc
...
Co-Authored-By: Khaled Hosny <khaledhosny@eglug.org>
2020-09-22 15:59:42 +02:00
d619ba0681
Add gtk-doc documentation to AAT layout functions and enums.
2020-09-22 15:59:14 +02:00
514e6baaf0
[gtk-doc] document AAT functions and enums.
2020-09-22 15:59:11 +02:00
a1f4d285e1
[buffer] Fix invalid write access in hb_buffer_deserialize_glyphs()
...
If buffer is immutable, we were trying to set content_type on it.
Ouch!
2020-09-21 16:50:11 -06:00
1f8b1e7f18
[ENOMEM] Return gracefully if stages isn't initialized correctly ( #2639 )
...
This happens if calls to 'm.lookups[table_index].push ()' has been
silently failed due to lack of memory.
This change just returns gracefully instead issuing the assert.
Fixes https://crbug.com/oss-fuzz/24494
2020-09-21 11:39:38 +03:30
e40c0d82e2
[ENOMEM] Handle immutable buffer in shape_full()
...
Move the content_type changing to shape_plan_execute() where it belongs.
Skip setting if content type is UNKNOWN, which happens with empty buffers
only, including the immutable buffer.
Alternate fix to https://github.com/harfbuzz/harfbuzz/pull/2606
and https://github.com/harfbuzz/harfbuzz/pull/2625
2020-09-16 12:48:30 -06:00
bbbcad0dbb
Revert "[ENOMEM] don't perform set process operations if the other set is in an error state."
...
This reverts commit f3929abafe
2020-09-16 12:23:38 -06:00
f3929abafe
[ENOMEM] don't perform set process operations if the other set is in an error state.
...
Running a process while the other set is in an error state can potentially corrupt this sets map map (for example by overwritting all of the major values with 0).
2020-09-16 10:36:30 -07:00
584d3a43b2
Merge pull request #2681 from khaledhosny/myanmar-liga
...
[myanmar] Don’t disable liga feature
2020-09-16 15:08:50 +01:00
7d64b09765
[myanmar] Don’t disable liga feature
...
This seems to have been carried over from the Indic shaper, but
Uniscribe enables it by default.
See https://github.com/harfbuzz/harfbuzz/issues/2213#issuecomment-686062915
2020-09-12 21:45:19 +02:00
8c3d4de796
[subset] Fix integer underflow in ContextFormat2.
2020-09-11 15:52:46 -07:00
ac3f859a30
Demote unregistered vendor-specific language tags
2020-09-09 17:50:59 -04:00
ee12c078ed
Merge pull request #2668 from rossburton/meson
...
meson: add hb-version.h to dependencies correctly
2020-09-08 15:37:30 +02:00
695d85ca32
Merge pull request #2674 from rossburton/reprod
...
src/hb-gobject-enums.cc.tmpl: write out only the filename, not the full path
2020-09-08 15:37:00 +02:00
91fe20f0f5
Disambiguate OT tags when primary tag is not first
2020-09-08 09:20:00 -04:00
e876886d1e
src/hb-gobject-enums.cc.tmpl: write out only the filename, not the full path
...
This is beneficial for reproducible builds, as build paths can vary
between builds.
2020-09-08 11:00:32 +01:00
5aff83104e
[build] generate hb-version.h once at configure time with Meson
...
Currently with Meson hb-version.h is generated during the build without
any explicit dependencies which can result in build failures due races
over the file.
Change this to be generated at configure time, so that the file is always
generated once before the build itself.
Closes #2667
2020-09-08 09:42:27 +01:00
bc1c93fbe0
[build] No need to pass source directory to gen-hb-version
...
The input file is by definition in the source directory, so dirname()
that instead of needing the directory to be passed.
Needed because a follow-up commit will change when this is called, and the
source directory isn't trivially available at that point.
2020-09-08 09:40:56 +01:00
faf09f5466
[USE] Support hieroglyph clusters
2020-09-02 19:50:49 -04:00
06f49fc8ae
[USE] Update to the 2020-08-13 USE specification
...
This also uses the data files from
<78b2134fdc/USE
2020-09-02 19:50:49 -04:00
6a38adeb57
[use] Skip most default ignorables when clustering
2020-09-02 15:51:15 -07:00
645f4e7cdd
Unhide CGJ before ccc=0 characters
...
If a CGJ precedes a starter, then it cannot have blocked any reordering,
so it can safely be skipped.
2020-09-02 15:51:15 -07:00
9825e3dd2e
[ENOMEM] fix access to unitialized memory.
...
If the serialize() call fails to write the object then we can't safely read varstore_prime fields. Fixes https://oss-fuzz.com/testcase-detail/5137462782066688 .
2020-09-02 11:01:07 -07:00
fe6381d9f1
[build] Minor
2020-09-01 03:44:01 +02:00
a4f3a752dd
[build] hb-directwrite needs a C++ linker
2020-09-01 03:21:12 +02:00
9c98b2b9a9
2.7.2
2020-08-29 00:39:42 +02:00
a495a54236
Ignore T & U when determining the joining scripts
2020-08-28 14:33:25 -04:00
420a74f772
[USE] Fix assertion failure for joining scripts
2020-08-28 14:11:48 -04:00
1e48225ca3
[ENOMEM] Check whether serialize context isn't in error
2020-08-13 23:22:14 +04:30
05ef75c553
2.7.1
2020-08-13 20:54:53 +04:30
253a8f7a51
[meson] Another approach to skip tests incompatible with MSVC
2020-08-13 18:28:42 +04:30
411b426c69
[meson] minor
2020-08-13 18:28:42 +04:30
6e32145dc9
[meson] Make compatbile with 0.47.0
2020-08-13 18:28:42 +04:30
58209c86a0
[meson] Make compatbile with 0.49.0
...
Contains a just put together summary feature polyfill and workaround
to broken ternary operator.
2020-08-13 18:28:42 +04:30
1e4fe10b98
[ENOMEM] check for error in visited map during closure features.
2020-08-13 01:43:11 +04:30
9562239f05
[ENOMEM] check for error in lookup visited set.
2020-08-13 01:43:11 +04:30
eea9b59fc5
[meson] fix generating introspection
...
Only libharfbuzz_gobject is introspectable, not libharfbuzz. Therefore,
it makes no sense to target the latter for introspection: it should
instead be listed as a dependency.
2020-08-12 16:07:30 +04:30
7bffb5d7ba
Generate `has_arabic_joining`
2020-08-12 11:34:49 +04:30
6f754852c1
[ENOMEM] skip asserts in to_bias if serializer is in an error state.
2020-08-12 11:25:30 +04:30
ef2e380342
Revert "Remove cmake-config support of HarfBuzz"
...
This reverts commit 75efa89343
2020-08-12 01:00:33 +04:30
0ca3557048
Turn -Wunused-but-set-variable to warning
...
As #2555 turned out some glib headers are imposing that so let's turn it to warning
2020-08-12 00:38:00 +04:30
5193357832
Revert "Remove autotools build support"
...
This reverts commit 01ac32aab2
2020-08-11 23:51:59 +04:30
9748ae7299
Revert "Reordering fails when GDEF table is absent #2140 "
...
This reverts commit f4cd99f28ehttps://github.com/harfbuzz/harfbuzz/issues/2516#issuecomment-670969185
2020-08-11 22:51:48 +04:30
d03eecb4d6
[glyf] minor
...
style improvement
2020-08-11 16:40:40 +04:30
732a9164d9
[gvar] minor
2020-08-11 16:37:55 +04:30
0c1561894a
[glyf] minor
2020-08-10 08:52:01 +04:30
f06d7331e8
[glyf] minor
2020-08-10 08:43:54 +04:30
db96c7f67a
[glyf] protect CompositeGlyph fields
...
Introduce methods instead
2020-08-10 08:43:54 +04:30
e5fe363aa5
[glyf] Minor, don't pass accelerator_t to points_aggregator_t
...
No need to pass it to aggregator itself
2020-08-10 07:39:36 +04:30
2b9927f7e1
[glyf] minor
...
No need to pass glyph_for_gid as a lambda now that we are passing the accelerator itself
2020-08-10 06:26:21 +04:30
fce64a407d
Minor
2020-08-08 14:05:03 -06:00
ffe06c8f04
[glyf] Guard all the public APIs against null pool runs
...
Fixes https://crbug.com/oss-fuzz/24575 and https://crbug.com/oss-fuzz/24737
2020-08-08 13:43:49 +04:30
01ac32aab2
Remove autotools build support
2020-08-07 23:28:12 +04:30
1f519c2567
[glyf] Optimize retrieval of hmtx/vmtx/gvar
...
This should make glyf/gvar faster as makes it to invoke less table wrapper atomic operations and things.
$ meson build -Dexperimental_api=true --buildtype=release && ninja -Cbuild && build/perf/perf "--benchmark_filter=glyf.*- ot -"
Before:
extents/glyf - ot - SourceSerifVariable 46091 ns 46036 ns 16173
extents/glyf/vf - ot - SourceSerifVariable 4160142 ns 4154913 ns 174
extents/glyf - ot - Comfortaa 25754 ns 25726 ns 27030
extents/glyf/vf - ot - Comfortaa 2627804 ns 2624596 ns 265
extents/glyf - ot - Roboto 33556 ns 33540 ns 18513
draw/glyf - ot - SourceSerifVariable 2716848 ns 2715438 ns 256
draw/glyf/vf - ot - SourceSerifVariable 4602379 ns 4598907 ns 151
draw/glyf - ot - Comfortaa 1659364 ns 1658142 ns 417
draw/glyf/vf - ot - Comfortaa 2845100 ns 2842549 ns 246
draw/glyf - ot - Roboto 1571509 ns 1570060 ns 442
After:
extents/glyf - ot - SourceSerifVariable 34738 ns 34713 ns 21332
extents/glyf/vf - ot - SourceSerifVariable 3700510 ns 3698104 ns 187
extents/glyf - ot - Comfortaa 21604 ns 21595 ns 31907
extents/glyf/vf - ot - Comfortaa 2324787 ns 2323440 ns 296
extents/glyf - ot - Roboto 31259 ns 31246 ns 21814
draw/glyf - ot - SourceSerifVariable 2689230 ns 2687589 ns 260
draw/glyf/vf - ot - SourceSerifVariable 4625135 ns 4622036 ns 131
draw/glyf - ot - Comfortaa 1690336 ns 1689454 ns 402
draw/glyf/vf - ot - Comfortaa 2898748 ns 2897074 ns 241
draw/glyf - ot - Roboto 1570911 ns 1570138 ns 440
2020-08-07 01:21:19 +04:30
0907c10214
[gvar] minor
2020-08-07 00:15:32 +04:30
679fac87df
Skip hb_shape if buffer object is immutable
2020-08-06 23:47:35 +04:30
55c41f219f
[glyf] Clamp advance value result
...
Fixes a sanitizer complain https://circleci.com/gh/harfbuzz/harfbuzz/150247 revealed by 02d1ec1
2020-08-06 23:37:43 +04:30
02d1ec1658
[gvar] Don't fail on imprefect gvar
...
No need to fail even if gvar doesn't have that much glyphs
2020-08-06 22:18:35 +04:30
ec17b62457
[var] Apply variations on empty glyphs
...
It was ignoring empty glyphs for no good reason, this fixes it.
Fixes #2618
2020-08-06 20:16:11 +04:30
5cab55ca90
[gvar] minor
2020-08-06 18:54:58 +04:30
75efa89343
Remove cmake-config support of HarfBuzz
...
Reverts d38f37b2#2316
2020-08-03 16:45:17 +04:30
11bb8aa83e
[meson] limit check-libstdc++ check to 0.55
...
library(..., link_language: 'c') is introduced in 0.55 but we were relying on this anyway
assuming b_asneeded being true on meson.
#2614
2020-08-02 00:47:21 +04:30
9d3fbe0588
[meson] Add darwin versions to library()
...
We now have,
$ otool -L src/libharfbuzz.dylib
src/libharfbuzz.dylib:
@rpath/libharfbuzz.0.dylib (compatibility version 0.0.0, current version 0.0.0)
And with the change should we get
$ otool -L src/libharfbuzz.dylib
src/libharfbuzz.dylib:
@rpath/libharfbuzz.0.dylib (compatibility version 20700.0.0, current version 20700.0.0)
2020-08-02 00:34:29 +04:30
18ab8029d5
[ENOMEM] check vector status in cmap subsetting.
2020-08-02 00:30:17 +04:30
06dbb6acbb
[ENOMEM] in GSUB ChainContext subsetting check maps for allocation errors.
2020-08-01 09:21:22 +04:30
fb1477795c
[ENOMEM] Check result of vector resize in CBDT subsetting.
2020-08-01 09:20:52 +04:30
efd716de3f
[cff] Check for scalars array resize result
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=24504
2020-07-31 09:27:27 +04:30
040ed094ef
[ENOMEM] popragate packed/packed_map errors to the serializer.
...
Will disable further modifications based on a bad state.
2020-07-31 08:39:26 +04:30
7f358a55f4
[ENOMEM] unchecked resize in CFF2.
2020-07-31 02:04:06 +04:30
32f052b033
[ENOMEM] Fix several instances of not checking resize in CFF.
2020-07-31 02:04:06 +04:30
4cbc7d61bc
[ENOMEM] check for unset current in serializer->length().
2020-07-31 02:04:06 +04:30
15644ee60e
[ENOMEM] fix memory leak if allocation fails during pop_pack().
2020-07-30 04:15:35 +04:30
42237adffc
[ENOMEM] make serializer modification operations no-ops if it's in an error state.
2020-07-30 03:59:49 +04:30
d1f1301490
[icu] Remove support for versions older than 49
...
It just doesn't make sense anymore, c9e5da8ded (r41018112)
2020-07-30 02:01:43 +04:30
0b74aaece7
[icu] Remove useless HB_UNUSED tags
...
As c9e5da8ded (r41018040)
2020-07-30 01:47:30 +04:30
c9e5da8ded
[icu] Remove support of ICU versions before 42
...
ICU 42 is released in 2012, see also 44a3136ae6 (commitcomment-41016353)
2020-07-30 01:03:07 +04:30
4ba8e3c6fd
[ENOMEM] Fix failure to check calloc return.
...
Fixes https://oss-fuzz.com/testcase-detail/6246465148813312 .
2020-07-30 00:08:08 +04:30
d307c24abf
[ENOMEM] check resize() return.
...
Fixes https://oss-fuzz.com/testcase-detail/5641892164009984 .
2020-07-30 00:08:08 +04:30
58a5961ca1
minor spacing tweak
2020-07-29 08:44:23 +04:30
07c43b8cf6
minor spacing tweak
2020-07-29 08:42:52 +04:30
5a7cc7fd8b
minor spacing tweak
2020-07-29 08:33:38 +04:30
48ad745996
[ENOMEM] Fix buffer's content check logic
...
So now rest of shape fuzzer also can be enabled.
Fixes #2571
2020-07-29 08:09:10 +04:30
c33e8006fd
[fuzz] Implement failing allocator
2020-07-29 07:35:34 +04:30
44a3136ae6
[glib] Default to glib's script type handling
...
2.29.14 is almost released a decade ago, no need to support archaic glib versions.
2020-07-29 07:05:31 +04:30
dae32b4f12
[subset] bail out of subsetting if plan allocation fails.
2020-07-29 06:37:25 +04:30
a01c7a380b
2.7.0
2020-07-25 12:40:57 +04:30
b32f2e8b49
Remove unused code from the Khmer shaper.
2020-07-24 20:38:05 +04:30
46ec6db965
minor
2020-07-22 17:30:48 +04:30
83c44f69d3
[tests] fix PGO build testing
...
Adds 'mangle_path' to IGNORED_SYMBOLS
2020-07-21 03:05:28 +04:30
d0e2addd43
minor
2020-07-18 22:16:02 +04:30
7e3edfa454
minor
2020-07-18 19:03:36 +04:30
8e5bc535d1
[subset] call collect_mapping only when --gids option is used.
...
collect_mapping is time consuming as it iterates all codepoints in all
cmap subtables, only trigger it when necessary
2020-07-16 11:25:53 -07:00
7c433ffde2
Add HB_CUSTOM_MALLOC definition
...
So one can use just HB_CUSTOM_MALLOC instead need for define each of hb_*alloc_impl
2020-07-15 09:38:12 +04:30
60959b08e5
[meson] execute find_program('gen-ragel-artifacts.py') only once
...
should rename the script also
2020-07-14 20:28:06 +04:30
5c8e1bd237
[meson] Don't allow introspection on static library
2020-07-14 18:02:40 +04:30
9566904cb3
[morx] minor, mark with unlikely
...
at least just to show this is the unusual path
2020-07-14 15:17:17 +04:30
11d583a9ea
[aat] Consume glyph insertion from buffer's max_ops ( #2223 )
...
Glyph insertion is an expensive operation and we like to have it limited
based on buffer's input size which is handled by buffer's max_ops.
clusterfuzz-testcase-minimized-harfbuzz_fuzzer-5754958982021120:
Before the change: 0.67s user 0.00s system 99% cpu 0.674 total
After the change: 0.02s user 0.00s system 98% cpu 0.024 total
Which takes much longer on valgrind and tsan bots.
2020-07-13 18:53:06 -07:00
6937092a66
[py] apply lgtm.com python suggestions
2020-07-13 23:37:52 +04:30
2a182128b9
[py] minor, comment buffer_add_utf8 call
...
mainly to apply lgtm suggestion, looks better also however,
some minor spacing is also applied.
2020-07-13 20:41:13 +04:30
cdf18e8338
[py] minor, remove unnecessary pass
...
discovered by lgtm
2020-07-13 20:07:51 +04:30
45d9e8d76c
[py] minor, remove unused import
2020-07-13 19:25:53 +04:30
1dfa33854f
[arabic] Remove stale comment
2020-07-12 09:24:03 -07:00
6a45df0a54
Fix -Wambiguous-reversed-operator warning
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/2554
2020-07-08 18:17:40 -05:00
1e6027e29c
[aat] Correct array indexing when looking up actions in KerxSubTableFormat4 ( #2539 )
...
* [aat] Correct array indexing when looking up actions in KerxSubTableFormat4.
- For action_type 0 and 1, there are 2 values per action record; for action_type 2, there are 4. So we need to account for these factors when indexing into the ankrData array.
Fixes https://github.com/harfbuzz/harfbuzz/issues/2531 .
2020-07-05 22:44:10 +01:00
122a2897e4
[aat] Remove lcar support
...
Very low use, only two distinct font files, Apple Chancery.ttf and Hoefler Text.ttc
have it so it really doesn't worth the size addition and so, but one may argue that
whole ligature caret is low use but guess we better to encourage GDEF one anyway.
2020-07-06 00:05:36 +04:30
a3b9b94b63
[style] Remove fdsc support ( #2541 )
...
It isn't exposed yet and low use between Apple fonts,
32 fdsc table vs 767 OS/2 tables, even Apple doesn't
support it anymore per Ned.
2020-07-06 00:05:21 +04:30
a6fb8ce98a
Minor, fix -Wrange-loop-analysis warnings
...
Fixing these complains raised by newer versions of clang,
./hb-ot-layout-common.hh:1720:53: error: loop variable 'gid_klass_pair' is always a copy because the range of type 'hb_map_iter_t<hb_sorted_array_t<OT::HBGlyphID>, (lambda at ./hb-ot-layout-common.hh:1672:29), hb_function_sortedness_t::RETAINS_SORTING, nullptr>' does not return a reference [-Werror,-Wrange-loop-analysis]
for (const hb_pair_t<hb_codepoint_t, unsigned>& gid_klass_pair : + it)
And
./hb-ot-color-colr-table.hh:177:44: error: loop variable '_' is always a copy because the range of type 'hb_map_iter_t<hb_filter_iter_t<hb_map_iter_t<hb_range_iter_t<unsigned int, unsigned int>, (lambda at ./hb-ot-color-colr-table.hh:209:31), hb_function_sortedness_t::RETAINS_SORTING, nullptr>, (anonymous struct at ./hb-algs.hh:331:1) &, (anonymous struct at ./hb-algs.hh:51:1) &, nullptr>, (anonymous struct at ./hb-algs.hh:338:1) &, hb_function_sortedness_t::RETAINS_SORTING, nullptr>' does not return a reference [-Werror,-Wrange-loop-analysis]
for (const hb_item_type<BaseIterator>& _ : + base_it.iter ())
2020-07-05 11:18:04 +04:30
4444482297
meson: Pin harfbuzz in .pc files to the built version
...
This ensures that we link -subset, -icu and -gobject with a matching
version of the main library.
2020-07-04 23:16:09 +04:30
3adcf398a0
meson: Make Requires in .pc files match autotools
...
Libreoffice tries to use only harfbuzz-icu.pc and assumes this includes
-lharfbuzz.
2020-07-04 23:16:09 +04:30
6a2b0ba78a
[py] minor, replace exit with sys.exit
2020-07-04 16:16:15 +04:30
a07672d353
[py] minor, replace os.environ.get with os.getenv
2020-07-04 16:16:15 +04:30
359dbc97ae
[meson] Use the recommended way to generate harfbuzz.cc
...
As https://github.com/harfbuzz/harfbuzz/pull/2532
2020-07-04 13:55:48 +04:30
a7e82e4ffd
[meson] use the recommended way to generate hb-version.h
...
As https://github.com/harfbuzz/harfbuzz/pull/2532
2020-07-04 13:55:48 +04:30
404ecc252c
[meson] use basename in check scripts now that meson passes dir also
2020-07-04 13:55:48 +04:30
785a9a8f8a
[meson] use the recommended way to generate ragel headers
...
As described in https://github.com/mesonbuild/meson/issues/7156#issuecomment-629622827
2020-07-04 13:55:48 +04:30
5c07c291c7
[make] use sed the way autotools used to generate hb-version.h
...
Left from 1853f84 and now exactly is like 4fc6189a32
2020-07-04 04:33:46 +04:30
63322513e4
[make] Revert the way harfbuzz.cc and hb-version.h are generated
...
Partially reverts 4fc6189
2020-07-04 03:34:58 +04:30
1853f84abc
[py] overwrite harfbuzz.cc only when there is a needed change
2020-07-03 15:51:13 +04:30
82c6ddb986
[py] remove not needed imports
2020-07-03 15:51:13 +04:30
42d039cc99
[meson] minor
2020-07-03 04:49:12 +04:30
f2a80ab2c2
[meson] use null_dep idiom
2020-07-03 04:49:12 +04:30
d543923294
[fvar] minor
2020-07-02 01:30:24 +04:30
40ec187dec
win32: Cleanup PARTITION handling
...
Use the WINAPI_PARTITION macro to filter desktop/app flavors.
We use a negated desktop check because the default (for mingw-w64 at
least) is to allow all API by combining desktop + app partitions.
This causes build failures if we were to filter using
WINAPI_PARTITION(WINAPI_FAMILY_APP) because it would always be true, but
those API also require Windows 8 or later, while we only require Vista
Fixes warnings like
../src/hb-blob.cc:572:47: warning: 'WINAPI_FAMILY_PC_APP' is not defined, evaluates to 0 [-Wundef]
#if defined(WINAPI_FAMILY) && (WINAPI_FAMILY==WINAPI_FAMILY_PC_APP || WINAPI_FAMILY==WINAPI_FAMILY_PHONE_APP)
^
../src/hb-blob.cc:572:86: warning: 'WINAPI_FAMILY_PHONE_APP' is not defined, evaluates to 0 [-Wundef]
#if defined(WINAPI_FAMILY) && (WINAPI_FAMILY==WINAPI_FAMILY_PC_APP || WINAPI_FAMILY==WINAPI_FAMILY_PHONE_APP)
2020-07-01 13:05:14 +04:30
ea8e784146
[fvar] Improve naming
2020-07-01 01:33:02 +04:30
5de07b8acd
[fvar] Move normalize logic where it is actually filled
2020-07-01 01:33:02 +04:30
0f8dda2cf2
[fvar] Move shared axis filling values into a new method
2020-07-01 01:33:02 +04:30
98c42b3bc7
[fvar] Make AxisRecord fields protected
2020-07-01 01:33:02 +04:30
7ee3194f98
[meta] Remove wrong comment
2020-06-28 15:41:44 -07:00
26b9670d99
[ft] Better handle allocation failures
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/2513
2020-06-28 14:52:15 -07:00
26111a11ad
[dagger] Minor cleanup using hb_enumerate
2020-06-28 13:26:38 -07:00
08d57d9eca
Add hb_array_t::lfind
2020-06-28 13:13:25 +04:30
a783840789
Always round up
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/2496
2020-06-28 13:10:37 +04:30
2267da4ee0
[ft] Do not deference ft_font if it is nullptr ( #2502 )
2020-06-27 20:18:16 -07:00
a373e16131
[ot-shape] Free shape plan maps upon error creating data ( #2497 )
2020-06-27 20:09:45 -07:00
dbf9896e7a
[ft] Handle nullptr when destroying freetype font ( #2494 )
2020-06-27 19:57:34 -07:00
76ba619daa
Fix autotools's harfbuzz.cc build
...
How this works? gen-harfbuzzcc.py operates at its own source path (see its 7th line)
and that is reliable when used both on meson and autotools.
Just like 19ecabed
2020-06-25 01:37:52 +04:30
12a9d57292
[face] Destroy blob if face closure can not be created ( #2490 )
...
This fixes issue #2489 .
2020-06-23 12:25:43 -07:00
53b0a183c7
Remove concept of stable/unstable from build tools
...
We never practiced the concept of stable and unstable releases, let's
remove the code and always use the stable scheme.
2020-06-23 14:46:47 +04:30
e4203c1469
2.6.8
2020-06-22 12:51:22 +04:30
e541fb474c
minor, replace single hb_apply daggers with foreach
2020-06-21 10:31:39 +04:30
8bca9a420e
[fvar] minor
2020-06-21 09:18:12 +04:30
82ec9ef2e9
[fvar] minor simplification
2020-06-21 08:49:26 +04:30
4e37c48e37
[fvar] Remove get_axis_info and get_axis_deprecated
2020-06-21 08:49:26 +04:30
61c240f399
[fvar] Push _axis_info fill logic deeper
2020-06-21 08:49:26 +04:30
47a0fbec31
[meson] Mark longer tests with slow
...
So one can skip them easily by `meson test -Cbuild --no-suite slow`
2020-06-21 08:47:10 +04:30
b2d0dba5ef
[cpal] Port to dagger
2020-06-20 22:06:19 +04:30
25cf687443
Use dagger in OffsetTable::get_table_tags ( #2477 )
2020-06-19 14:06:50 -07:00
dce4353f86
Merge pull request #2476 from ebraminio/cv-get-chars
...
[layout] Use dagger in hb_ot_layout_feature_get_characters
2020-06-20 01:24:41 +04:30
89a2c46e61
[math] Use dagger ( #2478 )
...
* [math] Use dagger
* [ot-math] Address Behdad's review
2020-06-19 13:01:46 -07:00
d38eb49f46
Move the iteration logic to FeatureParamsCharacterVariants
...
Hopefully I can make members protected also.
2020-06-19 23:46:49 +04:30
9b3d4f457e
Use dagger in hb_ot_layout_feature_get_characters
...
The way it used to work was a bit nonidiomatic but the replacment
is idiomatic way of iterating used elsewhere.
The new code just doesn't check nullability of "characters", which isn't
what we do anywhere else.
2020-06-19 23:46:44 +04:30
63422c4cbc
[ot-layout] simplify
2020-06-19 23:26:18 +04:30
407bba3e0d
minor
...
move FeatureParamsCharacterVariants::sanitize method right above members
2020-06-19 23:12:56 +04:30
f1488152bd
[doc] Remove the not needed comment
...
All the other similar iterating API are like this and don't have such
comment, written at the time I wasn't familiar enough with the way such
API are shaped.
2020-06-19 23:07:30 +04:30
1535440b48
[dispatch] Fix debug builds
2020-06-19 08:32:57 -07:00
bb9a40da65
[lcar] Use dagger
2020-06-19 19:22:47 +04:30
6fbb59aba6
Use daggers in a few get_array functions
...
As I review https://github.com/harfbuzz/harfbuzz/pull/2471
2020-06-19 00:05:52 -07:00
a512ca8eae
Merge pull request #2473 from harfbuzz/gsub-alternate
...
fixes #673
2020-06-19 10:46:12 +04:30
70d6696cc6
[dispatch] Don't require debug_depth for untraced objects
2020-06-18 17:09:39 -07:00
5bc4cedde6
Rename
2020-06-18 17:04:35 -07:00
dc492d7c8a
[dispatch] Comment
2020-06-18 17:03:05 -07:00
25aec0265c
[dispatch] Default return type to hb_empty_t
2020-06-18 16:58:01 -07:00
8d0a90ac1b
[dispatch] Default debug level to 0
2020-06-18 16:53:54 -07:00
d7d8604ec8
Remove excessive trace routes
2020-06-18 16:51:24 -07:00
e47a2ab8f8
Remove unused dispatcher names
2020-06-18 16:48:07 -07:00
b2a1acccd9
Simplify get_glyph_alternates() dispatcher
...
Trying to make it **very simple** to add a specialized dispatcher for
one API to be routed to just a few objects (one in this case).
2020-06-18 16:41:31 -07:00
ffe8d3f39d
Use dispatch for get_glyph_alternates_t
...
First time we do this in a way that if target object doesn't have the matching
function we basically "ignore". Risky but I feel like is the right decision
for this case.
I'm going to put back the template varargs and use those, which would make
the dispatcher be just that: "dispatcher", and wouldn't need to carry the
call context. That would be a refreshing change I think.
2020-06-18 16:31:39 -07:00
bedf417121
Push get_glyph_alternates() work all the way down
2020-06-18 15:49:01 -07:00
5bede33885
Whitespace
2020-06-18 15:25:19 -07:00
e13aaaaa45
Move API to right place in header
2020-06-18 15:22:54 -07:00
26514ad70e
Fix API comment
2020-06-18 15:22:07 -07:00
1bac85828c
[layout] Rename _get_alternates to _get_glyph_alternates
2020-06-18 22:56:07 +04:30
David Corbett
Simon Cozens
Fabrice Fontaine
Behdad Esfahbod
Laurenz
Garret Rieger
Qunxin Liu
Koji Ishii
Khaled Hosny
n8willis
Nathan Willis
ebraminio
Khaled Hosny
Alexander Kanavin
Ross Burton
David Corbett
Tom Schoonjans
Evgeniy Reizner
insilications
jfkthame
Jan Alexander Steffens (heftig)
Hugo Beauzée-Luyssen
Sebastian Rasmussen