4941e95f10
2.3.0
2018-12-20 21:48:57 -05:00
87f7c83fff
[serializer] Add operator <<
...
Not sure if we are going to use it. But might incentivize us to.
2018-12-20 15:54:17 -05:00
5b70074edf
Add hb_assign(obj, value)
2018-12-20 15:38:59 -05:00
6124123393
[serialize] Adjust ClassDef
...
[skip ci]
2018-12-20 12:26:44 -05:00
4220b7bdd7
Fix code on big-endian gcc / clang
...
Ouch! We need a bigendian bot...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1498
2018-12-20 11:48:45 -05:00
c87ee72232
Minor [skip ci]
2018-12-19 22:28:16 -05:00
5000a59a63
[saitnize] Minor
2018-12-19 22:27:09 -05:00
3ee4ea9456
Fix build on older Visual Studio versions ( #1499 )
...
* src/hb-cff-interp-dict-common.hh: Use ull for unsigned int64_t
The llu suffix does not work for older Visual Studio versions
(pre-2013), but ull works for all the compilers that we attempt to
support.
* test/api: Fix build on pre-C99 compilers
Ensure variables are declared at the top of the block.
* src/hb-dsalgs.hh: Add specialization for hb_is_signed<> for __int8
Pre-Visual Studio 2010 does not consider __int8 (which is typedef'ed to
int8_t) to be equivilant to signed char, so the compiler cannot find the
corresponding hb_is_signed<> specialization that is needed.
The interesting thing is unsigned __int8 is considered to be equivilant
to unsigned char, so as the other types (short, int, long) that we look
for here, so only the specialization for __int8 is added here.
This will fix builds on Visual Studio 2008 at least.
2018-12-19 22:26:54 -05:00
a62870506d
[sanitize] Use hb_static_size instead of ::static_size
...
https://github.com/harfbuzz/harfbuzz/issues/1496#issuecomment-448818112
2018-12-19 21:05:00 -05:00
0c9cd5d5f4
[test] Fix test-name-table.cc leak issue
...
Spotted it accidentally but wanted to see if is anything serious so went for fixing it
2018-12-19 21:18:30 +03:30
3d9d7dc4dd
[arrays] Add hb_ubytes_t for unsigned char
2018-12-18 22:11:23 -05:00
f1e95e40ed
[arrays] Remove hb_supplier_t<>
2018-12-18 16:49:08 -05:00
f9417af29b
[serialize] Propagate error from hb-face
2018-12-18 13:23:32 -05:00
9aebfb4182
[serialize] Streamline error propagation
2018-12-18 13:22:17 -05:00
969ff3c7aa
Remove unused hb-iter.hh
...
The ideas there are all part of hb-array.hh now. To be determined how we
want to use generic iterator patterns.
2018-12-17 22:43:00 -05:00
b1094fc2d2
[arrays] Minor tweaks to hb_supplier_t
...
I think I like to keep this hb_supplier_t thing separately from hb_array_t.
2018-12-17 22:41:04 -05:00
cf39c24205
[arrays] Rename Supplier to hb_supplier_t
2018-12-17 22:36:23 -05:00
6b5eaa7530
Hide hb_addressof()
2018-12-17 21:55:33 -05:00
6befa75cdf
Enable __builtin_* on clang
...
We'll see which old clang versions this breaks...
2018-12-17 20:35:45 -05:00
8d2d410256
Add hb_addressof() and use it to fix bug after hb_bytes_t merge
...
We cannot take address hb_bytes_t direction. We need to use the
newly added hb_addressof(), ala std::addressof().
2018-12-17 20:23:26 -05:00
49334f9b50
Enable system extensions in hb.hh
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1491
2018-12-17 18:27:36 -05:00
37c14bc745
Fix Solaris use after free ( #1495 )
2018-12-17 17:59:37 -05:00
483f2491e4
Remove define GNU_SOURCE
...
Not needed. We get it in our config.h automatically thanks to
AC_USE_SYSTEM_EXTENSIONS. Let's see whose build it breaks...
If we end up putting it back, we should add other things from
that macro and remove the macro.
2018-12-17 17:56:10 -05:00
87ff65aea1
Fix more warnings
2018-12-17 17:19:54 -05:00
f9d219a174
Fix Solaris Trailing comma in enum warnings ( #1490 )
2018-12-17 17:18:47 -05:00
244a8627f7
Lower coretext_aat shaper priority ( #1488 )
...
Related to https://github.com/harfbuzz/harfbuzz/issues/1478
2018-12-17 13:01:43 -05:00
e412008599
Remove redundant void from C++ sources ( #1486 )
2018-12-17 13:01:01 -05:00
7ace10078c
Minor, fix two more ArrayOf incorrect operator logic
2018-12-17 20:07:04 +03:30
a1240383aa
[arrays] Minor fix
2018-12-17 10:44:14 -05:00
381c3548e9
[array] Add cast operator to add const to Type
...
In lieu of constructor removed in previous commit.
2018-12-17 00:39:30 -05:00
15acf33c22
[array] Remove problematic constructor
2018-12-17 00:38:13 -05:00
470369a871
[array] Add arithmetic operators
2018-12-17 00:21:38 -05:00
6cd60c2f2a
[array] Return Crap instead of Null if Type is not const
...
Ouch!
2018-12-17 00:09:06 -05:00
94e72cf1c9
[array] Add operator *
2018-12-17 00:06:40 -05:00
68d4a5eee0
[array] Add constructor from fixed-size array
2018-12-17 00:02:42 -05:00
a4354d2fd3
[array] Organize
2018-12-16 23:57:27 -05:00
84c1865821
[arrays] Reduce Supplier<> even further
2018-12-16 23:52:17 -05:00
1bcc4fc9f3
Whitespace
2018-12-16 23:47:56 -05:00
f85f6e815f
[array] Add operator +=
2018-12-16 23:45:07 -05:00
7c0e3e9b2b
[array] Add constructor from hb_array_t<const Type>
2018-12-16 23:43:17 -05:00
92680361ec
[arrays] Move Supplier<> to hb-array.hh
2018-12-16 23:38:51 -05:00
2a3fa3f82f
[arrays] Remove unnecessary constructor from Supplier<>
...
Looks like operator hb_array_t<> from vector works here. :)
2018-12-16 23:33:03 -05:00
507cac4943
[arrays] Start moving Supplier<> to hb_array_t<>
2018-12-16 23:31:19 -05:00
1e2c98126e
[arrays] Remove unused stride from Supplier
2018-12-16 22:31:16 -05:00
0d0fe9df46
[arrays] Remove need of stride in Supplier<>
2018-12-16 22:31:13 -05:00
dcfa4a8d71
[array] Remove custom hb_bytes_t implementation
2018-12-16 22:31:13 -05:00
3656f56d47
[arrays] Minor
2018-12-16 22:31:13 -05:00
aa8f94714e
[array] Minor
2018-12-16 22:31:13 -05:00
5a552f7546
[array] Move hb_array_t and related types to hb-array.hh
2018-12-16 22:31:10 -05:00
01d06e34ff
Minor change to explicit_operator aesthetics
2018-12-16 14:27:43 -05:00
b2ebaa9afa
Remove redundant 'inline' from methods ( #1483 )
2018-12-16 14:08:10 -05:00
7251c77290
Whitespace
2018-12-15 21:00:55 -05:00
829b56b1a2
Whitespace
2018-12-15 16:20:13 -05:00
42a1012562
[subset] Actually subset GDEF
2018-12-13 19:39:59 -05:00
c9c746c7f6
[subset] Fix up ClassDef some more
2018-12-13 18:39:30 -05:00
7ee6128902
[subset] Fix ClassDefFormat1 subsetting
2018-12-13 18:32:04 -05:00
1b6d0c44b3
[subset] Sketch GDEF subsetting
2018-12-13 18:10:48 -05:00
705e2f5056
[subset] Implement for ClassDef
2018-12-13 17:48:42 -05:00
6e33a3955d
Minor
2018-12-13 16:40:01 -05:00
cc65901ca7
[serialize] Implement for ClassDef
2018-12-13 16:01:45 -05:00
e5309e4fd8
[serialize] Implement for ClassDefFormat2
2018-12-13 15:57:12 -05:00
c8b43cbe31
[serialize] Implement for ClassDefFormat1
2018-12-13 15:53:00 -05:00
5761031329
[subset] Minor
2018-12-12 21:21:26 -05:00
798e98c47b
[CFF] bad offset in Index ( #1476 )
...
* Update hb-ot-cff-common.hh
* fix bug
* bummer fix wasn't hit. refix
* additional sanity check
* Added test cases for oss-fuzz issues 11805, 11806
2018-12-12 21:08:15 -05:00
bcb4ecaf68
[CFF] check out of range FD index ( #1477 )
...
* add fd index checks to subr subsetter
also added oss-fuzz test case
* undid SubrSubsetParam::is_valid
because already validated by SubrClosures.valid
2018-12-12 20:36:01 -05:00
2cc993e035
[dispatch] Minor
2018-12-12 10:07:38 -05:00
602fbfe3c9
[sanitize] Fix sanitizing sublookup array
2018-12-12 09:56:47 -05:00
c78e4784fb
[dispatch] Minor
2018-12-12 09:50:18 -05:00
f9d211af1d
Revert "Minor fix re sanitize of Lookup subtables"
...
This reverts commit 7146718bef
2018-12-12 09:44:30 -05:00
7ee5c52345
minor style fix, use void in methods on no argument
2018-12-12 15:14:37 +03:30
7146718bef
Minor fix re sanitize of Lookup subtables
...
We were dereferencing Null pointers and trying to sanitize them,
which is not necessary...
2018-12-11 23:44:29 -05:00
ce069d1932
Minor
2018-12-11 23:07:48 -05:00
1aea869446
[subset] Map glyphs during SingleSubst subsetting
...
Ha!
2018-12-11 22:53:58 -05:00
41d1a1c10f
[subset] Minor
2018-12-11 22:48:27 -05:00
2aba2c6c73
[serialize] Break down assert
2018-12-11 21:21:13 -05:00
2941208f1e
[CFF] oss-fuzz issue 11690 ASSERT: substr.offset >= opStart ( #1461 )
...
* fix oss-fuzz 11690: substr.offset >= opStart
detect recursive subroutine call & handle as error
* fix build failure
* add minimized test case for oss-fuzz 11690
* removed asserts
2018-12-11 15:21:24 -05:00
333586245c
minimize use of assert: removed or changed to error handling ( #1467 )
2018-12-11 15:20:20 -05:00
9f3a51ddb9
[ucdn] Fix header
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1470
2018-12-11 13:38:05 -05:00
1683bb2c93
[glyf] minor
2018-12-08 13:57:39 +03:30
f7cfe99815
[os2] Move typometrics detection logic to the table ( #1465 )
2018-12-08 13:40:44 +03:30
47cf9a9633
Apply non-controversial parts of ot-style ( #1464 )
...
Things to be used in https://github.com/harfbuzz/harfbuzz/pull/1459
2018-12-08 10:20:25 +03:30
4d809696ef
fix for issue #1447 ( #1462 )
...
Added case for OpCode_BaseFontName. This opcode in spec but practically unused.
Added a comment for default case which can't be hit
2018-12-07 20:49:39 -08:00
1abd4fcaec
[fdsc] minor
2018-12-07 22:34:12 +03:30
59345cdef3
[CFF] Refix oss-fuzz 11714: set_blends (PR #1458 ) ( #1460 )
...
* pass subarray of stack to set_blends
* get_subarray to return a value, not ref
* restored error check (with tweak)
2018-12-06 13:36:26 -08:00
20245f0000
Fix likely check
...
Ouch!
2018-12-06 10:27:37 -08:00
d866e905fd
Add default value to first argument of sub_array()
2018-12-06 10:26:32 -08:00
f1352f7486
Add sub_array to hb_vector_t
2018-12-06 10:21:17 -08:00
ca23b71935
Add default-value for second arg of sub_array()
2018-12-06 10:21:17 -08:00
1ccbdcf73b
Merge branch 'master' into cff-check-blends
2018-12-05 21:37:38 -08:00
14d29a1043
check number of blends against args on stack
2018-12-05 21:33:29 -08:00
f95324a335
Merge pull request #1457 from harfbuzz/cff-varstore-sanitize
...
[CFF] oss-fuzz issue 11713 (CFF2VariationStore::serialize)
2018-12-06 08:33:44 +03:30
c31092ab34
sanitize variationStore in CFF2 against its size
2018-12-05 17:04:55 -08:00
34e3ef8ff3
Merge branch 'master' into cff-subr-sanitize
2018-12-05 15:50:05 -08:00
d9dabc00e9
Merge pull request #1454 from harfbuzz/cff-fixbcd
...
[CFF] fix oss-fuzz issue 11674: parse_bcd
2018-12-05 15:39:34 -08:00
6dcfda92c1
sanitize CFF1 & CFF2 global subrs
2018-12-05 15:07:46 -08:00
6708c5595f
fix oss-fuzz issue 11675 (ASSERT: count <= str.len)
...
Also added an additional error check to avail ()
2018-12-05 12:51:18 -08:00
2cb9d4c183
Merge branch 'master' into cff-fixbcd
2018-12-05 11:25:29 -08:00
a5fa843c74
fixed a bug with fractional part in a negative value
2018-12-05 11:18:16 -08:00
8394a6cb25
[os2] Make newer table fields accessible ( #1452 )
2018-12-05 15:23:41 +03:30
5ab086ebb1
[fdsc] Implement the table parsing
...
Related to https://github.com/harfbuzz/harfbuzz/issues/1337
May used in addition to an API related to STAT.
Lots of Apple fonts have it.
2018-12-05 14:48:31 +03:30
8f80e53341
[gasp] Implement the table parsing
...
May or may not be used in https://github.com/harfbuzz/harfbuzz/pull/1432
2018-12-05 14:48:31 +03:30
79e7e3445e
Merge pull request #1449 from harfbuzz/cff-fixcharset
...
[CFF] fix for oss-fuzz 11657: Charset overrun
2018-12-05 13:25:18 +03:30
cf4b7db6b1
Merge pull request #1448 from harfbuzz/cff-leak
...
[CFF] fix leak: oss-fuzz 11662
2018-12-05 13:23:23 +03:30
620d1ef588
fix unsigned long const
2018-12-05 00:36:11 -08:00
28dfb4c142
fix signed/unsigned comparison
2018-12-05 00:26:03 -08:00
f9cee08edd
use sized int types in parse_bcd
2018-12-04 23:58:26 -08:00
c01a5f32a3
refix
2018-12-04 23:23:23 -08:00
755fefc921
fix bug
2018-12-04 23:18:28 -08:00
0e81b153af
fix typo
2018-12-04 22:40:07 -08:00
85d4b15cd8
include float.h
2018-12-04 22:30:33 -08:00
5a7c371e4c
check overflow & clamp
2018-12-04 22:24:38 -08:00
32cc46c75a
[CFF] fix oss-fuzz issue 11670: NULL dereference ( #1450 )
...
* guard against no subr access
* code tweak
* add minimized testcase for oss-fuzz 11670 (Null deference)
2018-12-05 09:02:34 +03:30
d3d2f32c6e
fix oss-fuzz 11657: buffer overrun
...
Check overrun in Charset1_2::get_glyph
2018-12-04 13:51:26 -08:00
d0a250a7b1
Reuse hb_aat_layout_has_* logic in coretext-aat detection logic ( #1442 )
2018-12-04 23:42:13 +03:30
803d2f92dc
Merge branch 'master' into cff-leak
2018-12-04 11:01:26 -08:00
6ce8d10b45
add unlikely to error handling
2018-12-04 10:39:17 -08:00
0b952e6026
more leak fixes
2018-12-04 10:22:35 -08:00
9473463f5c
fix attempt for oss-fuzz 11662 leak
2018-12-04 09:58:48 -08:00
04f2ca9421
removed assert
2018-12-04 09:24:07 -08:00
c968869f21
Merge pull request #1441 from harfbuzz/cff-doublenum
...
use double as CFF Number implementation
2018-12-04 04:14:13 -05:00
c48f53d309
more double changes
2018-12-03 16:59:41 -08:00
5fff6ab002
additional precision made a difference in extents test
2018-12-03 16:06:58 -08:00
9e5180cd44
more double changes
2018-12-03 15:32:42 -08:00
9af33d7a2a
Number to use double for all types
2018-12-03 14:48:46 -08:00
01f628cf55
[aat] Expose hb_aat_layout_has_tracking API
2018-12-03 22:27:26 +03:30
d19b1680b5
[aat] Expose a couple APIs
...
New API:
+hb_aat_layout_has_substitution()
+hb_aat_layout_has_positioning()
2018-12-03 10:41:37 -05:00
84efe0438e
[aat] Fix division sign fallout
...
Happened after 11d2f49af8
2018-12-02 12:39:14 -05:00
2087f5a2a7
Add casts to hb_array_t<>
2018-12-01 20:04:45 -05:00
58d4d19947
Simplify build source list
2018-12-01 19:34:18 -05:00
11d2f49af8
New approach to change BigEndian casts to be int-sized
...
Fixes spurious warnings like:
Fixes https://github.com/harfbuzz/harfbuzz/issues/1436
2018-12-01 13:12:21 -05:00
50e0273ab1
Change hb_assert_unsigned_t<> to hb_is_signed<>
2018-12-01 13:07:49 -05:00
c3a8b047aa
Revert "Change BigEndian casts to be int-sized"
...
This reverts commit eb5ddd32bf
2018-12-01 00:26:39 -05:00
be45677ab6
Minor
2018-12-01 00:04:29 -05:00
eb5ddd32bf
Change BigEndian casts to be int-sized
...
Fixes spurious warnings like:
Fixes https://github.com/harfbuzz/harfbuzz/issues/1436
2018-12-01 00:03:01 -05:00
e8860fdcaa
Fix more warning
2018-11-30 23:38:24 -05:00
af349ee348
Fix warning
2018-11-30 23:20:50 -05:00
825df6dbc7
[CFF] Change spaces to tabs
2018-11-30 23:04:59 -05:00
592f39b3c4
[CFF] Whitespace
2018-11-30 22:54:57 -05:00
a2e8d1d455
Minor
2018-11-30 22:54:20 -05:00
5e64e0f532
Merge pull request #1113 from harfbuzz/cff-subset
...
CFF/CFF2 subsetter
2018-11-30 22:40:54 -05:00
09096aa89f
Use nullptr instead of 0/NULL. ( #1435 )
...
* Use nullptr instead of 0/NULL.
* Update test-name-table.cc
2018-11-30 22:22:49 -05:00
d8c6913765
undo 0u
2018-11-30 18:58:14 -08:00
2c859b3880
Merge branch 'master' into cff-subset
2018-11-30 18:47:34 -08:00
fb05908213
Revert ugly fixes
...
Now that we have 6daf45e0, revert cryptic hacks...
This reverts commit abd81ed4f59c6921c08cd39760cabffedd8e6c17https://github.com/harfbuzz/harfbuzz/issues/1374
2018-11-30 20:56:15 -05:00
dfad19ad5a
Make operator [] take signed int
...
The built-in operator takes signed int. So, match it, such that
the built-in is never a better or equally-good match to our operator.
Fixes "ambiguous overload" errors from gcc 4.2 and VS 2008.
See https://github.com/harfbuzz/harfbuzz/issues/1374
2018-11-30 20:56:14 -05:00
9483da145d
redo fixes
2018-11-30 16:59:41 -08:00
291da44823
yet another
2018-11-30 16:50:46 -08:00
b1821b9d09
some more
2018-11-30 16:31:01 -08:00
9784cff556
fix another pesky gcc error
2018-11-30 16:07:08 -08:00
23a797b443
silence picky gcc errors
2018-11-30 15:15:31 -08:00
9ae954f43a
Merge branch 'master' into cff-subset
2018-11-30 15:00:52 -08:00
fedd8e6c17
One more.........
...
I wonder if there's something better to do about these :(.
In file included from hb-ot-color.cc:31:
hb-ot-color-cpal-table.hh: In member function 'unsigned int OT::CPAL::get_size() const':
hb-ot-color-cpal-table.hh:118: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
2018-11-30 16:50:30 -05:00
bc5db9b080
One more....
...
hb-ot-vorg-table.hh:96: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-vector.hh:87: note: candidate 1: const Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) const [with Type = OT::VertOriginMetric, unsigned int PreallocedCount = 8u]
hb-ot-vorg-table.hh:96: note: candidate 2: operator[](const T*, int) <built-in>
2018-11-30 16:04:52 -05:00
d39760cabf
One more...
...
Sigh.
hb-ot-kern-table.hh: In member function 'int OT::KernSubTableFormat3<KernSubTableHeader>::get_kerning(hb_codepoint_t, hb_codepoint_t) const':
hb-ot-kern-table.hh:59: error: ambiguous overload for 'operator[]' in 'kernValue[kernIndex[i]]'
hb-ot-kern-table.hh:59: note: candidates are: operator[](T*, int) <built-in>
hb-dsalgs.hh:574: note: Type& hb_array_t<Type>::operator[](unsigned int) const [with Type = const OT::IntType<short int, 2u>]
2018-11-30 15:55:30 -05:00
9c6921c08c
More...
...
hb-ot-layout-gsubgpos.hh:1707: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
...
2018-11-30 15:16:57 -05:00
f998bb2086
More weird fixes
...
In file included from hb-ot-name.cc:29:
hb-ot-name-table.hh: In member function 'unsigned int OT::name::get_size() const':
hb-ot-name-table.hh:157: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-open-type.hh:354: note: candidate 1: const Type& OT::UnsizedArrayOf<Type>::operator[](unsigned int) const [with Type = OT::NameRecord]
hb-ot-name-table.hh:157: note: candidate 2: operator[](const T*, int) <built-in>
hb-ot-name-table.hh: In member function 'void OT::name::accelerator_t::init(hb_face_t*)':
hb-ot-name-table.hh:196: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-dsalgs.hh:574: note: candidate 1: Type& hb_array_t<Type>::operator[](unsigned int) const [with Type = const OT::NameRecord]
hb-ot-name-table.hh:196: note: candidate 2: operator[](T*, int) <built-in>
hb-ot-name-table.hh:197: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-dsalgs.hh:574: note: candidate 1: Type& hb_array_t<Type>::operator[](unsigned int) const [with Type = const OT::NameRecord]
hb-ot-name-table.hh:197: note: candidate 2: operator[](T*, int) <built-in>
hb-ot-name-table.hh:198: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-dsalgs.hh:574: note: candidate 1: Type& hb_array_t<Type>::operator[](unsigned int) const [with Type = const OT::NameRecord]
hb-ot-name-table.hh:198: note: candidate 2: operator[](T*, int) <built-in>
make[4]: *** [libharfbuzz_la-hb-ot-name.lo] Error 1
make[3]: *** [all-recursive] Error 1
2018-11-30 12:52:21 -05:00
abd81ed4f5
Umm. Cryptic, yes
...
In file included from hb-face.cc:35:
hb-ot-cmap-table.hh: In member function 'void OT::CmapSubtableFormat4::_compiles_assertion_on_line_388() const':
hb-ot-cmap-table.hh:388: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-open-type.hh:354: note: candidate 1: const Type& OT::UnsizedArrayOf<Type>::operator[](unsigned int) const [with Type = OT::IntType<short unsigned int, 2u>]
hb-ot-cmap-table.hh:388: note: candidate 2: operator[](const T*, int) <built-in>
hb-ot-cmap-table.hh: In member function 'void OT::CmapSubtableFormat4::_instance_assertion_on_line_388() const':
hb-ot-cmap-table.hh:388: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-open-type.hh:354: note: candidate 1: const Type& OT::UnsizedArrayOf<Type>::operator[](unsigned int) const [with Type = OT::IntType<short unsigned int, 2u>]
hb-ot-cmap-table.hh:388: note: candidate 2: operator[](const T*, int) <built-in>
hb-face.cc: In function 'hb_blob_t* _hb_face_builder_data_reference_blob(hb_face_builder_data_t*)':
hb-face.cc:650: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) [with Type = hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount = 32u]
hb-face.cc:650: note: candidate 2: operator[](T*, int) <built-in>
hb-face.cc:650: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) [with Type = hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount = 32u]
hb-face.cc:650: note: candidate 2: operator[](const T*, int) <built-in>
hb-face.cc:651: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) [with Type = hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount = 32u]
hb-face.cc:651: note: candidate 2: operator[](T*, int) <built-in>
hb-face.cc:651: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) [with Type = hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount = 32u]
hb-face.cc:651: note: candidate 2: operator[](const T*, int) <built-in>
2018-11-30 11:52:41 -05:00
0f32c95e14
Fix a few more sizeof(vector[0]) errors with weird compilers
2018-11-30 11:31:39 -05:00
88630a458b
Fix build for realz
2018-11-30 01:11:04 -05:00
346286d04e
Fix build
2018-11-30 00:44:40 -05:00
31f39cb41e
[post] Rename v2 to v2X
2018-11-30 00:38:08 -05:00
e3dd47e602
Move things
2018-11-30 00:32:12 -05:00
27a6b0a2f7
Fix build for realz
2018-11-29 16:29:30 -05:00
e2af4dd1ec
[uniscribe] Fix build
2018-11-29 16:03:24 -05:00
e7bd29ea11
Limit __builtin_bswap16 to GCC >= 5 as it was implemented on 4.8
2018-11-29 23:47:20 +03:30
ac0264717b
[coretext] Fix compile
...
Fingers crossed.
2018-11-29 15:07:44 -05:00
5c4fead734
Convert "static const hb_tag_t" constants to enum
2018-11-29 15:05:47 -05:00
9e4138c825
Convert misc "static const" constants to enum
2018-11-29 15:01:10 -05:00
44cbd2ea3d
Convert "static const bool" constants to anonymous enum
2018-11-29 14:56:27 -05:00
861bc75349
[vector] Make pointer cast explicit
...
Too bad this doesn't help MSVC 2008 build, as explicit operators are
C++11.
2018-11-29 14:34:44 -05:00
72955e6825
Hand-hold older compilers
2018-11-29 14:28:44 -05:00
000d4b128e
Make shaper's override_features() override user features as well
...
The override_features is used to override features that are normally
discretionary features, but in a specific shaper are for various
reasons desired to be bolted on or off, because they've been used
for inherent shaping. As such, it makes sense that they also
override user features. Ie. if user turned 'liga' on, we don't
want Khmer shaping to become broken... Or turn 'clig' off...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1310
2018-11-29 12:32:47 -05:00
a95d9d8c84
[khmer] Move 'clig' to overrides
...
Prerequisite for https://github.com/harfbuzz/harfbuzz/issues/1310
2018-11-29 12:32:04 -05:00
282ce7230b
Fix "typename outside template" issues
...
Nothing an extra template class wouldn't fix...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1419
2018-11-29 12:18:14 -05:00
dc41ecef85
2.2.0
2018-11-29 11:53:53 -05:00
7b85081be4
[icu] Minor
2018-11-29 11:34:22 -05:00
0bcb1de126
Merge pull request #1418 from gvictor/replace_icu_deprecated
...
Replace @Deprecated ICU API - USCRIPT_CODE_LIMIT
2018-11-29 10:39:18 -05:00
471db3aa6f
workaround for issue #1417
2018-11-28 17:06:11 -08:00
32d291ae89
Merge branch 'master' into cff-subset
2018-11-28 16:27:45 -08:00
42a2b496e4
[kerx] Fix Format2 index calc again
2018-11-28 15:24:30 -05:00
a3267cf803
[kern] Fix kern table Format2 offsetToIndex
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1421
2018-11-28 15:06:01 -05:00
f9a9c0fd1e
[kerx] Fix ClassTable implementation for 'kern' table Format 2
2018-11-28 14:51:56 -05:00
5b4a789ca8
[aat] Towards adding two ClassTable's
2018-11-28 14:49:45 -05:00
987f418772
Merge pull request #1398 from Adenilson/bigInt01
...
Optimize harfbuzz big integer conversions
2018-11-27 17:40:32 -05:00
4e2a03b6b6
Comment
2018-11-27 17:40:09 -05:00
4a719a7f4c
Optimize harfbuzz big integer conversions
...
Profiling showed that type conversions were adding considerable cycles in time
spent doing text shaping.
The idea is to optimize it using native processor instructions to help Blink
layout performance.
Doing further investigation revelead that compilers may not use the
proper instruction on ARM 32bits builds (i.e. REV16).
One way to insure that the generated ASM was ideal for both gcc/clang
was using __builtin_bswap16.
Added bonus is that we no longer need to test for CPU architecture.
2018-11-27 13:43:05 -08:00
a85886fc77
Replace @Deprecated ICU API - USCRIPT_CODE_LIMIT
...
Use of the deprecated API USCRIPT_CODE_LIMIT prevents harfbuzz
using the ICU4C as a shared library.
The API has been replaced by u_getIntPropertyMaxValue(UCHAR_SCRIPT)
2018-11-27 11:51:45 +00:00
574d888c8a
[aat] Ignore GSUB table of Muthu Foundry if they have morx table
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1410
2018-11-25 16:51:22 -05:00
4151c2848d
[GDEF] Move more code
2018-11-25 16:38:36 -05:00
4f21703f22
[GDEF] Move code around
2018-11-25 15:59:18 -05:00
4ed9fb1a00
[GDEF] Minor
2018-11-25 15:53:20 -05:00
926f512f35
[aat.feat] Rework API and implementation
...
Fixes https://github.com/harfbuzz/harfbuzz/pull/1346
2018-11-25 01:16:02 -05:00
84dacbca7e
[aat.feat] Add _MAX_VALUE to enums
2018-11-25 01:16:02 -05:00
3922aae162
[aat.feat] Minor
2018-11-25 01:16:02 -05:00
0f8e98eca2
[aat.feat] Whitespace
2018-11-25 01:16:02 -05:00
c225606833
[aat.feat] Port to SortedUnsizedArrayOf.bsearch()
2018-11-25 01:16:02 -05:00
52ae9867ef
[AAT.feat] Use lsearch for looking up SettingName's
...
They are not sorted.
2018-11-25 01:16:02 -05:00
44b9331f66
[aat] Fix include issues
2018-11-25 01:16:02 -05:00
b206133d1f
[aat] Move contents of hb-aat.h to hb-aat-layout.h
...
Since it was pages and pages...
2018-11-25 01:16:02 -05:00
2cb235d021
[aat.feat] Fix enum namespace
2018-11-25 01:16:02 -05:00
712762cabb
Minor
2018-11-25 01:16:02 -05:00
e20f81f4fa
[aat] Rename feat API a bit more
2018-11-25 01:16:02 -05:00
54f4c17f0a
[feat] Rename API uses of setting to selector
2018-11-25 01:16:02 -05:00
9c64b216ec
[feat] Apply renamings and add documentation
2018-11-25 01:16:02 -05:00
a8726cb483
[feat] Use bsearch
2018-11-25 01:16:02 -05:00
4009a05ca7
[feat] Address Behdad comments
2018-11-25 01:16:02 -05:00
19b6025534
[feat] Address @behdad comments
2018-11-25 01:16:02 -05:00
9212ec203c
[feat] Complete feature types list
2018-11-25 01:16:02 -05:00
fbad794bd2
[feat] Add feature iteration API
2018-11-25 01:16:02 -05:00
7a0471aa35
[feat] Turn AAT feature id into enum
2018-11-25 01:16:02 -05:00
b233fa4bc9
[feat] Rename records to selectors as @drott
2018-11-25 01:16:02 -05:00
a157b3e4eb
[feat] Apply @behdad comments
2018-11-25 01:16:02 -05:00
3aff3f822f
[feat] Apply @drott and @jfkthame comments
2018-11-25 01:16:02 -05:00
b791bbbae4
[feat] Apply @jfkthame reviews
2018-11-25 01:16:01 -05:00
95abd53758
[feat] Expose public API
...
* hb_aat_get_feature_settings
2018-11-25 01:16:01 -05:00
9326912941
[kerx] Fix crash
2018-11-25 00:27:23 -05:00
6ee401049d
Simplify sanitize set_object() / fix bots
2018-11-25 00:21:13 -05:00
c5a6b355e1
[kerx] Port to hb_sanitize_with_object_t
2018-11-24 23:49:23 -05:00
c405ed0509
[morx] Port to hb_sanitize_with_object_t
2018-11-24 23:46:15 -05:00
1e8994221f
Add hb_sanitize_with_object_t
...
Context manager.
2018-11-24 23:38:06 -05:00
b3c5affc05
Simplify sanitize set_object()
2018-11-24 23:34:34 -05:00
3d30972699
[aat] Skip terminator in VarSizedBinSearchArray<>
...
Fixes shaping with Apple Chancery on 10.13 again. In that font,
there was a terminator segment, that was tripping off sanitize().
2018-11-24 23:12:28 -05:00
4202a3cde3
Minor
2018-11-24 22:49:50 -05:00
1c2302bbf1
[debug] Print function in return_trace()
2018-11-24 22:32:17 -05:00
748198a671
Revert "[aat.morx] Remove set_object() business"
...
This reverts commit ae8ed58a6e
2018-11-24 22:16:59 -05:00
c8a2dc820e
Revert "[aat.kerx] Remove kerx subtable boundary enforcement"
...
This reverts commit 15905a2a29
2018-11-24 22:16:53 -05:00
9eeebd8dde
Revert "[sanitize] Remove now-unused set_object() machinery"
...
This reverts commit bbdb6edb3e
2018-11-24 22:16:47 -05:00
f47c5da0aa
[arrays] Use hb_array_t<> in all places with sub_array()
2018-11-24 21:36:57 -05:00
3246a8ebbd
[arrays] Merge ArrayOf's sub_array into hb_array_t's
2018-11-24 21:32:00 -05:00
bbdb6edb3e
[sanitize] Remove now-unused set_object() machinery
2018-11-24 17:15:38 -05:00
15905a2a29
[aat.kerx] Remove kerx subtable boundary enforcement
...
Have not encountered fonts needing this, but same reasoning as
for morx (see previos commit.)
2018-11-24 17:14:39 -05:00
ae8ed58a6e
[aat.morx] Remove set_object() business
...
With OS X 10.13 Apple Chancery fails to ligate if we limit each morx
sub-chain to its declared length. Perhaps their newer compiler does
object-sharing across sub-chains. Anyway, since that's a valid, if
unspecified, way to compile tables, remove enforcement.
Probably do the same with kern/kerx.
2018-11-24 17:14:09 -05:00
20edc70d53
[morx/kerx] Fix sanitize regression
...
Broke in 8dcc1913a1
2018-11-24 14:53:05 -05:00
ae96c98dfa
[color] Use SortedUnsizedArrayOf<>
2018-11-24 10:25:10 -05:00
4a3b20738f
[trak] Coment
2018-11-24 10:17:59 -05:00
918b1ee54d
[arrays] Add not_found to reference bsearch as well
2018-11-24 10:09:17 -05:00
d77a098b73
[arrays] Improve bfind() interface
...
Much more useful now. :)
2018-11-24 10:06:13 -05:00
8dcc1913a1
[kerx/morx] Make sure object length is sanitized before accessing it
2018-11-24 09:48:06 -05:00
70d80c90fe
[arrays] Port ArrayOf.qsort() and hb_vector_t.qsort() to hb_array_t
2018-11-24 09:48:06 -05:00
073d837aa2
[arrays] Port ArrayOf.qsort() to hb_array_t's
2018-11-24 09:48:06 -05:00
ad5c871d80
[arrays] Add copy-constructor to hb_array_t and hb_sorted_array_t
2018-11-24 09:48:06 -05:00
61de55bf49
[arrays] Port hb_vector_t.qsort() to hb_array_t's
2018-11-24 09:48:06 -05:00
e3face8e79
[arrays] Remove one flavor of hb_vector_t.qsort()
2018-11-24 09:48:06 -05:00
7c1600dcd9
[arrays] Add (unused) SortedUnsizedArrayOf<>
2018-11-24 09:48:06 -05:00
e700392f5c
[arrays] Port SortedArrayOf.bsearch/bfind to hb_sorted_array_t's
2018-11-24 09:48:06 -05:00
e604306f28
[arrays] Port hb_vector_t.bsearch/bfind to (new) hb_sorted_array_t's
2018-11-24 09:48:06 -05:00
268eca2492
[arrays] Port (unused) ArrayOf.lsearch() to hb_array_t's
2018-11-24 09:48:06 -05:00
830856ba6b
[arrays] Port hb_vector_t.lsearch() to hb_array_t's
2018-11-24 09:48:06 -05:00
96cf088980
[arrays] More
2018-11-24 09:48:06 -05:00
3e26c8d2b1
[arrays] Update ArrayOf.lsearch()
...
Currently unused apparently
2018-11-24 09:48:06 -05:00
22e1857b01
[arrays] Change argument type of cmp called by hb_vector_t.bsearch()
...
Towards consolidating all array bsearch/...
2018-11-24 09:48:06 -05:00
30cb45b3ea
Change ArrayOf.bsearch() return semantics
...
Towards consolidating all array bsearch/...
2018-11-24 00:48:26 -05:00
5cd9546ba7
Minor
2018-11-24 00:46:07 -05:00
fd94e729cb
Whitespace
2018-11-24 00:46:07 -05:00
bb2a206508
Assert that item-type of arrays have static size
2018-11-24 00:31:40 -05:00
690d9eb83d
[vector] Rename
2018-11-24 00:29:22 -05:00
ba38378fd4
[aat] Minor
2018-11-24 00:27:57 -05:00
39b9d63b01
Add hb_static_size(T)
2018-11-24 00:25:40 -05:00
f99abcc379
Add template-function convenience macros
2018-11-24 00:24:01 -05:00
ec83b2228e
Add null bytes for CmapSubtableLongGroup
2018-11-23 19:59:31 -05:00
e2ffb33a53
Remove lsearch for small TableDirectorys
2018-11-23 16:24:28 -05:00
04f7e55369
[arrays] Add as_array() to hb_vector_t<>
2018-11-23 16:07:43 -05:00
c514f65181
[arrays] Add as_array() to ArrayOf<>
2018-11-23 16:04:56 -05:00
9552f4ef0d
[kern] Don't enforce length of last subtable
2018-11-23 15:24:17 -05:00
018ba46e4d
Don't canonicalize '@' to '-' in language tags
...
Fixes #1406 .
2018-11-23 13:21:22 -05:00
748962264a
[aat] Disable mark advance zeroing if kern table has state-machines
...
Geeza Pro for example, relies on that for fancy mark positioning.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1405
2018-11-23 11:10:17 -05:00
3d2b98ef14
Minor
2018-11-23 10:58:43 -05:00
22798e93c4
[use] Minor clarification
2018-11-22 22:47:51 -05:00
a2d6c1075a
Minor tweak to FLAG64
2018-11-22 22:40:57 -05:00
8280459e74
Merge pull request #1291 from harfbuzz/use-reordering
...
[use] Fix reordering
2018-11-22 22:39:12 -05:00
e4a4555d1e
[cmap] Move code around
2018-11-22 22:17:49 -05:00
758c9d68e2
[morx/kerx] Limit range to subtable when sanitizing
2018-11-22 22:16:12 -05:00
a9fe787a11
[sanitizer] Add reset_object(), make set_object() do bounds-check
...
Affects morx/kerx run-time only currently. Will adjust their sanitize next.
2018-11-22 22:12:36 -05:00
2c8188bf59
[kerx] Make sure subtables are non-zero-length
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11400
2018-11-22 22:02:19 -05:00
a9e0bdc35d
[GSUB] Don't flush glyphset during recursion in closure()
...
See comment.
Supercedes https://github.com/harfbuzz/harfbuzz/pull/1401
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11366
2018-11-22 21:30:04 -05:00
d0e81b2cc8
[set] Rename
2018-11-22 21:20:39 -05:00
e866910579
Enforce requiring null_size even if min_size is 0
...
This concludes null-size enforcement changes
2018-11-22 18:07:59 -05:00
4d4fd64ff4
Allow non-nullable OffsetTo<> to non-Null'able objects
2018-11-22 18:07:36 -05:00
fa9f585ec5
[glyf] Don't mark structs UNBOUNDED
...
See comments.
2018-11-22 17:56:51 -05:00
f47a60a754
Mark UnsizedArrayOf<> as UNBOUNDED
...
Since min_size is 0, Null() still accepts this type.
2018-11-22 17:53:29 -05:00
199a0f7b41
[ot-shape] Simplify logic
2018-11-22 17:31:07 -05:00
014e4980ed
Move
2018-11-22 16:21:49 -05:00
62890dee18
[aat] Zero mark advances if decided so even if there's cross-kerning
...
Cross-kerning can only take care of positioning vertically. It doesn't
adjust mark advance...
2018-11-22 16:20:29 -05:00
a201fa74cd
[aat] Tweak fallback positioning logic when applying morx
...
Such that for Indic-like scripts (eg. Khmer), we don't do any fallback mark
advance-zeroing / positioning, but we do for Latin, etc. Reuses preferences
of our script-specific OpenType shapers for those.
Fixes regression: https://github.com/harfbuzz/harfbuzz/issues/1393
Which means, fixes again: https://github.com/harfbuzz/harfbuzz/issues/1264
While not regressing: https://github.com/harfbuzz/harfbuzz/issues/1357
2018-11-22 15:52:29 -05:00
fa0bd8964d
[myanmar] Minor move
2018-11-22 14:46:39 -05:00
7dc561984b
[myanmar] If there's no GSUB table, pick myanmar shaper
...
Needed for morx+kern mark-zeroing interaction. All other scripts
work this way.
2018-11-22 14:45:46 -05:00
25f52f58c2
[myanmar] Remove myanmar_old shaper
...
Over time it has become the same as default shaper. So, remove.
2018-11-22 14:41:01 -05:00
eeed802b1d
Fix spurious gcc warnings
...
../../src/hb-null.hh:53:39: warning: enum constant in boolean context [-Wint-in-bool-context]
2018-11-22 01:53:36 -05:00
b96ecb9971
More
...
This makes more of the gcc spurious warning:
../../src/hb-null.hh:53:39: warning: enum constant in boolean context [-Wint-in-bool-context]
But not going to let that defeat correct code. Type to switch to clang
as my main compiler...
2018-11-22 01:49:12 -05:00
2737aa81e5
Fix up recent change
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1300
2018-11-22 01:44:27 -05:00
fffea5aff7
Minor
2018-11-22 01:25:34 -05:00
209b58ef73
Minor
2018-11-22 01:22:33 -05:00
3b9fd176e8
Disallow taking Null() of unbounded structs
...
Not sure I've marked all such structs. To be done as we discover.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1300
2018-11-22 01:18:55 -05:00
f2b91d6510
Use Type::null_size for our structs in Null(), sizeof() for other types
2018-11-22 01:10:22 -05:00
7dd945a876
One more time..
2018-11-22 01:05:17 -05:00
d062ad10de
Fix bots happy again, hopefully
...
So, our fallback static_assert cannot be had more than once per line
of source.
2018-11-22 00:39:14 -05:00
fb10c021c8
Revert alignof() == 1 check
...
Bots not happy with using "this" inside assertion...
This reverts 2656644887
2018-11-22 00:21:49 -05:00
8d778877b8
..
2018-11-21 23:46:09 -05:00
8cfeed9948
Minor
2018-11-21 23:42:31 -05:00
e5d954a2fb
Minor
2018-11-21 23:30:50 -05:00
e987059c61
Minor
2018-11-21 23:25:06 -05:00
a2b6d308a4
Remove DEFINE_SIZE_ARRAY2
2018-11-21 23:23:49 -05:00
2656644887
Check alignof() structs are 1
2018-11-21 23:23:21 -05:00
6321fdf704
Whitespace
2018-11-21 23:19:00 -05:00
ecdceea861
Merge pull request #1399 from harfbuzz/sharada-sandhi-mark
...
Fix USE categories for U+111C9 SHARADA SANDHI MARK
2018-11-21 16:12:32 -05:00
b89c7fd3dc
Allow defining HB_USE_ATEXIT to 0
...
That's better use of that value than requiring extra macro HB_NO_ATEXIT
2018-11-21 12:32:48 -05:00
b3d5b0a5d9
Fix USE categories for U+111C9 SHARADA SANDHI MARK
2018-11-21 11:35:44 -05:00
f48bb9a393
[var] Deprecated axis enumeration API and add new version
...
New version has axis flags.
New API:
+hb_ot_var_axis_info_t
+hb_ot_var_find_axis_info()
+hb_ot_var_get_axis_infos()
Deprecated API:
-HB_OT_VAR_NO_AXIS_INDEX
-hb_ot_var_axis_t
-hb_ot_var_find_axis()
-hb_ot_var_get_axes()
2018-11-20 20:46:14 -05:00
b2d803cef6
Remove newly-added -hb_ot_var_axis_get_flags()
2018-11-20 20:46:14 -05:00
736897d7a1
[var] Make sure hb_ot_var_axis_flags_t is int-sized
2018-11-20 20:46:14 -05:00
eab5d15f61
[var] Move code
2018-11-20 20:46:14 -05:00
1ecbf4d3e3
Merge branch 'master' into cff-subset
2018-11-20 17:19:05 -08:00
8295118279
Shrink the emoji table by merging adjacent ranges
2018-11-20 15:41:45 -05:00
be1828daaa
[var] Fix type of coords returned
...
Ouch. Wonder how none of the bots caught the float->int truncation.
2018-11-20 11:16:23 -05:00
831ba74382
Fix Codacy "issues"
2018-11-20 01:16:08 -05:00
3c7792ca32
[use] Fix reordering
...
Fixes #1235 .
2018-11-19 16:49:40 -05:00
587d49fc65
[fvar] Add named-instance API
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1241
2018-11-19 14:51:34 -05:00
46c0da820f
Fix build
2018-11-19 13:32:48 -05:00
56c9238d3d
[fvar] Rewrite sanitize
2018-11-19 13:09:53 -05:00
4a6a692e3e
[fvar] Use hb_array_t for axes
2018-11-19 13:06:44 -05:00
e009739601
[fvar] Minor
2018-11-19 12:53:53 -05:00
1a2eb108b8
[ot-var] Add hb_ot_var_axis_get_flags()
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1241
New API:
+hb_ot_var_axis_flags_t
+hb_ot_var_axis_get_flags
2018-11-19 12:36:56 -05:00
bd6b2ba1d3
[ot-var] Add flags
...
Unfortunate that we don't have room in hb_ot_var_axis_t to expose flags :(.
2018-11-19 11:34:56 -05:00
c076c7b85c
[ot-var] Use hb_ot_name_id_t
2018-11-19 11:30:40 -05:00
515f1a1614
Merge branch 'master' into cff-subset
2018-11-16 17:38:47 -08:00
a6da9b9415
fixed Charset format selection
2018-11-16 17:29:03 -08:00
e3a1a8350a
2.1.3
2018-11-16 16:53:25 -08:00
9714e114b8
Fix recent commits
2018-11-16 16:52:42 -08:00
0328a1ce41
Revert b4c6113032
...
Was causing more trouble than it solved. We use unsigned for indexing,
and it's not helpful to allow that wrapping to negative integers on
32bit machines. The only way we could work around it would have been
by accepting int64_t arg, but that's overkill.
Ignore the MSVC 2008 build issue. We don't support that compiler.
2018-11-16 16:48:28 -08:00
52f61cdb87
Detect over/under-flow in UnsizedArray::operator[]
...
Was causing bad substitutions in mort table because of WordOffsetToIndex()
producing negative numbers that were cast to unsigned int and returned as
large numbers (which was desirable, so they would be rejected), but then
they were cast to int when passed to this operator and acting as small
negative integers, which was bad...
Detect overflow. Ouch, however, now I see this still fails on 32-bit.
Guess I'm going to revert an earlier change.
2018-11-16 16:41:59 -08:00
6910ff03e6
[aat] Fix mort shaping
...
Ouch!
2018-11-16 16:11:02 -08:00
fdb29ab2b0
2.1.2
2018-11-16 15:38:11 -08:00
cff4c6087f
Fix vertical fallback space sign
...
Ouch!
Follow-up to cf203af8a3https://github.com/harfbuzz/harfbuzz/issues/1343
2018-11-16 15:04:41 -08:00
7a97f70740
Don't apply GPOS if applying morx
...
That's what Apple does, and it wouldn't degrade our OpenType performance.
Part of https://github.com/harfbuzz/harfbuzz/issues/1348
2018-11-16 14:46:40 -08:00
eafd515639
Prefer morx table if GSUB is empty (no scripts)
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1348
2018-11-16 14:45:56 -08:00
aa06574823
Minor
2018-11-16 14:31:05 -08:00
b6903bd6c4
ensure fdmap initialized as identity for single-FD (non-CID) fonts
2018-11-16 13:46:58 -08:00
b403be8ad9
Merge branch 'master' into cff-subset
2018-11-16 12:29:18 -08:00
b67a7c731f
drop dotsection as hint along with test case
2018-11-16 12:28:24 -08:00
50d1a41c08
[coretext] Hopefully the last one
2018-11-16 08:52:57 -05:00
0aab861f9c
[coretext] Another round
2018-11-16 08:43:25 -05:00
0809b76a9a
[coretext] One more try..
2018-11-16 08:29:47 -05:00
78bd447594
[coretext] One more try
2018-11-16 04:10:53 -05:00
fd27a23c82
[coretext] Another build fix attemt
2018-11-16 03:57:12 -05:00
729aedf0da
[directwrite] Fix build
2018-11-16 03:26:46 -05:00
cfb9771a3b
[coretext] Try to fix
2018-11-16 03:25:07 -05:00
e3e9547365
[coretext] Unbreak build
2018-11-16 02:55:29 -05:00
ce5da0f36a
[shaper] Rewrite shaper data code to be more template-driven than macro-driven
2018-11-16 02:52:20 -05:00
cb4bf85b14
[hdmx] Fix bounds checking
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11351
2018-11-16 02:02:24 -05:00
af727b4e62
[hdmx] Minor
2018-11-16 01:55:39 -05:00
9e9f16c92d
[subset] Remove invalid glyphs from glypset to retain
...
Fixes https://github.com/harfbuzz/harfbuzz/pull/1388
2018-11-16 01:48:26 -05:00
072c7aba92
use 2-byte offset instead of 4-byte for local subrs
...
more than enough since local subrs immediately follow its corresponding private dict, as the result 2-byte redunction for each font dict with local subrs
updated api test expected subset fonts accordingly
2018-11-15 15:41:46 -08:00
9d0231cfe7
fixed a subset bug when no font dicts reduce
2018-11-15 15:39:43 -08:00
11aa0468ac
[subset] minor, adjust spaces
2018-11-16 00:02:47 +03:30
d7c50ff0d6
[math] minor, adjust spaces
2018-11-16 00:02:47 +03:30
13735570f0
reject nested seac
2018-11-15 12:10:23 -08:00
c37aecd41c
Merge branch 'master' into cff-subset
2018-11-15 11:03:46 -08:00
ecdb77f0ae
fixed CFF1 subset of std encoding & non-std charset combo
2018-11-15 10:54:15 -08:00
cabe433fbb
[base] Add TODO items
2018-11-15 02:48:50 -05:00
3bf1ce748f
[shaper] Rename
2018-11-14 21:08:54 -05:00
c221dc0ba7
[ot-shape] Move code around
2018-11-14 19:57:19 -05:00
892ab37e7c
Merge branch 'master' into cff-subset
2018-11-14 13:54:07 -08:00
3787c07856
Implemented seac for extents & subset along with API tests
2018-11-14 13:38:03 -08:00
7867c2bad0
[STAT] Add table parsing ( #1384 )
2018-11-14 22:13:50 +03:30
48d16c2ab2
[hmtx] Fix signedness issue
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1248#issuecomment-438689499
2018-11-14 09:57:05 -05:00
29db2a44a6
[ot-color/svg] Note that it can be gzipped
2018-11-14 12:13:16 +03:30
3c3eb5ea9c
[aat] Disable fallback mark advance zeroing and positioning if morx applied
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1357
2018-11-13 21:10:10 -05:00
dc4225ccd1
Don't retry creating again and again in lazy_loader if create failed
...
Still does that if get_null() returns nullptr. Our shaper data objects
are like that. Shrug.
2018-11-13 20:48:46 -05:00
086235f593
Merge pull request #1382 from punchcutter/master
...
Change USE Category for Grantha Virama
2018-11-13 19:50:25 -05:00
2092f595c7
Merge pull request #1380 from kbrow1i/cygwin
...
Don't use Win32 API on Cygwin
2018-11-13 19:49:06 -05:00
c565fc3fb3
Change USE Category for Grantha Virama
...
https://github.com/harfbuzz/harfbuzz/issues/1379
2018-11-13 12:51:10 -08:00
475be9d5c6
Fix Windows build
2018-11-13 13:01:13 -05:00
fc44dea341
Use atomic ints for upem and num_glyphs on face
2018-11-13 11:54:33 -05:00
9579ed9755
Make atomic types' internal values non-mutable
...
This resulted from confusion previously...
2018-11-13 11:46:20 -05:00
c52d5bcd94
[ot-face] Add 'head' table
2018-11-13 11:41:29 -05:00
eee5b5ed04
Don't use Win32 API on Cygwin
...
Cygwin is a Posix platform to the extent possible. It should use the
Posix API except in special circumstances.
2018-11-12 21:07:34 -05:00
56f541d000
[shape-plan] Remove unused code
2018-11-12 19:46:37 -05:00
6c22f3fd95
[shape-plan] Implement fine-grained caching plans with user-features
...
Only tag, value, and global-ness of features are considered, not their
start/end offsets.
2018-11-12 19:26:01 -05:00
cc8428756a
[shape-plan] Cache shape plans with variations based on variation indices
2018-11-12 18:48:10 -05:00
8284cb9fb3
[shape-plan] Refactor more
2018-11-12 18:18:20 -05:00
1082338525
[shape-plan] Only use shape-plan key to initialize hb_ot_shape_plan_t
...
Such that we don't accidentally use info not in the cache key.
2018-11-12 18:05:02 -05:00
7ac03f88a2
[shape-plan] Minor
2018-11-12 17:50:30 -05:00
c7be933439
[shape-plan] Refactor some more
2018-11-12 17:49:15 -05:00
fc27777833
[shape-plan] Refactor more
2018-11-12 17:27:34 -05:00
566612295b
[shape-plan] Turn hb_shape_plan_proposal_t into hb_shape_plan_key_t
...
And include it in hb_shape_plan_t itself.
2018-11-12 17:19:45 -05:00
af123bd1b8
Add hb_memcmp()
2018-11-12 16:27:08 -05:00
65456bff37
[shape-plan] Minor
2018-11-12 16:21:21 -05:00
1db672a5e9
[shaper] Rename
2018-11-12 16:05:46 -05:00
274f4c726f
Rename check_array2() to check_array()
2018-11-12 14:24:36 -05:00
e014405a21
Rename check_array(array, a, b) to check_range()
2018-11-12 14:23:31 -05:00
c8f4cc4927
[kerx] Fix integer overflow in multiply
...
Fixes https://oss-fuzz.com/v2/testcase-detail/5754863779053568
2018-11-12 14:11:29 -05:00
1300f027a9
[kerx] Minor tweak on previous commit
2018-11-12 13:56:48 -05:00
d6666b3866
[fuzzing] Remove limited-edition build of libraries
...
Use normal, production, shared libraries.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1237
2018-11-12 13:21:14 -05:00
a549aa14a0
[kerx] Protect against stack underflow
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11367
2018-11-12 13:02:39 -05:00
41a8bc7fd9
Merge branch 'master' into cff-subset
2018-11-12 08:49:00 -08:00
0dfa584cb4
changed Adobe company name
2018-11-12 08:47:07 -08:00
3e284e02c2
[shape-plan] Minor
2018-11-11 22:51:34 -05:00
420c9de644
[shape-plan] Minor rename
2018-11-11 22:50:37 -05:00
77bd0a6458
Add variation coords to shape_plan proposal
...
This is the root cause of bug worked around in 19e77e01bc
2018-11-11 22:08:48 -05:00
9c767d075d
Minor
2018-11-11 22:03:15 -05:00
f521a28b4a
Embed hb_ot_shape_plan_t into hb_shape_plan_t
...
No other shaper will need shape_plan_data, by definition. So, remove
abstraction layer and always create hb_ot_shape_plan_t as part of
hb_shape_plan_t.
2018-11-11 21:54:10 -05:00
fabb012104
Remove wrong comment
2018-11-11 17:10:23 -05:00
1fd183ee1c
Finish off eecccc919c
2018-11-11 16:47:52 -05:00
1beacdded9
Minor
2018-11-11 16:35:28 -05:00
e88d47b7f2
Minor
2018-11-11 16:25:43 -05:00
55c66c7c56
Revert "Declare Null() constexpr"
...
This reverts commit 442a72d95a
2018-11-11 16:09:38 -05:00
98c6f03ccd
Minor
2018-11-11 15:54:20 -05:00
442a72d95a
Declare Null() constexpr
2018-11-11 15:51:23 -05:00
eecccc919c
Don't store to null object
...
Ouch :).
2018-11-11 15:48:47 -05:00
903856ab50
Remove unused function
2018-11-11 15:45:58 -05:00
0e0af11c62
[hdmx] Renames
2018-11-11 12:54:16 -05:00
da6aa3b033
Add hb_blob_ptr_t.destroy()
2018-11-11 11:40:57 -05:00
bb9abb4efd
[hmtx/port] Use hb_blob_ptr_t
2018-11-11 00:42:23 -05:00
0e2680a6e8
[cmap] Port to hb_blob_ptr_t
...
Although didn't need it...
2018-11-11 00:28:47 -05:00
0b0fad3ea8
[color] Port to hb_blob_ptr_t
...
Fix hb_blob_ptr_t::get_length () as well.
2018-11-11 00:26:55 -05:00
925b7a214f
Comment
2018-11-11 00:17:30 -05:00
dcb6386833
[shape-plan] Remove use of custom null object
2018-11-11 00:16:17 -05:00
109891d498
[shape-plan] Make null object all zeros
...
To remove custom null object next..
2018-11-11 00:15:08 -05:00
34185ff3bc
[blob] Use default null object
2018-11-11 00:12:30 -05:00
2ee1d9f555
[blob] Change null object memory mode to DUPLICATE
...
We never rely on that being equal to readonly. Just not being
writable. Maybe not even that given that the object is inert.
In prep for next commit, using default null pool.
2018-11-11 00:11:28 -05:00
5d0078a48b
Add hb_blob_ptr_t
...
Use in a couple of places. Push to bots to see how many unhappy before
I convert the rest.
2018-11-10 23:52:15 -05:00
e44046ec49
Minor
2018-11-10 22:41:35 -05:00
752bd8a192
[kerx] Fix Format1 tupleKern sanitization
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11312
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11305
2018-11-10 21:13:32 -05:00
f9e0552deb
[fuzzing] Make "make lib" faster and more usable
2018-11-10 21:06:56 -05:00
4674655841
Minor
2018-11-10 20:11:10 -05:00
a953b64750
Revert parts of previous commit that made clang unhappy
2018-11-10 20:10:03 -05:00
1d66cdcf77
Better fix for MSVC 2008
...
Follow up on b4c6113032https://github.com/harfbuzz/harfbuzz/issues/1374
2018-11-10 19:57:51 -05:00
fb2a037f54
Merge branch 'master' into cff-subset
2018-11-10 16:23:11 -08:00
b4c6113032
Try fixing MSVC 2008 build
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1374
2018-11-10 16:35:39 -05:00
f2e942f302
Fix hb_bytes_t's unused template array constructor
2018-11-10 16:11:14 -05:00
6213a75b68
Add trivial casts to hb_bytes_t
2018-11-10 16:09:21 -05:00
8bb97d2ce1
Revert back hb_bytes_t.cmp() to the scheme it was
...
But fix UBSan complaint.
There's nothing in hb_bytes_t that guarantees lexical ordering, and
ordering by length first is much faster.
2018-11-10 16:00:51 -05:00
534e1d7694
Fix hb_bytes_t.cmp() for realz this time
2018-11-10 15:45:31 -05:00
929f07dbfc
Fix hb_bytes_t.cmp()
...
Ouch!
2018-11-10 15:39:07 -05:00
1d82b4761d
[colr/feat/trak] minor
2018-11-10 19:31:12 +03:30
3a9fa8c026
[qsort] Fix O(N^2) behavior if all array elements are the same
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11327
Reported as https://github.com/noporpoise/sort_r/issues/7
2018-11-10 01:58:26 -05:00
b308aaccf0
[post] Minor
2018-11-10 01:58:26 -05:00
4111c3b8cd
[post] Move sanitize close to data fields
2018-11-10 01:58:26 -05:00
e26e6dbb33
[post] Remove unnecessary hb_nonnull_ptr_t<>
2018-11-10 01:58:26 -05:00
6b8178c649
[glyf] minor
2018-11-10 02:42:08 +03:30
8798416587
fixed vstem handling (lack thereof) in check_width
...
bug exposed by U+2261 equivalence in SourceCodePro-Regular.otf
2018-11-09 08:59:18 -08:00
5f97fe9956
Fix a few MSVC 2008 warnings
...
https://github.com/harfbuzz/harfbuzz/issues/1374
2018-11-09 10:01:50 -05:00
f51bb6ee7b
Merge pull request #1358 from ebraminio/lcar
...
Hook AAT's lcar to _get_ligature_carets
2018-11-08 14:42:40 -05:00
b986fead0a
Hook AAT's lcar to _get_ligature_carets
2018-11-08 23:06:26 +03:30
2d987110c0
[aat] Minor
2018-11-08 21:46:26 +03:30
b989507fa6
[aat] Minor ( #1369 )
2018-11-08 20:48:54 +03:30
26c291aaa0
Merge branch 'master' into cff-subset
2018-11-08 09:06:49 -08:00
417963dd9f
got rid of Remap::fullset() as incorrect, redundant, inefficient
2018-11-08 09:01:20 -08:00
f90423847b
[just] Initial table implementation ( #1364 )
...
A starting point, its sanitization is not tested however
2018-11-08 19:17:02 +03:30
b8b00fb3c6
[aat] Support Lookup<OffsetTo<>>, needed by just and lcar ( #1368 )
2018-11-08 18:53:14 +03:30
15326826bf
[aat] Ignore cross-stream offset of deleted-glyphs
...
I think it makes sense to accumulate it, but Ned tells me that's
what CoreText does.
2018-11-07 21:58:04 -05:00
636a6833c5
fixed ends_in_hint bug
...
subr ends in hint itself should be regarded as hint
this flag should propagate to its caller if the call itself is at the end of the caller
2018-11-07 17:58:45 -08:00
517a1bac97
Merge pull request #1362 from harfbuzz/cross-kern
...
Vastly improve kern/kerx tables, including cross-stream "kerning"
2018-11-07 18:40:48 -05:00
b18a56a290
[kerx] Comment
2018-11-07 18:13:22 -05:00
4d74020694
Merge branch 'master' into cff-subset
2018-11-07 15:09:30 -08:00
e0c30b961d
merge with cff-subset branch
2018-11-07 15:08:55 -08:00
006386be3a
[kern] Implement negative state numbers
...
Let the fuzzing bots rip this code apart...
2018-11-07 18:04:53 -05:00
0996c0ff62
implented no-desubroutinize with CFF2 along with API test
...
replaced AdobeVFPrototype.abc.otf with a hinted (maually) & subroutinized copy
replaced expected results as well
2018-11-07 14:48:37 -08:00
29c5302376
[morx] Minor
2018-11-07 17:29:37 -05:00
385f78b312
[aat] Remove deleted-glyhs after applying kerx/kern
...
Finally: Fixes https://github.com/harfbuzz/harfbuzz/issues/1356
Test case:
$ ./hb-shape GeezaPro.ttc -u U+0628,U+064A,U+064E,U+0651,U+0629
[u0629.final.tehMarbuta=4+713|u064e_u0651.shaddaFatha=1@0,-200+0|u064a.medial.yeh=1+656|u0628.initial.beh=0+656]
The mark positioning (kern table CrossStream kerning) only works if deleted
glyph (as result of ligation) is still in stream and pushed through the
state machine.
2018-11-07 17:20:47 -05:00
1909072235
[aat] Add debug info to state machine
2018-11-07 16:42:16 -05:00
ca23567f41
Disable fallback mark positioning if kern table has cross-stream kerning
...
Happens even if the cross-stream kerning is for cursive attachment only. Oh well..
2018-11-07 16:19:51 -05:00
5cf6f94dfd
Don't apply both kerx and kern
...
Ouch!
2018-11-07 16:07:22 -05:00
41cff7afc9
Minor
2018-11-07 16:05:36 -05:00
9af983af24
[kern] Switch to dispatch
2018-11-07 16:03:09 -05:00
bc06e2805a
[kerx/kern] Add has_cross_stream()
2018-11-07 16:02:40 -05:00
ea579f9ccc
[kerx] Fix peculiar indexing that was needed previously
...
Not needed now that we use GPOS attachment for cursive kerx.
2018-11-07 15:50:23 -05:00
6ee6cd93d8
[GPOS] Only mark unsafe-to-break if kerning happened
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1365
2018-11-07 15:40:55 -05:00
501a364d9b
[GPOS] Add TODO item
2018-11-07 15:02:16 -05:00
7a9629f2f1
[kerx] Implement CrossStream kerning for non-state-machine subtables
...
Untested.
2018-11-07 14:52:57 -05:00
0eb4157011
[kerx] Disable backwards-kerning for non-state-machine tables
...
That's what the spec says for Backwards flag, only applicable to
formats 1 and 4.
2018-11-07 14:42:15 -05:00
b2f687c256
[kerx] Use GPOS attachment facilities for CrossStream kerning
2018-11-07 14:38:29 -05:00
e10a856eb2
[kerx] Format
2018-11-07 14:11:48 -05:00
649cc3ef27
[kerx] Don't disable crossKerning if kern feature is off
2018-11-07 14:07:13 -05:00
0c3b061ac2
[kern] Apply erlier, where GPOS/kerx are applied
2018-11-07 13:58:41 -05:00
f4bad0086e
[kerx] Implement tupleKerning for Format1
...
Untested.
2018-11-07 13:51:17 -05:00
39b4ef6f18
[kerx] Better sanitize tupleKerning
2018-11-07 13:48:45 -05:00
14772da06f
[kern/kerx] Share KernTable, renamed to KerxTable
2018-11-07 13:40:22 -05:00
c038f5be6b
[fallback] Minor
2018-11-07 13:35:06 -05:00
db6e658e8c
[kern/kerx] More towards sharing KernTable
2018-11-07 13:33:23 -05:00
89ec095979
[kern] Disable Format1 and Format3 for OT-style tables
2018-11-07 13:10:05 -05:00
ab57bcae0f
[kern] Minor
2018-11-07 13:04:21 -05:00
30af5b4a4c
[kern] Move code
2018-11-07 12:57:10 -05:00
1ff300464a
[kern] Massage more
2018-11-07 12:51:49 -05:00
8e9f6cd0fd
[kerx] More minor
2018-11-07 12:49:20 -05:00
f8c3df7d4a
[kern/kerx] Minor
2018-11-07 12:48:06 -05:00
f5e0a63a22
[kern/kerx] Towards sharing KernTable
2018-11-07 12:32:51 -05:00
330508497d
[kern/kerx] Minor
2018-11-07 12:27:44 -05:00
1a5ef84900
[kern/kerx] Share Format2
...
This, enables Format2 for kern table, which was disabled before.
2018-11-07 12:19:52 -05:00
8faec4e334
[kerx] Towards merging Format2
2018-11-07 12:16:38 -05:00
ae8fd0dbfb
clear stack after vsindex op
2018-11-07 09:16:12 -08:00
7fed7d80f7
fixed off-by-one error in CFF1 Encoding lookup
2018-11-07 09:09:13 -08:00
d5c0ca210f
[aat] Minor
2018-11-07 12:08:44 -05:00
e72e041c3c
[kerx] Rename
2018-11-07 11:56:36 -05:00
241ba7da51
[morx/kerx] Rename types
2018-11-07 11:51:40 -05:00
c808e444da
[kern/kerx] Share Format1 subtable
2018-11-07 11:47:12 -05:00
a244190afa
[kerx] Minor
2018-11-07 11:47:12 -05:00
2a72091196
[kerx] Minor
2018-11-07 11:26:57 -05:00
f5f4ca7871
[kern/kerx] Enable crossStream kerning in vertical
...
CoreText doesn't, but no reason we shouldn't do.
2018-11-07 11:21:09 -05:00
d5c88af4a2
[kerx] More towards sharing Format1
2018-11-07 11:20:14 -05:00
b693fd0dc6
[morx] Simplify
2018-11-07 11:10:24 -05:00
ce3451dc2a
[kerx] Towards sharing Format1
2018-11-07 11:02:04 -05:00
e890753ebb
[morx] Minor
2018-11-07 10:59:53 -05:00
5b17853547
[kern/kerx] Share Format0
2018-11-07 10:45:25 -05:00
c97dde5d55
[kern/kerx] Towards merge more
2018-11-07 10:39:39 -05:00
540ccc38b0
[kern/kerx] More towards sharing
2018-11-07 10:33:46 -05:00
d0f8f4c200
[kern] Move kern machine to hb-kern.hh
2018-11-07 10:25:25 -05:00
a6acff252c
[kerx] Towards sharing subtables with kern
2018-11-07 10:19:57 -05:00
befac337ca
[kern] Remove Override business
...
Not used in any fonts. Not well-specified when mixing kerning with
Cross-Stream positioning.
2018-11-07 09:53:50 -05:00
9d5027696e
[post] Return true on truncation
...
Client can check that buffer was completely filled out and reallocate.
2018-11-07 09:16:53 -05:00
7d91f07edf
[post] Protect against huge empty tables
2018-11-07 09:14:42 -05:00
5ed816ab59
[post] Minor
2018-11-07 09:13:51 -05:00
64f0becd89
[post] Fix bound checking
2018-11-07 09:10:55 -05:00
7ec694ddf2
Use non-GRID-fitted values for metrics ( #1363 )
...
* Use non-GRID-fitted values for metrics
See freetype/src/base/ftobjs.c:ft_recompute_scaled_metrics() and
the usage of GRID_FIT_METRICS inside.
Fixes https://github.com/behdad/harfbuzz/issues/1262
* Update hb-ft.cc
2018-11-07 08:19:36 -05:00
59e04e4231
[kern/kerx] Fix cursive joining
...
Tested with Waseem TTC:
$ hb-shape Waseem.ttc جحخج
[F1Jeem_R2=3@0,180+479|M1Khah_L2_R2=2@0,682+403|M1Hah_L2_R2=1@0,1184+403|I1Jeem_L2=0@0,1184+744]
2018-11-07 00:27:20 -05:00
8d0f797139
[kern/kerx] Fix "reset" magic value
2018-11-07 00:05:10 -05:00
0123976a0c
[kerx] Adjust CrossStream kern to match 'kern' table
2018-11-06 21:46:14 -05:00
80a33b9ac3
[kern] More tweaks
...
Solves a mystery or two. I'm fairly confident this is what CoreText does now.
2018-11-06 21:46:14 -05:00
564e8ac046
[kern] Adjust some more
...
Getting closer. So many open questions still...
2018-11-06 21:46:14 -05:00
4d003b8503
[kern] Add TODO
2018-11-06 21:46:14 -05:00
9810f0b80e
[kern] Minor
2018-11-06 21:46:14 -05:00
9c04b60583
[kern] In Format1, adjust how kerning is done
...
In a series of kerns in one action, kern all but last glyph forward,
and the last one backward. Seems to better match what CoreText is doing.
Test cases, with GeezaPro Arabic:
$ ./hb-shape GeezaPro_10_10.ttc -u U+0631,U+0628
[u0628.beh=1+1415|u0631.reh=0@-202,0+700]
$ ./hb-shape GeezaPro_10_10.ttc -u U+0628,U+064F
[u064f.damma=0@0,-250+-250|u0628.beh=0@250,0+1665]
In a later change, I'll make kern machine avoid producing negative kerns.
2018-11-06 21:46:14 -05:00
e8c4772463
[kern] XXX Negate CrossKerning sign
...
Not sure why, but seems to better match GeezaPro Arabic w CoreText.
Quite possibly I'm doing something very wrong...
2018-11-06 21:46:14 -05:00
01bf43ac01
[kern] Implement CrossStream kerning
2018-11-06 17:59:31 -05:00
b11830c09e
[kern] Improve Format 2
...
Still disabled.
2018-11-06 17:59:31 -05:00
c0383c6bb7
Minor
2018-11-06 17:59:31 -05:00
10e6f708f3
[kern] Minor
2018-11-06 17:16:23 -05:00
164eedd918
[kern] Minor
2018-11-06 17:16:23 -05:00
220a5991ba
[kern/kerx] Fix trace numbering
2018-11-06 17:16:23 -05:00
7b21319edf
don't reject empty Dict
2018-11-06 13:59:07 -08:00
43ee0e4d00
Merge branch 'master' into cff-subset
2018-11-06 09:57:17 -08:00
bfafe208da
[kern] Switch to dispatch
2018-11-06 12:13:20 -05:00
213fa3bf71
[kern] Refactor to include header in each subtable type
2018-11-06 12:13:20 -05:00
b0da2cd0b9
[kern] Some more
2018-11-06 12:13:20 -05:00
75b00b51c8
[kern] Renames
2018-11-06 12:13:20 -05:00
37f421c951
Minor
2018-11-06 10:03:38 -05:00
9139cc23ea
Fix link issue of some of the bots
...
e.g. https://circleci.com/gh/harfbuzz/harfbuzz/52410
2018-11-06 11:17:14 +03:30
98b37f0c10
[mort] Fix table detection logic
...
mort really needs some initial tests at least.
2018-11-06 09:16:28 +03:30
fa3ebf845f
Simplify some more
2018-11-05 23:34:07 -05:00
61f52231f4
[math] Shorten names a bit
2018-11-05 23:28:52 -05:00
737efbe655
[ot-layout] Simplify GSUB/GPOS access
...
This concludes simplifying table access to face->table.XXXX.
2018-11-05 23:26:29 -05:00
5e68cec179
[ot-layout] Simplify GDEF access
2018-11-05 23:23:57 -05:00
33b006cc51
[ot-layout] Simplify some access
2018-11-05 23:19:04 -05:00
db35409f0d
[ot-layout] Remove ensures
2018-11-05 23:11:46 -05:00
9198de7b9b
[ot-font] Remove ensure
2018-11-05 23:10:37 -05:00
ea6d9b661f
[ot-face] Remove a few ensures
2018-11-05 23:10:21 -05:00
0fe7a745c9
[ot-face] Simplify more table access
2018-11-05 23:10:18 -05:00
a35c92cbe7
[ot-face] Simplify table access
...
Yoohoo!
2018-11-05 23:10:16 -05:00
914b595f25
[ot-face] Include hb-ot-face directly in hb_face_t
...
Simplifying access coming next.
2018-11-05 23:10:12 -05:00
56ba998cdd
[cmap] Push get_nominal_glyphs down into cmap accelerator
2018-11-05 19:49:54 -05:00
36d85dce25
[cmap] Use hb_nonnullptr_t
2018-11-05 19:46:29 -05:00
8be74d8553
2.1.1
2018-11-05 18:47:22 -05:00
252632c477
[uniscribe] Fix use of deprecated API
2018-11-05 14:33:41 -05:00
bb380ec183
[cmap] Make null accelerator safe
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1146
2018-11-05 13:47:30 -05:00
f6fc5574d3
Add pointer magic operators to hb_atomic_ptr_t
2018-11-05 13:23:54 -05:00
f6e7cb51b1
Fix const-confusion in hb_array_t as well
2018-11-05 13:23:07 -05:00
0da22fb0ad
[null] Tweak hb_nonnull_ptr_t some more
2018-11-05 13:20:06 -05:00
03348ce005
Minor
2018-11-05 12:59:32 -05:00
b721fdae66
fixed leaks in CFF subr subset
2018-11-04 16:19:15 -08:00
85f5644e8e
added missing switch breaks
2018-11-04 14:17:30 -08:00
1682d1bbec
Merge branch 'master' into cff-subset
2018-11-04 13:25:41 -08:00
b605db2f65
[aat] Clean up ankr table include mess
2018-11-04 12:58:02 -05:00
17335a8161
Clean up buffer->swap_buffers() calls
...
That function checks for buffer->successful already. No need
to check at call site.
2018-11-04 02:25:07 -05:00
191ca0f15b
CFF1 no-desubr fixes
...
make sure charstring/subrs not ending with endchar/return handled correctly
if no local subrs, skip serializing Subrs op in Private
misc fixes
2018-11-03 22:42:22 -07:00
4eb52460c8
Fix >>
2018-11-03 21:45:39 -04:00
ae9ad1076e
Fix "Warning: extra ";" ignored."
2018-11-03 21:41:50 -04:00
d0163afb7b
Revert "Add operator char * to the naked array types as well"
...
This reverts commit db889c182e
2018-11-03 21:38:30 -04:00
c8f94a1ca6
Minor
2018-11-03 21:08:13 -04:00
1da4de7e7b
fix for subset fuzzer failure
...
A called subr must be freshly parsed or completely parsed. otherwise the prevoius parse must have terminated prematurely
2018-11-03 15:41:29 -07:00
0b0b38ec1e
Fix null accelerator's
...
Fixes all except for cmap. To be done separately.
Part of https://github.com/harfbuzz/harfbuzz/issues/1146
2018-11-03 16:16:31 -04:00
db889c182e
Add operator char * to the naked array types as well
2018-11-03 16:04:19 -04:00
d6fdae310f
Add operator char * to hb_nonnull_ptr_t
2018-11-03 16:02:03 -04:00
7430ff604a
Template casts in hb_nonnull_ptr_t
2018-11-03 15:59:13 -04:00
da408fce98
[blob] Allow null parent in create_sub_blob()
...
Like font and unicode.
2018-11-03 15:49:37 -04:00
fb0f30f55a
Add hb_nonnull_ptr_t
...
Towards fixing https://github.com/harfbuzz/harfbuzz/issues/1146
2018-11-03 15:41:32 -04:00
8d98c51d13
[kern] Third try fix access violation in Format3
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11245
2018-11-03 15:14:57 -04:00
f074da8c2b
[kern] Really fix access violation in Format3
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11245
2018-11-03 15:07:39 -04:00
93ef20a83b
Replace most uses of is_inert with is_immutable
2018-11-03 15:03:06 -04:00
0589787ff5
[kern] Fix access violation in Format3
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11245
2018-11-03 14:59:40 -04:00
5570c87f21
Port objects to use header.writable instead of immutable
...
Saves 4 or 8 bytes per object on 64bit archs.
2018-11-03 14:59:40 -04:00
ee351a38ec
[object] Add "writable"
2018-11-03 14:59:40 -04:00
b8a78ce201
[BASE] Improvements ( #1347 )
2018-11-03 22:28:30 +03:30
34b06d994a
fixed FDSelect size calcluation
2018-11-02 16:40:20 -07:00
481fdfdc23
Merge branch 'cff-subset' of https://github.com/harfbuzz/harfbuzz into cff-subset
2018-11-02 15:28:09 -07:00
1bc710a8c9
added CFF1 desubr api test cases & bug fixes
2018-11-02 15:28:01 -07:00
2c68f34bdd
[os2] Capitalize table tag and struct
...
Other tables follow the case of the OT tag, except this one.
2018-11-02 17:17:54 -04:00
8034d1dda0
[kern] Implement Format1
...
Also, implement backwards kerning for Format1 in kern and kerx.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1350
2018-11-02 14:48:04 -04:00
46b3885c1a
[kern] Set subtable on sanitizer
2018-11-02 14:43:38 -04:00
74c7a2c6c8
[kern] Respect more flags
2018-11-02 14:26:04 -04:00
9f880bad0d
[kern] Minor
...
We like check_struct() more.
2018-11-02 13:57:41 -04:00
04b82b181d
Remove pointer cast operators from ArrayOf<>
...
ArrayOf<>, unlike UnsizedArrayOf<>, has data before the array.
This was confusing. Remove.
2018-11-02 13:47:33 -04:00
f1df441bed
[kern] Comment
2018-11-02 13:26:15 -04:00
095f5add0b
[kern] Push apply loop to each subtable
2018-11-02 13:23:54 -04:00
949dad89a8
[kern] Remove accelerator
...
It wasn't doing anything.
2018-11-02 12:47:55 -04:00
0382b7184a
Use as_array in more places
2018-11-02 12:23:26 -04:00
91de9dfcf3
Fix &array_of<>
2018-11-02 12:16:51 -04:00
9b7cb13794
Fixup
2018-11-02 12:00:55 -04:00
6e06fe162e
[kern] Implement Format3
...
Untested.
2018-11-02 11:56:55 -04:00
c6ef5dbd5c
Add cast operators to hb_array_t
2018-11-02 11:51:21 -04:00
72462eb765
Add UnsizedArrayOf::as_array() instead of hb_array() template
2018-11-02 11:46:42 -04:00
Behdad Esfahbod
fanc999
Ebrahim Byagowi
prrace
Behdad Esfahbod
Michiharu Ariza
👻
Bruce Mitchener
Adenilson Cavalcanti
Victor Chang
David Corbett
punchcutter
Ken Brown
HinTak
Khaled Hosny