harfbuzz

Author SHA1 Message Date

Author	SHA1	Message	Date
Garret Rieger	49c9392412	[subset] During LigatureSubstFormat1 subsetting always place Coverage last. In Windows 7 on Chrome if the coverage table comes before any of the LigatureSet or Ligature subtables the font won't load. This changes the packing order to always place the Coverage table last. Virtual links are used to ensure the repacker maintains the desired ordering. Coincidentally fontTools also does the same thing (`a3f988fbf6/Lib/fontTools/ttLib/tables/otTables.py (L1137)`) to reduce overflows during packing.	2021-11-02 12:19:13 -06:00
Garret Rieger	c2cc566c9d	[subset] Fix subset_offset_array adding unused space to serializer. ArrayOf.serialize_append allocates space for the new item, but ArrayOf.pop() does not recover the allocated space. So in the case where the revert path was entered the extra space added by serialize_append gets left in the serialization buffer. This moves the snapshot to before ArrayOf.serialize_append is called so that revert cleans up the buffer extend.	2021-09-22 16:07:18 -06:00
Qunxin Liu	8c5c81746d	[subset] fix find_duplicate_features We should check each feature against all other features with the same tag for duplicates.	2021-09-22 15:35:38 -06:00

Garret Rieger

49c9392412

[subset] During LigatureSubstFormat1 subsetting always place Coverage last.

In Windows 7 on Chrome if the coverage table comes before any of the LigatureSet or Ligature subtables the font won't load. This changes the packing order to always place the Coverage table last. Virtual links are used to ensure the repacker maintains the desired ordering.

Coincidentally fontTools also does the same thing (a3f988fbf6/Lib/fontTools/ttLib/tables/otTables.py (L1137)) to reduce overflows during packing.

2021-11-02 12:19:13 -06:00

Garret Rieger

c2cc566c9d

[subset] Fix subset_offset_array adding unused space to serializer.

ArrayOf.serialize_append allocates space for the new item, but ArrayOf.pop() does not recover the allocated space. So in the case where the revert path was entered the extra space added by serialize_append gets left in the serialization buffer. This moves the snapshot to before ArrayOf.serialize_append is called so that revert cleans up the buffer extend.

2021-09-22 16:07:18 -06:00

Qunxin Liu

8c5c81746d

[subset] fix find_duplicate_features

We should check each feature against all other features with the same
tag for duplicates.

2021-09-22 15:35:38 -06:00

3 Commits