5fa52e62b1
[iter] Accept iterator, not iterable, in hb_sink()()
2019-02-14 10:51:02 -08:00
0f292ea85f
[iter] Accept iterator, not iterable, in hb_filter()()
2019-02-14 10:49:31 -08:00
345bfbb207
[iter] Accept iterator, not iterable, in hb_map()()
2019-02-14 10:48:20 -08:00
16cc313dcd
[iter] Use hb_sink()
2019-02-14 10:40:05 -08:00
b702a0cbf8
[iter] Add hb_sink()
2019-02-14 10:39:58 -08:00
1cb1d5d7fb
Merge branch 'master' into cff-more-arrayof-fixes
2019-02-14 10:09:19 -08:00
6f1dfd082c
Merge branch 'master' into cff-retain-gids
2019-02-14 10:08:16 -08:00
7d2376de33
Merge branch 'master' into iter
2019-02-13 22:13:37 -08:00
890d0ee77f
Minor, use a meaningful naming in template parameter ( #1582 )
2019-02-14 00:27:01 +03:30
8a568a8858
Merge branch 'master' into cff-more-arrayof-fixes
2019-02-13 11:25:00 -08:00
b1dbc77fa6
Merge branch 'master' into cff-retain-gids
2019-02-13 11:24:38 -08:00
1e1d0e63df
Fix djgpp complains by tweaking templates ( #1579 )
...
For some reasons djgpp doesn't understand "unsigned int" can be same
with one of uint*_t anyway so lets do that for it explicitly.
Just to note, our CI's djgpp is based GCC 7.2.0 and isn't old.
2019-02-13 12:58:01 +03:30
bc33c617b8
Merge branch 'master' into cff-retain-gids
2019-02-12 15:10:50 -08:00
c6af846178
tweaked --desubroutinize to remove hintmask only subrs
2019-02-12 15:10:43 -08:00
c83412e4ce
Merge branch 'master' into cff-more-arrayof-fixes
2019-02-11 14:16:25 -08:00
fdfa3d29b7
hb-coretext.cc: remove TARGET_OS_MAC from test ( #1578 )
...
it is always true when building on APPLE systems
and this file only builds on APPLE systems
2019-02-11 11:16:05 +03:30
e2856c2d85
retain FDSelect & FDArray with --retain-gids
...
so in sync with fonttools behavior
2019-02-07 15:32:32 -08:00
1239b6b2b4
Merge branch 'master' into cff-more-arrayof-fixes
2019-02-07 10:29:40 -08:00
a5fa76977b
Merge branch 'master' into cff-retain-gids
2019-02-07 10:28:13 -08:00
214d0b024b
minor change
2019-02-07 10:27:43 -08:00
7859decdd0
hb-coretext.cc: clean up macosx test
...
TARGET_OS_OSX was introduced only in late OS versions
so always returns as "0" on older systems.
if !TARGET_OS_IPHONE can work, as it returns as !0 on older
systems where TARGET_OS_IPHONE is not defined, but is not
specific
if TARGET_OS_MAC && !(defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)
is both specific and accurate on all systems.
2019-02-05 20:26:49 -08:00
30b781f20a
Merge branch 'master' into cff-retain-gids
2019-02-01 14:50:34 -08:00
c12862657f
added desubroutinize & retain-gids full test cases with CFF fonts
...
and CFF retain-gids fixes
2019-02-01 14:50:01 -08:00
f2908b4d8f
Implement subset --regain-gids option with CFF1/2
...
along with api tests & expected results
2019-01-31 14:16:37 -08:00
1e06282105
Adjust hb_is_signed<>
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1535
2019-01-31 13:57:17 -08:00
21ea1c9152
Remove stale comment
2019-01-31 13:57:17 -08:00
9f80eb0177
Merge branch 'master' into cff-more-arrayof-fixes
2019-01-31 12:54:36 -08:00
2d940946d5
[iter] Fix mystery crash
...
Fuzzer caught it:
==14==ERROR: AddressSanitizer: stack-use-after-return on address 0x7fca2ed7a3e0 at pc 0x0000006057aa bp 0x7ffc3290f1d0 sp 0x7ffc3290f1c8
READ of size 4 at 0x7fca2ed7a3e0 thread T0
SCARINESS: 55 (4-byte-read-stack-use-after-return)
#0 0x6057a9 in OT::SingleSubstFormat2::subset(hb_subset_context_t*) const /src/harfbuzz/src/./hb-ot-layout-gsub-table.hh:194:40
#1 0x5ff921 in hb_subset_context_t::return_t OT::SingleSubst::dispatch<hb_subset_context_t>(hb_subset_context_t*) const /src/harfbuzz/src/./hb-ot-layout-gsub-table.hh:256:13
I can't reproduce locally, but many of the bots are failing because of this
as well.
It's a pity that operator-> must return pointer. Ugh. Why?!
2019-01-30 16:03:16 -08:00
cbe2118c58
Merge branch 'master' into iter
2019-01-30 15:07:09 -08:00
7c292c0853
[iter] Warning fix
...
Not sure why I don't get it, but this warning:
warning: base class ‘struct hb_iter_fallback_mixin_t<hb_array_t<const OT::UVSMapping>, const OT::UVSMapping&>’ should be explicitly initialized in the copy constructor [-Wextra]
2019-01-30 14:54:23 -08:00
d983c529b6
Merge pull request #1564 from googlefonts/retain_gids
...
[subset] Add --retain-gids option to the subsetter.
2019-01-30 17:17:59 -05:00
55d1d7c8bc
2.3.1
2019-01-30 13:54:15 -08:00
e799004e9f
[iter] Whitespace
2019-01-29 17:15:12 -08:00
849a0f1758
[iter] Add hb_iter_with_fallback_t instead
2019-01-29 17:10:19 -08:00
4d40ed9d1a
[iter] Add hb_iter_with_mixin_t<>
2019-01-29 13:55:23 -08:00
6521d5b201
[iter] Export operator << / >>
2019-01-29 13:44:39 -08:00
84a25d79c6
[iter] Rename
2019-01-29 13:39:19 -08:00
198859bb37
[subset] For retain gids don't truncate glyphs past the highest requested subset glyph.
2019-01-29 13:19:21 -08:00
05e99c86ba
[subset] A few small fixes for the new subset plan api.
2019-01-29 13:19:21 -08:00
bdbe047d6c
[subset] Update hb-subset-plan.cc to match hb-subset-plan.hh.
2019-01-29 13:19:21 -08:00
74c44ffeba
[subset] Update hb-subset-glyf.cc to use new hb-subset-plan API.
2019-01-29 13:19:21 -08:00
4842294b86
[subset] Update gsub to use glyphset() method of subset plan.
2019-01-29 13:19:21 -08:00
853b1f1aa5
[subset] Correct maxp num glyph's to use new subset plan method.
2019-01-29 13:19:21 -08:00
846e05a298
[subset] Re-add glyphs array to subset plan, with new name 'glyphs_deprecated'. Switch CFF subsetting to use it.
2019-01-29 13:19:21 -08:00
03e88eab5c
Re-implement HMTX/VMTX subsetting. Update it to support glyph renumbering and simplify the implementation.
2019-01-29 13:19:21 -08:00
925be29223
Update hb-ot-vorg-table and hb-ot-layout-common to use the updated subset plan api.
2019-01-29 13:19:21 -08:00
4af3be6ef8
Remove glyph array from subset plan, make num_glyphs and glyphset private.
2019-01-29 13:19:21 -08:00
23f364429d
[subset] Fix hdmx subsetting when retain gids is enabled.
2019-01-29 13:19:21 -08:00
2da1654aef
[subset] Compute num_glyphs during subset plan construction.
...
Update maxp to use the correct num glyphs.
2019-01-29 13:19:21 -08:00
96b038f375
[subset] fix failure to init instruction ranges values for an invalid glyph.
2019-01-29 13:19:21 -08:00
4b1ac3a2fa
[subset] Do some refactoring in hb-subset-glyf.cc.
...
- Extract code out into helper methods in several places.
- Bundle loca address, size and is short into a struct.
2019-01-29 13:19:21 -08:00
b7f971884e
Add retain_gids option to subset input. Update glyf and loca handling to respect retain_gids.
2019-01-29 13:19:21 -08:00
b379900755
Merge branch 'master' into cff-more-arrayof-fixes
2019-01-29 12:19:57 -08:00
e75b22039f
Move hb_addressof() to hb-meta.hh
2019-01-28 21:26:23 -05:00
71157a4520
[meta] Remove _ft struct names
...
Using decltype() instead.
2019-01-28 21:20:12 -05:00
9103bd056f
[pair] Use decltype
2019-01-28 21:16:51 -05:00
a30e13469e
[iter] Add operator << to set / vector
2019-01-28 16:39:01 -05:00
d438e61042
[iter] Fix operator() impls
2019-01-28 16:34:04 -05:00
57795bc8dd
[iter] Add operator>> and operator<<
2019-01-28 16:23:12 -05:00
8bd96be994
[iter] Use auto c = C.iter() internally
2019-01-28 16:17:36 -05:00
073fa4ac5a
Merge branch 'master' into iter
2019-01-28 14:35:41 -05:00
9a1df82e3f
[uniscribe] Whitelist function type cast
2019-01-28 14:15:18 -05:00
6e1c3eaf70
Fix sign comparison error
2019-01-28 14:12:41 -05:00
9db7a7da63
Fix warning
...
c:\projects\harfbuzz\src\hb-ot-color-cbdt-table.hh(59): warning C4146: unary minus operator applied to unsigned type, result still unsigned [C:\projects\harfbuzz\build\harfbuzz.vcxproj]
2019-01-28 14:09:59 -05:00
51b584880e
[pragma] Silence MSVC unknown-pragma warning
2019-01-28 14:09:45 -05:00
d592bd16cd
Try fixing MSVC build
2019-01-28 13:41:40 -05:00
0363ce650b
[iter] Accept C arrays in hb_iter()
2019-01-27 01:06:32 +01:00
b62e7f9223
[test] Test unary operator+
...
"Test" as in compiles..
2019-01-27 00:51:57 +01:00
778c96b8d7
[iter] Fix hb_iter()
2019-01-27 00:50:54 +01:00
2f5b1a9104
[iter] Add unary operator+ that returns a copy
2019-01-27 00:49:37 +01:00
fbab07f9b3
[iter] Add hb_bool() and make hb_filter default to it for predicate
2019-01-27 00:44:45 +01:00
313d63e240
[meta] Back to using _ft suffix for function-object types
...
Seprate namespace, cleaner, more clear.
2019-01-26 22:58:26 +01:00
2aff6d9625
[iter] Test that default-constructed iterators are empty
2019-01-26 22:54:25 +01:00
f35e7eabf1
pragma GCC diagnostic error "-Winjected-class-name"
...
See 6b6783e158
2019-01-26 22:50:00 +01:00
509353357c
[iter] Use hb_declval() instead of Null() to get instance
...
I had used Null to make one of the bots happy before. Not going
to bend to such demands anymore..
2019-01-26 22:47:35 +01:00
6b6783e158
[iter/meta] Fix build on newer clang
...
The mystery failure had to do with SFINAE failure because the template
function involved was accessing ::iter_t of a type that was also named iter_t.
In this context, apparently:
warning: ISO C++ specifies that qualified reference to 'iter_t' is a
constructor name rather than a type in this context, despite preceding 'typename' keyword
[-Winjected-class-name]
We use a new macro, also called hb_iter_t(), to get iterator type of
a type. This uses declval/hb_decltype, and has the added benefit
that it returns correct type for const vs non-const objects, if they
have different iterators.
2019-01-26 22:44:09 +01:00
5adb113baf
[meta] Mark function-objects as const
2019-01-26 22:15:59 +01:00
ac90f17c55
Merge branch 'master' into iter
2019-01-26 14:05:39 +01:00
60022ecced
Fix -Wcast-function-type warnings in util/ with gcc 4.8
2019-01-26 14:04:51 +01:00
f398097529
More static constexpr
2019-01-25 16:08:25 +01:00
090fe56dc6
Merge branch 'master' into iter
2019-01-25 16:06:52 +01:00
c685644386
Merge branch 'master' into cff-more-arrayof-fixes
2019-01-24 13:19:18 -08:00
e970de48bc
[AAT] Minor sign
2019-01-24 18:16:17 +01:00
a371a28cda
[AAT] Use a ring buffer for ligature stack
...
I think Apple does very similarly, but probably with a stack size of 16.
We do it with a stack size that is currently set to 64.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1531
2019-01-24 18:12:25 +01:00
7886b1578f
Whitespace
2019-01-24 18:06:17 +01:00
b976940243
[AAT] Handle transition errors during machine operation
...
Before we used to give up. Now, just ignore error and continue processing.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1531
2019-01-24 18:01:07 +01:00
0bd0a3311c
Merge branch 'master' into cff-more-arrayof-fixes
2019-01-24 08:53:28 -08:00
e234bb6a42
[AAT] Ignore machine errors and continue
2019-01-24 17:23:11 +01:00
1ec90514f6
[AAT] Minor
2019-01-24 17:21:41 +01:00
299eca0c3b
[AAT] Handle out-of-bounds classes
2019-01-24 17:17:00 +01:00
c4623db4a3
[AAT] Minor
2019-01-24 17:10:12 +01:00
c4e36f97b6
[AAT] Minor
2019-01-24 17:06:16 +01:00
f60282c5bf
More pragma control
...
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=924848
2019-01-24 16:29:09 +01:00
fd0889f903
Comment
2019-01-24 16:12:52 +01:00
9f31417733
Form cluster for Emoji sub-region tag sequences
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1556
2019-01-24 16:08:33 +01:00
3ecda71041
Adjust mark offsets when zeroing from fallback mark positioning code
...
Adjust tests.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1532
2019-01-24 12:28:24 +01:00
12cd3171ba
Merge branch 'master' into cff-more-arrayof-fixes
2019-01-23 14:05:42 -08:00
261a742181
more rewriting with ArrayOf<>
...
CFF1 Encoding0, Encoding1, CFF1SuppEncData
2019-01-23 14:04:29 -08:00
36fb2b4da9
[AAT] In InsertionChain, set mark to previous-position if inserting
...
Fixes MORX-31
2019-01-23 20:53:57 +01:00
baf4d6a68a
[AAT] Remove mark_set from InsertionChain
2019-01-23 20:36:07 +01:00
0b2fa342de
More of previous
2019-01-22 16:36:00 +01:00
a5e5dd8b42
Fix sign-compare error resulted from promoting unsigned integers to signed larger ints
...
Clang and gcc know not to warn in these cases, but not nonmainstream compilers
2019-01-22 16:30:07 +01:00
32379bbf10
Cast HB_UNTAG results to uint8_t
2019-01-22 12:55:29 +01:00
83d4aa5ca9
More -Wcast-error fix
2019-01-22 12:52:23 +01:00
447323b85a
Better fix for -Wcast-align errors
2019-01-22 12:50:12 +01:00
81ec543d80
More -Wcast-error fixes
2019-01-22 12:43:12 +01:00
9077272549
pragma GCC diagnostic error "-Wsign-compare"
2019-01-22 12:40:18 +01:00
8d05bf7dc0
Fix cast-align error
...
If compiler doesn't inline StructAtOffset, this was an error since we
only disable cast-align at call-site. So, move the cast out.
../src/hb-machinery.hh: In instantiation of 'const Type& StructAtOffset(const void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:146:85: required from here
../src/hb-machinery.hh:63:12: error: cast from 'const char*' to 'const unsigned int*' increases required alignment of target type [-Werror=cast-align]
{ return * reinterpret_cast<const Type*> ((const char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/hb-machinery.hh: In instantiation of 'Type& StructAtOffset(void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:147:79: required from here
../src/hb-machinery.hh:66:12: error: cast from 'char*' to 'unsigned int*' increases required alignment of target type [-Werror=cast-align]
{ return * reinterpret_cast<Type*> ((char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-01-22 12:34:05 +01:00
70a52d6bd8
Convert all other enum class consts to static constexpr
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1553
2019-01-22 12:17:26 +01:00
5d4b0377b9
Convert unsigned enum class consts to static constexpr
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1553
2019-01-22 12:17:26 +01:00
ef00654962
Convert tag enum class consts to static constexpr
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1553
2019-01-22 12:17:26 +01:00
39e1b6d03f
Convert boolean enum class consts to static constexpr
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1553
2019-01-22 12:17:26 +01:00
271cb7c1c0
Make some enum constants unsigned
2019-01-22 12:17:26 +01:00
3d9a6e6266
Whitespace
2019-01-22 12:17:26 +01:00
c81f02fd06
pragma GCC diagnostic error "-Wvla"
2019-01-22 12:17:26 +01:00
380c3cffb9
Use enum for class constant
2019-01-22 10:51:20 +01:00
6d042a18e7
[CFF] Use enum for tableTag
2019-01-22 10:51:20 +01:00
c1cbbb9459
Use static constexpr for large class constants
2019-01-22 10:51:20 +01:00
21c0713a1c
Whitespace
2019-01-20 20:12:12 -05:00
934d3fa2a7
Use more iter pipelines
2019-01-20 20:12:12 -05:00
420d8ac350
[algs] Add hb_iter()
...
Makes it nicer in pipelines.
2019-01-20 20:12:12 -05:00
54ec48ea20
Use iter pipelines more
2019-01-20 20:12:12 -05:00
83cecd80d9
[iter] Default projection to identity
2019-01-20 20:12:12 -05:00
a699c6b17c
[algs] Add hb_identity
2019-01-20 20:12:12 -05:00
463cfb426f
Fix unused-variable warnings
...
inline variables are not C++11, so mark them unused...
2019-01-20 20:12:12 -05:00
f4cbb1ee0c
WIP
2019-01-20 20:12:12 -05:00
471e96e55d
[iter] Use forwarding references
2019-01-20 20:12:12 -05:00
528ea66f24
[algs] Fix hb_first() / hb_second()
2019-01-20 20:12:12 -05:00
343f5a4bfc
[iter] Misc fixes to get piping almost work
2019-01-20 20:12:12 -05:00
7cedf7f64c
Change hb_first() and hb_second() to function objects
2019-01-20 20:12:12 -05:00
f35568d603
[iter] Add hb_filter()
...
Untested.
2019-01-20 20:12:12 -05:00
1733e4702c
[iter] Add hb_map()
...
Untested.
2019-01-20 20:12:12 -05:00
f7fcc47641
[iter] Make hb_zip() take const references
2019-01-20 20:12:12 -05:00
ede1a71b31
Minor rename
2019-01-20 20:12:12 -05:00
93551669c5
Remove unused Coverage::iter_t::get_coverage()
2019-01-20 20:12:12 -05:00
af2067e87b
Use hb_zip() moooore
2019-01-20 20:12:12 -05:00
0d1fdf939d
Use hb_zip() some mooore
2019-01-20 20:12:12 -05:00
af6c190235
Use hb_zip() some moore
2019-01-20 20:12:12 -05:00
83ad0b6d0f
Use hb_zip() some more
2019-01-20 20:12:12 -05:00
f0dd0656b8
Use hb_zip() some
2019-01-20 20:12:12 -05:00
200cdb721b
[iter] Rename hb_zip_t to hb_zip_iter_t
2019-01-20 20:12:12 -05:00
3290c181c1
[algs] Whitespace
2019-01-20 20:12:12 -05:00
014c50292b
[iter] Move code
2019-01-20 20:12:12 -05:00
6e3ad650d1
Rename hb-dsalgs to hb-algs
2019-01-20 20:12:12 -05:00
f27607580e
[algs] Add hb_first() and hb_second()
2019-01-20 20:12:12 -05:00
a7de144df3
Implement uniform map interface
...
Coverage, ClassDef, hb_set_t, and hb_map_t implement.
2019-01-20 20:12:12 -05:00
7987095e64
[meta] Remove hb_enable_if_t
...
It was only used for C++<11 which does not allow default parameters
in function templates. Looks like we cannot support <11 anyway, so,
start cleaning up.
2019-01-20 20:12:12 -05:00
15a6928436
[iter] Implement operator-> unconditionally
...
The right condition to check for would have been "is_struct", which
we don't have.
2019-01-20 20:12:12 -05:00
8f52a827e7
Allow rvalues in hb_addressof()
2019-01-20 20:12:12 -05:00
a4ea0d3680
[iter] Change from const_iter_t/iter_t to iter_t/writer_t
2019-01-20 20:12:12 -05:00
7798e4fcc3
[iter] Change Coverage iterator to only return glyph-id
2019-01-20 20:12:12 -05:00
84e5d00229
[iter] Add hb_zip()
2019-01-20 20:12:12 -05:00
636786ecaf
[iter] Rename __item_type__ to __item_t__
2019-01-20 20:12:12 -05:00
6caf76f4a8
Tighten Coverage iteration
2019-01-20 20:12:12 -05:00
ff3a7ce1e7
[subset] Minor
2019-01-20 20:12:12 -05:00
42bf80e578
[iter] More semicolon
2019-01-20 20:12:12 -05:00
f78f837ef1
[iter] Use aliasing using for types
...
Fix ambiguity of hb_sorted_array_t::item_t with gcc. No idea if that's a gcc bug
or what spec requires, but using aliasing using seems to fix it. It probably breaks
our non-C++11 bots, in which case I have to condition the change. Testing.
2019-01-20 20:12:12 -05:00
3fc03e42ce
[iter] Use static_assert with hb_is_random_access_iterator()
...
Both, checks constexpr'ness, and fixes build with cra**y implementations
of assert() macro:
test-iter.cc:108:11: error: too many arguments provided to function-like macro invocation
assert (hb_is_random_access_iterator (array_iter_t<int>));
^
./hb-iter.hh:186:42: note: expanded from macro 'hb_is_random_access_iterator'
hb_is_random_access_iterator_of (Iter, typename Iter::item_t)
^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:89:9: note: macro '__STRING' defined here
\#define __STRING(x) #x
^
test-iter.cc:108:3: error: use of undeclared identifier '__STRING'
assert (hb_is_random_access_iterator (array_iter_t<int>));
^
/usr/include/assert.h:91:21: note: expanded from macro 'assert'
: __assert_fail (__STRING(expr), __FILE__, __LINE__, __ASSERT_FUNCTION))
^
2019-01-20 20:12:12 -05:00
6af9c5f18e
[iter] Remove stray semicolons
2019-01-20 20:12:12 -05:00
74ca7b580c
[OT] Implement operator[] for Coverage and ClassDef
2019-01-20 20:12:12 -05:00
6c548b6657
[iter] Add TODO
2019-01-20 20:12:12 -05:00
362d4e7cc3
[iter] Implement for OT::ArrayOf / OT::SortedArrayOf
2019-01-20 20:12:12 -05:00
2f837a365c
[SortedArrayOf] Fix sub_array() return type
2019-01-20 20:12:12 -05:00
54c30e949e
[iter] Constrain hb_fill() and hb_copy()
2019-01-20 20:12:12 -05:00
dc0a98cbe7
[iter] Add TODO
2019-01-20 20:12:12 -05:00
2658e40ffb
[iter] Add hb_is_random_access_iterator()
2019-01-20 20:12:12 -05:00
445364d80a
[iter] Rename hb_is_[sorted_]iterator() -> hb_is_[sorted_]iterator_of()
2019-01-20 20:12:12 -05:00
a6c013b1bf
[meta] Add hb_declval() macro
2019-01-20 20:12:12 -05:00
adc5910a63
[iter] Syntax
2019-01-20 20:12:12 -05:00
ca6adcd1ad
[iter] Test hb_is_iterable / hb_is_iterator
2019-01-20 20:12:12 -05:00
8237809f06
[serialize] Make SortedArrayOf:;serialize() take sorted-iterator
2019-01-20 20:12:12 -05:00
47333c8a30
[iter] Fix operator->
2019-01-20 20:12:12 -05:00
177a8af380
[array] SFINAE fun
2019-01-20 20:12:12 -05:00
8414f16787
[meta] Rename
2019-01-20 20:12:12 -05:00
8e0a58e1b3
[array] Remove construction that was removing constness
2019-01-20 20:12:12 -05:00
85969e357a
[iter] Fix test
2019-01-20 20:12:12 -05:00
da49961836
[iter] Remove comment
2019-01-20 20:12:12 -05:00
815cde9fa3
[iter] Use is_sorted_iterator
2019-01-20 20:12:12 -05:00
ed4336680d
[iter] Handhold hb_is_iterator() type deduction
...
by partial-instantiating on Iter.
2019-01-20 20:12:12 -05:00
cb5011d364
Revert "[iter] Add hb_iter_of_t<>"
...
This reverts commit d6cbe96e2fc7bc8f1c10e631b52b1ef31ff9a6f5.
Isn't useful, as duplicate inheritance of same type results in ambiguity
errors...
2019-01-20 20:12:12 -05:00
c132cda9d9
[iter] Fix warnings
2019-01-20 20:12:12 -05:00
c9d8a07e30
[iter] Add hb_iter_of_t<>
2019-01-20 20:12:12 -05:00
b5d6fe1a45
[iter] Remove hb_sorted_iter_t
...
Not enforcing it using type hierarchy.
2019-01-20 20:12:12 -05:00
255085bd59
[iter] Const correctness
2019-01-20 20:12:12 -05:00
415f3f4320
Add operator= to IntType, commented out
...
https://github.com/harfbuzz/harfbuzz/pull/1510
2019-01-20 20:12:12 -05:00
183be8f452
[iter] Minor
2019-01-20 20:12:12 -05:00
6cd96ba1ac
[iter] Make is_random_access_iterator a constant
...
We cannot rely on constexpr functions...
2019-01-20 20:12:12 -05:00
a685bfe8fc
Separate GlyphID from HBUINT16
...
For stricter enforcement.
2019-01-20 20:12:12 -05:00
8ac64d0090
[iter] Fix sorted_iter iter class
2019-01-20 20:12:12 -05:00
93615b9598
[iter/meta] Add hb_is_sorted_iterator()
2019-01-20 20:12:12 -05:00
92f25db1e8
[iter] Remove stale comment
2019-01-20 20:12:12 -05:00
40c24fd4a6
[iter] Port Coverage towards iter_t instead of array_t specifics
2019-01-20 20:12:12 -05:00
d552b6818c
[meta] Move typename around
...
We'll see if bots like.
2019-01-20 20:12:12 -05:00
f64ea8fc65
[meta] Move code around
2019-01-20 20:12:12 -05:00
aa2ab4f061
[iter] WHitespace
2019-01-20 20:12:12 -05:00
851fbb23ea
[iter] Port Coverage::serialize to hb_is_iterator
2019-01-20 20:12:12 -05:00
06a44e2e53
[iter/meta] Match hb_is_iterator<> using SFINAE
...
By specifying Item type, which is desirable.
2019-01-20 20:12:12 -05:00
bcb913efb4
Minor
2019-01-20 20:12:12 -05:00
859a880b08
[iter] Add back operator +
...
Too ugly to remove..
2019-01-20 20:12:12 -05:00
076faf7c18
[iter] Disable operator +
...
To see if it makes bots happy... This is frustrating.
2019-01-20 20:12:12 -05:00
a46874f1ab
[iter] Revert back uses of C++11 auto type deduction
2019-01-20 20:12:12 -05:00
0828db8444
[iter] Rename
2019-01-20 20:12:12 -05:00
037f735efd
[iter] Remove friend operator +, hoping to fix some bots
2019-01-20 20:12:12 -05:00
cb27918d0a
Use Null() instead of declval(), hoping to fix some bots
2019-01-20 20:12:12 -05:00
3d22900f62
[meta] Don't use template default arguments for functions
...
That's a C++11 extension apparently...
2019-01-20 20:12:12 -05:00
b89d20dd9f
[meta] Fix unused-function-template warning
2019-01-20 20:12:12 -05:00
df138da2e6
[iter/meta] Implement is_iterator
...
Removes use of auto type deduction again, which was not supported on many bots.
2019-01-20 20:12:12 -05:00
8570da1d74
[meta] Minor
2019-01-20 20:12:12 -05:00
442f4a5891
[meta] Move more code here
2019-01-20 20:12:12 -05:00
8c6cbbdfa3
[iter/meta] Add hb_is_iterable
2019-01-20 20:12:12 -05:00
576d5e2420
Don't use delegating constructors
...
Not all C++11 features are created equal when it comes to support...
2019-01-20 20:12:12 -05:00
e32bf39766
[meta] Add enable_if
2019-01-20 20:12:12 -05:00
e76a3cae0f
Add hb-meta.hh for meta-programming
2019-01-20 20:12:12 -05:00
5ec11ce13a
[iter] Clarify readonly vs lvalue iterators
...
lvalue iterators must declare __item_type__ as a reference.
2019-01-20 20:12:12 -05:00
2cbf5bf3a9
[iter] Test OT::Coverage iter
2019-01-20 20:12:12 -05:00
fd75d29f0f
[iter] Streamline vector iterators
2019-01-20 20:12:12 -05:00
570473a345
[iter] Make hb_sorted_array_t work as iter
...
Ugly, but does the job.
2019-01-20 20:12:12 -05:00
d6024794fb
Change hb_void_t implementation
2019-01-20 20:12:12 -05:00
cde31988c2
[iter] Mark Coverage iterator sorted
2019-01-20 20:12:12 -05:00
49161d411f
[subset] Take iterator in ArrayOf serialize
...
Still not satisfied with how I can enforce iterators only, but
seems to work for now.
2019-01-20 20:12:12 -05:00
e16884248f
[iter] Port Coverage iterator to hb_iter_t
2019-01-20 20:12:12 -05:00
c68bca0f95
Add hb_pair_t<> and hb_pair()
2019-01-20 20:12:12 -05:00
8303a9b011
[Coverage] Ensure increasing coverage in iteration
2019-01-20 20:12:12 -05:00
50cd26d394
[Coverage] Mark iterator methods const
2019-01-20 20:12:12 -05:00
9df1a6eba7
[iter] Use operator bool in a few places
2019-01-20 20:12:12 -05:00
7788ac14a4
[iter] Remove redundant methods
2019-01-20 20:12:12 -05:00
3dea9affda
[iter] Test default-constructability
2019-01-20 20:12:12 -05:00
743ff09368
[iter] Implement friend opeator + (int, iter)
2019-01-20 20:12:12 -05:00
6dc4a1c9b1
[iter] Remove const_iter
2019-01-20 20:12:12 -05:00
f2b56af3ef
[iter] Remove hack for older compilers
2019-01-20 20:12:12 -05:00
2ea79e0340
[iter] Minor
2019-01-20 20:12:12 -05:00
fb053b6333
[iter] Rename random_access() to constexpr is_random_access()
2019-01-20 20:12:12 -05:00
2790aad28c
[iter] Add operator ->
2019-01-20 20:12:12 -05:00
d3976b7e63
[iter] Make them work, mostly
2019-01-20 20:12:12 -05:00
959bb58bdd
[vector] Add iterator
2019-01-20 20:12:12 -05:00
dd7c628ed1
Use enum for class constant
2019-01-20 19:51:08 -05:00
cf7edf52c3
[CFF] Use enum for tableTag
2019-01-20 19:49:59 -05:00
bd1318b8cc
Use static constexpr for large class constants
2019-01-20 19:47:52 -05:00
043b610fa6
Fix sign compare warnings
...
../../third_party/harfbuzz-ng/src/src/hb-map.hh(56,45): warning: comparison of integers of different signs: 'const hb_codepoint_t' (aka 'const unsigned int') and 'hb_map_t::(anonymous enum at ../../third_party/harfbuzz-ng/src/src/hb-map.hh:169:3)' [-Wsign-compare]
bool is_unused () const { return key == INVALID; }
2019-01-19 09:21:33 -05:00
ce317d0320
Fix warning
...
warning: '_WIN64' is not defined, evaluates to 0 [-Wundef]
2019-01-19 09:21:33 -05:00
0c2bd1b160
[dwrite] Fix delete-non-virtual-dtor warning ( #1550 )
2019-01-19 16:30:07 +03:30
89bcfb204c
Remove TRACE_COLLECT_GLYPHS
2019-01-18 14:59:18 -05:00
f13b6786f0
[pragma] Only add if GCC or clang
2019-01-18 14:53:54 -05:00
c2ea7a9da4
[directwrite] More fix
2019-01-18 14:20:45 -05:00
9714d3ec5c
[dwrite] Try to fix delete-non-virtual-dtor warnings
...
Fixes #1548 hopefully
2019-01-18 21:55:21 +03:30
0772c06f96
Remove tracing from closure
2019-01-18 12:53:47 -05:00
d9f6be3a61
Fix -Wundef errors with __GNUC__
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1549
2019-01-18 12:53:47 -05:00
28917e58f9
init interp_env_t::hintmask_size
...
fixes issue #1547
2019-01-18 09:43:51 -08:00
9b4e51b2e4
[pragma] Enable error -Wdelete-non-virtual-dtor
...
Currently fails directwrite backend.
2019-01-18 12:23:02 -05:00
e65272281c
[directwrite] Fix error
...
hb-directwrite.cc: In constructor 'TextAnalysis::TextAnalysis(const wchar_t*, uint32_t, const wchar_t*, DWRITE_READING_DIRECTION)':
hb-directwrite.cc:489:18: error: 'TextAnalysis::mText' will be initialized after [-Werror=reorder]
const wchar_t* mText;
^~~~~
hb-directwrite.cc:488:12: error: 'uint32_t TextAnalysis::mTextLength' [-Werror=reorder]
uint32_t mTextLength;
^~~~~~~~~~~
hb-directwrite.cc:282:3: error: when initialized here [-Werror=reorder]
TextAnalysis (const wchar_t* text, uint32_t textLength,
^~~~~~~~~~~~
hb-directwrite.cc: In function 'hb_bool_t _hb_directwrite_shape_full(hb_shape_plan_t*, hb_font_t*, hb_buffer_t*, const hb_feature_t*, unsigned int, float)':
2019-01-18 12:22:07 -05:00
b900f78088
[pragma] More cast-align whitelist
2019-01-18 10:08:23 -05:00
0d8b931bbe
[pragma] Allow cast-align in hb-font.cc
...
../src/hb-machinery.hh: In instantiation of 'const Type& StructAtOffset(const void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:144:85: required from here
../src/hb-machinery.hh:63:12: error: cast from 'const char*' to 'const unsigned int*' increases required alignment of target type [-Werror=cast-align]
{ return * reinterpret_cast<const Type*> ((const char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/hb-machinery.hh: In instantiation of 'Type& StructAtOffset(void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:145:79: required from here
../src/hb-machinery.hh:66:12: error: cast from 'char*' to 'unsigned int*' increases required alignment of target type [-Werror=cast-align]
{ return * reinterpret_cast<Type*> ((char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/hb-machinery.hh: In instantiation of 'Type& StructAtOffset(void*, unsigned int) [with Type = int]':
2019-01-18 10:03:43 -05:00
a25174a56b
[pragma] GCC diagnostic error "-Wreorder"
2019-01-18 09:59:36 -05:00
4660090569
[pragma] GCC diagnostic warning "-Wmaybe-uninitialized"
2019-01-18 09:53:16 -05:00
7a634d7d5b
[pragma] Massage more
2019-01-18 09:49:14 -05:00
16e5ba85b1
[pragma] More
2019-01-18 09:46:17 -05:00
2bd530d598
[pragma] Reorg again
...
https://github.com/harfbuzz/harfbuzz/issues/1546
2019-01-18 09:28:22 -05:00
c04272fac8
[pragma] GCC diagnostic ignored "-Wunknown-warning-option"
...
Try at fixing https://github.com/harfbuzz/harfbuzz/issues/1546
2019-01-18 08:49:45 -05:00
4d3c8f9685
[uniscribe] More warnings
2019-01-17 19:58:54 -05:00
6a5d2b21d8
[uniscribe] Fix warnings
2019-01-17 19:57:17 -05:00
5b13e458c3
Fix build
2019-01-17 19:52:32 -05:00
a77bd6bb89
[pragma] GCC diagnostic ignored "-Wclass-memaccess"
2019-01-17 19:33:41 -05:00
436c7b294a
[pragma] ignored -Wunsafe-loop-optimizations // TODO fix
2019-01-17 19:03:33 -05:00
e3b3181e9d
[pragma] error -Wclass-memaccess
2019-01-17 19:02:06 -05:00
1a6b97a491
[pragma] More
2019-01-17 18:55:03 -05:00
06e8091661
[pragma] More
2019-01-17 18:47:32 -05:00
1077e40bf1
[pragma] Flesh out more
2019-01-17 18:36:10 -05:00
7e6bd510fc
Use NNOffsetTo<> in rest of places
2019-01-17 18:24:18 -05:00
b1152d5e66
Use NNOffsetTo<>
2019-01-17 18:17:04 -05:00
205d72a198
Add NNOffsetTo<>
2019-01-17 18:10:38 -05:00
c99d13d860
[AAT] Comment
2019-01-17 17:56:27 -05:00
f39b5603ff
Comment
2019-01-17 17:50:01 -05:00
347ad454b8
[AAT] Remove unused code
2019-01-17 17:47:29 -05:00
b344d4385a
[AAT] Allow null in ankr lookupTable offset
2019-01-17 17:44:39 -05:00
14a560a245
[pragma GCC] Ignore -Wtype-limits
2019-01-17 17:42:44 -05:00
3f2daae630
More GCC pragmas
2019-01-17 15:27:31 -05:00
d6c5473e1f
Rename macro
2019-01-17 15:22:46 -05:00
a9946b7cfe
Add more GCC warning pragmas
2019-01-17 15:22:28 -05:00
868b0c0c2e
Move -Wcast-align to hb.hh
2019-01-17 15:18:18 -05:00
8874eef8ff
Add pragram GCC diagnostic ignored "-Wunused-macros"
2019-01-17 15:04:44 -05:00
cc8e9a436f
[AAT] Fully sanitize ankr table at sanitize time
...
Third try to fix access. Followup 6879efc2c1https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12532
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=922303
2019-01-17 14:55:05 -05:00
6879efc2c1
[AAT] Fix anchor bound checking, again
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12532
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=922303
2019-01-17 14:08:02 -05:00
a262eb3d0b
[aat] Minor
2019-01-17 14:06:32 -05:00
c986ca15a6
Improve overflow avoidance
...
Better fix for 480406cd3e
2019-01-15 13:58:19 -05:00
0d2727f4fe
fix FDSelect fuzzing bug ( #1539 )
...
Rewrote struct FDSelect3_4.ranges as ArrayOf
Updated FDSelect3_4::sanitize () to call ranges.sanitize ()
nRanges now a function to return a reference to ranges.len
2019-01-14 18:23:17 -08:00
9f6172d669
Move _POSIX_SOURCE definition
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1308
2019-01-14 20:45:31 -05:00
480406cd3e
Fix assertion on address overflow
...
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=917031
2019-01-14 15:27:34 -05:00
7a6686a589
[AAT] Fix mort ContextualSubtable offset access
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12312
2019-01-14 15:09:14 -05:00
a3fa7d3336
[AAT] Fix ankr table access
...
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=918340
2019-01-14 14:37:36 -05:00
760303d411
deleted a duplicate fontdicts_mod.fini() call ( #1538 )
2019-01-11 15:27:35 -08:00
7b48641aa8
fix leak in subset_enc_supp_codes ( #1537 )
...
oss-fuzz issue 12310
2019-01-08 15:37:48 -05:00
97f67a3c3d
[ci] Enable more of GCC compile warnings ( #1533 )
2019-01-04 23:10:39 +03:30
26c5b54fb0
CircleCI: Test for Python 3 syntax errors and undefined names ( #1522 )
...
Catch missing imports and errors like #1520 and #1521
__E901,E999,F821,F822,F823__ are the "_showstopper_" [flake8](http://flake8.pycqa.org ) issues that can halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.
* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable name referenced before assignment
* E901: SyntaxError or IndentationError
* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
2018-12-31 07:00:43 +03:30
f4da28b1f1
Python 3 fixes to gen-os2-unicode-ranges.py ( #1521 )
...
In Python 3, __reload()__ was moved and __sys.setdefaultencoding()__ because the default is already utf-8. Also __Error()__ is an _undefined name_ and __Exception()__ creates a generic exception.
2018-12-30 15:28:34 +03:30
d092fb2719
Ouch! Fix build on C++<11
2018-12-30 01:53:03 -05:00
89949ed28d
Fix ubsan with passing nullptr to qsort()
2018-12-30 01:52:19 -05:00
357a0a7ad3
Fix build on C++ < 11
2018-12-27 18:29:23 -05:00
54c0a17310
[vector] Fix warning
2018-12-27 18:28:07 -05:00
1043ddbee8
[aat] Minor
2018-12-27 18:27:11 -05:00
71da9ca62f
[vector] Remove use of arrayZ() by using casts
2018-12-27 18:01:06 -05:00
fa333e34d6
[vector] Remove static_array
...
Was good idea, but with C++ types with constructor/destructor, was getting in
the way as compiler was destructing those items where it was not desired.
Since C++ does not allow zero-sized arrays, just remove it...
2018-12-27 17:56:22 -05:00
ab2258a419
[vector] Use allocated = -1 to signify failure
2018-12-27 17:45:05 -05:00
09fa536d89
fix lealk with cff2::accelerator_templ_t::topDict ( #1517 )
2018-12-27 11:33:09 -05:00
3b81442cd5
[vector] Change pre-alloced count from 8 to 2
...
I'm thinking about dropping it to zero, but that needs slight code changes.
2018-12-24 11:31:04 -05:00
d25a2f1496
Fix a few warnings
2018-12-23 20:34:24 -05:00
85003b594b
[iter] Fix warning
2018-12-23 20:34:24 -05:00
e4355b1ca1
[set] Add iter_t as alias to const_iter_t
2018-12-23 20:34:24 -05:00
33f8de6186
[set] Change to const_iter
2018-12-23 20:34:24 -05:00
f88fed5cd8
[set] Cache length in iterator
2018-12-23 20:34:24 -05:00
d0a706c7fd
Minor, remove redundant inline
2018-12-22 20:07:57 +03:30
ae6e348d64
Minor, tweak spaces
2018-12-22 20:07:57 +03:30
29f0b6bce7
CFF renaming ( #1507 )
...
* reimplement ByteStr as byte_str_t based on hb_ubytes_t
Unuse start_embed<ByteStr>
Also renamed SubByteStr to byte_str_ref_t
More renaming to come
* substr renamed to str_ref in line with its type byte_str_ref_t
* uncamelize non-table struct names
* uncamelized non-struct types OpCode etc
* add byte_str_t copy ctor
* test
* test2
* undo tests
* fix bot failure
* undo the previous change
* fixed tabs, added inline
* Revert "fixed tabs, added inline"
This reverts commit 21163c30e9
2018-12-22 10:47:04 -05:00
89d04129e2
[set] Actually derive iterator from hb_sorted_iter_t<>
2018-12-21 20:07:52 -05:00
fc35919d01
[set] Implement unified iterator
2018-12-21 20:06:17 -05:00
4911e67d2d
[set] Mark some internals protected
2018-12-21 20:00:52 -05:00
954b985422
[iter] Add hb_sorted_iter_t<>
2018-12-21 19:55:02 -05:00
b205105c9e
[iter] Change operator[] operand to be signed
...
To fix older compilers again (this was the case in hb_array_t).
hb-ot-layout-common.hh:1353: note: candidate 2: operator[](T*, int) <built-in>
hb-ot-layout-common.hh:1354: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-iter.hh:63: note: candidate 1: Item& hb_iter_t<Iter, Item>::operator[](unsigned int) const [with Iter = hb_array_t<const OT::IntType<short unsigned int, 2u> >, Item = const OT::IntType<short unsigned int, 2u>]
hb-ot-layout-common.hh:1354: note: candidate 2: operator[](T*, int) <built-in>
hb-ot-layout-common.hh: In member function 'bool OT::ClassDef::serialize(hb_serialize_context_t*, hb_array_t<const OT::IntType<short unsigned int, 2u> >, hb_array_t<const OT::IntType<short unsigned int, 2u> >)':
hb-ot-layout-common.hh:1490: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-iter.hh:63: note: candidate 1: Item& hb_iter_t<Iter, Item>::operator[](unsigned int) const [with Iter = hb_array_t<const OT::IntType<short unsigned int, 2u> >, Item = const OT::IntType<short unsigned int, 2u>]
hb-ot-layout-common.hh:1490: note: candidate 2: operator[](T*, int) <built-in>
2018-12-21 19:48:21 -05:00
25786f49c1
[array] Port to hb_iter_t<>
...
hb_array_t is its own iterator...
2018-12-21 19:29:00 -05:00
2a33ab0560
[iter] Change __more__ to fallback to __len__
2018-12-21 18:53:01 -05:00
474a12058d
[array/vector] Rename len to length
2018-12-21 18:53:01 -05:00
2fc1860a5b
[iter] Split hb_iter_t<> into hb_iter_t<> and hb_iter_mixin_t<>
2018-12-21 18:09:45 -05:00
865deeb3be
Adjust internal header dependencies
2018-12-21 17:46:10 -05:00
8e5c2bc60b
[Makefile.am] Minor
2018-12-21 17:29:11 -05:00
f419cef417
[iter] Include from hb.hh
2018-12-21 17:22:09 -05:00
7557e34872
[iter] Move hb_fill() and hb_copy() to hb-iter.hh
2018-12-21 17:21:19 -05:00
5e1840e031
[iter] Disallow copy-construction or assignment of hb_iter_t<>
...
Should only be done by subclass.
2018-12-21 16:39:57 -05:00
65e8bd56ad
[iter] Fix hb_copy() return value
2018-12-21 16:20:30 -05:00
40d71211a8
[iter] Add const_iter_t / const_iter()
2018-12-21 16:19:44 -05:00
aaddfaa57a
[iter] Make hb_fill() take collection type, not iter
...
Starting to get the hang of when take which.
2018-12-21 16:04:38 -05:00
7b4eea853c
[array] Add more hb_array() / hb_sorted_array() variants
2018-12-21 16:02:16 -05:00
09740148e3
[serialize] Use component_list by reference, as a supplier
2018-12-21 15:56:01 -05:00
3dbe1e364c
[iter] Add .random_access()
2018-12-21 15:53:09 -05:00
20f14b4aa6
[iter] Fix __end__()
2018-12-21 15:19:22 -05:00
95265aeab7
[array] Remove copy constructor
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1502
2018-12-21 15:12:55 -05:00
69d232eaea
Fix bot
...
C:\projects\harfbuzz\src\hb-uniscribe.cc(709): error C2666: 'hb_vector_t<OPENTYPE_FEATURE_RECORD,8>::operator +': 3 overloads have similar conversions [C:\projects\harfbuzz\build\harfbuzz.vcxproj]
2018-12-21 15:08:06 -05:00
b9a51f5310
Minor
2018-12-21 15:05:00 -05:00
bdb6da7226
[iter] Fix test again
2018-12-21 11:20:27 -05:00
e952075248
Minor
2018-12-21 11:15:16 -05:00
35503d7d73
[iter] More prototyping
2018-12-21 03:03:46 -05:00
73c7a896d1
[iter] Make hb_fill() and hb_copy() take iterators
...
I'm still going back and force...
2018-12-21 02:48:28 -05:00
12e506fda4
[iter] Add hb_fill()
2018-12-21 02:47:04 -05:00
ad3ed58de5
[iter] Start prototyping hb_copy()
2018-12-21 02:25:58 -05:00
44af738d19
[iter] Showcase implicit casts
2018-12-21 01:59:37 -05:00
879faa2aee
Rename
2018-12-21 01:57:40 -05:00
aeb696a91c
[iter] Rename
2018-12-21 01:57:02 -05:00
8001e00a47
[iter] First sample use
2018-12-21 01:53:27 -05:00
19d2b5013d
[iter] Add bidirectionality
2018-12-21 01:20:04 -05:00
314d8698d0
[iter] Sketch new iterator design
2018-12-21 01:15:49 -05:00
f6d5f1e91c
[iter] Add empty test
2018-12-21 00:23:46 -05:00
b80b97b549
Revert "Remove unused hb-iter.hh"
...
This reverts commit 969ff3c7aa
2018-12-21 00:08:05 -05:00
a728c63a98
[vector] Add operator bool
2018-12-20 23:15:49 -05:00
bd36977392
Rename
2018-12-20 23:14:24 -05:00
e6ebc9b6f8
Remove unused typedef
2018-12-20 23:13:36 -05:00
4941e95f10
2.3.0
2018-12-20 21:48:57 -05:00
87f7c83fff
[serializer] Add operator <<
...
Not sure if we are going to use it. But might incentivize us to.
2018-12-20 15:54:17 -05:00
5b70074edf
Add hb_assign(obj, value)
2018-12-20 15:38:59 -05:00
6124123393
[serialize] Adjust ClassDef
...
[skip ci]
2018-12-20 12:26:44 -05:00
4220b7bdd7
Fix code on big-endian gcc / clang
...
Ouch! We need a bigendian bot...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1498
2018-12-20 11:48:45 -05:00
c87ee72232
Minor [skip ci]
2018-12-19 22:28:16 -05:00
5000a59a63
[saitnize] Minor
2018-12-19 22:27:09 -05:00
3ee4ea9456
Fix build on older Visual Studio versions ( #1499 )
...
* src/hb-cff-interp-dict-common.hh: Use ull for unsigned int64_t
The llu suffix does not work for older Visual Studio versions
(pre-2013), but ull works for all the compilers that we attempt to
support.
* test/api: Fix build on pre-C99 compilers
Ensure variables are declared at the top of the block.
* src/hb-dsalgs.hh: Add specialization for hb_is_signed<> for __int8
Pre-Visual Studio 2010 does not consider __int8 (which is typedef'ed to
int8_t) to be equivilant to signed char, so the compiler cannot find the
corresponding hb_is_signed<> specialization that is needed.
The interesting thing is unsigned __int8 is considered to be equivilant
to unsigned char, so as the other types (short, int, long) that we look
for here, so only the specialization for __int8 is added here.
This will fix builds on Visual Studio 2008 at least.
2018-12-19 22:26:54 -05:00
a62870506d
[sanitize] Use hb_static_size instead of ::static_size
...
https://github.com/harfbuzz/harfbuzz/issues/1496#issuecomment-448818112
2018-12-19 21:05:00 -05:00
0c9cd5d5f4
[test] Fix test-name-table.cc leak issue
...
Spotted it accidentally but wanted to see if is anything serious so went for fixing it
2018-12-19 21:18:30 +03:30
3d9d7dc4dd
[arrays] Add hb_ubytes_t for unsigned char
2018-12-18 22:11:23 -05:00
f1e95e40ed
[arrays] Remove hb_supplier_t<>
2018-12-18 16:49:08 -05:00
f9417af29b
[serialize] Propagate error from hb-face
2018-12-18 13:23:32 -05:00
9aebfb4182
[serialize] Streamline error propagation
2018-12-18 13:22:17 -05:00
969ff3c7aa
Remove unused hb-iter.hh
...
The ideas there are all part of hb-array.hh now. To be determined how we
want to use generic iterator patterns.
2018-12-17 22:43:00 -05:00
b1094fc2d2
[arrays] Minor tweaks to hb_supplier_t
...
I think I like to keep this hb_supplier_t thing separately from hb_array_t.
2018-12-17 22:41:04 -05:00
cf39c24205
[arrays] Rename Supplier to hb_supplier_t
2018-12-17 22:36:23 -05:00
6b5eaa7530
Hide hb_addressof()
2018-12-17 21:55:33 -05:00
6befa75cdf
Enable __builtin_* on clang
...
We'll see which old clang versions this breaks...
2018-12-17 20:35:45 -05:00
8d2d410256
Add hb_addressof() and use it to fix bug after hb_bytes_t merge
...
We cannot take address hb_bytes_t direction. We need to use the
newly added hb_addressof(), ala std::addressof().
2018-12-17 20:23:26 -05:00
49334f9b50
Enable system extensions in hb.hh
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1491
2018-12-17 18:27:36 -05:00
37c14bc745
Fix Solaris use after free ( #1495 )
2018-12-17 17:59:37 -05:00
483f2491e4
Remove define GNU_SOURCE
...
Not needed. We get it in our config.h automatically thanks to
AC_USE_SYSTEM_EXTENSIONS. Let's see whose build it breaks...
If we end up putting it back, we should add other things from
that macro and remove the macro.
2018-12-17 17:56:10 -05:00
87ff65aea1
Fix more warnings
2018-12-17 17:19:54 -05:00
f9d219a174
Fix Solaris Trailing comma in enum warnings ( #1490 )
2018-12-17 17:18:47 -05:00
244a8627f7
Lower coretext_aat shaper priority ( #1488 )
...
Related to https://github.com/harfbuzz/harfbuzz/issues/1478
2018-12-17 13:01:43 -05:00
e412008599
Remove redundant void from C++ sources ( #1486 )
2018-12-17 13:01:01 -05:00
7ace10078c
Minor, fix two more ArrayOf incorrect operator logic
2018-12-17 20:07:04 +03:30
a1240383aa
[arrays] Minor fix
2018-12-17 10:44:14 -05:00
381c3548e9
[array] Add cast operator to add const to Type
...
In lieu of constructor removed in previous commit.
2018-12-17 00:39:30 -05:00
15acf33c22
[array] Remove problematic constructor
2018-12-17 00:38:13 -05:00
470369a871
[array] Add arithmetic operators
2018-12-17 00:21:38 -05:00
6cd60c2f2a
[array] Return Crap instead of Null if Type is not const
...
Ouch!
2018-12-17 00:09:06 -05:00
94e72cf1c9
[array] Add operator *
2018-12-17 00:06:40 -05:00
68d4a5eee0
[array] Add constructor from fixed-size array
2018-12-17 00:02:42 -05:00
a4354d2fd3
[array] Organize
2018-12-16 23:57:27 -05:00
84c1865821
[arrays] Reduce Supplier<> even further
2018-12-16 23:52:17 -05:00
1bcc4fc9f3
Whitespace
2018-12-16 23:47:56 -05:00
f85f6e815f
[array] Add operator +=
2018-12-16 23:45:07 -05:00
7c0e3e9b2b
[array] Add constructor from hb_array_t<const Type>
2018-12-16 23:43:17 -05:00
92680361ec
[arrays] Move Supplier<> to hb-array.hh
2018-12-16 23:38:51 -05:00
2a3fa3f82f
[arrays] Remove unnecessary constructor from Supplier<>
...
Looks like operator hb_array_t<> from vector works here. :)
2018-12-16 23:33:03 -05:00
507cac4943
[arrays] Start moving Supplier<> to hb_array_t<>
2018-12-16 23:31:19 -05:00
1e2c98126e
[arrays] Remove unused stride from Supplier
2018-12-16 22:31:16 -05:00
0d0fe9df46
[arrays] Remove need of stride in Supplier<>
2018-12-16 22:31:13 -05:00
dcfa4a8d71
[array] Remove custom hb_bytes_t implementation
2018-12-16 22:31:13 -05:00
3656f56d47
[arrays] Minor
2018-12-16 22:31:13 -05:00
aa8f94714e
[array] Minor
2018-12-16 22:31:13 -05:00
5a552f7546
[array] Move hb_array_t and related types to hb-array.hh
2018-12-16 22:31:10 -05:00
01d06e34ff
Minor change to explicit_operator aesthetics
2018-12-16 14:27:43 -05:00
b2ebaa9afa
Remove redundant 'inline' from methods ( #1483 )
2018-12-16 14:08:10 -05:00
7251c77290
Whitespace
2018-12-15 21:00:55 -05:00
829b56b1a2
Whitespace
2018-12-15 16:20:13 -05:00
42a1012562
[subset] Actually subset GDEF
2018-12-13 19:39:59 -05:00
c9c746c7f6
[subset] Fix up ClassDef some more
2018-12-13 18:39:30 -05:00
7ee6128902
[subset] Fix ClassDefFormat1 subsetting
2018-12-13 18:32:04 -05:00
1b6d0c44b3
[subset] Sketch GDEF subsetting
2018-12-13 18:10:48 -05:00
705e2f5056
[subset] Implement for ClassDef
2018-12-13 17:48:42 -05:00
6e33a3955d
Minor
2018-12-13 16:40:01 -05:00
cc65901ca7
[serialize] Implement for ClassDef
2018-12-13 16:01:45 -05:00
e5309e4fd8
[serialize] Implement for ClassDefFormat2
2018-12-13 15:57:12 -05:00
c8b43cbe31
[serialize] Implement for ClassDefFormat1
2018-12-13 15:53:00 -05:00
5761031329
[subset] Minor
2018-12-12 21:21:26 -05:00
798e98c47b
[CFF] bad offset in Index ( #1476 )
...
* Update hb-ot-cff-common.hh
* fix bug
* bummer fix wasn't hit. refix
* additional sanity check
* Added test cases for oss-fuzz issues 11805, 11806
2018-12-12 21:08:15 -05:00
bcb4ecaf68
[CFF] check out of range FD index ( #1477 )
...
* add fd index checks to subr subsetter
also added oss-fuzz test case
* undid SubrSubsetParam::is_valid
because already validated by SubrClosures.valid
2018-12-12 20:36:01 -05:00
2cc993e035
[dispatch] Minor
2018-12-12 10:07:38 -05:00
602fbfe3c9
[sanitize] Fix sanitizing sublookup array
2018-12-12 09:56:47 -05:00
c78e4784fb
[dispatch] Minor
2018-12-12 09:50:18 -05:00
f9d211af1d
Revert "Minor fix re sanitize of Lookup subtables"
...
This reverts commit 7146718bef
2018-12-12 09:44:30 -05:00
7ee5c52345
minor style fix, use void in methods on no argument
2018-12-12 15:14:37 +03:30
7146718bef
Minor fix re sanitize of Lookup subtables
...
We were dereferencing Null pointers and trying to sanitize them,
which is not necessary...
2018-12-11 23:44:29 -05:00
ce069d1932
Minor
2018-12-11 23:07:48 -05:00
1aea869446
[subset] Map glyphs during SingleSubst subsetting
...
Ha!
2018-12-11 22:53:58 -05:00
41d1a1c10f
[subset] Minor
2018-12-11 22:48:27 -05:00
2aba2c6c73
[serialize] Break down assert
2018-12-11 21:21:13 -05:00
2941208f1e
[CFF] oss-fuzz issue 11690 ASSERT: substr.offset >= opStart ( #1461 )
...
* fix oss-fuzz 11690: substr.offset >= opStart
detect recursive subroutine call & handle as error
* fix build failure
* add minimized test case for oss-fuzz 11690
* removed asserts
2018-12-11 15:21:24 -05:00
333586245c
minimize use of assert: removed or changed to error handling ( #1467 )
2018-12-11 15:20:20 -05:00
9f3a51ddb9
[ucdn] Fix header
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1470
2018-12-11 13:38:05 -05:00
1683bb2c93
[glyf] minor
2018-12-08 13:57:39 +03:30
f7cfe99815
[os2] Move typometrics detection logic to the table ( #1465 )
2018-12-08 13:40:44 +03:30
47cf9a9633
Apply non-controversial parts of ot-style ( #1464 )
...
Things to be used in https://github.com/harfbuzz/harfbuzz/pull/1459
2018-12-08 10:20:25 +03:30
4d809696ef
fix for issue #1447 ( #1462 )
...
Added case for OpCode_BaseFontName. This opcode in spec but practically unused.
Added a comment for default case which can't be hit
2018-12-07 20:49:39 -08:00
1abd4fcaec
[fdsc] minor
2018-12-07 22:34:12 +03:30
59345cdef3
[CFF] Refix oss-fuzz 11714: set_blends (PR #1458 ) ( #1460 )
...
* pass subarray of stack to set_blends
* get_subarray to return a value, not ref
* restored error check (with tweak)
2018-12-06 13:36:26 -08:00
20245f0000
Fix likely check
...
Ouch!
2018-12-06 10:27:37 -08:00
d866e905fd
Add default value to first argument of sub_array()
2018-12-06 10:26:32 -08:00
f1352f7486
Add sub_array to hb_vector_t
2018-12-06 10:21:17 -08:00
ca23b71935
Add default-value for second arg of sub_array()
2018-12-06 10:21:17 -08:00
1ccbdcf73b
Merge branch 'master' into cff-check-blends
2018-12-05 21:37:38 -08:00
14d29a1043
check number of blends against args on stack
2018-12-05 21:33:29 -08:00
f95324a335
Merge pull request #1457 from harfbuzz/cff-varstore-sanitize
...
[CFF] oss-fuzz issue 11713 (CFF2VariationStore::serialize)
2018-12-06 08:33:44 +03:30
c31092ab34
sanitize variationStore in CFF2 against its size
2018-12-05 17:04:55 -08:00
34e3ef8ff3
Merge branch 'master' into cff-subr-sanitize
2018-12-05 15:50:05 -08:00
d9dabc00e9
Merge pull request #1454 from harfbuzz/cff-fixbcd
...
[CFF] fix oss-fuzz issue 11674: parse_bcd
2018-12-05 15:39:34 -08:00
6dcfda92c1
sanitize CFF1 & CFF2 global subrs
2018-12-05 15:07:46 -08:00
6708c5595f
fix oss-fuzz issue 11675 (ASSERT: count <= str.len)
...
Also added an additional error check to avail ()
2018-12-05 12:51:18 -08:00
2cb9d4c183
Merge branch 'master' into cff-fixbcd
2018-12-05 11:25:29 -08:00
a5fa843c74
fixed a bug with fractional part in a negative value
2018-12-05 11:18:16 -08:00
8394a6cb25
[os2] Make newer table fields accessible ( #1452 )
2018-12-05 15:23:41 +03:30
5ab086ebb1
[fdsc] Implement the table parsing
...
Related to https://github.com/harfbuzz/harfbuzz/issues/1337
May used in addition to an API related to STAT.
Lots of Apple fonts have it.
2018-12-05 14:48:31 +03:30
8f80e53341
[gasp] Implement the table parsing
...
May or may not be used in https://github.com/harfbuzz/harfbuzz/pull/1432
2018-12-05 14:48:31 +03:30
79e7e3445e
Merge pull request #1449 from harfbuzz/cff-fixcharset
...
[CFF] fix for oss-fuzz 11657: Charset overrun
2018-12-05 13:25:18 +03:30
cf4b7db6b1
Merge pull request #1448 from harfbuzz/cff-leak
...
[CFF] fix leak: oss-fuzz 11662
2018-12-05 13:23:23 +03:30
620d1ef588
fix unsigned long const
2018-12-05 00:36:11 -08:00
28dfb4c142
fix signed/unsigned comparison
2018-12-05 00:26:03 -08:00
f9cee08edd
use sized int types in parse_bcd
2018-12-04 23:58:26 -08:00
c01a5f32a3
refix
2018-12-04 23:23:23 -08:00
755fefc921
fix bug
2018-12-04 23:18:28 -08:00
0e81b153af
fix typo
2018-12-04 22:40:07 -08:00
85d4b15cd8
include float.h
2018-12-04 22:30:33 -08:00
5a7c371e4c
check overflow & clamp
2018-12-04 22:24:38 -08:00
32cc46c75a
[CFF] fix oss-fuzz issue 11670: NULL dereference ( #1450 )
...
* guard against no subr access
* code tweak
* add minimized testcase for oss-fuzz 11670 (Null deference)
2018-12-05 09:02:34 +03:30
d3d2f32c6e
fix oss-fuzz 11657: buffer overrun
...
Check overrun in Charset1_2::get_glyph
2018-12-04 13:51:26 -08:00
d0a250a7b1
Reuse hb_aat_layout_has_* logic in coretext-aat detection logic ( #1442 )
2018-12-04 23:42:13 +03:30
803d2f92dc
Merge branch 'master' into cff-leak
2018-12-04 11:01:26 -08:00
6ce8d10b45
add unlikely to error handling
2018-12-04 10:39:17 -08:00
0b952e6026
more leak fixes
2018-12-04 10:22:35 -08:00
9473463f5c
fix attempt for oss-fuzz 11662 leak
2018-12-04 09:58:48 -08:00
04f2ca9421
removed assert
2018-12-04 09:24:07 -08:00
c968869f21
Merge pull request #1441 from harfbuzz/cff-doublenum
...
use double as CFF Number implementation
2018-12-04 04:14:13 -05:00
c48f53d309
more double changes
2018-12-03 16:59:41 -08:00
5fff6ab002
additional precision made a difference in extents test
2018-12-03 16:06:58 -08:00
9e5180cd44
more double changes
2018-12-03 15:32:42 -08:00
9af33d7a2a
Number to use double for all types
2018-12-03 14:48:46 -08:00
01f628cf55
[aat] Expose hb_aat_layout_has_tracking API
2018-12-03 22:27:26 +03:30
d19b1680b5
[aat] Expose a couple APIs
...
New API:
+hb_aat_layout_has_substitution()
+hb_aat_layout_has_positioning()
2018-12-03 10:41:37 -05:00
84efe0438e
[aat] Fix division sign fallout
...
Happened after 11d2f49af8
2018-12-02 12:39:14 -05:00
2087f5a2a7
Add casts to hb_array_t<>
2018-12-01 20:04:45 -05:00
58d4d19947
Simplify build source list
2018-12-01 19:34:18 -05:00
11d2f49af8
New approach to change BigEndian casts to be int-sized
...
Fixes spurious warnings like:
Fixes https://github.com/harfbuzz/harfbuzz/issues/1436
2018-12-01 13:12:21 -05:00
50e0273ab1
Change hb_assert_unsigned_t<> to hb_is_signed<>
2018-12-01 13:07:49 -05:00
c3a8b047aa
Revert "Change BigEndian casts to be int-sized"
...
This reverts commit eb5ddd32bf
2018-12-01 00:26:39 -05:00
be45677ab6
Minor
2018-12-01 00:04:29 -05:00
eb5ddd32bf
Change BigEndian casts to be int-sized
...
Fixes spurious warnings like:
Fixes https://github.com/harfbuzz/harfbuzz/issues/1436
2018-12-01 00:03:01 -05:00
e8860fdcaa
Fix more warning
2018-11-30 23:38:24 -05:00
af349ee348
Fix warning
2018-11-30 23:20:50 -05:00
825df6dbc7
[CFF] Change spaces to tabs
2018-11-30 23:04:59 -05:00
592f39b3c4
[CFF] Whitespace
2018-11-30 22:54:57 -05:00
a2e8d1d455
Minor
2018-11-30 22:54:20 -05:00
5e64e0f532
Merge pull request #1113 from harfbuzz/cff-subset
...
CFF/CFF2 subsetter
2018-11-30 22:40:54 -05:00
09096aa89f
Use nullptr instead of 0/NULL. ( #1435 )
...
* Use nullptr instead of 0/NULL.
* Update test-name-table.cc
2018-11-30 22:22:49 -05:00
d8c6913765
undo 0u
2018-11-30 18:58:14 -08:00
2c859b3880
Merge branch 'master' into cff-subset
2018-11-30 18:47:34 -08:00
fb05908213
Revert ugly fixes
...
Now that we have 6daf45e0, revert cryptic hacks...
This reverts commit abd81ed4f59c6921c08cd39760cabffedd8e6c17https://github.com/harfbuzz/harfbuzz/issues/1374
2018-11-30 20:56:15 -05:00
dfad19ad5a
Make operator [] take signed int
...
The built-in operator takes signed int. So, match it, such that
the built-in is never a better or equally-good match to our operator.
Fixes "ambiguous overload" errors from gcc 4.2 and VS 2008.
See https://github.com/harfbuzz/harfbuzz/issues/1374
2018-11-30 20:56:14 -05:00
9483da145d
redo fixes
2018-11-30 16:59:41 -08:00
291da44823
yet another
2018-11-30 16:50:46 -08:00
Behdad Esfahbod
Michiharu Ariza
Ebrahim Byagowi
Ken
Ken Cunningham
Behdad Esfahbod
Garret Rieger
cclauss
fanc999
prrace
Behdad Esfahbod
👻
Bruce Mitchener