c346671b6b
Minor doc fixes
2012-03-06 20:47:50 -05:00
461b9b6347
Fix cluster formation in Indic
...
Makes number of failures against Uniscribe with hi_IN dictionary from
OO.o to go down from 6334 to 4290. Not bad for a one-line change!
Mozilla Bug 729626 - ASAN: heap-buffer-overflow HTML
2012-03-01 18:11:19 -08:00
bc71ad4973
Fix atomic-int op on Apple
...
The OSAtomicAdd32Barrier operator returns the new value, we want the
old value.
2012-03-01 17:30:29 -08:00
a1970d9afc
Add support for atomic int and mutex on Apple systems
...
So, apparently there's no atomic int 'get' method on Apple. You have to
add(0) to get. And that's not const-friendly. So switch inert-object
checking to a non-atomic get. This, however, is safe, and a negligible
performance boost too.
2012-02-24 16:19:52 -05:00
8004429102
Remove unused hb_atomic_int_set()
...
Apparently it can't be implemented on OS X. We weren't using it anyway.
2012-02-24 16:19:52 -05:00
45227c10e4
Add hb-warning.cc. Oops!
2012-02-23 19:47:43 -05:00
bd7ff1dec5
Allow disabling multi-threaded support
...
By defining HB_NO_MT.
Also, only warn once per missing MT feature support.
Mozilla Bug 666661 - gfx/harfbuzz/src/hb-prive.h - compiler warnings on mac
2012-02-23 15:06:16 -05:00
634c9e3423
Minor
2012-02-22 16:43:21 -05:00
514b6f8866
Followup: Reorder Hebrew combining classes for better rendering
...
Patch from Jonathan Kew.
Bug 662055 - advanced Hebrew diacritics are shown correctly only in
particular order.
2012-02-22 16:34:37 -05:00
6e78607ea7
Reorder Hebrew combining classes for better rendering
...
Patch from Jonathan Kew.
Bug 662055 - advanced Hebrew diacritics are shown correctly only in particular order
2012-02-22 16:31:15 -05:00
134aa7bc7e
Make checks more OS X friendly
2012-01-27 02:23:22 -05:00
6152199368
Fix check-header-guards on OS X
2012-01-27 02:23:22 -05:00
71632c96da
Fallback to Latin script if the font has no other usable scripts
...
Patch and description from Jonathan Kew:
It turns out that some legacy Thai fonts provide OpenType substitution
features to implement mark positioning, but (incorrectly) put those
features/lookups under the 'latn' script tag instead of using 'thai' (or
possibly 'DFLT'). See
https://bugzilla.mozilla.org/show_bug.cgi?id=719366 for an example and
more detailed description.
Although this is really a font bug, I suggest that we could improve the
rendering of such fonts by looking for the 'latn' as a fallback if
neither the requested script nor "default" is found in
hb_ot_layout_table_choose_script. Suggested patch against harfbuzz
master is attached.
This does _not_ affect the other kind of legacy Thai font, where custom
code to support vendor-specific PUA codepoints would be needed. I'm not
keen to go down that path; IMO, such fonts should be ruthlessly stamped
out in favour of standards-based solutions. :)
JK
2012-01-22 15:31:44 -05:00
7a4a848db2
Minor
2012-01-19 15:15:21 -05:00
3b5c22c39b
Remove src/test.cc
...
Not really useful.
2012-01-19 14:28:11 -05:00
889caa52fa
[icu] Use U_FAILURE
2012-01-18 22:32:52 -05:00
36a4f4a482
Replace u_strlen() with u_countChar32()
...
The latter is what I meant.
2012-01-18 22:16:49 -05:00
c521e793bd
Fix OOB in replace_glyph()
...
Patch from Kenichi Ishibashi.
2012-01-18 21:51:05 -05:00
03408ce73d
Fix more possible buffer overruns
...
I have this function, but can't clean up it to my satisfaction.
2012-01-18 21:28:34 -05:00
7d479900cd
Refactor the two remaining uses of _hb_ot_layout_skip_mark()
2012-01-18 21:19:32 -05:00
506ffeb8e7
Further mark skippy fixes from Jonathan Kew
...
We should be in good shape now.
2012-01-18 16:07:53 -05:00
a4a48fe6d4
Fix mark skipping regression
...
Ouch!
2012-01-17 18:08:41 -05:00
4ab9731154
Refactor mark skipping
2012-01-16 22:20:31 -05:00
370f03e9c6
Minor
2012-01-16 17:06:59 -05:00
4d3aeb8cb2
[GSUB/GPOS] Fix mark skip indexing issues
...
Mozilla bug 701637 and 714067 combined.
Patch from Jonathan Kew.
2012-01-16 16:43:26 -05:00
e8eedf2687
Avoid enum trailing commas
...
Based on patch from Jonathan Kew.
2012-01-16 16:39:40 -05:00
299ae0c3a3
[icu] Remove glib-ism
2012-01-14 21:29:45 -05:00
af92135424
Minor
2011-10-21 09:18:43 -07:00
89d89646e8
Fix intrin.h b0rkage with older MSVC
...
Reported by Jonathan Kew.
2011-10-17 11:50:54 -07:00
af913c5788
Fix infinite loop in normalization code with variation selectors
...
Reported by Jonathan Kew.
2011-10-17 11:39:28 -07:00
55deff7595
Add comments
2011-09-28 16:20:09 -04:00
52ebdff49d
Fix GSUB lookuptype 1 subtype 1 delta wrapping
2011-09-27 12:38:16 -04:00
b95324cdd2
Minor
2011-09-21 16:50:39 -04:00
0cd33592ab
Fix possible leaks
2011-09-21 16:49:33 -04:00
d606daa4cc
Whitespace
2011-09-20 14:34:06 -04:00
f83f0f4836
[graphite] Add note about graphite shaker brokenness
2011-09-19 18:51:48 -04:00
0a965eee88
Minor
2011-09-19 16:53:47 -04:00
5c29934311
[uniscribe] Various improvements
2011-09-19 14:53:26 -04:00
5ddd9cc499
Minor
2011-09-16 16:40:44 -04:00
947c9a778c
Minor
2011-09-16 16:33:18 -04:00
d5476a30a1
Minor
2011-09-16 12:30:50 -04:00
36b10f58cc
Minor
2011-09-15 16:29:51 -04:00
c4611cb66f
Fix test
2011-09-15 00:32:39 -04:00
bc187e5ac7
Refine Indic scripts, following Martin Hosken's recommendation
2011-09-08 13:35:17 -04:00
738d096a06
Pass through unknown ISO 639-3 language tags to OpenType engine
...
In hb_ot_tag_from_language(), if first component of an unknown
language is three letters long, use it directly as OpenType language
tag (after case conversion and padding).
2011-09-02 13:31:19 -04:00
ea02cbf03c
[graphite] Don't preload glyphs
...
Doesn't seem to be slower.
2011-09-02 12:39:20 -04:00
210a06f3d7
Minor
2011-08-26 13:39:49 +02:00
4a8d2e379a
[graphite2] Chop a few more lines
2011-08-26 09:40:54 +02:00
81ec289da7
Minor
2011-08-26 09:33:06 +02:00
3380de5abb
[graphite] Use buffer->replace_glyphs()
2011-08-26 09:30:49 +02:00
9ebe8c0286
Add buffer->replace_glyphs()
2011-08-26 09:29:42 +02:00
a5edb1031c
Minor
2011-08-26 09:27:13 +02:00
290e3ee517
[graphite] Only pass the first part language tag to graphite
...
Still not sure about:
1) Case. We pass lowercase for now. Would be nice if graphite was
uppercase 3letter like OpenType,
2) Padding. IMO, tag padding is always with spaces, but Martin was
talking about NUL bytes.
2011-08-26 09:25:04 +02:00
4c9fe88d30
[API] Make all _from_string() functions take a len parameter
...
Can be -1 for NUL-terminated string. This is useful for passing parts
of a larger string to a function without having to copy or modify the
string first.
Affected functions:
hb_tag_t hb_tag_from_string()
hb_direction_from_string()
hb_language_from_string()
hb_script_from_string()
2011-08-26 09:22:12 +02:00
a499bdea5c
[graphite2] Bail if grface is NULL
2011-08-25 22:46:21 +02:00
3007ffa9e5
Reorder combining-class to better suit Arabic shadda mark-mark positioning
...
As reported by Khaled on the list:
"After the introduction of canonical reordering of combining marks
(commit 34c22f8http://unicode.org/faq/normalization.html#8
http://unicode.org/faq/normalization.html#9
2011-08-25 09:08:53 +02:00
74ef81a0b0
Fix make distcheck
2011-08-24 19:36:50 +02:00
24bcdbcc06
Add hb-ot-hmtx-table.hh
...
Oops!
2011-08-24 19:13:15 +02:00
a3bd8a0e18
[graphite] Rewrite properly
2011-08-24 03:25:57 +02:00
5072934c35
Minor
2011-08-24 02:24:27 +02:00
71388b3ee7
[uniscribe] Minor
2011-08-24 02:09:04 +02:00
cd2b901027
[graphite] Minor
2011-08-24 01:48:03 +02:00
834af3b48a
[graphite] Remove hb_graphite2_feature_check()
...
I don't see how this function can be useful.
2011-08-24 01:45:47 +02:00
1f49cf32c9
Add graphite2 integration from Martin Hosken
...
To be modified, a lot.
2011-08-24 01:32:41 +02:00
0e6d36d8a3
Minor
2011-08-24 01:31:29 +02:00
efde811325
Add a constructor for hb_prealloced_array_t
...
Fixes build with MSVC.
2011-08-23 00:04:57 +02:00
d75333f166
Add gobject enum support, but disabled for now
...
need to figure out the naming. The generated code doesn't have the
right name.
2011-08-19 19:59:24 +02:00
7d235d272f
Flesh out tt funcs a bit
2011-08-19 19:23:28 +02:00
b9415e76d7
[API] Add hb_font_set_funcs_data()
2011-08-19 19:20:30 +02:00
e6c09cdf43
Remove the pre_allocate argument from hb_buffer_create()
...
For two reasons:
1. User can always call hb_buffer_pre_allocate() themselves, and
2. Now we do a pre_alloc in add_utfX anyway, so the total number of
reallocs is limited to a small number (~3) anyway. This just makes the
API cleaner.
2011-08-19 19:20:26 +02:00
187bdeaa6c
Do (nothing for) hmtx sanitize
2011-08-17 19:03:06 +02:00
d6016e4910
Fix name-table sanitize
2011-08-17 15:00:18 +02:00
ae9877dea6
Add hhea-table support
2011-08-17 15:00:10 +02:00
7a750ac33e
Rename table files from eg maxp-private.hh to maxp-table.hh
2011-08-17 14:19:59 +02:00
0b7e4d9f20
[ft] FT_Get_Advance() for advance-width callbacks
...
Using graphite2's comparerenderer suggests that this makes hb-ft 15
times faster. No caching layer needed anymore.
2011-08-15 20:41:59 +02:00
4e9ff1dd6e
Pre-allocate buffers when adding string
...
We do a conservative estimate of the number of characters, but still,
this limits the number of buffer reallocs to a small constant.
2011-08-15 16:21:22 +02:00
553bc3de82
Minor
2011-08-15 16:21:06 +02:00
254142bb67
[ft] FT_Select_Charmap() when we create face
2011-08-15 16:15:44 +02:00
a4cbd03dd1
Apply 'locl' with 'ccmp' in Arabic shaper
...
According to Peter Constable this is indeed what Uniscribe has been
doing for years.
Mozilla Bug 667166 - wrong shape of letter when it comes at the end of
word in the arabic version of Firefox 5.0
2011-08-15 09:52:05 +02:00
c214cff55c
Start adding gobject-introspection support
2011-08-14 15:17:51 +02:00
9527fb200f
Fix missing return
2011-08-13 19:03:48 +02:00
77a3287695
Minor
2011-08-13 17:16:45 +02:00
d6660356dd
Add uniscribe font getters
2011-08-10 22:08:36 +02:00
01ec13a1d9
Implement hb_ft_font_get_face
2011-08-10 22:00:35 +02:00
0501573ded
Fix const correctness in the API
2011-08-10 16:25:56 +02:00
511a136f0c
Move hb-view into util/
2011-08-09 15:03:00 +02:00
d753ac78da
[uniscribe] Remove zerowidth glyphs from output
2011-08-09 14:03:12 +02:00
ddd247b0c5
Minor
2011-08-09 11:44:42 +02:00
1b8196c986
Add fallback shaper
2011-08-09 11:37:46 +02:00
13a601fe99
[FT] Don't make font immutable
2011-08-09 11:36:54 +02:00
38b2118724
[API] Add hb_ft_font_set_funcs(), remove hb_ft_get_font_funcs()
...
Remove hb_ft_get_font_funcs() as it cannot be used by the user anyway.
Add hb_ft_font_set_funcs(). Which will make the font internally use
FreeType. That is, no need for the font to have created using the
hb-ft API. Just create using hb_face_create()/hb_font_create() and
then call this on the font (after having set font scale). This
internally creates an FT_Face and attached to the font.
2011-08-09 11:10:32 +02:00
255f176fdc
Minor
2011-08-09 08:35:07 +02:00
a9057eb3f3
[uniscribe] Unbreak
2011-08-09 00:47:55 +02:00
33ccc77902
[API] Make set_user_data() functions take a replace parameter
...
We need this to set data on objects safely without worrying that some
other thread unsets it by setting it at the same time.
2011-08-09 00:43:24 +02:00
944b2ba1ce
[buffer] Make API take signed int length
...
Since we already switched to accepting -1 as 'zero-terminated'.
2011-08-09 00:23:58 +02:00
de1e1cf9bc
[FT] Adapt to new face API
2011-08-09 00:19:38 +02:00
bf3eef540f
[uniscribe] Cleanup backend
2011-08-09 00:14:22 +02:00
3897335c76
[API] Sort out get_blob API
...
hb_face_get_blob() renamed to hb_face_reference_blob(), returns a
reference now.
hb_face_[sg]et_index() added.
hb_face_set_upem() added.
2011-08-08 23:37:41 +02:00
e715784be3
Rename get_table to reference_table in all API
2011-08-08 21:43:06 +02:00
670c873499
Fix shaper ordering logic
2011-08-08 21:36:24 +02:00
cc797e0d53
Minor
2011-08-08 03:50:38 +02:00
826e22732d
[uniscribe] Fix blob lifecycles
2011-08-07 03:53:42 -04:00
ff199ba356
Fix shaper_list manipulation, aaaaaaaaaaaaargh
2011-08-07 03:43:46 -04:00
577326b86a
[uniscribe] Fix cluster calculation
2011-08-07 01:04:40 -04:00
f6d83b2dcf
Minor
2011-08-07 00:59:58 -04:00
2eb474afb4
[uniscribe] Fix shaper
...
It's kinda working finally!
2011-08-07 00:59:38 -04:00
f22e661147
[glib] Protect against invalid characters
2011-08-07 00:59:12 -04:00
144cd49a0e
[buffer] Accept -1 for text_length and item_length
...
A -1 text_length means: zero-terminated string.
A -1 item_length means: to the end of string.
2011-08-07 00:51:50 -04:00
e9c71fab30
Fix name-table lookup
...
Oops!
2011-08-07 00:01:04 -04:00
3fd2b5bece
[uniscribe] Use font size directly
2011-08-06 22:59:54 -04:00
892eb2e462
[uniscribe] Make font selection work
...
Not tested yet.
2011-08-06 22:32:07 -04:00
b492299eb3
Start implementing the 'name' table
2011-08-05 20:34:50 -04:00
4538efacca
Skip tests by returning 77
...
automake test runner understands this.
2011-08-05 20:11:06 -04:00
54eb65538d
Fix check on OS X sh
2011-08-05 20:09:25 -04:00
9da554504e
Add hb_shape_list_shapers()
2011-08-05 19:59:02 -04:00
d7bf473ef2
Minor
2011-08-05 19:59:02 -04:00
c62a8f10f3
Free all static memory upon exit
2011-08-05 19:59:02 -04:00
c4d63ef744
Fix env parsing code
...
Also changed the separator to comma instead of colon.
2011-08-05 19:59:02 -04:00
3931837beb
Change hb_shape() API back to what it was, add hb_shape_full()
...
I disliked changing hb_shape() API, and disliked the fact that it was
returning a bool now. So, reverted. Added new API for the extra
functionality.
2011-08-05 19:59:02 -04:00
3ca6c4ecc2
Change hb_shape() API back to what it was, add hb_shape_full()
...
I disliked changing hb_shape() API, and disliked the fact that it was
returning a bool now. So, reverted. Added new API for the extra
functionality.
2011-08-05 17:22:19 -04:00
02aeca985b
[API] Changes to main shape API
...
hb_shape() now accepts a shaper_options and a shaper_list argument.
Both can be set to NULL to emulate previous API. And in most situations
they are expected to be set to NULL.
hb_shape() also returns a boolean for now. If shaper_list is NULL, the
return value can be ignored.
shaper_options is ignored for now, but otherwise it should be a
NULL-terminated list of strings.
shaper_list is a NULL-terminated list of strings. Currently recognized
strings are "ot" for native OpenType Layout implementation, "uniscribe"
for the Uniscribe backend, and "fallback" for the non-complex backend
(that will be implemented shortly). The fallback backend never fails.
The env var HB_SHAPER_LIST is also parsed and honored. It's a
colon-separated list of shaper names. The fallback shaper is invoked if
none of the env-listed shapers succeed.
New API hb_buffer_guess_properties() added.
2011-08-04 22:38:09 -04:00
57692adf12
Make test.cc do something more useful
...
Hardcoded to the uniscribe backend for now. Will fix soon.
2011-08-04 20:49:16 -04:00
c605bbbb6d
Remove C++ guards from source files
...
Where causing issues for people with MSVC.
2011-08-04 20:00:53 -04:00
8336186a52
Zero map objects
2011-08-04 19:49:05 -04:00
c747f509bc
More out-of-tree build fixes
2011-08-04 01:51:30 -04:00
20dde61016
Minor
2011-08-04 01:07:33 -04:00
44b4f50d05
Fix typo
2011-08-04 00:52:20 -04:00
0fbb2dc831
Add draft experimental Uniscribe backend
...
Not complete yet, font selection doesn't work. But hey it shapes!
This is not supposed to be a production backend, more like a testing
backend.
2011-08-03 19:55:04 -04:00
e62df43649
Add internal hb_buffer_t::get_scratch_buffer()
2011-08-03 17:38:54 -04:00
bf8c57ba74
[API] Add hb_face_get_blob()
...
Need to think more about it.
2011-08-03 17:38:04 -04:00
2118fdb9f5
Fix fallback shaping
...
Broke it a few commits ago.
2011-08-02 14:06:51 -04:00
f60271c0c2
Add mingw32 support
...
With these changes, on Ubuntu I can do:
./configure --host=i586-mingw32msvc && make
2011-08-02 10:00:55 -04:00
f5414cf0a2
Use missing script for calling ragel
2011-08-01 16:34:16 -04:00
a91c58bf98
[Indic] Disable CJCT-disabling logic
...
Read comment.
2011-08-01 16:30:11 -04:00
5e72071062
[Indic] Stop looking for base upon seeing joiners
...
Not sure where this is documented, but I remember this being the desired
behavior.
test-shape-complex failures are down from 48 to 46. Meh.
2011-07-31 17:52:44 -04:00
281683995a
Cosmetic
2011-07-31 16:00:35 -04:00
6b37bc8084
[Indic] Fix ZWJ/ZWNJ application
...
Not quite working just yet. False alarm re 10 failures. It was
crashing. Ouch! Back to 48 failures.
2011-07-31 15:57:00 -04:00
e7be057024
[Indic] Add Final Reordering rules into comments
...
Not applied yet.
2011-07-31 15:22:46 -04:00
cfd4382ec1
[Indic] Handle Reph when determining base consonant
2011-07-31 15:08:40 -04:00
97158392a5
[Indic] Ra is a consonant too
2011-07-31 15:01:28 -04:00
0d8f8a177c
[Indic] Fix reph inhibition logic
2011-07-31 14:57:59 -04:00
9da0487cd4
[Indic] Support ZWJ/ZWNJ
...
Brings test-shape-complex failures down from 52 to 10!
I hereby declare harfbuzz-ng supporting Indic!
2011-07-31 13:46:44 -04:00
9ee27a928a
[Indic] Suppress reph formation upon joiners
2011-07-31 11:10:14 -04:00
8354e004e5
Un-Ra U+09F1. According to the test suite this is correct.
...
But I'm not sure... Down from 54 failures to 52.
2011-07-31 02:24:51 -04:00
ba7e85c104
Cosmetic
2011-07-30 21:11:53 -04:00
f5bc2725cb
[Indic] For old-style Indic tables, move Halant around
...
In old-style Indic OT standards, the post-base Halants are moved after
their base. Emulate that by moving first post-base Halant to
post-last-consonant.
Brings test-shape-complex failures down from 88 to 54. Getting there!
2011-07-30 21:08:10 -04:00
c47a31fb47
[OT] Save chosen script tag
2011-07-30 20:57:01 -04:00
fd06bf5611
[Indic] Handle initial Ra+Halant in scripts that support Reph
...
Brings test-shape-complex failures down from 104 to 92. Way to go!
2011-07-30 20:14:44 -04:00
ee58f3bc75
Minor
2011-07-30 19:15:53 -04:00
352372ae5e
[Indic] Categorize Ra in scripts that have Reph
...
Is the categorization correct? I don't know.
2011-07-30 19:04:02 -04:00
Behdad Esfahbod