walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
9,243 Commits 16 Branches 166 Tags 114 MiB
Commit Graph

7460 Commits

Author SHA1 Message Date
Behdad Esfahbod b7be59311f Fix msan issue 
The fact that HB_AUTO_RETURN will return rvalue-references for rvalues
is very disturbing.

Even apart from that, I'm totally lost re any hb_move needs or
hb_forward'ing to functions/templates where the type is fixed by
explicitly specifying template parameters.

==1==ERROR: AddressSanitizer: stack-use-after-return on address 0x7f6ad65e51e0 at pc 0x0000005da240 bp 0x7ffc104ab670 sp 0x7ffc104ab668
READ of size 4 at 0x7f6ad65e51e0 thread T0
SCARINESS: 55 (4-byte-read-stack-use-after-return)
     #0 0x5da23f in bool OT::Coverage::serialize<hb_map_iter_t<hb_map_iter_t<hb_filter_iter_t<OT::Coverage::iter_t, hb_set_t const&, $_7&, (void*)0>, OT::SingleSubstFormat1::subset(hb_subset_context_t*) const::'lambda'(unsigned int), (hb_function_sortedness_t)1, (void*)0>, $_20&, (hb_function_sortedness_t)1, (void*)0>, (void*)0>(hb_serialize_context_t*, hb_map_iter_t<hb_map_iter_t<hb_filter_iter_t<OT::Coverage::iter_t, hb_set_t const&, $_7&, (void*)0>, OT::SingleSubstFormat1::subset(hb_subset_context_t*) const::'lambda'(unsigned int), (hb_function_sortedness_t)1, (void*)0>, $_20&, (hb_function_sortedness_t)1, (void*)0>) harfbuzz/src/hb-ot-layout-common.hh:1055:16
     #1 0x5d88f9 in bool OT::SingleSubstFormat1::serialize<hb_map_iter_t<hb_map_iter_t<hb_filter_iter_t<OT::Coverage::iter_t, hb_set_t const&, $_7&, (void*)0>, OT::SingleSubstFormat1::subset(hb_subset_context_t*) const::'lambda'(unsigned int), (hb_function_sortedness_t)1, (void*)0>, $_20&, (hb_function_sortedness_t)1, (void*)0>, (void*)0>(hb_serialize_context_t*, hb_map_iter_t<hb_map_iter_t<hb_filter_iter_t<OT::Coverage::iter_t, hb_set_t const&, $_7&, (void*)0>, OT::SingleSubstFormat1::subset(hb_subset_context_t*) const::'lambda'(unsigned int), (hb_function_sortedness_t)1, (void*)0>, $_20&, (hb_function_sortedness_t)1, (void*)0>, unsigned int) harfbuzz/src/hb-ot-layout-gsub-table.hh:98:9
 2019-05-16 13:34:19 -07:00
Behdad Esfahbod bcd3ffc948 Whitespace 2019-05-16 13:27:08 -07:00
Behdad Esfahbod 05bc5f96fb [subset] Remove extra iteration 2019-05-16 13:05:58 -07:00
Garret Rieger 6555f20958 [subset] Truncate empty gids at the end in retain-gids mode. 2019-05-16 10:34:53 -07:00
Behdad Esfahbod 2376867649 Use hb_map(hb_add(this)) to dereference OffsetTo<>'s 2019-05-15 22:01:44 -07:00
Behdad Esfahbod 6f51e55524 [algs] Rename hb_bind to hb_partial 
Since our API is the invers of what std::bind is, and closer to Python
functools.partial().
 2019-05-15 21:41:12 -07:00
Behdad Esfahbod 0888e7bc86 [algs] Change hb_bind parameter number to be from one 
To match std:;bind, even though our interfaces are very different.
 2019-05-15 21:36:42 -07:00
Behdad Esfahbod dfa5e42971 Add back symmetric OffsetTo<>::friend operator+ 
Finally seems to be working now.
 2019-05-15 21:18:14 -07:00
Behdad Esfahbod a06a236891 [algs] Partialize all operators 2019-05-15 21:16:09 -07:00
Behdad Esfahbod edc69ec935 [algs] Rewrite bind API 
And add a partialization API use example to hb_add()
 2019-05-15 21:09:56 -07:00
Behdad Esfahbod 16a3540ea4 [algs] Add hb_bind0 and hb_bind1 2019-05-15 20:48:20 -07:00
Behdad Esfahbod d214b07883 Fix clang build 
Ugh.

In file included from hb-ot-face.cc:41:
./hb-ot-layout-gsub-table.hh:293:7: error: template parameter redefines default argument
         hb_requires (hb_is_sorted_source_of (Iterator,
         ^
./hb-meta.hh:59:27: note: expanded from macro 'hb_requires'
 define hb_requires(Cond) hb_enable_if((Cond))
                          ^
./hb-meta.hh:57:67: note: expanded from macro 'hb_enable_if'
 define hb_enable_if(Cond) typename hb_enable_if<(Cond)>::type* = nullptr
                                                                  ^
./hb-ot-layout-gsub-table.hh:40:5: note: previous default template argument defined here
    hb_requires (hb_is_sorted_source_of (Iterator,
    ^
./hb-meta.hh:59:27: note: expanded from macro 'hb_requires'
 define hb_requires(Cond) hb_enable_if((Cond))
                          ^
./hb-meta.hh:57:67: note: expanded from macro 'hb_enable_if'
 define hb_enable_if(Cond) typename hb_enable_if<(Cond)>::type* = nullptr
                                                                  ^
 2019-05-15 19:07:39 -07:00
Behdad Esfahbod 371b55c7a0 Fix clang build 
In file included from hb-ot-face.cc:41:
./hb-ot-layout-gsub-table.hh:293:7: error: template parameter redefines default argument
         hb_requires (hb_is_sorted_source_of (Iterator,
         ^
./hb-meta.hh:59:27: note: expanded from macro 'hb_requires'
 define hb_requires(Cond) hb_enable_if((Cond))
                          ^
./hb-meta.hh:57:67: note: expanded from macro 'hb_enable_if'
 define hb_enable_if(Cond) typename hb_enable_if<(Cond)>::type* = nullptr
                                                                  ^
./hb-ot-layout-gsub-table.hh:40:5: note: previous default template argument defined here
    hb_requires (hb_is_sorted_source_of (Iterator,
    ^
./hb-meta.hh:59:27: note: expanded from macro 'hb_requires'
 define hb_requires(Cond) hb_enable_if((Cond))
                          ^
./hb-meta.hh:57:67: note: expanded from macro 'hb_enable_if'
 define hb_enable_if(Cond) typename hb_enable_if<(Cond)>::type* = nullptr
                                                                  ^
1 error generated.
 2019-05-15 19:04:24 -07:00
Behdad Esfahbod 243a5a6af2 [algs] Remove pair copy constructor 
Use default.
 2019-05-15 19:04:24 -07:00
Behdad Esfahbod f92d188d77 Whitespace 2019-05-15 18:52:57 -07:00
Garret Rieger 962f95cf80 [subset] Switch SingleSubst to use iterators in serialize. 2019-05-15 18:37:32 -07:00
Behdad Esfahbod 78d35f0e78 Reduce captures of lambdas 2019-05-15 18:15:05 -07:00
Behdad Esfahbod 5266ca86b6 Fix tests 
Oops.
 2019-05-15 17:59:00 -07:00
Behdad Esfahbod 5da8a3a90d Remove variadic form of hb_min/hb_max 
Unused, and why here and not in other functions...
 2019-05-15 17:11:18 -07:00
Behdad Esfahbod e5cfe9d582 Add arithmetic operators 2019-05-15 16:59:36 -07:00
Behdad Esfahbod f7a458510d Add hb_bitwise_* ops 2019-05-15 16:53:12 -07:00
Behdad Esfahbod d822e0a16f [array] Adjust operator!= 
See comments.
 2019-05-15 16:30:08 -07:00
Behdad Esfahbod 203ea58bf6 More adjustment to OffsetTo<>::friend opeator+ 
Let's see if I break any bots.  But yeah, it wasn't accepting a
non-const pointer.  It just happens that we don't use that in the
code it seems.
 2019-05-15 16:14:40 -07:00
Behdad Esfahbod ebf47a95f2 [iter] Simplify operator!= of iterator filters 
Both to save ops, and also because lambdas don't implement operator!=,
so this was failing in range-based for loop if a lambda was passed to
hb_map() or hb_filter().  Just check end-condition assuming that we
are comparing to .end() or iterators that are otherwise derived from
current iterator.  Ie. don't compare things that are expected to be
in common.
 2019-05-15 15:14:26 -07:00
Behdad Esfahbod d3e1d5044f Add all pair_t comparison operators 2019-05-15 14:34:36 -07:00
Behdad Esfahbod f244224dbb [iter] Use default operators instead of redefining empty ones 2019-05-15 14:34:36 -07:00
David Corbett 125c45ed36 Convert Consonant_Initial_Postfixed to CONS_MED 2019-05-15 14:34:25 -07:00
Ebrahim Byagowi e2767e438c
[ci][test] Ignore other gcov symbols also 
To fix https://travis-ci.org/harfbuzz/harfbuzz/jobs/532693197
 2019-05-15 13:14:09 +04:30
Behdad Esfahbod 763ea4224b Another try 2019-05-15 01:21:32 -07:00
Behdad Esfahbod e1b2edb04a Completely revert the thing back 2019-05-15 01:12:04 -07:00
Behdad Esfahbod c58eeb5fb3 Another try at fix 
Fails locally.  Trying to understand.  Sigh
 2019-05-15 01:10:31 -07:00
Behdad Esfahbod 004edf3bda Ugh. How was the Travis bot happy before, but isn't now?! :( 2019-05-15 01:02:50 -07:00
Behdad Esfahbod e01c7b1648 Move OffsetTo operator+ back out of class 
Apparently there's different overload resolution rules that apply, at
least with some (older?) version of gcc.

hb-ot-name-table.hh: In member function ‘void OT::name::accelerator_t::init(hb_face_t*)’:
hb-ot-name-table.hh:244:62: error: ambiguous overload for ‘operator+’ (operand types are ‘hb_blob_ptr_t<OT::name>’ and ‘OT::NNOffsetTo<OT::UnsizedArrayOf<OT::IntType<unsigned char, 1u> > > {aka const OT::OffsetTo<OT::UnsizedArrayOf<OT::IntType<unsigned char, 1u> >, OT::IntType<short unsigned int, 2u>, false>}’)
       this->pool = (const char *) (const void *) (this->table+this->table->stringOffset);
                                                              ^
hb-ot-name-table.hh:244:62: note: candidates are:
hb-ot-name-table.hh:244:62: note: operator+(const C*, long int) <built-in>
hb-ot-name-table.hh:244:62: note: operator+(const char*, long int) <built-in>
 2019-05-15 00:52:17 -07:00
Behdad Esfahbod b213042f87 Revert "Revert symmetric OffsetTo overloads" 
This reverts commit 01912efb74.

Actually this didn't break things.  Fixing
 2019-05-15 00:50:48 -07:00
Behdad Esfahbod 01912efb74 Revert symmetric OffsetTo overloads 
Reverts 57f65ae935

Caused ambiguous-overload on some gcc...
 2019-05-15 00:42:47 -07:00
Behdad Esfahbod d0df996cdc Use implicit lambda return type 2019-05-15 00:32:41 -07:00
Behdad Esfahbod 57f65ae935 Add symmetric friend operator+ for OffsetTo 2019-05-14 22:52:59 -07:00
Behdad Esfahbod 71208e5047 Move OffsetTo<> deref operators in-class as friends 2019-05-14 22:51:59 -07:00
Behdad Esfahbod e6d6f4b96d Whitespace 2019-05-14 22:46:31 -07:00
Behdad Esfahbod 889dc1eb06 [iter] Remove sort categorization 
See comments.
 2019-05-14 22:28:07 -07:00
Behdad Esfahbod b4eff38397 Start of gen-ucd.py, to replace UCDN 2019-05-14 14:44:27 -07:00
Qunxin Liu 02e5e5d939 [subset] retian nameids from STAT and fvar tables 2019-05-14 14:44:17 -07:00
Behdad Esfahbod ff7995200e Hopefully last warning fix 2019-05-14 07:44:03 -07:00
Ebrahim Byagowi 9e7c9c3adb
Fix -Wunused-function on HB_NO_SHAPE_AAT 
We should add a bot for it
Part of #1652
 2019-05-14 15:58:51 +04:30
Dominik Röttsches c73d7ba75d Fix building with HB_NO_SUBSET_LAYOUT 
Fixes an unused function warning when building with HB_NO_SUBSET_LAYOUT
as part of the Chrome build.
 2019-05-14 13:31:44 +03:00
Behdad Esfahbod f39934983f [ucdn] Fix Hangul composition 
https://github.com/grigorig/ucdn/issues/23
 2019-05-14 00:13:21 -07:00
Behdad Esfahbod b2ab15a78c Fix more warnings 2019-05-13 23:47:28 -07:00
Behdad Esfahbod 42ae468a8a [config] Add NDEBUG and HB_NDEBUG 
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
 2019-05-13 23:43:45 -07:00
Behdad Esfahbod 0a01deb76f One more warning fix 
No idea where these appear from...
 2019-05-13 18:04:09 -07:00
Behdad Esfahbod f76e9f2ede [icu] Comment 2019-05-13 17:39:46 -07:00
Behdad Esfahbod 70fe9e7355 Fix moreeeeeeeeeee 2019-05-13 17:35:02 -07:00
Behdad Esfahbod 68e12e68f8 Fix more semi-colon issues 2019-05-13 17:28:59 -07:00
Behdad Esfahbod 4d3cf2adb6 [iter] Fix zip iterator sortedness classification logic 2019-05-13 17:25:07 -07:00
Behdad Esfahbod c572732f29 Fix more excess semi-colon errors 2019-05-13 15:41:09 -07:00
Behdad Esfahbod 513762849a [iter] Track strictly-sorted iterators 
This make output of hb_enumerate() sorted regardless of input iterator.
 2019-05-13 15:36:14 -07:00
Behdad Esfahbod 7e02063f32 [iter] Minor 2019-05-13 15:26:00 -07:00
Garret Rieger a5fb44a8cb [subset] Fix shadowed 'groups' param in cmap. 2019-05-13 15:04:35 -07:00
Behdad Esfahbod 73943bdf21 Adjust uniscribe_bug_compatible mode 
More correct behavior.  We were commenting out some legit conditions
before.

Part of https://github.com/harfbuzz/harfbuzz/issues/1652
 2019-05-13 14:48:31 -07:00
Behdad Esfahbod 809c587083 [config] Better compile away morx/kerx/trak 
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
 2019-05-13 14:45:51 -07:00
Behdad Esfahbod b1d3e54bd3 [indic] Don't constrain how many C, M, ... occur 
Fixes https://github.com/harfbuzz/harfbuzz/issues/1709

Part of https://github.com/harfbuzz/harfbuzz/issues/1652
 2019-05-13 14:35:04 -07:00
Behdad Esfahbod a487fc3324 Another extra semi-colon 2019-05-13 14:16:33 -07:00
Behdad Esfahbod 8461ade783 Revert "[ragel] Regenerate ragel-generated files using ragel 7.0.0.11 May 2018" 
This reverts commit 9b05db33b5.

Fixes https://github.com/harfbuzz/harfbuzz/issues/1708
 2019-05-13 14:10:48 -07:00
Behdad Esfahbod 52c15b053a Revert "[ragel] Switch to -T1 output instead of -F1" 
This reverts commit ae8719eb59.

Part of https://github.com/harfbuzz/harfbuzz/issues/1708
 2019-05-13 14:10:28 -07:00
Behdad Esfahbod e98f0ddd63 Fix extra semi-colon 2019-05-13 13:53:06 -07:00
Behdad Esfahbod ae8719eb59 [ragel] Switch to -T1 output instead of -F1 
Fedora upgraded to ragel 7, which is buggy if char is signed.
Switching to -G2 output fails with sign-compare error:

../../src/hb-buffer-deserialize-json.hh:107:12: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘const char’ [-Werror=sign-compare]
    if ( 9u <= ( (*( p))) && ( (*( p))) <= 13u ) {
         ~~~^~~~~~~~~~~~~

Switching to -T1 for now.  It actually results in smaller code,
at the expense of some binary searching instead of flat tables.
In the not distant future, we might actually generate two different
outputs and choose between depending on size-optimize options.

Fixes https://github.com/harfbuzz/harfbuzz/issues/1708
 2019-05-13 12:30:40 -07:00
Behdad Esfahbod df3f36f0bb Minor 2019-05-12 20:56:36 -07:00
Behdad Esfahbod ccc88e98f3 Fix MSVC build 2019-05-12 16:12:06 -07:00
Behdad Esfahbod f8f9cb93b7 [config] Define HB_NO_SUBSET_LAYOUT in HB_LEAN 
Assumning subsetter would be used for printing-like uses in that case,
which don't need GSUB/GPOS.
 2019-05-12 15:56:25 -07:00
Behdad Esfahbod a1394a28fc [config] Add HB_NO_UNISCRIBE_BUG_COMPATIBLE 
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
 2019-05-12 15:47:46 -07:00
Behdad Esfahbod dba1ac1b0e [config] Disable buffer serialize routines in HB_TINY 
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
 2019-05-12 15:33:49 -07:00
n8willis 3d9be2ad50
Merge pull request #1665 from n8willis/docs-gtkdoc-colormath 
[Docs] Add gtk-doc comments for OT color and OT math
 2019-05-12 20:03:29 +01:00
Behdad Esfahbod a20db496f0 Fix builds 2019-05-12 11:08:45 -07:00
Behdad Esfahbod 8694d60829 [config] Enable HB_NO_MT in HB_TINY 
Now that user can override it if needed...

Part of https://github.com/harfbuzz/harfbuzz/issues/1652
 2019-05-12 11:05:24 -07:00
Behdad Esfahbod 7f6fca4ef7 Force-disable CFF code under disabling conditions 
Subsetter size goes down from 190kb to 119kb.  Main library about 7kb.

Part of https://github.com/harfbuzz/harfbuzz/issues/1652
 2019-05-12 10:29:47 -07:00
Behdad Esfahbod 5249eee437 [config] Allow overriding chosen config 2019-05-11 16:12:23 -07:00
n8willis 1a850abd66
Merge branch 'master' into docs-gtkdoc-colormath 2019-05-11 20:16:57 +01:00
Nathan Willis 8a544171d1 Corrections to OT Color gtk-doc comments. 2019-05-11 20:11:49 +01:00
Nathan Willis 301f5091f6 Corrections to OT Math gtk-doc comments. 2019-05-11 20:11:36 +01:00
Behdad Esfahbod a6048e4cd0 Fix build 2019-05-11 12:11:22 -07:00
Behdad Esfahbod 32d3c06b61 Disable sbix if no-color or no-ot-font-bitmap 
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
 2019-05-11 11:59:18 -07:00
Behdad Esfahbod 606841b070 [iter] Check for more before forwarding/rewinding past ends 2019-05-11 11:56:26 -07:00
David Corbett c1c122e7b3 [iter] Fix filter rewinding 2019-05-11 11:52:40 -07:00
David Corbett b854d4ff46 [array] Fix rewinding 2019-05-11 11:52:40 -07:00
n8willis 76e80c5ca5
Update src/hb-ot-color.cc 
Co-Authored-By: Khaled Hosny <khaledhosny@eglug.org>
 2019-05-11 19:51:24 +01:00
Behdad Esfahbod 79126df307 [iter] Add hb_map_sorted() and hb_map_retains_sorting() 2019-05-11 11:23:31 -07:00
n8willis bcd81932f0
Update src/hb-ot-math.cc 
Co-Authored-By: Khaled Hosny <khaledhosny@eglug.org>
 2019-05-11 14:10:32 +01:00
n8willis ddc6dd42f7
Update src/hb-ot-math.cc 
Co-Authored-By: Khaled Hosny <khaledhosny@eglug.org>
 2019-05-11 14:10:11 +01:00
n8willis 46e05ecca1
Update src/hb-ot-color.cc 
Co-Authored-By: Khaled Hosny <khaledhosny@eglug.org>
 2019-05-11 14:09:52 +01:00
n8willis 6d9870b479
Update src/hb-ot-color.cc 
Co-Authored-By: Khaled Hosny <khaledhosny@eglug.org>
 2019-05-11 14:09:26 +01:00
n8willis 12ea4a24c4
Update src/hb-ot-color.cc 
Co-Authored-By: Khaled Hosny <khaledhosny@eglug.org>
 2019-05-11 14:08:40 +01:00
n8willis 3535f2d31e
Update src/hb-ot-color.cc 
Co-Authored-By: Khaled Hosny <khaledhosny@eglug.org>
 2019-05-11 14:07:38 +01:00
n8willis 12d2c472fe
Update src/hb-ot-color.cc 
Co-Authored-By: Khaled Hosny <khaledhosny@eglug.org>
 2019-05-11 14:06:56 +01:00
Behdad Esfahbod 7f45ce42db [config] Rename 2019-05-11 01:28:31 -07:00
Behdad Esfahbod 0e78d4ddae [config] Add HB_NO_NAME 
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
 2019-05-11 01:27:50 -07:00
Behdad Esfahbod 1fc0772117 [config] HB_NO_OT_NAME_LANGUAGE AAT 2019-05-11 01:24:23 -07:00
Behdad Esfahbod 4381bb2de7 [config] Comment 2019-05-11 01:14:04 -07:00
Behdad Esfahbod 9c921e6c32 [config] Enable HB_NO_NAME_TABLE_AAT 
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
 2019-05-11 01:08:51 -07:00
Behdad Esfahbod 81b79dfc39 [config] Add HB_NO_COLOR to HB_LEAN 
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
 2019-05-11 00:53:52 -07:00
Behdad Esfahbod b63a8e173c [config Add HB_NO_OT_SHAPE_COMPLEX_VOWEL_CONSTRAINTS to LEAN 
Already I don't like the inflexibility of this approach :(.

Part of https://github.com/harfbuzz/harfbuzz/issues/1652
 2019-05-11 00:47:20 -07:00
Behdad Esfahbod 42a2128477 [config] Disbale getenv() and atexit() if HB_LEAN 
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
 2019-05-11 00:44:38 -07:00