Commit Graph

11427 Commits

Author SHA1 Message Date
Christoph Reiter 93aea76a25 Fix the GHA msvc build
Use the 'ilammy/msvc-dev-cmd' action for setting up the msvc env,
so we can use powershell everywhere.

Remove a directory from PATH which was interfering with the meson build
by providing an unrelated pkg-config.exe.
2020-07-18 19:52:45 +02:00
Ebrahim Byagowi d0e2addd43 minor 2020-07-18 22:16:02 +04:30
Ebrahim Byagowi 3a46ae5127 Use GitHub Actions for msvc bots 2020-07-18 19:15:53 +02:00
Ebrahim Byagowi 7e3edfa454
minor 2020-07-18 19:03:36 +04:30
Qunxin Liu 8e5bc535d1 [subset] call collect_mapping only when --gids option is used.
collect_mapping is time consuming as it iterates all codepoints in all
cmap subtables, only trigger it when necessary
2020-07-16 11:25:53 -07:00
Ebrahim Byagowi 1ebe5bad1a
[ci] minor fix 2020-07-16 01:45:38 +04:30
Ebrahim Byagowi e9b71c296b
[ci] cleanup 2020-07-16 01:40:48 +04:30
Ebrahim Byagowi 8cbdb6fa41 [meson] Don't enable benchmark under the conditions ever
As we don't want to make headache for packagers as we don't want to
enable it when --auto-features=enabled is used.
2020-07-15 13:33:00 +04:30
Ebrahim Byagowi dc981fe951
[meson] Merge gdi and uniscribe
They are the same thing obviously
2020-07-15 13:15:27 +04:30
Christoph Reiter 8e7a9b6eeb msys2-ci: clean up 2020-07-15 12:11:49 +04:30
Christoph Reiter 9a4d590eee CI: Port MSYS2 jobs from appveyor to github actions 2020-07-15 12:11:49 +04:30
Ebrahim Byagowi 945bcd7230
minor 2020-07-15 09:54:32 +04:30
Ebrahim Byagowi fa0436ddd1
[ENOMEM][fuzzer/subset] early return if the result is null
I don't see _or_fail APIs idiomatic for the project but since it is there, let's have this
2020-07-15 09:52:40 +04:30
Ebrahim Byagowi 7c433ffde2
Add HB_CUSTOM_MALLOC definition
So one can use just HB_CUSTOM_MALLOC instead need for define each of hb_*alloc_impl
2020-07-15 09:38:12 +04:30
Ebrahim Byagowi 60959b08e5
[meson] execute find_program('gen-ragel-artifacts.py') only once
should rename the script also
2020-07-14 20:28:06 +04:30
Ebrahim Byagowi 5c8e1bd237 [meson] Don't allow introspection on static library 2020-07-14 18:02:40 +04:30
Ebrahim Byagowi 9566904cb3
[morx] minor, mark with unlikely
at least just to show this is the unusual path
2020-07-14 15:17:17 +04:30
Ebrahim Byagowi 11d583a9ea
[aat] Consume glyph insertion from buffer's max_ops (#2223)
Glyph insertion is an expensive operation and we like to have it limited
based on buffer's input size which is handled by buffer's max_ops.

clusterfuzz-testcase-minimized-harfbuzz_fuzzer-5754958982021120:

Before the change: 0.67s user 0.00s system 99% cpu 0.674 total
 After the change: 0.02s user 0.00s system 98% cpu 0.024 total

Which takes much longer on valgrind and tsan bots.
2020-07-13 18:53:06 -07:00
Ebrahim Byagowi 6937092a66 [py] apply lgtm.com python suggestions 2020-07-13 23:37:52 +04:30
Ebrahim Byagowi 2a182128b9
[py] minor, comment buffer_add_utf8 call
mainly to apply lgtm suggestion, looks better also however,
some minor spacing is also applied.
2020-07-13 20:41:13 +04:30
Ebrahim Byagowi 2c1d699409
[ci] use clang for cov-build
to be honest this is done as a let's see what
happens move but the background is coverity
reveals more things for Firefox project and there
should be an interesting reason for it.
2020-07-13 20:26:57 +04:30
Ebrahim Byagowi cdf18e8338
[py] minor, remove unnecessary pass
discovered by lgtm
2020-07-13 20:07:51 +04:30
Ebrahim Byagowi 45d9e8d76c
[py] minor, remove unused import 2020-07-13 19:25:53 +04:30
Ebrahim Byagowi 9ab7525a06
[ci] use a fixed version of meson in gh actions bot
a patch is uploaded to fix the issue with b_coverage in meson upstream thus let's revive our bot at least for now
2020-07-13 01:15:36 +04:30
Ebrahim Byagowi 3236db625b
[ci] install a fixed version of meson in msys2 bots
for some reason apparently msys2 installation here has 0.51 version, which, is weird, lets use a fixed version anyway
2020-07-13 01:06:24 +04:30
Ebrahim Byagowi 51a8eb1c02
[ci] use meson package from msys2
as https://github.com/harfbuzz/harfbuzz/issues/2561#issuecomment-657261692
2020-07-12 23:40:50 +04:30
Ebrahim Byagowi 3163e9fedb
[ci] Remove HB_TEST_SUBSET_FUZZER_TIMEOUT
meson is passing it itself

Fortunately oss-fuzz has its own timeout value, I just like to be conservative here
and not involve outsiders with flakiness of tests specially as meson which runs
them concurrently so consuming more time is expected on meson.
2020-07-12 23:11:45 +04:30
Ebrahim Byagowi cd6f62d960
[meson] Raise timeout value of subset fuzzer testcases
happens when tsan is enabled
2020-07-12 23:05:11 +04:30
Behdad Esfahbod 1dfa33854f [arabic] Remove stale comment 2020-07-12 09:24:03 -07:00
Ebrahim Byagowi f8d345ee06
[ci] Remove ambiguous-reversed-operator warning from whitelist
Should be fixed by 6a45df0
2020-07-09 10:57:51 +04:30
Behdad Esfahbod 6a45df0a54 Fix -Wambiguous-reversed-operator warning
Fixes https://github.com/harfbuzz/harfbuzz/issues/2554
2020-07-08 18:17:40 -05:00
Ebrahim Byagowi 5ea11cb817
[ci] don't use harfbuzz.cc with -Weverything
Causes

In file included from src/harfbuzz.cc:13:
src/hb-ot-cff1-table.cc:36:17: error: using namespace directive in global context in header [-Werror,-Wheader-hygiene]
using namespace CFF;
                ^
In file included from src/harfbuzz.cc:14:
src/hb-ot-cff2-table.cc:35:17: error: using namespace directive in global context in header [-Werror,-Wheader-hygiene]
using namespace CFF;
                ^
2 errors generated.
2020-07-08 19:29:47 +04:30
Ebrahim Byagowi e4f9969108 [ci] migrate to meson
two bots, one bot here (distcheck) and one in travis still run autotools and
won't be removed till we decide about autotools
2020-07-08 19:18:31 +04:30
Ebrahim Byagowi f62f4e388b [meson] minor on gdi, dwrite and icu 2020-07-08 03:12:32 +04:30
Ebrahim Byagowi 69a1e07acb
[meson] don't enable benchmark if is in nodownload wrap mode
Fixes #2551
2020-07-08 03:12:09 +04:30
Ebrahim Byagowi e04050e3b8
[meson] split fuzzer_ldflags before use 2020-07-08 01:06:30 +04:30
Ebrahim Byagowi 747f65f9ef
[meson] Remove HAVE_OT and HAVE_FALLBACK
No need as 1e8fdd2 and 23768a9
2020-07-07 11:37:16 +04:30
Ebrahim Byagowi c5def34730 [meson] don't underscorify fuzzers names 2020-07-06 23:51:52 +04:30
Ebrahim Byagowi d608f2ac85 [meson] Add fuzzer_ldflags
As ots, https://github.com/khaledhosny/ots/commit/4d37b9b
2020-07-06 23:51:52 +04:30
Ebrahim Byagowi e1c35ca581
[meson] rename the section
As Behdad's comment
2020-07-06 22:29:11 +04:30
Ebrahim Byagowi ddb103ea1a
[meson] minor 2020-07-06 22:27:39 +04:30
Ebrahim Byagowi 13d78b50f2
[doc] minor 2020-07-06 22:22:42 +04:30
Ebrahim Byagowi e5dd7d3ef9 [doc] more on build 2020-07-06 22:19:59 +04:30
Ebrahim Byagowi 471ae786ce [ci] Install a newer meson version 2020-07-06 22:19:59 +04:30
Ebrahim Byagowi 694a0c6bbc [meson] Always add icu deps 2020-07-06 22:19:59 +04:30
Ebrahim Byagowi 28554cb831 [doc] add a note for packagers 2020-07-06 22:19:59 +04:30
Ebrahim Byagowi 0fc52d3b2d [doc] Simplify and extend build instructions 2020-07-06 22:19:59 +04:30
Ebrahim Byagowi 3a8d137c2c [ci] migrate macOS bots to meson 2020-07-06 22:19:59 +04:30
Khaled Hosny a2b52cbb77 [ci] Use --wrap-mode=default for MSVC builds 2020-07-06 21:15:44 +04:30
Khaled Hosny dc684103d4 [meson] Set the default wrap mode to nofallback
This, I believe, will prevent any automatic use of subprojects be
default and will only look for dependencies on the system.
https://mesonbuild.com/Subprojects.html#commandline-options
2020-07-06 21:15:44 +04:30