e25efb31f2
[subset] consider all value formats when computing effective format.
2021-04-23 19:09:37 -07:00
84dbfacfec
[subset] fix collect_variation_idx in PairPosFormat2
2021-04-23 18:52:24 -07:00
d356d0f79c
[subset] optimize ValueRecord's for PairPosFormat1.
2021-04-23 18:50:34 -07:00
f9fbe4817e
[subset] implement value record optimization for PairPosFormat2.
2021-04-23 18:50:34 -07:00
badb8e409b
[subset] use copy_values for PairPos serialize.
2021-04-23 18:50:33 -07:00
2f50283cd3
[subset] Begin implementing ValueRecord optimization:
...
remove value records which have a zero value.
2021-04-23 18:50:33 -07:00
5df7c668ba
[subset] In SinglePosFormat1 serialize only 1 value record.
...
Previously one record per glyph in the subset was serialized.
2021-04-23 18:50:33 -07:00
92757f6809
[subset] Don't drop anchor device tables when dropping hints. These may contain variation data.
...
Update subseting expected files to match latest version of fontTools.
2021-04-23 18:50:33 -07:00
6fddc2bbf9
[subset] subset layout tables (G*) by default.
2021-04-22 15:08:49 -07:00
425ba1f4ab
[subset] fixes infinite loop in hb_set_get_max().
...
Fixes https://oss-fuzz.com/testcase-detail/5363902507515904
2021-04-20 13:18:07 -06:00
ec4321068b
[subset] fix infinite loop caused by alloc failure in repacker.
...
Fixes: https://oss-fuzz.com/testcase-detail/5609112151916544 .
2021-04-20 13:18:07 -06:00
0e845d973e
[subset] fix memory leak in repacker caused by failed alloc.
...
Fixes: https://oss-fuzz.com/testcase-detail/5616763250278400 .
2021-04-20 13:18:07 -06:00
3fb62cdc14
[subset] fail on offset overflow in tables that we don't repack.
...
Fixes: https://oss-fuzz.com/testcase-detail/5229304507138048
2021-04-19 17:01:05 -06:00
23a28f5ad0
Avoid undefined-behavior
...
If a struct had (because it's a union) sizeof that is larger than the null_size,
we were providing only null_size bytes for its Null object. We know we'd never
access beyond that, but is undefined-behavior nonetheless according to the
standard.
The alternative fix would have required use of flexible-arrays, which are not
standard and have their own issues in various compiler. We've discussed that
extensively in the follow Mozilla issue (currently locked; I've asked that it
be opened):
https://bugzilla.mozilla.org/show_bug.cgi?id=1577584
Part of
https://github.com/harfbuzz/harfbuzz/pull/2067
2021-04-16 13:23:25 -06:00
499248c533
[blob] Use min_size, instead of null_size in .as<T>()
...
Part of https://github.com/harfbuzz/harfbuzz/pull/2067
2021-04-16 13:14:48 -06:00
e116058bba
[directwrite] Use correct UTF-16 string length
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/2474
2021-04-15 09:30:40 -06:00
668acff1f0
similarly improve comments on Hebrew ccc 18 & 19
...
Should have committed this along with commit 9658435a25
2021-04-13 11:01:22 -06:00
43d955207b
improve comments on Hebrew ccc 18 & 19
...
improve comments to reflect that:
ccc 18 includes both "flavors" of qamats: qamats [gadol] and qamats qatan
ccc 19 includes both "flavors" of holam: holam [not haser for vav] and holam haser for vav
This code and its comments may have been written before these code points were added to Unicode.
I.e. originally, these comments may have been complete, but they may have become incomplete in the meantime.
2021-04-13 11:01:22 -06:00
9dc9f0385d
[subset] fix for fuzzer testcase: https://oss-fuzz.com/testcase-detail/5858518134554624
2021-04-09 11:07:28 -06:00
430a67ceab
[subset] COLRv1 struct definitions
2021-04-08 11:27:01 -06:00
553ffaf682
[subset] fix for fuzzer testcase: https://oss-fuzz.com/testcase-detail/6382598554255360
...
avoid writing to null pointer
2021-04-08 09:54:48 -06:00
8b686afeb5
[subset] add unlikely().
2021-04-06 12:34:44 -06:00
64122b5a44
[subset] don't visit lookup if covered glyph set has failed.
...
If covered glyph set is in error then the same lookup can be recursed into repeatedly potentially causing a fuzzer timeout. Fixes: https://oss-fuzz.com/testcase-detail/5416421032067072 .
2021-04-06 12:34:44 -06:00
6f98a8ed46
[subset] Anchor should only use format 1 when hints are dropped.
...
Refactor Anchor to have a subset method instead of copy. This also allows
use to use serialize_subset in several places which simplifies calculating
offset bases.
2021-04-06 11:50:44 -06:00
71d6d15600
[subset] clamp distance to prevent shifting outside of the limits of int64.
...
Fixes https://oss-fuzz.com/testcase-detail/4961171477233664 .
2021-04-06 11:48:39 -06:00
fcacd17748
[ot] Update _hb_glyph_info_is_default_ignorable_and_not_hidden()
...
Used _hb_glyph_info_substituted() similar to the change made to
_hb_glyph_info_is_default_ignorable() in
7686ff854b
2021-04-06 11:47:06 -06:00
596f4258d0
[subset] copy Lookup::markFilteringSet when subseting.
2021-04-02 15:33:52 -06:00
d3a2f999e4
Fix up build
...
This was left out; oops.
2021-04-02 08:33:03 -06:00
c35d786397
[subset] never drop the 'pref' feature.
...
Never ever drop feature 'pref', even if it's empty. Harfbuzz uses it to choose the shaper for Khmer.
2021-04-01 16:27:35 -06:00
092094f705
Use as_array() and range loops in a few places
2021-04-01 16:02:54 -06:00
55e7f3fe32
[subset] Match FeatureVariationRecord dropping from fontTools.
...
Only drop records with no matching features that are at the end of the list. See: cab7d13dc0
2021-04-01 15:26:02 -06:00
f0c78e0282
[subset] don't drop features referenced in a feature variation substitution.
2021-04-01 15:26:02 -06:00
dae99b7769
[subset] don't keep FeatureVariationRecord's with no subsittutions.
2021-04-01 15:26:02 -06:00
b10741ca7f
[subset] when closing glyphs in context lookups don't use a current glyph set if a lookup is already applied.
2021-03-31 21:03:33 -06:00
8ef4257dc8
[sanitize] change max ops to track number of bytes processed.
...
Counting bytes as the operations is likely to be a better proxy for how
much work processing the table will cost vs. the current approach of
counting the number of sub-objects.
This should allow checks for max features, max scripts, etc. to be removed.
I tested this change against the full collection of fonts at https://github.com/google/fonts
and a max ops factor of 3 was sufficient to successfully sanitize all of them.
2021-03-31 19:03:30 -06:00
70110f6aaa
Modify OffsetTo<>::sanitize() overflow check
...
The code in question was introduced in 70eb2ff682https://github.com/harfbuzz/harfbuzz/pull/2923
2021-03-31 17:04:02 -06:00
4dba749d83
Add SortedArray{16,32}Of<>
2021-03-31 16:09:39 -06:00
5639e253f9
Add Array16Of<>
2021-03-31 16:04:43 -06:00
2520a82df9
s/LArrayOf/Array32Of/g
2021-03-31 15:41:54 -06:00
5efe360986
Rename (Unsized)OffsetListOf
2021-03-31 15:33:22 -06:00
6c4e0491d7
s/OffsetArrayOf/Array16OfOffset16To/g
2021-03-31 15:31:32 -06:00
1fc6b69aed
s/UnsizedOffsetArrayOf/UnsizedArray16OfOffsetTo/g
2021-03-31 15:30:35 -06:00
2a54c9f744
.
2021-03-31 15:26:42 -06:00
c539afb08b
[CFF] Use NNOffsetTo<> instead of OffsetTo<>
...
I'm pretty sure that's what is intended.
2021-03-31 13:28:25 -06:00
9b4b58493b
Fixup for recent OffsetTo<> changes
2021-03-31 13:27:21 -06:00
ad28f973f3
Rename offset types to be explicit about their size
...
Add Offset16To<>, Offset24To<>, and Offset32To<> for most use-cases.
2021-03-31 13:00:07 -06:00
c5c13006a1
[subset] fix memory leaks found in https://oss-fuzz.com/testcase-detail/5179935334465536
2021-03-31 12:37:45 -06:00
bd2950b393
Make VariationStore::get_delta(outer, inner) private
2021-03-31 11:36:36 -06:00
934675a429
Use VarIdx in VariationDevice
2021-03-31 11:34:41 -06:00
0f7f7536b9
[hvar] Change variation-index types from "unsigned int" to uint32_t
2021-03-31 11:31:49 -06:00
9ffc46b8ff
Add VarIdx
2021-03-31 11:26:18 -06:00
2179281c40
Add Offset24
2021-03-31 11:20:21 -06:00
cab9d5a57d
hb-config: Include config-override earlier
...
Currently config-override.h is included at the end of this file. This caused a problem for me while undefing HB_DISABLE_DEPRECATED, namely HB_IF_NOT_DEPRECATED was defined before actual undef took place and broke the whole build. I believe it would break builds for some other defines, too. Moving config-override.h include right after predefined configs is more sane and fixes all potential problems with includes.
2021-03-30 20:50:02 -06:00
adca4ce071
[subset] fixes https://oss-fuzz.com/testcase-detail/6173520787800064 .
...
Caused by incorrect bounds check in glyph closure for context lookups.
2021-03-30 15:44:41 -06:00
9f77a0c1ff
[subset] use hb_set_clear to avoid calling clear() on null pool set.
2021-03-30 15:12:52 -06:00
752e393ad2
[subset] avoid calling clear on null pool set.
2021-03-30 15:12:52 -06:00
9ed5f04a70
[subset] Simplify recent out-of-memory fixes
...
By checking return status of map->set().
2021-03-29 18:14:30 -06:00
a8f9f85a91
[map] Return success from ->set()
2021-03-29 18:13:22 -06:00
8741914a80
[subset] fix memory leak when map insert fails.
2021-03-29 18:02:32 -06:00
2397689387
Remove hb_success_t
...
Was not rolled-out yet. So just expand.
2021-03-29 17:49:16 -06:00
7a2eda7817
Move code around
2021-03-29 17:49:12 -06:00
bcb57dccaa
[sanitize] Add short-circuit to ArrayOfM1
...
Like the sibling ArrayOf types.
2021-03-29 17:49:08 -06:00
52df6b9fd8
[subset] check for set insertion success.
2021-03-29 17:41:07 -06:00
c6adb90a27
[subset] fix nullptr deref.
2021-03-29 17:41:07 -06:00
9a3537e5f6
[subset] invert err() return value. Undo previous change to check_success.
2021-03-29 17:15:22 -06:00
cdba5d44c2
[subset] fix incorrect handling of return value in check_success in the error case.
2021-03-29 17:15:22 -06:00
05e845c49a
Make previous commit gcc-only
2021-03-29 16:02:10 -07:00
b5e4032392
-Wno-unused-result
...
GCC doesn't let one turn off the warning using "(void) foo()".
People have introduced macros that do "unused << foo()" instead.
Until we do something similar, silence gcc.
Clang on the other hand understands "(void) foo()".
2021-03-29 15:57:36 -07:00
95230e291d
[subset] support subsetting GSUB8
2021-03-29 15:54:11 -06:00
d18915f920
Reformat gen-tag-table.py
2021-03-28 10:21:46 -07:00
3c8273ab68
Check for alloc failures on the gsub/gpos_langsys maps in subset plan creation.
2021-03-25 16:53:56 -06:00
29708e959a
[aat] Fix offsetToIndex math for out-of-bounds values
...
Previously, some bad font data was accidentally being interpretted as
legit if it happened to not fall out of memory bounds. The intention
of the code was what this commit does. I'm surprised we weren't getting
a "arithmetic between signed and unsigned values" warning / error
before.
2021-03-22 15:22:15 -07:00
46bf03d691
[subset] add NODISCARD to error checking methods on serializer.
2021-03-18 14:35:36 -07:00
3827a3eb56
[subset] rename serializer::set_error() to err().
2021-03-18 11:20:03 -07:00
f561fa6e4c
Change priority queue to use (priority, value) instead of (value, priority).
2021-03-18 11:13:47 -07:00
b14475d2ae
[subset] further changes to serializer error handling.
...
- Rename enum type and enum members.
- in_errors() now returns true for any error having been set. hb-subset now looks for offset overflow only errors to divert to repacker.
- Added INT_OVERFLOW and ARRAY_OVERFLOW enum values.
2021-03-18 10:51:26 -07:00
73ed59f7a6
[subset] store errors in the serializer as a flag set.
...
Make check_assign/check_equal specify the type of error to set.
2021-03-17 15:58:34 -07:00
b9ecc7420d
[subset] init offset_overflow in hb_serialize_context_t.
2021-03-17 15:53:58 -07:00
cf79fc342d
[subset] limit priority bumps to 16.
2021-03-17 15:53:58 -07:00
e2f14e81bd
[subset] fix memory leaks in test-repacker.
2021-03-17 15:53:58 -07:00
d3e2ba7c01
[subset] comment cleanup in hb-repacker.hh
2021-03-17 15:53:58 -07:00
832f2b599b
[subset] Refactor _subset () to reduce nesting and eliminate the use of 'goto'.
2021-03-17 15:53:58 -07:00
bb5c80a7c2
[subset] add error tracking to the repacker.
...
Also check for allocation failures as needed.
2021-03-17 15:53:58 -07:00
6e9468fcfb
[subset] cleanup memory leaks in the repacker.
2021-03-17 15:53:58 -07:00
a7a86a6eb4
[subset] Add prioritization offset resolution.
...
Vertices can now be prioritized to force them to sort closer to their parent. The resolver will attempt to use this for overflows on non-shared vertices.
2021-03-17 15:53:58 -07:00
b452b2c76c
[subset] refactor repacker graph to cache edge count and distances of vertices.
2021-03-17 15:53:57 -07:00
75414e82b5
[subset] Add table duplication overflow resolution.
2021-03-17 15:53:57 -07:00
8286bd8094
[subset] use vectors instead of hashmaps throughout the repacker since all keys will be mapped for these use cases.
2021-03-17 15:53:57 -07:00
519ae96617
[subset] switch sort_shortest_distance() to use priority queue.
2021-03-17 15:53:57 -07:00
5d3511e5b1
[subset] Change compute_distances() to use a priority queue.
2021-03-17 15:53:57 -07:00
59ac0a0d0a
[subset] Use priority for comparison in heap.
2021-03-17 15:53:57 -07:00
4c8dd41ed9
[subset] re-write compute distances to use an array lookup for the distance map.
2021-03-17 15:53:57 -07:00
5c4e0ffd97
[subset] Add a basic priority queue datastructure (binary heap).
2021-03-17 15:53:57 -07:00
dd8e5d0e1b
[subset] Only run the repacker for GSUB/GPOS.
2021-03-17 15:53:57 -07:00
aaa7873d42
[subset] add topological sort by closest distance via Dijkstra's algorithm.
2021-03-17 15:53:57 -07:00
8ebe5d734f
Implement will_overflow ().
2021-03-17 15:53:57 -07:00
6b1ea4cbe7
[subset] hook up the repacker to run if offset overflows are encountered during subsetting.
2021-03-17 15:53:57 -07:00
f4c78cc7dd
[subset] Implement Kahn's algo for topological sorting instead of BFS.
2021-03-17 15:53:57 -07:00
00f393dc3f
[subset] finish up BFS sort implementation.
2021-03-17 15:53:57 -07:00
1584d3cb8f
[subset] Start a proof of concept implementation of the GSUB/GPOS offset overflow resolver.
2021-03-17 15:53:57 -07:00
56ca435787
[subset] fix for collect_features and remove_redundant_lamngsys
...
previously remove_redundant_sys () is missing in harfbuzz, after
redundant langsys removal, some features are removed as well in
prune_features() in fonttools. This change is trying to get the same
result between harfbuzz and fonttools.
2021-03-17 14:24:04 -07:00
0e1c0fa404
[subset] optimize glyph closure method: step 5
...
add testcase and some fixes
2021-03-17 15:22:07 -06:00
b8a58a0c0b
[subset] optimize glyph closure method: step 4
...
optimize recurse_lookups in Context/ChainContext
glyph closure, only the glyphs that the parent lookup
can apply the recursion to can participate in recursing
the lookup.
2021-03-17 15:22:07 -06:00
62423504ee
[subset] optimize glyph closure method: step 3
...
Add function intersects_coverage_glyphs that collects
set of matching glyphs in Coverage table
2021-03-17 15:22:07 -06:00
ef78d0f923
[subset] optimize glyph closure method: step 2
...
Add function intersects_class_glyphs that collects
set of glyphs matching class in ClassDef table
2021-03-17 15:22:07 -06:00
b4fc593c3c
[subset] optimize glyph closure method: step1
...
Previous GSUB glyph closure is done by recursively visiting
all reachable lookup tables that apply to any glyphs in the
current/input glyph set, but actually only the glyphs that
the parent lookup can apply the recursion to can participate
in recursing the lookup. This is step 1 for glyph closure
optimization:
1. Add stack of currently active glyph set pointers into hb_closure_context_t
2. Update closure() method in simple GSUB tables to use
this stack in order not to change current glyph set at different stages
of recursion
3. Add function may_have_non_1to1() to GSUB tables
2021-03-17 15:22:07 -06:00
2df39bcae7
[subset] don't allocate a set to use as a glyph filter for PairPosFormat2.
2021-03-16 14:49:35 -07:00
bb54e1047d
[subset] Also filter class1 by coverage when collecting variation indices for PairPosFormat2.
2021-03-16 14:49:35 -07:00
190b7a98f8
[subset] Update PairPosFormat2 subsetting to match fontTools updated subsetting ( https://github.com/fonttools/fonttools/pull/2221 )
...
- subset class def 1 against the coverage table.
- Don't re-use class 0 in class def 2.
- Ignore class 0 glyphs for the purposes of determing format 1 vs format 2 encoding for ClassDef.
Add an additional test case which demonstrates these issues.
2021-03-16 14:49:35 -07:00
03538e872a
2.8.0
2021-03-16 19:28:35 +02:00
9e397ff2fb
[buffer] Fix order of HB_INTERNAL HB_DISCARD
...
Sucks that has to be specified in this order. But that is what it is for now.
Was only exhibiting problem on C++>=17 since that's when the [[nodiscard]]
was introduced.
2021-03-15 16:51:17 -06:00
8450f43ae1
[buffer] HB_NODISCARD next_glyph()
2021-03-15 16:01:35 -06:00
f4bc7673db
[buffer] Implement copy_glyph() in terms of output_info()
2021-03-15 16:01:35 -06:00
f73982a699
[buffer] Implement replace_glyph() in terms of replace_glyphs(1,1)
...
I get exact same binary size with this, suggesting that compiler is
optimizing these as needed.
2021-03-15 16:01:35 -06:00
862f913489
[buffer] Implement output_glyph() in terms of replace_glyphs(0,1)
...
To my surprise, saves ~20kb in my build (non-size-optimized) build.
The output_glyph() method is never used in the fast paths, so doesn't
matter if is not fully optimized for the special case it is.
2021-03-15 16:01:35 -06:00
34a1204f10
[buffer] HB_NODISCARD output_glyph()
...
Also, generalize and use replace_glyphs() in morx where output_glyph() was used
in a loop.
2021-03-15 16:01:35 -06:00
e6be9eb4fb
[buffer] HB_NODISCARD output_info()
2021-03-15 14:12:10 -06:00
2a0dbb3ee5
[buffer] HB_NODISCARD copy_glyph()
2021-03-15 14:10:39 -06:00
b05e5d9a79
[buffer] HB_NODISCARD next_glyphs()
2021-03-15 14:08:08 -06:00
4ae8aab83b
[buffer] HB_NODISCARD has_separate_output()
2021-03-15 14:01:52 -06:00
8d3701f507
[buffer] HB_NODISCARD in_error()
2021-03-15 14:01:32 -06:00
41e05479b6
[buffer] HB_NODISCARD shift_forward()
2021-03-15 14:00:00 -06:00
83b3784d1d
[buffer] HB_NODISCARD make_room_for()
2021-03-15 13:59:14 -06:00
c355508a89
[buffer] HB_NODISCARD ensure_glyphs() / ensure_unicode()
2021-03-15 13:58:30 -06:00
bc22305b6a
[buffer] HB_NODISCARD ensure_inplace()
2021-03-15 13:57:18 -06:00
cac6c86d2f
[buffer] HB_NODISCARD move_to()
2021-03-15 13:56:46 -06:00
05d2d37f9a
[buffer] HB_NODISCARD ensure()
2021-03-15 13:56:46 -06:00
d8028a0762
[buffer] HB_NODISCARD enlarge()
2021-03-15 13:34:36 -06:00
3f1998a065
[buffer] HB_NODISCARD replace_glyph()
2021-03-15 13:33:44 -06:00
607979d12f
[buffer] HB_NODISCARD replace_glyphs()
2021-03-15 13:23:48 -06:00
906c9928bb
[buffer] Return success status from buffer ops that can fail
...
Previous error-handling philosophy was that user doesn't need to
immediately know whether operation failed. But as can be seen after
we added malloc-failing fuzzing, there's just so many places in the
code that a failure of these operations needs to be mitigated before
further operations. So I'm moving towards returning success here,
and possibly making it nodiscard.
2021-03-15 13:13:45 -06:00
a5b8e7db4d
[hangul] Improve error handling
...
I did a review; changed some "return"s to "break"s, which should be identical.
Removed one check just before "continue" because not necessary.
The added error check is the actual fix.
Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=31755
2021-03-15 12:46:58 -06:00
99767f9386
[hangul] Whitespace
2021-03-15 12:36:59 -06:00
3622120fab
[subset] Make ClassDef format2 .intersects() return false if range value 0
...
We treat Class0 as "doesn't intersect". That's the only meaningful
interpretation. If one allos Class0 to mean "intersects", then the
intersects() result should be true iff glyphset is non-empty.
Related to https://github.com/harfbuzz/harfbuzz/issues/2703
2021-03-10 12:21:43 -07:00
e19de65eae
Update hb-ot-tag-table.hh ( #2890 )
2021-03-08 10:12:47 -08:00
7686ff854b
[ot] Keep substituted Default_Ignorables ( #2886 )
...
Don’t replace Default_Ignorables with zero-width space if they are
substituted or multiplied, not just when ligated.
After this change, HarfBuzz output matches that of Uniscribe and
CoreText for the new tests.
Fixes https://github.com/harfbuzz/harfbuzz/issues/2883
2021-03-04 13:09:32 -08:00
5efa04c890
[Makefile] Rebuild .def files if config changed
...
I was getting check-symbols failure because my previous build was
without CoreText, and after reconfiguring with CoreText, the old
harfbuzz.defs file was not being regenerated.
2021-03-02 16:30:13 -07:00
d351bbf0fb
[Makefile] Remove unused variable HBNODISTHEADERS
...
Not sure what it was used for before.
2021-03-02 16:30:13 -07:00
fd489433a8
[indic] Fix cluster-merging logic with cluster-level=1
...
Was producing non-monotonic cluster numbers because our faulty logic
was not merging clusters if something from before base and after base
had switched positions.
Fixes https://github.com/harfbuzz/harfbuzz/issues/2272
2021-03-02 16:30:09 -07:00
2902529b92
[subset] Fix HB_TINY build
...
Fixes https://github.com/harfbuzz/harfbuzzjs/issues/34#issuecomment-789247723
2021-03-02 15:05:39 -07:00
7cb22ba7eb
Include C headers with their C++ names ( #2882 )
...
Remove unnecessary includes.
Fixes build with some known broken SDKs (Nintendo Switch?)
https://en.cppreference.com/w/cpp/header
Fixes https://github.com/harfbuzz/harfbuzz/pull/2881
2021-03-01 11:44:06 -08:00
486da35cc0
m Add comments to IntType cast out operator
...
Okay, bots seem to be happy. Merging.
2021-02-23 13:58:35 -07:00
83b66bfb66
Another try to fix narrowing error
...
../src/hb-ot-layout-gsubgpos.hh: In instantiation of ‘void OT::ChainRule::serialize_array(hb_serialize_context_t*, OT::HBUINT16, Iterator) const [with Iterator = hb_map_iter_t<hb_array_t<const OT::IntType<short unsigned int> >, const hb_map_t*&, (hb_function_sortedness_t)0, 0>; typename hb_enable_if<hb_is_iterator_of<Lhs, typename Lhs::item_t>::value>::type* <anonymous> = 0; OT::HBUINT16 = OT::IntType<short unsigned int>]’:
../src/hb-ot-layout-gsubgpos.hh:2341:30: required from here
../src/hb-ot-layout-gsubgpos.hh:2326:15: error: narrowing conversion of ‘(unsigned int)g’ from ‘unsigned int’ to ‘short unsigned int’ inside { } [-Werror=narrowing]
c->copy (HBUINT16 {g});
~~~~~~~~^~~~~~~~~~~~~~
https://github.com/harfbuzz/harfbuzz/pull/2875
2021-02-23 13:04:38 -07:00
6c4bb60829
Fix narrowing errors with recent changes
2021-02-22 23:05:55 -07:00
d6bd00a488
Revert back IntType out cast to signed/unsigned
...
Previous commit didn't fix the bots. Putting it back now that I
understand why I initially did the "Wide" casts. But only doing
it for out-cast this time. This causes "narrowing" warnings
whenever we are converting signed/unsigned to smaller HBUINT16
etc. But those are valuable warnings. We should address those
separately instead of ignoring.
Maybe we should start using uint16_t more liberally in the
internal subsetter function signatures then.
2021-02-22 22:42:50 -07:00
0983601399
Add back wider cast to IntType
...
My local clang12 is fine, but many bots are not:
../src/hb-ot-cff1-table.hh: In instantiation of ‘bool CFF::Charset1_2<TYPE>::sanitize(hb_sanitize_context_t*, unsigned int) const [with TYPE = OT::IntType<unsigned char>]’:
../src/hb-ot-cff1-table.hh:554:13: required from here
../src/hb-ot-cff1-table.hh:377:60: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
if (unlikely (!ranges[i].sanitize (c) || (num_glyphs < ranges[i].nLeft + 1)))
~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
Enabling the extra cast operator mentioned in previous commit to see if
that fixes this case.
Again, I'd be happy to say "use 1u instead of 1" if this was universally
erred on. But since some compilers happily compile this while others
err, it would be a huge headache. Let's see...
https://github.com/harfbuzz/harfbuzz/pull/2875
2021-02-22 22:33:17 -07:00
567cedcc5f
Narrow down cast operators on IntType
...
Say for USHORT, we were implementing casts from and to unsigned.
With this change, we cast from and to uint16_t only. This allows
compiler more opportunities to catch possible narrowing issues in
the code.
It needed a couple of fixes in the codebase though, because
previously, if a USHORT was participating in arithmetic with signed
numbers, eg. "u + 1", the result would have been unsigned. With
this change, it would be signed. The correct fix is to update the
code to read "u + 1u".
That said, I think about conditionally adding back the cast
out to signed/unsigned, to facilitate better type deduction.
But I couldn't think of a real situation where that would help
with anything. So I didn't add. Here's what it was:
template <typename Type2 = hb_conditional<hb_is_signed (Type), signed, unsigned>,
hb_enable_if (sizeof (Type) < sizeof (Type2))>
operator hb_type_identity_t<Type2> () const { return v; }
https://github.com/harfbuzz/harfbuzz/pull/2875
2021-02-22 22:32:42 -07:00
f4f35a4d5f
[constexpr] Use initializer instead of assignment
2021-02-22 22:32:42 -07:00
cc16b26ef4
[constexpr] IntType
...
See https://github.com/harfbuzz/harfbuzz/pull/2875
2021-02-22 21:59:56 -07:00
8b2f9adf29
m Simplify Tag operator char*
2021-02-22 17:42:24 -07:00
021a1725ed
Merge pull request #2874 from harfbuzz/constexpr2
...
Some more cleanup towards using constexpr to simplify our internal datastrcutures.
https://github.com/harfbuzz/harfbuzz/pull/2874
2021-02-22 17:40:22 -07:00
b368a0736b
[atomic] Remove IBM/AIX implementation
...
The C++11 implementation shall be enough for everyone.
2021-02-22 17:24:09 -07:00
52f9126960
[atomic] Remove Windows implementation
...
Since we require C++11 now, there's no point to do a macro version check.
Which means we don't hit the MSVC issue defining __cplusplus wrongly.
2021-02-22 17:22:09 -07:00
a666fe64a9
[atomic] Comment
2021-02-22 17:21:27 -07:00
3528a21e8d
[atomic] Remove Apple implementation
...
Continuation of https://github.com/harfbuzz/harfbuzz/pull/676
2021-02-22 17:19:43 -07:00
140797d4a2
[constexpr] hb_atomic_int_t
2021-02-22 17:19:26 -07:00
2ec802b42a
[object] Simplify reference_count_t
2021-02-22 17:18:47 -07:00
12a283d513
m[ft] No need to use atomic ops for cached_x_scale
...
We have added a mutex since, so no need for atomicity.
2021-02-22 12:51:09 -07:00
a3c35aee30
m Move HB_SCRIPT_MYANMAR_ZAWGYI
2021-02-20 15:45:34 -07:00
c55bf55154
Remove HB_CONST_FUNC and HB_PURE_FUNC
...
They are not necessary for inline functions.
2021-02-20 15:45:12 -07:00
cba9893ac5
m[algs] Move roundf() here
2021-02-20 15:44:47 -07:00
f0947717ff
m[machinery] Move HB_VAR_ARRAY here
2021-02-20 15:44:25 -07:00
69464e9da0
[algs] Another try at fixing BEInt constexpr
...
../src/hb-algs.hh:120:3: error: body of constexpr function ‘constexpr BEInt<Type, 2>::operator Type() const [with Type = short unsigned int]’ not a return-statement
2021-02-20 15:42:44 -07:00
ff7bf88192
m[algs] Fix BEInt -Wnarrowing errors
2021-02-20 15:39:29 -07:00
a89d9f25b4
m Err on -Wnarrowing instead of -Wc++11-narrowing
...
On clang, -Wnarrowing is synonym for -Wc++11-narrowing.
On gcc it isn't. So, use the widely-available one
2021-02-20 15:38:05 -07:00
e208f80449
Make constexpr BEInt<Type, 2>::operator Type() C++11-compatible
...
Multiple return values not permitted until C++14
2021-02-20 15:31:43 -07:00
c2fc2aa44c
[atomic] Remove Solaris intrinsics
2021-02-20 15:20:33 -07:00
7099a6dca1
[atomic] Remove old Intel primitives implementation
2021-02-20 15:20:06 -07:00
711c241f6c
m[mutex] Remove busyloop mutex implemenation
...
Don't know why I ever added this. :)
2021-02-20 15:16:59 -07:00
47f01c0726
m[algs] Move BEInt here
2021-02-20 15:14:50 -07:00
e5b7bc424d
m Add default value to BEInt<> Size template parameter
2021-02-20 15:14:15 -07:00
2caae4a59a
m Move class traits
2021-02-20 15:13:52 -07:00
c2dbd6cc0f
Remove static_assert of sizeof basic sized int types
2021-02-20 15:11:47 -07:00
e1706ffecd
m [algs] Move flags here
2021-02-20 15:11:26 -07:00
017f6b0d24
m Move static_assert_expr<>
2021-02-20 15:11:14 -07:00
61f8d0e57d
m Rename ASSERT_STATIC_EXPR_ZERO to static_assert_expr
2021-02-20 15:08:19 -07:00
59cfffb1af
m Change ASSERT_STATIC_EXPR_ZERO template arg type to bool
2021-02-20 15:07:28 -07:00
1981d83d7f
[constexpr] HB_MARK_AS_FLAG_T
2021-02-20 15:07:14 -07:00
a4a99de0eb
[constexpr] bswap
2021-02-20 15:07:07 -07:00
f8ebe1dacd
[constexpr] BEInt
2021-02-20 15:06:12 -07:00
2fbd34f89a
m[set/map] Add operator bool()
...
Probably should use in places..
2021-02-19 18:40:48 -07:00
bf75a0a03a
m[dispatch] Use inline class member initialization
...
Let's see how bots like this...
2021-02-19 18:40:48 -07:00
82928d9cf6
m[blob] Move immutable check to C API boundary
...
Similarly to 08ed9e3f77
2021-02-19 18:40:48 -07:00
4020c6b286
m[blob] An empty blob can always be made writable
2021-02-19 18:40:48 -07:00
2d39031f7b
[buffer/set/map] Move immutable check only to C API boundary
...
The immutable objects are a concept only enforced by the C API.
So move checks only to that region.
This does assume that the rest of the code is careful not getting
into these internal methods on immutable objects, which something
we do, but have no way of enforcing (currently).
.
2021-02-19 18:40:48 -07:00
6d83d44052
m[set] Recover set from error in .reset()
2021-02-19 18:40:48 -07:00
445efe8d04
m[vector] Recover vector from error in .reset()
2021-02-19 18:40:48 -07:00
21433fa563
m[buffer] In hb_buffer_append() don't change until allocation success
2021-02-19 18:40:48 -07:00
0f61a6213a
m[vowels] Simplify
...
If we didn't "process" anything, swap_buffers() becomes a no-op.
2021-02-19 18:40:48 -07:00
3b91e0b592
m[buffer] Rename internal variable
2021-02-19 18:40:48 -07:00
9fcba109bf
[buffer] Make swap_buffers() copy rest
2021-02-19 18:40:48 -07:00
86993c09a1
Ignore -Wrange-loop-analysis
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/2834
2021-02-19 17:10:06 -07:00
6d94194497
Use auto in range-for-loop more
2021-02-19 17:10:06 -07:00
79e4f436e7
Apply rounding correctly when calculating glyph extents for CFF and CFF2; adjust expected test results
2021-02-19 16:53:21 -07:00
d01ebeae21
calculate extents based on scaled then rounded values; undo two of the earlier test result adjustments
2021-02-19 16:53:21 -07:00
1d8a89504b
do not round added deltas; fixes #2866
2021-02-19 16:53:21 -07:00
103ed7da83
[subset] Use dagger
...
Better fix for https://github.com/harfbuzz/harfbuzz/pull/2858
2021-02-19 16:48:30 -07:00
d8ea552d10
[aat] Improve unsafe-to-break logic
...
Reduces false-positives. See comments for new logic.
Fixes https://github.com/harfbuzz/harfbuzz/issues/2860
Adjusts run-tests.sh to allow unhashed absolute filenames.
2021-02-19 16:23:22 -07:00
cf203936d7
[aat] Unbreak builds
...
Some compilers don't like this:
../src/hb-aat-layout-common.hh:732:9: error: declaration of 'using StateTable = struct AAT::StateTable<Types, EntryData>' changes meaning of 'StateTable' [-fpermissive]
732 | using StateTable = StateTable<Types, EntryData>;
2021-02-18 12:03:26 -07:00
b6fdaa6948
[minor:aat] Use injected class name
2021-02-18 11:16:37 -07:00
e27420bb18
[minor:aat] Simplify template reference
2021-02-18 11:15:46 -07:00
7b8a8adb7d
[aat] Fix unsafe-to-break marking when end-of-text action kicks in
...
The state we are dealing with here is the previous state; so it should
cause unsafe_to_break before current glyph.
I'm surprised this wasn't caught by any tests. Guess we don't have any
fonts with fancy end-of-text forms.
2021-02-18 09:47:24 -07:00
aa80c7c8b4
[aat] Add buffer->successful check before buffer->next_glyph()
2021-02-18 09:31:46 -07:00
bcd10bf274
[normalize] Add buffer success check before ->next_glyph()
...
Speculative fix for:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=27843
2021-02-17 13:58:56 -07:00
505b3fc6cf
[harfbuzz.cc] Fix OffsetTable name clash with Mac headers
...
There's no easy way to undo a "using namespace" in our sources, so by the time
we get to include hb-coretext.cc from harfbuzz.cc, we already have "using namespace OT"
active, which clashes with Mac headers.
Error was:
$ gcc -O3 -Wall -arch i386 -DHAVE_CORETEXT=1 -c harfbuzz.cc -o harfbuzz.o -std=c++11
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/TextUtils.h:288:3: error:
reference to 'OffsetTable' is ambiguous
OffsetTable offsets,
^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/IntlResources.h:115:41: note:
candidate found by name lookup is 'OffsetTable'
typedef OffPair OffsetTable[3];
^
./hb-open-file.hh:81:16: note: candidate found by name lookup is 'OT::OffsetTable'
typedef struct OffsetTable
^
1 error generated.
2021-02-17 11:34:47 -07:00
6a9f576fd4
[coretext] Silence CoreText deprecation warning
...
As suggested by Ned, just ignoring it.
warning: 'CTGetCoreTextVersion' is deprecated: first deprecated in macOS 11.0 - Use
-[NSProcessInfo operatingSystemVersion] [-Wdeprecated-declarations]
2021-02-17 11:31:32 -07:00
8e53c7c125
[coretext] Fix more CGFloat double-promotion warnings
...
The warning is:
warning: implicit conversion increases floating-point precision: 'CGFloat' (aka 'float') to
'double' [-Wdouble-promotion]
2021-02-17 11:12:56 -07:00
5ca353a2d0
[subset] fix heap buffer overflow found by fuzzer.
2021-02-16 12:43:02 -07:00
751ed68fee
[indic] Fix shaping of U+0B55 ORIYA SIGN OVERLINE
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/2849
2021-02-14 12:47:34 -05:00
7a60f4e3a4
[subset] Remove debug burden
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/2360
2021-02-12 14:14:17 -07:00
08a4997fde
[subset] Add subset support for Extension lookups (GPOS 9, GSUB 7).
2021-02-11 13:41:31 -07:00
bbbea3dbd8
[minor] Rewrite set operation in OS/2 subsetting
...
This patch could be nicer:
https://github.com/harfbuzz/harfbuzz/pull/2572/files
Just tiny touchup now.
2021-02-11 12:23:33 -07:00
cdb9197b41
[khmer] Remove more unused code
...
Prodded by https://github.com/harfbuzz/harfbuzz/pull/2583
These are leftovers from when we forked Khmer shaper from the Indic shaper.
2021-02-11 11:33:47 -07:00
dfa9d7acdc
[minor] Use serializer->propagate_error() to simplify code
2021-02-11 11:19:51 -07:00
5faae8260a
[post] Remove unneeded error check
2021-02-11 10:58:02 -07:00
d7e2a51de2
[minor] Add unlikely() when checking for error
2021-02-11 10:55:03 -07:00
c7d232ce4e
Merge pull request #2701 from googlefonts/Mark-To-Ligature_grieger
...
[subset] GPOS 5 MarkToLigature subsetting support
2021-02-10 18:13:38 -07:00
7b9e23f28b
[introspection] Fix g-ir-scanner syntax errors
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/2851
2021-02-10 23:37:43 +02:00
1da75afbe8
[minor] Add unlikely()
2021-02-10 00:03:41 -07:00
6e1afac64b
[minor] Rename internal variable
...
To address review comment:
https://github.com/harfbuzz/harfbuzz/pull/2699#discussion_r573370781
2021-02-09 18:48:46 -07:00
836814a571
[array] Swap order of args to hb_equal()
...
Prioritizes Key::cmp() over table's cmp.
2021-02-09 18:48:05 -07:00
98374cebe1
Conditionalize IntType::cmp() so it never fails to compile
...
Useful with lfind() since that calls hb_equal() which SFINAEs which
cmp() to use.
2021-02-09 18:48:05 -07:00
ed04174a64
Whitespace
2021-02-09 18:48:05 -07:00
6a3fd94f3b
Merge pull request #2699 from googlefonts/gpos_8
...
[subset] Add a more complex layout subsetting test case and fix the issues it exposed.
2021-02-09 20:49:04 -05:00
8f47dd5779
[subset] don't set lookup visited in closure_lookups_context_t::recurse.
...
- Lookup::closure_lookups also checks if the lookups visited and sets the lookup to visited. If we set visited in 'recurse' then Lookup::closure_lookups will fail to recurse into the children of the lookup.
- Also when copying ChainRule's skip LookupRecord's that point to lookups which aren't retained. This matches FontTool's behaviour.
2021-02-09 20:34:52 -05:00
d9e0244cdf
remove duplicate file names
2021-02-02 09:23:41 -08:00
dad41c07e4
[use] Typo
2021-02-01 11:30:39 -08:00
63a716c540
[indic] Use lfind()
2021-02-01 11:30:39 -08:00
921b4e46b0
[algs] Add hb_equal()
...
Use in hb_array_t::lfind()
2021-02-01 11:30:39 -08:00
f4ed3bf20b
[indic] Remove categorization of Khmer Ra
...
Khmer goes through its own shaper these days.
2021-02-01 11:30:39 -08:00
676d1e6adf
[indic] Spell out INDIC_TABLE_ELEMENT_TYPE
2021-02-01 11:30:39 -08:00
769c2b19a3
[indic/khmer/myanmar/use] Minor shuffling of found_syllable() macros
2021-02-01 11:30:39 -08:00
59721c2f37
[use] Move data table into same compilation unit
2021-02-01 11:30:39 -08:00
d9b167da3d
[use] Remove hb-ot-shape-complex-use.hh
...
Inline into ragel machine.
2021-02-01 11:30:39 -08:00
3bb2653a5e
[use] Reuse category numbers exported from ragel machine
...
Part of https://github.com/harfbuzz/harfbuzz/pull/2726
2021-02-01 11:30:39 -08:00
c417e0d2f9
[indic/khmer/myanmar/use] Move enum category around
...
Such that the generated -machine.hh headers are independent.
2021-02-01 11:30:39 -08:00
675b6c2994
[indic/khmer/myanmar/use] Remove unused dump-*-data programs
...
In prep for streamlining tables.
2021-02-01 11:30:39 -08:00
0a5c631140
[use] Rename internal enum joinint_form_t members
...
To ease upcoming change.
2021-02-01 11:30:39 -08:00
880fdb7460
[indic/khmer/myanmar/use] Export categories from Ragel source
...
Not hooked up yet.
Part of alternative approach to
https://github.com/harfbuzz/harfbuzz/pull/2726
2021-02-01 11:30:39 -08:00
b198d94489
use {} rather than {0}
2021-01-25 14:07:52 -08:00
2e50b517e1
Nicer more idiomatic fix
2021-01-25 14:07:52 -08:00
8f6559a373
[subet/COLR] Default initialize firstLayerIdx
2021-01-25 14:07:52 -08:00
a650243d39
[sanitize] Fix typo
2021-01-24 13:30:06 -07:00
881ad720fe
[algs] Remove passthru declaration
...
Let compiler figure it out.
2021-01-21 14:27:45 -07:00
ca0b7afee9
[set] Use hb_fill()
2021-01-21 12:22:00 -07:00
5fce8898e0
[iter] Allow passing rvalue iters to hb_fill()
2021-01-21 12:15:10 -07:00
6463ee02d6
Speed up ClassDef/Coverage intersect methods
...
Just avoiding overhead as measured by Garret.
Should rewrite as dagger in the future and confirm that it has the
same benefits. Later on, rewrite as lfind() maybe.
Fixes https://github.com/harfbuzz/harfbuzz/issues/2826
2021-01-21 11:16:04 -08:00
33368a12b7
uint32_t to unsigned in hb-set.hh
2021-01-21 12:12:05 -07:00
2a0d0b901f
Make set clear work even when set is in failed state.
2021-01-21 12:12:05 -07:00
0ba73e980c
[ENOMEM] handle allocation failures during page compaction.
2021-01-21 12:12:05 -07:00
a4c3732f59
[ENOMEM] fix set clear() causing corruption if the set is in_error().
2021-01-21 12:12:05 -07:00
9b8be9643c
[docs] Ignore hb-gobject headers
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/2797
2021-01-20 14:23:37 -08:00
051a3c7b9a
[docs] Fix typo
2021-01-20 14:22:15 -08:00
a44dd339f9
[docs] Missing param docs
2021-01-20 14:22:15 -08:00
478d169c0f
[docs] Document more deprecated symbols
2021-01-20 14:22:15 -08:00
ca0a7a8384
[docs] Document hb_ot_math_constant_t somehow
2021-01-20 14:22:15 -08:00
3ba1e7e783
[docs] Document HB_OT_TAG_DEFAULT_LANGUAGE/SCRIPT
2021-01-20 14:22:15 -08:00
4bfa0b3c02
[docs] Fix hb_color_get_* docs
2021-01-20 14:22:15 -08:00
2cdc92c0c2
[use] Move most joining scripts to USE
2021-01-18 12:06:23 -08:00
5c73c9082b
[syllabic] Fix signed/unsigned comparision errors
2021-01-18 12:00:58 -08:00
e3d4c29727
[indic/khmer/myanmar] Minor: Fix mask
...
Seems like a typo. No behavior change.
2021-01-18 12:00:58 -08:00
0ddade44cf
[syllabic] Merge various insert_dotted_circles implementations
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1810
2021-01-18 12:00:58 -08:00
e8e9fd9556
[syllabic] Add hb-ot-shape-complex-syllabic.cc/hh
...
Empty for now.
Part of https://github.com/harfbuzz/harfbuzz/issues/1810
2021-01-18 12:00:58 -08:00
8af85c4e86
Remove hb-ot-shape-complex-machine-index.hh file
...
Inline code into USE header.
2021-01-18 12:00:58 -08:00
9dd61c5b78
Rename internal buffer var use
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1810
2021-01-18 12:00:58 -08:00
3c5b7886eb
Revert "Avoid category duplication between C++ and Ragel"
...
This reverts commit 67ea8133d3https://github.com/harfbuzz/harfbuzz/pull/2726
2021-01-15 19:26:04 -07:00
67ea8133d3
Avoid category duplication between C++ and Ragel
2021-01-15 18:24:52 -08:00
c8c5e52aba
[use] Update overrides to 2021-01-04
...
This uses the data files from
<ed7b825ddb/USE
2021-01-06 05:45:01 +02:00
1fb7f3bda6
[docs] Document various HB_SCRIPT_*
...
Need to have something for all of them to keep GTK-Doc happy.
2020-12-30 19:21:49 -08:00
ea0907abf9
[docs] Document version macros
2020-12-30 19:21:49 -08:00
5e9f05ff3f
[docs] Expand memory modes docs
...
Per Behdad suggestions.
2020-12-30 19:21:49 -08:00
5151c2b668
[introspection] Replace deprecated allow-none
...
Use optional or nullable as appropriate.
2020-12-30 19:21:49 -08:00
a64d56a3e5
[introspection] nullable is for pointers
2020-12-30 19:21:49 -08:00
9936490c04
[docs] Invalid use of "optional" annotation
...
It is valid only for out and inout parameters.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1787
2020-12-30 19:21:49 -08:00
bf5b4b71c5
[docs] Duplicated documentation
2020-12-30 19:21:49 -08:00
3d7a361648
[docs] Miscellaneous missing docs
2020-12-30 19:21:49 -08:00
a31a51cdec
[docs] Complete hb-ft docs a bit
2020-12-30 19:21:49 -08:00
8c492d5c32
[docs] Complete hb-ot-math docs a bit
2020-12-30 19:21:49 -08:00
3f7ffd1b3d
[docs] Complete hb-unicode docs a bit
2020-12-30 19:21:49 -08:00
2fdab788ad
[docs] Complete hb-buffer docs a bit
2020-12-30 19:21:49 -08:00
492a5a9096
[docs] Complete hb-aat docs a bit
2020-12-30 19:21:49 -08:00
3a012cc469
[docs] Complete hb-metrics docs a bit
2020-12-30 19:21:49 -08:00
5a55b31a38
[docs] Complete hb-shape-plan docs a bit
2020-12-30 19:21:49 -08:00
8e8c3e5878
[docs] Complete hb-ot-layout docs a bit
2020-12-30 19:21:49 -08:00
5b7b730d4b
[docs] Complete hb-color docs a bit
2020-12-30 19:21:49 -08:00
aa107e657b
[docs] Complete hb-font docs a bit
2020-12-30 19:21:49 -08:00
9b602e8e22
[docs] Complete hb-common docs a bit
2020-12-30 19:21:49 -08:00
c9c3b3c94c
[docs] Use correct syntax
2020-12-30 23:28:26 +02:00
a8e72ee784
[docs] Use %true and %false consistently
2020-12-30 23:28:26 +02:00
a3fe43a410
[docs] Hide private enum values
...
"/*< skip >*/" does not seem to hide them.
2020-12-30 23:06:18 +02:00
e93de6362b
[docs] Document unused language in get_baseline
...
Document that language_tag in hb_ot_layout_get_baseline() is currently
unused.
Fixes https://github.com/harfbuzz/harfbuzz/issues/2662
2020-12-30 11:53:46 -08:00
c7b2e64c6d
[docs] make it clear that FT_Face must have size
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/2590
2020-12-30 11:50:49 -08:00
7236c7e29c
2.7.4
2020-12-27 01:59:00 +02:00
010bd54040
Merge pull request #2777 from harfbuzz/docs-unicode
...
[docs] Improve hb-unicode docs a bit
2020-12-26 01:17:27 +02:00
22468c8a90
[docs] Give destroy callbacks have (optional) annotation
2020-12-24 22:38:06 +02:00
35c4a15a67
[docs] Update hb-font documentation
2020-12-24 22:34:26 +02:00
8586f15957
[docs] Update hb-common documentation
2020-12-24 22:23:47 +02:00
e8c21e003d
[docs] Remove comments the duplicate docs
2020-12-24 21:56:31 +02:00
cb319f0d80
[docs] Add some missing annotations to hb-buffer.cc
2020-12-24 21:47:05 +02:00
9af0edd951
[docs] Document return value of hb_blob_get_data()
2020-12-24 21:41:14 +02:00
f88e845fc7
[docs] Minor fixes
2020-12-24 21:34:14 +02:00
82092d4005
[docs] Update gtk-doc comments in hb-font
2020-12-24 21:34:14 +02:00
e8de26e1ef
[docs] Add gtkdoc comments to hb-buffer
2020-12-24 21:34:14 +02:00
d13b7eaaf1
[docs] Add gtkdoc comments to hb-blob
2020-12-24 21:34:14 +02:00
4cdb12a3fa
[docs] Add gtkdoc comments to hb-common
2020-12-24 21:34:14 +02:00
922c32eb2d
[docs] Add gtkdoc comments to hb-map
2020-12-24 21:30:03 +02:00
71af2c6d9b
[docs] Add gtkdoc comments to hb-set
2020-12-24 21:29:56 +02:00
ec98730ff6
[docs] regularize whitespace in function params
2020-12-24 21:29:47 +02:00
fdf3e448fd
[docs] Improve hb-unicode docs a bit
...
Down to only one warning.
2020-12-24 00:52:02 +02:00
0fd6144a5f
[docs] Fix warnings about unknown annotations
...
Use square brackets so that gtk-doc does not consider these to be
annotations.
2020-12-24 00:20:24 +02:00
71a3b54f3c
2.7.3
2020-12-23 15:33:15 +02:00
8560c3e355
Merge pull request #2774 from harfbuzz/misc-doc
...
Doc fixes
2020-12-23 00:25:10 -08:00
769a21aab6
meson: avoid regenerating hb-version.h unnecessarily
...
The file is a dependency for the library as a whole, so previously editing the Meson build files at all would force a full rebuild. This will only rebuild it if the version has changed.
2020-12-23 00:22:06 -08:00
c2e2c40bac
[docs] Fix gtk-doc comment syntax
...
The documentation was not picked otherwise.
2020-12-23 00:58:49 +02:00
0826940821
[docs] Add messing sections
...
Docs for these sections were not generated at all.
2020-12-23 00:58:49 +02:00
b8b13018ed
[docs] Make gtk-doc find these typedef’s
2020-12-23 00:58:43 +02:00
8c3a530fd7
[docs] Some formatting fixes
2020-12-22 23:52:46 +02:00
25c0a792e3
Remove unused+wrong UnsizedArrayOf<> operators
...
Said compiler is wrong to err since they are unused. But yeah, they
didn't make sense and were copy/paste leftover.
Fixes https://github.com/harfbuzz/harfbuzz/issues/2763
2020-12-10 14:29:47 -07:00
07e304b2a4
Merge pull request #2755 from Myaamori/master
...
meson: use meson.current_source_dir() instead of @CURRENT_SOURCE_DIR@
2020-12-01 22:32:19 +02:00
7c241651ac
[algs] Don't forward rvalue twice
...
Part of https://github.com/harfbuzz/harfbuzz/issues/2293
2020-11-30 16:38:53 -07:00
53806e5b83
Tiny improvement on previous commit
...
Functionally the same.
2020-11-25 11:51:37 -07:00
a5f6f869e8
Drop layout table if layout lookup accelerator allocation failed
...
If the table is kept, when the table is present but only the accelerator
allocation failed, then we run into nullptr dereferences downstream in
hb_ot_map_t::apply when trying to access proxy.accels[i].
To fix this, instead of only setting lookup_count of accelerator_t
itself, drop the whole table to avoid hb-ot-map construction assuming
that the lookups will work correctly despite accelerator allocation
having failed.
Fixes:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=24490
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=24490
2020-11-25 10:18:04 -08:00
5f32fdff11
meson: use meson.current_source_dir() instead of @CURRENT_SOURCE_DIR@
...
@CURRENT_SOURCE_DIR@ is not listed as a valid string substitution
for custom targets in the Meson reference, and in practice
it does not get substituted when using the vs2019 backend.
2020-11-24 01:29:24 +00:00
b2e7bb2a7c
Don’t map BCP 47 to coincidentally similar OT tag
2020-11-22 19:35:47 -08:00
e1df2c5277
Map ISO 639 code qul to language system tag 'QUH '
2020-11-22 11:52:23 -07:00
f579c66108
Mark variable unused
...
Hopefully fixes build with newer ragel.
https://github.com/adrian-thurston/ragel/issues/56
Fixes https://github.com/harfbuzz/harfbuzz/issues/2752
2020-11-21 08:41:06 -07:00
f83496a910
[use] Remove workaround for reserved code points
...
See <https://github.com/microsoft/font-tools/issues/12 >.
2020-11-20 15:37:37 -07:00
17da41bd06
Update language system tag registry to OT 1.8.4
2020-11-18 11:13:35 -08:00
fd8f4ffcc6
Trace reorder, not normalize
2020-11-17 09:05:40 +00:00
2e0193d741
Add more cast spaces
2020-11-17 09:05:40 +00:00
4bb6d54e3b
Missing cast
2020-11-17 09:05:40 +00:00
8e1bedc50b
Keep phase names
2020-11-17 09:05:40 +00:00
428c111f13
Fix spacing around casts
2020-11-17 09:05:40 +00:00
f19018da41
Smaller issues from review
2020-11-17 09:05:40 +00:00
8b3b835a0a
Trace normalization and preprocessing stages
2020-11-17 09:05:40 +00:00
b50099bff2
Trace reordering in pause functions
2020-11-17 09:05:40 +00:00
0c3dcfae19
Merge remote-tracking branch 'upstream/master'
2020-11-17 07:31:07 +01:00
3bd43bd023
Map more ISO 15924 variants to `hb_script_t`s
2020-11-16 22:18:15 -08:00
27170e058d
Fix names for language tag in gen-tag-table.py
...
A BCP 47 language tag with both a script subtag and a region subtag
would be printed as a human-readable name in hb-ot-tag-table.hh as if it
only had its language subtag.
2020-11-16 10:59:07 -08:00
49ebb9ebdd
[use] Remove redundant O entries from the table
2020-10-17 22:07:34 +02:00
79fd5ce22e
[use] Merge IND and Rsv classes into O
2020-10-17 22:07:34 +02:00
cde2cf84c0
[use] Minor clean-up of unused categories
2020-10-17 11:22:19 -04:00
0792690b73
[use] Skip WJ and ZWJ when clustering
2020-10-16 22:39:46 -07:00
3fcf466b7b
[hb-shape-fallback] Use signed int for correction
2020-10-16 17:57:38 -07:00
77e704d1db
[buffer] Add assert_unicode()/assert_glyphs() and use internally
2020-10-15 02:02:04 -06:00
5ef0613909
[buffer] Add ensure_glyphs()/ensure_unicode()
...
Use in deserialize. To be used more.
2020-10-15 01:54:28 -06:00
3232e6f2a9
[buffer] Add hb_buffer_has_positions()
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/2716
2020-10-15 00:20:17 -06:00
dec52006d9
Map BCP 47 tags to all macrolanguages
...
The general rule is that if a BCP 47 macrolanguage maps to an OpenType
language system tag, all its individual languages map to it too.
Previously, a tag like "prs" (Dari) would not map to the language system
tag ('FAR ') of its macrolanguage ("fa") because "prs" already has its
own language system tag ('DRI '). That exception has been removed: now
"prs" maps to 'DRI ' and falls back to 'FAR '.
2020-10-11 11:38:40 -07:00
1d53268dfe
Fix two-way mapping of "man" and 'MNK '
2020-10-11 11:38:40 -07:00
ab38cf6746
Map hy-arevmda to 'HYE ' instead of HYE0
2020-10-11 11:38:40 -07:00
916c5a9007
Consistently emit BCP 47 subtag scope suffixes
2020-10-11 11:38:40 -07:00
1c05f6789b
[buffer] Increase work limits
...
Our previous limits of 64 per input character was already hit
by David Corbett's under-development Duployan font.
Increase work limits by factor of 16, and number of glyphs by factor of 2.
Fixes https://github.com/harfbuzz/harfbuzz/issues/2707
2020-10-11 12:28:25 -06:00
b37edebfcb
[buffer/deserialize] Do not clear() buffer upon content type mismatch
...
We return false. I don't see reason to clear buffer.
2020-10-09 22:27:56 -06:00
c396e1600f
[buffer/deserialize] Accept arbitrary glyph names
...
Accepts escapes. Added TODO items for matching escaping in serialize().
2020-10-09 22:27:56 -06:00
4a4eebcf86
[buffer/serialize] Minor renames in Ragel machines
...
As per my previous review on:
https://github.com/harfbuzz/harfbuzz/pull/2687
2020-10-09 22:27:56 -06:00
78fb6a11af
Whitespace
2020-10-09 22:27:55 -06:00
140552cec9
[buffer/serialize] Only serialize empty buffers of CONTENT_TYPE_INVALID
2020-10-09 22:27:55 -06:00
8f5d8b155c
[buffer] Buffer start <= end <= len requirement in (de-)serialize
2020-10-09 22:27:55 -06:00
3b64122a7f
[buffer] Fix immutable case with end_ptr==nullptr
2020-10-09 22:27:55 -06:00
7c0bc0bb92
Serialize invalid buffer to !! (text) or [] (json)
...
There is no generic deserialize - you have to choose glyphs or unicode - so there is no way to deserialize this buffer.
2020-10-09 22:27:55 -06:00
5bb88c4f45
Oops debug print
2020-10-09 22:27:55 -06:00
f56eb402f0
Immutable buffer fix
2020-10-09 22:27:55 -06:00
150f391438
Prohibit mixed glyphs/unicode buffers in deserialization
2020-10-09 22:27:55 -06:00
6b1726b6ef
Typos
2020-10-09 22:27:55 -06:00
3d3c87e7e7
Put the flags back in and serialize clusters.
...
Note that now JSON glyph buffers and Unicode buffers look very similar, except for the g/u property difference.
2020-10-09 22:27:55 -06:00
c03a2001b2
Deserialization routines for Unicode buffers
2020-10-09 22:27:55 -06:00
c0716bb5dc
Move delimiter addition into hb-buffer-serialize
2020-10-09 22:27:55 -06:00
36ede56962
Fix docs
...
Note the delimiters stuff isn’t true yet, will be working on that
2020-10-09 22:27:55 -06:00
bb7b634cd0
Simplify JSON unicode serialization
...
It’s just an array of codepoints; no need to turn them into objects
2020-10-09 22:27:55 -06:00
57a528ab2c
Convert tabs to spaces
2020-10-09 22:27:55 -06:00
aff6a36266
Use auxbuffer for serialize_unicode_text
2020-10-09 22:27:55 -06:00
58bcc1cedd
Serialize Unicode buffers
2020-10-09 22:27:55 -06:00
c39ab82c90
Fix usage text of gen-use-table.py
2020-10-06 16:51:40 -04:00
aace09a3ad
[subset] Use glyphset gsub for layout variation indices collection.
2020-10-06 10:26:17 -07:00
1d9801e012
[subset] In AnchorMatrix::subset eliminate the use of dynamically allocated vector.
2020-10-05 14:43:29 -07:00
093909b2ff
[subset] Fix wrong offset base for subsetting LigatureArray.
...
Offsets from LigatureArray must be relative to the beginning of the LigatureArray table. For the serialization mechanism to use the correct beginning point the LigatureArray must be created using the push()/pop() mechanism. So convert LigatureArray subsetting to use serialize_subset() instead of a manually called serialize and subset.
2020-10-05 13:14:53 -07:00
147e93b910
[subset] Fixes to get GPOS 5 subsetting code compiling.
2020-10-01 16:45:57 -07:00
3a0b05faf1
[subset] GPOS 5 MarkToLigature subsetting support
2020-10-01 15:59:16 -07:00
718bf5aab3
[subset] only keep features reachable from script in the final subset.
...
Matches fontTools behaviour.
2020-09-29 13:16:01 -07:00
e583505334
[subset] Use plan->glyphset_gsub instead of plan->glyphset for GSUB/GPOS
...
This matches fontTools behaviour. glyphset_gsub does not contain gids added from closing over composite glyphs in glyf, since these cannot particpate in GSUB/GPOS processing.
2020-09-29 11:16:15 -07:00
a99e8721bf
[use] Fix tests with MSVC
2020-09-29 09:54:33 -04:00
940e1c6f98
[subset] ChainContextFormat3 - don't subset glyph sequences.
...
The backtrack, input, and lookahead sequence must be matched in their entirety so these sequences should not be subset. If any of the coverage tables in a sequence subsets to empty then the whole subtable should be dropped since it's not possible for this lookup to be activated.
2020-09-28 17:22:01 -07:00
e31c2690f8
[subset] remove unnecessary returns.
2020-09-28 16:51:25 -07:00
ad241f9917
[subset] check that sub rules in ChainContextFormat 1 and 2 intersect the glyphs set before recursing during closure lookups.
2020-09-28 15:26:13 -07:00
9fad540245
[subset] check that sub rules in ContextFormat 1 and 2 intersect the glyphs set before recursing during closure lookups.
2020-09-28 13:24:25 -07:00
7e6070a47f
Set *coord to nullptr
2020-09-28 08:36:41 -06:00
4e0bddb7fe
get_baseline
2020-09-28 08:36:41 -06:00
cc7b3a1abd
[Docs] Address review comments
2020-09-26 10:22:39 +02:00
41b46a3cb2
Update hb-face.cc
2020-09-26 09:47:27 +02:00
726e320ece
Update inline doc for hb_face_create: explain index
2020-09-26 09:47:27 +02:00
70331ca485
[Docs] Minor
...
update GTK-Doc comments in hb-ot-layout.
2020-09-26 09:47:13 +02:00
eb10ef46aa
[Docs] Add GTK-Doc comments for hb-ot-font and hb-ot-shape.
2020-09-26 09:46:15 +02:00
3e72febde0
[Docs] Add GTK-Doc comments for hb-face.
2020-09-26 09:46:15 +02:00
88cdea60e0
[Docs] Add GTK-Doc comments to hb-shape-plan.
2020-09-26 09:46:10 +02:00
5b43eb5a4c
[Docs] Add GTK-Dod comments to hb-unicode.
2020-09-26 09:42:22 +02:00
a5c0ec7516
[subset] For [Chain]ContextFormat3 make sure the sub table intersects the retained glyphset before recursing to its lookups.
...
Otherwise the lookup closure will potentially pull in lookups which cannot be accessed via the retained glyph set.
2020-09-25 14:57:20 -07:00
dc375559fd
[subset] shrink the serialize buffer when pruning empty offsets in ChainContextFormat2.
...
Currently the code reduces the array length, but does not trim back the space allocated in the serializer for those empty offsets.
2020-09-25 13:08:46 -07:00
90eb1a40eb
[subset] In ChainContextFormat3 don't skip subsetting if backtrack or lookahead are empty.
...
It's valid to have a ChainContextFormat3 with either an empty backtrack or lookahead. Only drop the lookup if the input sequence is empty.
2020-09-25 12:36:32 -07:00
2604201ae0
src/meson.build: allow introspection when cross-compiling
...
introspection can be enabled when cross-compiling on certains conditions
(for example it is supported by buildroot) so, as suggested by
Tim-Philipp Müller, disable it by default for cross builds unless the
option was explicitly enabled by the user
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
2020-09-25 18:40:43 +02:00
df00f45e26
Fix annotation in previous commits
2020-09-24 11:57:46 +02:00
Garret Rieger
Qunxin Liu
Behdad Esfahbod
Khaled Hosny
Ben Denckla
Andrzej Perczak
David Corbett
justvanrossum
josephshen
ckitagawa
Nathan Willis
Ryan
Khaled Hosny
Dominik Röttsches
Myaamori
Khaled Hosny
Simon Cozens
Fabrice Fontaine
Laurenz
Koji Ishii
n8willis