Commit Graph

12831 Commits

Author SHA1 Message Date
Behdad Esfahbod 44da4e2a27 Revert "One more fix"
This reverts commit cab943a015.
2022-02-04 19:16:47 -06:00
Behdad Esfahbod 88798ee8be [GPOS] Disable split-kerning
Fixes https://github.com/harfbuzz/harfbuzz/issues/3408
Reverts https://github.com/harfbuzz/harfbuzz/pull/3235
Fixes https://github.com/harfbuzz/harfbuzz/pull/3235#issuecomment-1029814978
2022-02-04 19:01:57 -06:00
Behdad Esfahbod 9177953720 [atexit] Allow hb_atexit redefinition
Fixes https://github.com/harfbuzz/harfbuzz/issues/3412
2022-02-04 12:38:45 -06:00
Behdad Esfahbod 8670ffbf4c [buffer] Comment 2022-02-03 11:19:23 -06:00
Behdad Esfahbod e59da2871a [glyf] Don't store face in accelerator 2022-02-01 16:32:39 -06:00
Garret Rieger 0fb8e22406 [serialize] document how the serializer works. 2022-01-31 18:09:03 -06:00
Khaled Hosny 45df259538 3.3.1 2022-01-31 23:06:10 +02:00
Garret Rieger 4e2f409bce [subset] Don't hold references to members of the active_glyph_stack.
These references may get invalidated after the vector for the stack is resized. Fixes: https://oss-fuzz.com/testcase-detail/5422577634377728
2022-01-31 22:58:53 +02:00
Khaled Hosny 98da330638 3.3.0 2022-01-31 18:39:06 +02:00
Behdad Esfahbod 3e8742e376
Merge pull request #3402 from harfbuzz/language-tags
Make miscellaneous changes to hb-ot-tag-table.hh
2022-01-30 17:19:46 -08:00
David Corbett ae9afd9772 Let BCP 47 tag "mo" fall back to OT tag 'ROM ' 2022-01-30 14:32:59 -05:00
David Corbett a184c5f851 Don’t always inherit from macrolanguages
If an OpenType tag maps to a BCP 47 macrolanguage, that is presumably to
support the use of the macrolanguage as a vague stand-in for one of its
individual languages. For example, "ar" and "zh" are often used for
"arb" and "cmn". When the OpenType tag maps to a macrolanguage and some
but not all of its individual languages, that indicates that the
OpenType tag only corresponds to the listed individual languages (which
may be referred to using the macrolanguage subtag) but not the missing
individual languages. In particular, INUK (Nunavik Inuktitut) is mapped
to "ike" (Eastern Canadian Inuktitut) and "iu" (Inuktitut) but not to
"ikt" (Inuinnaqtun), so "ikt" should not inherit the INUK mapping from
its macrolanguage "iu".
2022-01-30 13:28:23 -05:00
Behdad Esfahbod b47b3b9972 [fallback-kern] Move buffer message to correct position 2022-01-29 10:24:38 -07:00
Behdad Esfahbod e986c12075 [verify] Show buffer input text when verification fails 2022-01-29 09:08:48 -07:00
Behdad Esfahbod d35f380126 [util] Change "All shapers failed." message to "Shaping failed."
Since we now emit this when verification fails as well.
2022-01-29 09:08:20 -07:00
Behdad Esfahbod 3972e0a8f1 [buffer] Whitespace 2022-01-29 08:22:19 -07:00
David Corbett 0b1bf89cc2 Replace “[family]” with “[collection]”
Not all language collections are language families.
2022-01-29 10:15:23 -05:00
David Corbett 0e31595e0d Infer tag mappings for unregistered macrolanguages
Every macrolanguage not mentioned in the OT language system tag registry
is mapped to every tag of its individual languages, if those have
registered tags.
2022-01-29 10:15:23 -05:00
David Corbett 5a6545940a Add the language system tag INUK 2022-01-28 21:29:43 -05:00
Garret Rieger bc899650c7 [subset] Fix for issue #3397.
cur_intersected_glyphs gets modified during recursion leading to incorrect filtering of sub tables in some cases. So don't use cur_intersected_glyphs. Instead just add an additional entry onto the parent_active_glyphs () stack.

Additionaly expands NotoNastaliqUrdu tests to include coverage of the issue from #3397.
2022-01-28 14:20:33 -08:00
Garret Rieger f3c1f4f0da [subset] convert active_glyphs_stack to be a vector of hb_set_t instead of hb_set_t*. 2022-01-28 14:20:33 -08:00
Behdad Esfahbod 476a6377a5 [buffer] Document HB_BUFFER_FLAG_VERIFY 2022-01-28 15:05:10 -07:00
Behdad Esfahbod 61856359cb [fuzz] Disable verification for now. 2022-01-28 14:07:29 -07:00
Behdad Esfahbod 6596e42d16 [fuzz] Verify shape results 2022-01-28 13:55:24 -07:00
Behdad Esfahbod 5b1d813b69 [config] Enable HB_NO_BUFFER_VERIFY in HB_LEAN 2022-01-28 13:53:44 -07:00
Behdad Esfahbod 61823838f9 [buffer] Add HB_BUFFER_FLAG_VERIFY
Move buffer verification code inside the library, from util/.

Part of https://github.com/harfbuzz/harfbuzz/issues/3010
2022-01-28 13:53:44 -07:00
Behdad Esfahbod 7c704d8982 [buffer] Make hb_buffer_append() take a const argument 2022-01-28 13:53:44 -07:00
Behdad Esfahbod 24650624c8 [font] Fix build with no-var configs 2022-01-28 13:53:21 -07:00
Behdad Esfahbod 91b779e23c Avoid redefinition of HB_NO_SETLOCALE in certain configs 2022-01-28 13:52:15 -07:00
Khaled Hosny fa29006bfa [doc] Fix generation of hb_glyph_flags_t docs
GTK-Doc does not like the empty lines here, and interprets everything
after the first empty line as the description of the enum itself not a
specific member and the generated text makes no sense.

Removing the empty lines makes the text harder to read (both in source
and HTML), but at least it is correctly organized.
2022-01-26 19:10:23 -08:00
Behdad Esfahbod e9cc5f6cdb
Merge pull request #3297 from harfbuzz/unsafe-to-concat
Implement UNSAFE_TO_CONCAT flag
2022-01-26 12:23:29 -08:00
Behdad Esfahbod 540af548dc [unsafe-to-concat] Clarify documentation as per feedback
Fixes https://github.com/harfbuzz/harfbuzz/pull/3297#discussion_r754395825
2022-01-25 09:10:56 -07:00
Behdad Esfahbod bad5c94562 [test] Remove HB_UNUSED 2022-01-23 10:53:19 -07:00
Behdad Esfahbod 6c09a8b5b0 [test-serialize] Assert len 2022-01-23 10:52:13 -07:00
Behdad Esfahbod 76c6f4164f [test] Add test-serialize 2022-01-23 10:43:37 -07:00
Behdad Esfahbod 3324606492 [buffer] Oops 2022-01-22 15:46:13 -07:00
Behdad Esfahbod 20031ddbb8 [unsafe-to-concat] Mark in all other shapers
unsafe_to_break() implies unsafe-to-concat; but setting the flag
manually wasn't.
2022-01-22 11:53:18 -07:00
Behdad Esfahbod 6e345f709d Cosmetic 2022-01-22 11:53:18 -07:00
Behdad Esfahbod 374a6f186d [fallback-shape] Add buffer trace log 2022-01-22 11:53:18 -07:00
Behdad Esfahbod bcdfedbc09 [unsafe-to-concat] Mark as unsafe in kern machine
Fixes that last test. Yay!
2022-01-22 11:53:18 -07:00
Behdad Esfahbod 14d43d1235 [unsafe-to-concat] Adjust end conditions 2022-01-22 11:53:18 -07:00
Behdad Esfahbod 8663eda4fd [unsafe-to-concat] More annotations for MarkMarkPos
Failures down to one:

265/401 harfbuzz:shaping+aots / lookupflag_ignore_attach         FAIL
2022-01-22 11:53:18 -07:00
Behdad Esfahbod 6a7d6d4b64 [unsafe-to-concat] More annotations for MarkLigaturePos 2022-01-22 11:53:18 -07:00
Behdad Esfahbod a575992057 [unsafe-to-concat] Mark LigatureSubst
Failures down to two:

209/401 harfbuzz:shaping+aots / gpos6                            FAIL             0.06s   exit status 1
265/401 harfbuzz:shaping+aots / lookupflag_ignore_attach         FAIL             0.06s   exit status 1
2022-01-22 11:53:18 -07:00
Behdad Esfahbod b443898cce [unsafe-to-concat] Adjust MarkBasePos
A couple more aots tests down. Four failing:

209/401 harfbuzz:shaping+aots / gpos6                            FAIL             0.06s   exit status 1
261/401 harfbuzz:shaping+aots / gsub4_1_multiple_ligatures       FAIL             0.07s   exit status 1
265/401 harfbuzz:shaping+aots / lookupflag_ignore_attach         FAIL             0.07s   exit status 1
267/401 harfbuzz:shaping+aots / lookupflag_ignore_combination    FAIL             0.07s   exit status 1
2022-01-22 11:53:18 -07:00
Behdad Esfahbod 95d052a791 [unsafe-to-concat] Adjust GPOS lookbacks
Fixes Cursive aots test, fails a couple new aots ones.
2022-01-22 11:53:18 -07:00
Behdad Esfahbod 909e34f68a [unsafe-to-concat] Adjust Arabic-joining start boundary condition more 2022-01-22 11:53:18 -07:00
Behdad Esfahbod 11bdd7a020 [unsafe-to-concat] Adjust CursivePos
Doesn't fix the test yet.
2022-01-22 11:53:18 -07:00
Behdad Esfahbod ea1b32c8c1 [unsafe-to-concat] Adjust "interior"ness of "from_out_buffer" 2022-01-22 11:53:18 -07:00
Behdad Esfahbod 4f04baef17 [unsafe-to-concat] Further adjust Arabic joining logic at boundary 2022-01-22 11:53:18 -07:00