a331e913dc
[bit-page] Hand-code equality
...
Faster than memcmp() because of alignment.
2022-11-26 14:59:37 -07:00
9df06a2695
[bit-set] Fix is_subset() short-circut criteria
...
Ouch!
2022-11-26 14:56:45 -07:00
915c1a00cf
[vector] Add remove_unordered
...
Saves 5% in NotoNastaliq/1000 subset benchmark.
2022-11-26 14:48:57 -07:00
4b8d8fbee4
[ot-map] Micro-optimize for size
2022-11-26 14:31:15 -07:00
93f3a9dbc6
[ot-map] Micro-optimize more
...
Another 500 bytes.
2022-11-26 14:25:21 -07:00
f39f049870
[ot-map] Micro-optimize
...
Weird that shrinks size by 500 bytes.
2022-11-26 14:16:15 -07:00
60bb32c454
[ot-map] Minor refactor
2022-11-26 14:12:57 -07:00
e3cc61838f
[PairPos] Adjust kerning buffer messages
2022-11-26 13:58:04 -07:00
a81dd1053d
[layout] Adjust printing feature tags
...
For required-feature, print spaces, not nul bytes.
2022-11-26 13:43:36 -07:00
56e3868b52
[layout/buffer-message] Print feature name in lookup buffer messages
2022-11-26 13:14:23 -07:00
a5d35fd80a
[subset] use charstrings directly from accelerator cache if mutability isn't needed.
2022-11-25 16:50:55 -07:00
026b64ef76
[subset-cff] Avoid set mallocation in hb_plan_subset_cff_fdselect
2022-11-25 14:57:40 -07:00
74acf52f33
[subset-cff] Micro-optimize copy_str more
2022-11-25 14:43:44 -07:00
d2f3cde7ef
[subset-cff] Micro-optimize copy_str
2022-11-25 14:38:30 -07:00
e333223f26
[array] Optimize serializing copy()
2022-11-25 14:26:02 -07:00
22990fca1d
Merge pull request #3894 from googlefonts/cff_accel
...
[subset] Cache parsed char strings in CFF accelerator
2022-11-25 14:12:58 -07:00
8d5c899b0f
[subset] In cff accelerator hold reference to CFF table instead of the whole font.
2022-11-25 20:53:20 +00:00
7b197446ac
[vector] Adjust for HB_OPTIMIZE_SIZE
2022-11-25 13:28:53 -07:00
75a99f28ab
[subset] destruct cff accelerator if present.
2022-11-25 20:24:05 +00:00
1d474194f0
[subset-cff] Micro-optimize encode_str
2022-11-25 13:21:35 -07:00
3c4a610b59
[subset-cff] Micro-optimize copy_str some more
2022-11-25 13:16:30 -07:00
535aadb309
[subset-cff] Micro-optimize collect_subr_refs_in_str more
2022-11-25 13:07:42 -07:00
00a9df3a43
[subset-cff] Micro-optimize collect_subr_refs_in_str
2022-11-25 13:05:05 -07:00
d2a2f5bf4e
[vector] Handroll copy
2022-11-25 12:44:02 -07:00
1fed366d5b
[serialize] Shut compiler warning off
2022-11-25 12:37:24 -07:00
f2297e6978
[buffer] Documentation
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/3889
2022-11-25 11:33:00 -07:00
71c23c1c07
[subset] don't copy the entire global/loca subr lists from the accelerator.
...
Instead run a closure on the retained charstrings and copy only the referenced subrs. This significantly speeds up cases with small character sets.
2022-11-25 18:05:39 +00:00
4ff09274a8
[subset] In CFF accelerator keep a reference to original face.
...
The charstring objects reference memory from the original face so we need to maintain a reference to prevent it from being destroyed.
2022-11-24 22:47:29 +00:00
6aaa16627c
[Coverage] Comment
2022-11-24 14:58:42 -07:00
06e2147a48
More call set->next() directly
2022-11-24 14:56:04 -07:00
196c9db06f
Call ->next() directly
2022-11-24 14:51:52 -07:00
03d64b7469
[bit-set] Remove TODO that would never happen
2022-11-24 14:33:18 -07:00
690df8a369
[bit-set] Micro-optimize prev()
2022-11-24 14:32:51 -07:00
fe5d9176ae
[bit-set] Micro-optimize size
...
It's silly that this saves size at all. :(
2022-11-24 14:30:18 -07:00
cf9b9929df
[bit-set] Micro-optimize process()
2022-11-24 14:26:28 -07:00
d77903db7b
[bit-set] Micro-optimize
2022-11-24 14:22:32 -07:00
13dd4b464b
[bit-set] Micro-optimize access
2022-11-24 14:20:42 -07:00
a3afa61ce8
[subset] use cached parsed char strings if available.
2022-11-24 21:14:00 +00:00
47c125845c
[subset] Cache parsed charstrings in the cff accelerator.
2022-11-24 21:14:00 +00:00
48b6837074
[subset] add a CFF specific accelerator object.
...
This allows CFF specific accelerator structures to be isolated to the CFF code.
2022-11-24 21:13:59 +00:00
d77f346d1a
[subset-cff] Minor rename
2022-11-24 14:02:46 -07:00
29a0fa089a
[subset-cff] Micro-optimize
2022-11-24 14:00:59 -07:00
d480ae1fac
[cff] Remove unused function
2022-11-24 13:53:43 -07:00
73046d53e5
[shaper] Disable dumber shaper if no AAT
2022-11-24 13:49:29 -07:00
e9f964c01a
[ot-face] Declare more tables as core
2022-11-24 13:38:53 -07:00
5bc27a128d
[machinery] Comment
2022-11-24 13:30:12 -07:00
d21bfb0861
[normalize] Remove an unlikely
...
Keep unlikely for truely unlikely scenarios.
2022-11-24 13:14:05 -07:00
9e1239f443
[config] Define HB_NO_VERTICAL in HB_LEAN and as such in HB_TINY
2022-11-24 13:00:47 -07:00
6f133ccfde
[glyf] Fix build with HB_NO_VERTICAL
2022-11-24 12:59:55 -07:00
76420ef769
[machine.rl] Remove unlikely from what happens 1/16 of the time
2022-11-24 12:52:15 -07:00
1248574454
[config] Disable Zawgyi shaper in HB_MINI/HB_TINY
2022-11-24 12:46:04 -07:00
05aa084e67
[PairPos] Another attempt at fixing unsafe-to-break with ValueFormat2
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/3888#issuecomment-1326781116
Test:
$ hb-shape XBRoya34.ttf ' الأ' --show-flags --script=arab
2022-11-24 12:14:09 -07:00
54ae3345b2
[buffer] Improve documentation of hb_buffer_add_codepoints()
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/3889
2022-11-24 12:00:36 -07:00
a4a4078632
Merge pull request #3893 from googlefonts/preprocess_test
...
[subset] Fix testing of preprocess
2022-11-24 11:56:58 -07:00
0c70bc7f32
[skippy-iter] Fix two logic errors
...
First, a signed underflow.
Second, a wrong condition.
Both were introduced in 42681bdb55
2022-11-24 11:48:48 -07:00
3b43096ef3
[buffer] Whitespace
2022-11-23 22:04:02 -07:00
094f80738a
[buffer] Handle null buffer in set_message_func
2022-11-23 22:03:26 -07:00
1fa64c0c23
[gsubgpos] Conditionalize skippy on unsafe-to-concat
2022-11-23 21:38:51 -07:00
42681bdb55
[gsubgpos] No logic-change minor rewrite
2022-11-23 21:36:43 -07:00
c15efdec49
[gsubgpos] Comment
2022-11-23 21:14:28 -07:00
7ec1c41a55
[gsubgpos] Skippy-iter: Prefer correctness to performance
...
Prefer unsafe-to-concat correctness, over performance.
2022-11-23 21:12:41 -07:00
dce3502e10
[array] Add commented-out static asserts
...
They don't work.
2022-11-23 18:34:54 -07:00
a7fee43cef
[priority-queue] Minor micro-optimize
2022-11-23 17:46:32 -07:00
ff3cac0ccd
[subset] Fix unecessary trailing 0 bytes left by ContextFormat2 pruning.
...
Uneeded rules where beind removed from the count by the bytes for them was being left in the font.
2022-11-23 23:50:49 +00:00
f2851e4157
[test-map] Test has() getter with unique-ptr
2022-11-23 16:50:30 -07:00
5f3a780614
[font] Protect against div-by-zero
2022-11-23 16:45:46 -07:00
060ecac949
[font] Respect subfont slant setting in hb-draw
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/3890
2022-11-23 16:31:37 -07:00
51028e63e6
[subset] Retain all glyphs in preprocessed face.
2022-11-23 22:51:16 +00:00
404cb99d86
[buffer-diff] Fix check for glyph flag equality
...
I'm not sure if the old behavior was intentional, but it was checking
that the glyph flags were a subset of the reference buffer's glyph
flags. I don't see why that is useful. Fix that.
Then make the buffer-verify code ignore flag differences when verifying
buffers, since our unsafe-to-concat flag at least, is conservative and
not guaranteed to be produced the same in fragments. See:
https://github.com/harfbuzz/harfbuzz/issues/3888
2022-11-23 15:37:03 -07:00
4c49daf7cd
[subset] actually use the preprocessed face in hb-subset.
...
Tests weren't actually using the preprocessed face due to this typo in util/hb-subset.
2022-11-23 22:33:57 +00:00
2c0afde737
[subset] add an inprogress accelerator to plan.
...
This allows subset code to cache information into the accelerator during preprocess subset. Previously the accelerator was created at the end of subsetting.
2022-11-23 13:41:52 -07:00
81640fdffe
[subset] fix leaked font in glyf::subset(...)
2022-11-23 13:41:52 -07:00
dcce53ddcb
[cff] Micro-optimize fetch_op
2022-11-23 13:20:48 -07:00
0bf7d9eb4d
[subset-cff] Micro-optimize encode_byte
2022-11-23 13:20:48 -07:00
a23f820427
[subset-cff] Micro-optimize array access
2022-11-23 13:20:48 -07:00
1e8f1ac677
[subset-glyf] Micro-optimize array access
2022-11-23 13:20:48 -07:00
356d135ed6
[subset-glyf] Reduce roundf calls
...
Saves 7% on MPLUS1-Variable/6000 benchmark.
2022-11-23 13:20:48 -07:00
463ae07e99
[subset] In the preprocess subset call always use long loca.
...
Long loca is needed so that we can store the trimmed glyph bytes to allow us to safely skip trimming in the later subset.
2022-11-23 12:52:55 -07:00
299ec902eb
[glyf] Move instanciation to serialize()
2022-11-22 16:03:02 -07:00
d8d881f22d
[subset-glyf] Don't create a second glyf accelerator
2022-11-22 15:24:16 -07:00
7560930070
[glyf] Add _create_font_for_instancing
2022-11-22 15:22:25 -07:00
40634ceeb0
[glyf] Adjust data types
2022-11-22 15:07:16 -07:00
ba0d28ea36
[glyf] Fix font error check
2022-11-22 15:01:48 -07:00
04c525019c
[glyf] Use a malloc instead of calloc
2022-11-22 14:54:55 -07:00
024aa81805
[glyf] Micro-optimize encode_coord
2022-11-22 14:51:42 -07:00
b6694597f9
[glyf] Micro-optimize encode_flag()
2022-11-22 14:49:01 -07:00
d47cfe7936
[glyf] Minor use operator ++
2022-11-22 14:45:04 -07:00
03e6bde790
[glyf] Minor adjustment to lastflag handling
...
No logic change.
2022-11-22 14:40:50 -07:00
0ca9fda889
[glyf] Remove misplaced comment
2022-11-22 14:39:10 -07:00
44be8ef4ce
[gvar] Skip degenerate all-untouched delta-sets
2022-11-22 14:21:25 -07:00
656bb223f1
[gvar] Micro-optimize unpack_points
2022-11-22 14:16:40 -07:00
a383027262
[gvar] Cosmetic
2022-11-22 14:15:17 -07:00
be89919a70
[gvar] is_valid() remove a check
...
I don't know why this check was there, but it doesn't make sense
because that function never returns 0 / false.
2022-11-22 13:56:20 -07:00
e8ddf107d0
[gvar] Optimize a loop
2022-11-22 13:29:32 -07:00
dd6fcec92c
[gvar] Remove a conditional
2022-11-22 13:27:40 -07:00
a02317238a
[gvar] Refactor deltas array access
2022-11-22 13:24:39 -07:00
c34c77698c
[gvar] Don't try IUP if all points are specified
2022-11-22 13:21:01 -07:00
27c4037e59
[gvar] Micro-optimize boundary-checking
2022-11-22 13:12:22 -07:00
ab8346fb6f
[gvar] Add an unlikely
2022-11-22 13:07:39 -07:00
1e8a342ea2
[gvar] Micro-optimize int types
2022-11-22 13:04:32 -07:00
4afcdf675b
More hb_memcpy
2022-11-22 12:56:48 -07:00
58a696d80e
More hb_memset
2022-11-22 12:56:05 -07:00
59c45f6deb
Use hb_memcpy instead of memcpy consistently
2022-11-22 12:54:50 -07:00
ac0efaf818
Use hb_memset instead of memset consistently
2022-11-22 12:50:36 -07:00
44a892a233
[shape] Use hb_memcmp instead of memcmp
2022-11-22 12:48:52 -07:00
c53c648127
[subset-cff] Another handrolled memcpy
2022-11-22 12:46:25 -07:00
ae578705c2
[array] Write hash as range for loop again
...
Now that our range loop is faster than our own iter.
2022-11-22 12:23:17 -07:00
13e1ca9eb5
[cff] Micro-optimize memcpy
2022-11-22 12:19:28 -07:00
2968dd7844
[gvar] Optimize as_array() access
2022-11-22 11:57:29 -07:00
bb3bb76450
[gvar] Optimize scalar = 1.0 case
2022-11-22 11:53:35 -07:00
2d098d5d7f
[gvar] Use memset
2022-11-22 11:51:04 -07:00
e630a65e60
[gvar] Micro-optize vector extend
2022-11-22 11:29:13 -07:00
49d4f62135
[gvar] Micro-optimize
2022-11-22 11:14:56 -07:00
1758ee6646
[glyf] Minor write loop more idiomatically
2022-11-22 10:55:16 -07:00
16ec9dcc1b
[gvar] Whitespace
2022-11-22 10:55:16 -07:00
b567ce51d3
[subset] Don't trim glyf's again if preprocessed
...
Speeds up M1/10000 benchmark by 30%!
2022-11-22 10:55:08 -07:00
72059a4789
[gvar] Optimize IUP alg
2022-11-22 10:41:37 -07:00
ee9873b5ed
[gvar] Disable initializing vectors when not necessary
2022-11-22 10:23:17 -07:00
b0d2641186
[vector] Add "initialize" argument to resize()
2022-11-22 10:20:11 -07:00
a2059f8f55
[gvar] Optimize unpack_points
2022-11-22 10:16:21 -07:00
6d7206b68b
[gvar] Optimize unpack_deltas
2022-11-22 10:13:14 -07:00
bca569ae53
[array] Speed up hash() for byte arrays
2022-11-21 23:19:42 -07:00
d7b492e3f5
Revert "[array] Remove hash specializations for bytes"
...
This reverts commit 213117317c
2022-11-21 23:08:51 -07:00
1572ba281a
[subset-cff] Return in subr closure if already seen subr
...
Not sure why this was not done before.
2022-11-21 22:26:44 -07:00
a29ca6efbc
[subset-cff] Comment
2022-11-21 22:02:17 -07:00
28e767ddea
[subset-cff] Really optimize op_str_t / parsed_cs_op_t layout
...
Now parsed_cs_op_t and op_str_t are both 16 bytes.
Saves another 7% in SourceHanSans/10000 benchmark.
2022-11-21 21:59:51 -07:00
2d5ee23731
[subset-cff] Readjust parsed_cs_op_t
...
Now it doesn't matter anymore since op_str_t is adjusted and
is 16 bytes with 8byte alignment.
2022-11-21 21:55:21 -07:00
4f056b923a
[subset-cff] Optimize op_str_t layout
2022-11-21 21:37:57 -07:00
a750cb0128
Simplify rvalue creation
2022-11-21 21:03:32 -07:00
86a763c651
[map] Make keys moveable
2022-11-21 20:53:44 -07:00
cf20d2ec5d
[map] Take const key
2022-11-21 20:47:17 -07:00
3d1c76f713
[serializer] Don't hash objects twice
2022-11-21 19:40:32 -07:00
35878df215
[algs] Implement swap() for pair_t
...
Helps priority_queue::pop_minimum and friends, which help subsetter
repacker. Shows a few percentage improvement on NotoNastaliq benchmark.
2022-11-21 19:14:03 -07:00
a2984a2932
[cff] Remove unnecessary namespacing
2022-11-21 18:40:52 -07:00
dc3bb5e0ed
[subset-cff] Pre-allocate values array for subroutines as well
2022-11-21 18:18:48 -07:00
c6279224db
[cff] Adjust pre-allocation
...
This better matches actual usage, given that ops are one or two
bytes, and vector also allocates 50% extra.
2022-11-21 18:01:50 -07:00
bab8ec58b0
[subset-cff] Disable sharing when packing charstring INDEXes
...
Saves another 8%ish.
2022-11-21 17:46:32 -07:00
2cadacad6c
[cff] Simplify str_encoder_t error handling
2022-11-21 17:17:15 -07:00
f263e3fe2e
[cff] Manually copy short strings instead of memcpy()
2022-11-21 17:04:55 -07:00
38efd1862f
[cff] Add a likely()
2022-11-21 17:02:11 -07:00
191025cc96
[cff] Adjust buffer pre-allocation
...
Most ops take one or two bytes, so allocate count*2, not count*3.
Shows minor speedup in subsetting benchmark (around 2%).
2022-11-21 16:58:19 -07:00
4b2caafea2
[subset-cff] Optimize parsed_cs_op_t size
...
Shows 5% speedup on SourceHanSans-Regular/10000 benchmark.
2022-11-21 16:46:20 -07:00
e0b06bd1b1
[subset] Cache has_seac in accelerator
...
Speeds up SourceHanSans-Regular/10000 benchmark by %25.
2022-11-21 16:30:34 -07:00
dd1ba328a8
[repacker] fix fuzzer timeout.
...
For https://oss-fuzz.com/testcase-detail/5845846876356608 . Only process the set of unique overflows.
2022-11-21 16:24:48 -07:00
59451502e9
[cff] Optimize env error checking
2022-11-21 15:23:16 -07:00
b238578a9c
[cff] Optimize INDEX operator[]
2022-11-21 14:36:57 -07:00
d9de515a38
[cff] Optimize byte_str_ref_t array access
2022-11-21 14:23:07 -07:00
a81ec9b2b6
[cff] Optimize byte_str_ref_t inc()
...
Shows a couple percent speedup.
2022-11-21 14:03:28 -07:00
3ff75411bd
[algs] Fix bot fail
2022-11-21 13:08:55 -07:00
b81e3989f8
Try fixing arm-eabi build after a10cfe3f32
2022-11-21 13:02:40 -07:00
4c14043b06
[algs] Add output argument to hb_unsigned_mul_overflows()
2022-11-21 12:56:33 -07:00
25adbb3825
[algs] Use __builtin_mul_overflow
...
Compiles to smaller binary.
2022-11-21 12:47:53 -07:00
a10cfe3f32
[algs] Write hb_in_ranges() recursively
2022-11-21 12:37:59 -07:00
2e86700e30
[gvar] Add memory-barrier as in ArrayOf
2022-11-21 12:28:10 -07:00
b00a911fa7
[sorted-array] Add faster iterator implementation here as well
2022-11-21 12:11:30 -07:00
7cc79a8a86
[vector] Adjust comment
2022-11-21 12:09:24 -07:00
e82a3c69dd
[array/vector] Optimize range-based for-loop
...
Avoid bounds-checking.
2022-11-21 12:00:10 -07:00
0387182c2a
[ot-map] Minor refactor features[i] access
2022-11-21 11:05:47 -07:00
5ee6d5d77e
[cff] Add memory-barrier to INDEX
...
Like we do for ArrayOf.
2022-11-21 11:00:29 -07:00
6905d36d73
[cff] Fix fetch_op() bounds-checking
2022-11-21 10:51:33 -07:00
b51ab1a9e5
[cff] Optimize byte_str_ref_t
...
Make it 16 bytes instead of 24. This struct is used in the subroutine
call stack heavily.
This change makes the HB AdobeVFPrototype benchmark to become faster
than FT one, with about 6% speedup as a result of this change.
2022-11-21 10:27:07 -07:00
7a39464b18
[cff] Hide members of byte_str_ref_t
2022-11-21 09:48:54 -07:00
18141f0007
[cff] Move a sub_array call
...
No logic change.... I hope?!
2022-11-21 09:47:03 -07:00
f66415cdd1
[cff] Move initialization of a type to constructor
2022-11-21 09:40:16 -07:00
70a5cd53f6
[algs] Assert trivial copy assignable in stable_sort
2022-11-21 08:52:33 -07:00
9bb39423f5
[algs] Simplify stable_sort signatures
2022-11-20 17:40:54 -07:00
d119568df6
[cbdt] Use vector tail()
2022-11-20 14:11:51 -07:00
87a88117c8
[object] Use vector tail()
2022-11-20 14:10:39 -07:00
76ce390b5a
[ucd] Document algorithms
2022-11-20 13:54:56 -07:00
ed43bc5118
[buffer] Move delete_glyphs_inplace() here
2022-11-20 13:10:19 -07:00
dd88dae8a9
[unicode] Simplify set_funcs a bit more
2022-11-19 15:23:53 -07:00
2d8ff3bcbe
[unicode] Destroy user_data in set_funcs fail paths
...
This is what the font_funcs / draw_funcs do.
2022-11-19 15:23:44 -07:00
527823ccac
[unicode] Destroy user_data in set_funcs fail paths
...
This is what the font_funcs / draw_funcs do.
2022-11-19 15:19:08 -07:00
56d6b6992b
[font/draw] Remove unneeded branch
...
The preamble sets user_data/destroy to nullptr if func is nullptr.
2022-11-19 15:11:59 -07:00
976bb26cc1
[draw] Optimize set_func functions
2022-11-19 15:06:23 -07:00
114167a933
[font] Optimize set_func functions
2022-11-19 14:47:45 -07:00
f9d7b303ed
[thai] Use smaller type for arrays
...
No logic change.
2022-11-19 14:20:36 -07:00
72c4e431af
[use-table] Add a OPTIMIZE_SIZE version
2022-11-19 13:40:33 -07:00
83c3a91dc6
[gen-use-table] Report fullCost
2022-11-19 13:34:58 -07:00
ba08de624e
[ucd] Change OPTIMIZE_SIZE to compression level 9
...
Also changes default compression level from 3 to 5, but that shows
no change in the generated table size.
2022-11-19 13:25:19 -07:00
b68f9f3cfe
[machinery] Adjust comment
2022-11-18 21:36:01 -07:00
a47ba1dc0e
[lazy-pointer] Hide instance
2022-11-18 21:14:07 -07:00
281b4705b4
[pool] Rewrite a loop as dagger
2022-11-18 20:25:05 -07:00
3ff8abf272
Revert "[map] Allow std::move-ing keys into the map"
...
This reverts commit f657ef7e57
2022-11-18 19:38:12 -07:00
039e476bac
[test-vector] Test sink-move'ing
2022-11-18 19:26:02 -07:00
a3a218edb5
[map] Add a couple more sink interfaces
2022-11-18 19:24:41 -07:00
90226eab89
[test-map] Test inserting shared_ptr key
2022-11-18 19:21:58 -07:00
f657ef7e57
[map] Allow std::move-ing keys into the map
2022-11-18 19:17:03 -07:00
a1768ad829
[map] Fix use of !=
2022-11-18 19:08:34 -07:00
e74b372b59
[test-map] Test moving values
2022-11-18 18:43:31 -07:00
a9c6a20b19
[map] Support moving value in sink interface
2022-11-18 18:29:12 -07:00
1bf9afaad0
[test-vector] Test sink interface
2022-11-18 18:20:50 -07:00
fa0e4b041d
[test-map] Test sink interface
2022-11-18 18:20:14 -07:00
1c612a8541
[test-set] Test sinking range
2022-11-18 18:19:31 -07:00
356708e34a
[test-set] Test length of iterator
2022-11-18 18:17:34 -07:00
2892fc71e8
[vector] Add std::move to pop()
...
This was removed in 76fc27713f
2022-11-18 18:03:59 -07:00
921f45f46d
[array] Rewrite hash() as dagger
2022-11-18 17:26:58 -07:00
213117317c
[array] Remove hash specializations for bytes
...
Not needed.
2022-11-18 17:24:44 -07:00
bef5a1c8dc
[vector] Comment
2022-11-18 17:22:17 -07:00
69b41f92ec
[vector] Simplify shift_down_vector()
...
Compiler is smarter than I am.
2022-11-18 17:04:34 -07:00
1dd9396c7a
[vector] Optimize grow_vector() for size
...
Again, compiler is smarter than I am.
2022-11-18 17:01:14 -07:00
d36f688131
[vector] Optimize shrink_vector for size
...
Compiler is smarter than I am.
2022-11-18 17:00:07 -07:00
bc8eded296
[vector] Remove a for loop
2022-11-18 16:51:24 -07:00
afd9a58bd7
[vector] Save a couple hb_iter() invocations
2022-11-18 16:47:32 -07:00
3ead9863d2
[map] Add size()
2022-11-18 16:43:47 -07:00
42db8be189
[map] Minor remove if condition
2022-11-18 16:41:50 -07:00
4ec706980c
[map] Rewrite hash() as dagger
...
Somehow our daggers instead of for loop save size. I cannot
pinpoint why, other than maybe not inlining.
2022-11-18 16:39:30 -07:00
025a68cb07
[map] Optimize copy resizing logic
2022-11-18 16:33:04 -07:00
f1d716871d
[map] Change bucket_for_hash() to item_for_hash()
2022-11-18 16:31:27 -07:00
d012f9a9b3
[map] Change bucket_for() to item_for()
2022-11-18 16:29:06 -07:00
68a29020c5
[bit-page] Write hash() as dagger
2022-11-18 16:02:45 -07:00
87271e1b2e
[bit-page] Write get_population as dagger
2022-11-18 16:01:23 -07:00
744eb6baf9
[bit-page] Write is_empty() as dagger
2022-11-18 15:56:06 -07:00
43a4028f0e
[algs] Move hb_vector_size_t to bit-page as only user
2022-11-18 15:54:34 -07:00
01f961ac3a
[gsubgpos] Minor call hb_iter() instead of ->iter() directly
2022-11-18 15:47:17 -07:00
bba5765583
[gsubgpos] Remove a few unnecessary namespace invocations
2022-11-18 14:52:17 -07:00
b4d0d1608d
[gsubgpos] Rewrite a couple apply() functions as daggers
2022-11-18 14:47:33 -07:00
76c8214eb5
[gsubgpos] Move member around
2022-11-18 12:30:46 -07:00
81a573008e
[map] Optimize storage
2022-11-17 16:59:36 -07:00
ae080bf202
[map] Initialize key and value explicitly
...
If they are of int time they won't be initialized otherwise.
2022-11-17 16:34:58 -07:00
1d41b9cb3c
[user-data] std::move item
2022-11-17 16:26:48 -07:00
ff0bb74895
[map] Call item_t constructor/destructor directly
2022-11-17 16:17:37 -07:00
5c88715949
[map] Add item_t.destruct()
2022-11-17 16:14:16 -07:00
7f83040836
[map] Simplify (de)construction of item_t
2022-11-17 16:10:37 -07:00
99103bd976
[map] Destruct objects when clearing
2022-11-17 15:57:06 -07:00
4caad5720c
[test-map] Add test for reset
...
I expect this to leak now, since we don't destruct items.
2022-11-17 15:51:39 -07:00
e93c01c3ae
[map] Rename item clear() to construct()
2022-11-17 15:50:00 -07:00
fc22d706fe
[test-map] Don't insert null smart-pointers in map
...
Dereferencing them is not supported anymore after
3aad7c2ddf
2022-11-17 15:47:43 -07:00
896377463f
[map] Don't resize map if not necessary
2022-11-17 15:25:45 -07:00
7595fa2d9a
[map] Fix copy-assignment operator
...
Ouch!
2022-11-17 15:23:14 -07:00
41f4bdac35
[map] Fix resize during copy-construction/assignment
2022-11-17 15:16:00 -07:00
3aad7c2ddf
[algs] Remove smart-pointers from hb_hash()
...
hb_deref() handles them. I think this code predated that.
2022-11-17 15:10:47 -07:00
7bd101728a
[map] Minor use hb_iter instead of hb_array
2022-11-17 15:01:55 -07:00
238fc14716
[map] Simplify iterators
2022-11-17 14:58:50 -07:00
410c14bfa2
[map] Fix equality
...
Ouch!
2022-11-17 14:53:00 -07:00
6dfd4a16e7
[ot-font] Remove stale TODO
2022-11-16 22:44:22 -07:00
a0bde1e1ea
[open-type] Remove (Sorted)ArrayOf.sub_array()
2022-11-16 21:27:12 -07:00
f2b5db700f
[vector] Remove .sub_array ()
2022-11-16 21:22:57 -07:00
c7d57dcf26
[vector/array] Simplify qsort()
2022-11-16 21:21:31 -07:00
1610008e62
[gsubgpos] Minor remove call to hb_iter
2022-11-16 20:02:36 -07:00
19ec01d25c
[gsubgpos] Sprinkle const around
2022-11-16 19:14:42 -07:00
561946c7d5
[layout] Comment
2022-11-16 17:59:29 -07:00
2268207c19
[layout] Update comment
2022-11-16 17:51:22 -07:00
658f8f4391
[layout] Comment
2022-11-16 17:50:35 -07:00
27a8fe7d58
[layout] Only update buffer digest if buffer changed by a pause
2022-11-16 17:49:44 -07:00
8b2a211123
[layout] Keep digest updated in the context
...
Don't recompute digest after every (applied) GSUB lookup.
2022-11-16 16:57:44 -07:00
a5964a2d2a
[layout] Minor simplify
2022-11-16 16:45:23 -07:00
80b8758881
[layout] Add a buffer message for digest-skipped lookups
2022-11-16 16:26:41 -07:00
afa71ee8ef
Fix alignment error
2022-11-16 16:22:45 -07:00
dff1b809a0
[buffer] Add .digest() and use
2022-11-16 16:19:05 -07:00
654a2eafc8
[layout] Use buffer-digest for GSUB as well
...
Combined with previous commit, this shows up to 12% speed up with
Roboto and the en-words (ie. short strings) benchmark, about 5%
for longer English tests, and no adverse effect on heavier fonts.
2022-11-16 16:13:52 -07:00
15b6c32599
[layout] Use a buffer digest for GPOS to skip whole lookups
2022-11-16 16:11:36 -07:00
a053b84cb9
[gsubgpos] Optimize set-digest initialization
...
Previously we were once collecting set-digest for each subtable,
and another time for each lookup.
Now we compute the one for each lookup simply from the ones for
its subtables.
2022-11-16 14:39:25 -07:00
20654cd889
[set-digest] Minor no logic change
2022-11-16 14:29:10 -07:00
95b9763dbc
[set-digest] Minor simplify
2022-11-16 14:15:01 -07:00
9855b678f2
[cache] Minor rewrite assertion
2022-11-16 13:37:34 -07:00
a10ff20562
[ft] Comment
2022-11-16 13:34:37 -07:00
557be9502a
[test-vector] Fix test
2022-11-16 12:47:05 -07:00
9027d15410
[test-iter] Fix leak
2022-11-16 12:39:30 -07:00
afd716d4cd
[serialize] Don't free object-pool in reset()
2022-11-16 12:28:56 -07:00
02949cf64f
[priority-queue] More assert adjustment
2022-11-16 12:06:44 -07:00
620ddd762d
[priority-queue] Fix asserts
2022-11-16 12:04:35 -07:00
57de568aad
[indic-table] Minor adjust empty lines
2022-11-16 11:50:40 -07:00
281a2602cc
Update generated file
2022-11-16 11:36:33 -07:00
f734c26c5c
[test-vector] Test inserting set and map
2022-11-15 16:27:56 -07:00
0a97d27c2b
[test-iter] Add another test
2022-11-15 16:23:48 -07:00
e9e985682a
[fallback-shape] Remove TODO
2022-11-15 16:11:57 -07:00
6df8498da2
[sample.py] Fix warning
2022-11-15 15:52:04 -07:00
49fe5c1e5a
[glib] Remove old cruft from pre-2011
2022-11-15 15:37:23 -07:00
1bd1a37837
[test] Minor
2022-11-15 15:18:36 -07:00
35aa492eb7
[main] sprintf -> snprintf
2022-11-15 15:05:15 -07:00
72c6962012
[buffer-deserialize-text] Fix glyph name for glyph flags
...
Skip "#" in glyph names.
2022-11-14 21:34:16 -07:00
dee26de76f
[test-buffer-serialize] Allow no font
2022-11-14 16:24:25 -07:00
f6076890c5
Hide all mentions of name_table_overrides behind EXPERIMENTAL_API
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/3872
2022-11-14 16:06:39 -07:00
ebc382a847
Revert "Avoid use values () in hb-hashmap if value_t has an overriden operator &"
...
This reverts commit b92e4cc009
2022-11-14 15:59:46 -07:00
ff0d0d020e
[meta] Use std::decay
2022-11-14 14:48:07 -07:00
24cf86b009
[array] Fix MSVC fail
2022-11-14 13:58:43 -07:00
a87843be3d
[array] Another try at sizeof sorted_array
2022-11-14 13:43:58 -07:00
72ba0b2aa2
[array] Fix MSVC fail
2022-11-14 13:41:15 -07:00
b92e4cc009
Avoid use values () in hb-hashmap if value_t has an overriden operator &
2022-11-14 13:19:55 -07:00
ea63e95e4c
[GPOS.PairPos] Adjust unsafe-to-break for non-zero ValueFormat2
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/3824
2022-11-14 12:36:48 -07:00
85e0be1357
[vector/array] Add simple test for sorted size
2022-11-13 17:28:09 -07:00
4e618557a6
[vector] Don't subclass sorted vector from unsorted
...
Was doubling the size unnecessarily.
2022-11-13 17:23:25 -07:00
630f09c8b6
Another hb_memcpy instead of strncpy use
2022-11-09 11:32:30 -07:00
cd011ceadf
Use hb_memcpy instead of strncpy
...
Nul-termination is not intended.
2022-11-09 11:30:44 -07:00
c158b626c3
[name] Simplify buffer-length calculation
2022-11-08 15:05:31 -07:00
55edf59d52
[name] Typo
2022-11-08 14:53:27 -07:00
27c8bbcb04
Revert "[name] Simplify buffer-length calculation"
...
This reverts commit d70595657e
2022-11-08 14:48:38 -07:00
d70595657e
[name] Simplify buffer-length calculation
2022-11-08 14:15:56 -07:00
6314aa7da4
[subset] add an experimental API that can override name strings for specified name_id
2022-11-08 14:10:25 -07:00
f53ef69d59
[indic] Order left-matras inside-out
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/3863
2022-11-05 15:40:05 -06:00
dbb7f47b19
fix bug in hb_hashmap_t has() interface
...
It was not working when the value type is hb_bytes_t because hb_array_t
overloaded operator &
2022-11-03 13:48:23 -06:00
d1f445ec1e
[name] Typo
2022-11-02 12:24:04 -06:00
fc935fb81b
Fix snprintf use
...
https://github.com/harfbuzz/harfbuzz/pull/3495#issuecomment-1299107964
2022-11-01 14:40:47 -06:00
2ee42bbac2
hb_variation_to_string: Fix GIR annotation
2022-11-01 11:21:25 -06:00
02b76393ef
[config] Re-enable BORING_EXPANSION
...
Only the non-experimental parts (currently avar2) are
enabled by default.
2022-10-29 11:19:04 -06:00
6a47ef34b1
[config] If not HB_EXPERIMENTAL, then HB_NO_BEYOND_64K
2022-10-29 11:14:27 -06:00
a0f999cd95
[config] Rename HB_NO_VARIATIONS2 to HB_NO_AVAR2
2022-10-29 11:13:40 -06:00
60c6b7786d
Disable -Wcast-function-type-strict
...
https://github.com/harfbuzz/harfbuzz/pull/3859#issuecomment-1295409126
2022-10-28 14:19:39 -06:00
d88269c827
freetype: Fix function signatures to match without casts
...
Clang 16 has got a new stricter warning for casts of function types
(see 1aad641c79
2022-10-28 13:49:41 -06:00
8a5524833c
[instance] update OS2/.usWeightClass and .usWidthClass when
...
no-prune-unicode-ranges option is enabled
2022-10-27 11:59:31 -06:00
fddeba26e4
Merge pull request #3857 from 2xsaiko/outgoing/cmake-abs-path
...
Pass through absolute paths to cmake config directly
2022-10-26 22:34:02 +02:00
db292f6f02
Pass through absolute paths to cmake config directly
...
The previous code concatenates includedir to _harfbuzz_prefix verbatim,
which results in a wrong final include path in case includedir is an absolute
path. Instead, we can let meson determine the absolute include and lib paths
in advance and save them in the cmake config.
This is an issue in nixpkgs, where includedir is set to the final (absolute)
path of the built library in the Nix store, which causes CMake projects
depending on harfbuzz to not configure.
See https://github.com/NixOS/nixpkgs/issues/180054 .
2022-10-26 22:13:44 +02:00
477d71724c
[glyf] Limit points in a glyf to 10000 roughly
...
Only enforced when components are being expanded.
Fixes https://github.com/harfbuzz/harfbuzz/issues/3838
2022-10-26 13:11:47 -06:00
9aad3dba8f
[SingleSubst] Fix degenerate-lookup test
...
Part of https://github.com/harfbuzz/harfbuzz/issues/3853
2022-10-26 13:04:02 -06:00
83769b9cb1
[subset] add comment for why we retain empty lookups.
2022-10-21 18:29:23 -06:00
70e2de2bd4
[subset] Always output Lookup's even if they are empty.
...
The rest of layout subsetting depends on lookup indices being consistent with those computed during planning. So if an empty lookup is discarded during the subset phase it will invalidate all subsequent lookup indices. Generally we shouldn't end up with an empty lookup as we pre-prune them during the planning phase, but it can happen in rare cases such as when a subtable is considered degenerate (eg. #3853 )
2022-10-21 18:29:23 -06:00
c813f84235
Make build work for arm-none-eabi
2022-10-21 11:09:35 -06:00
b0b7a65388
[subset] Fix check-symbols failure
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/3850
2022-10-20 17:13:26 -06:00
970321db7b
5.3.1
2022-10-19 22:06:46 +02:00
a73137d101
[face] Fix annotation
2022-10-17 12:18:24 -06:00
d65af60213
[shape] Adjust Grapheme clusters for Katakana voiced sound marks
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/3844
2022-10-15 14:26:02 -06:00
bda42fc34a
Merge pull request #3842 from harfbuzz/patch_mode
...
[subset] Begin implementing a subset accelerator
2022-10-14 15:08:22 -06:00
f53ebf5584
[subset] Add hb_subset_preprocess to experimental symbol list for check-symbols.
2022-10-14 19:38:19 +00:00
fdb98ed88e
[subset] add missing HB_EXTERN.
2022-10-14 18:30:39 +00:00
515863e57c
[subset] Remove add accelerator flag, replace with new api method.
...
Adds hb_subset_preprocess() which preprocesses the face and attaches accelerator data.
2022-10-13 23:42:00 +00:00
573640c99f
[subset] Add hb-subset-accelerator.hh to Make soure list.
2022-10-13 23:21:35 +00:00
a756bd1944
[glyf] Use component phantom points after transformation
2022-10-13 17:18:19 -06:00
82d19c08fc
Revert "[glyf/Composite] Remove phantom points when not needed anymore"
...
This reverts commit 527e63a3bd
2022-10-13 17:17:03 -06:00
527e63a3bd
[glyf/Composite] Remove phantom points when not needed anymore
2022-10-13 17:13:40 -06:00
f4903defc4
[subset] use the accelerator in the subsetting benchmark.
2022-10-13 21:38:54 +00:00
01481db582
[subset] use accelerator unicode to gid map if available.
2022-10-13 21:12:22 +00:00
4ec5eb955f
[subset] add a subset accelerator.
...
Can be optionally attached to the face during subsetting. Contains data which can accelerate future subsets.
2022-10-13 19:40:31 +00:00
f105c28749
[subset] Suggested flags to enable more performant subset production for use in incxfer.
2022-10-13 18:53:41 +00:00
5769d422c5
[type] Add HBFixed template
2022-10-13 12:12:24 -06:00
8c29dcaee4
s/HBFixed/F16DOT16/g
2022-10-13 12:06:15 -06:00
294b1c9f6e
Use snprintf instead of sprintf
2022-10-13 11:30:02 -06:00
9559d3c1c1
[repacker] fix incorrect coverage table size estimation.
...
During splitting of PairPosFormat2 the code was assuming the maximum size of the generated coverage table would be equal too the current size. This is incorrect size the new coverage table may not preserve the ranges found in the original coverage table (since we are splitting based on class, not coverage) and in the worst case may convert from format2 to format1. So use the size of a format1 table as the max size.
2022-10-11 14:06:04 -06:00
3ce4b8f5c9
5.3.0
2022-10-08 19:10:07 +02:00
99f4668e19
[repacker] use mutable copies of Coverage/ClassDef in MarkBasePos shrink operation.
...
Also make mutable copies (when needed) of the top level subtables during a split operation.
2022-09-30 10:58:50 -06:00
8f1bf23cc9
[subset] optimize glyf subsetting w/ retain gids.
...
When retain gids is enabled the subset plan may require the output of many empty glyphs. This change optimizes the glyf subsetting code when the number of retained glyphs << number of output glyphs. Unnessecary lookups to the glyph map are reduced by iterating through the glyph map instead of the output glyph set.
2022-09-29 15:44:49 -06:00
e94fe2adf3
[instance] minor optimizations to glyf instancing
2022-09-29 12:14:43 -06:00
b90ce34a25
[instance] fix for non-empty .notdef glyph metrics update
...
we need pass in source glyph's outline data to calculate boundaries, and
then drop the outline data if notdef-outline is specified.
Also disable shifting points for instancing in get_points () API
2022-09-29 12:14:43 -06:00
b706c6f77e
[instance] update FeatureList with variations
2022-09-29 12:14:43 -06:00
8f3a7017c3
[instance] support FeatureVariations table
2022-09-29 12:14:43 -06:00
f4813e3b7f
[instance] update collect_lookups/prune_features()/closure_features() with variations
...
Some features will be substituted with variations, so we do not collect
lookups from the original feature tables.
2022-09-29 12:14:43 -06:00
64e2f2fc58
[instance] store active featurevariation record/condition idxes in the plan
2022-09-29 12:14:43 -06:00
0a6c16a313
[instance] instantiate fvar table
...
Added an old->new axes_indices mapping in the subset plan
2022-09-29 12:14:43 -06:00
486fc2271a
[cplusplus] Add missing const
2022-09-28 15:11:45 -06:00
c335bf469f
support dereferencing shared_ptrs and unique_ptrs
2022-09-27 15:44:29 -06:00
8cd7d1c3fe
[subset] Allow table ordering on the face builder to be overriden.
2022-09-22 16:52:14 -06:00
b70032edda
[layout] Fix typo in docs
2022-09-22 15:59:16 -06:00
d2966d3919
[ot-font] Try CBDT extents before outline tables
...
Like we do for sbix table.
Fixes https://github.com/harfbuzz/harfbuzz/issues/3827
2022-09-22 15:50:27 -06:00
1fdf046427
Merge pull request #3799 from harfbuzz/optical-bounds
...
Optical bounds
2022-09-22 12:03:17 -06:00
3ca5fbda76
[USE] Update the data files
...
This uses the data files from
<3254c94606/USEcloses #3817 .
2022-09-21 16:28:02 -06:00
b78d4b1e58
[color] Fix documentation re UPEM vs PPEM
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/3826
2022-09-21 13:27:12 -06:00
56c4670935
[subset] Fix compiler warning
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/3823
2022-09-20 17:40:13 -06:00
c02a1a4adc
[ot-font] Remove unused include
2022-09-20 17:40:13 -06:00
d7cc82ad48
Update the language system tag registry URL
2022-09-20 10:37:50 -06:00
f54d2b3e2c
[aat] Map 'rlig' to AAT required-ligatures setting.
...
Fixes #3819 .
2022-09-20 10:37:27 -06:00
Behdad Esfahbod
Garret Rieger
Qunxin Liu
Lorenz Wildberg
Martin Storsjö
خالد حسني (Khaled Hosny)
Marco Rebhan
Joel Auterson
David Corbett
Jonathan Kew