0c65a232fa
minor, add unlikely around lookup_limit_exceeded checks
...
addresses https://github.com/harfbuzz/harfbuzz/pull/2294#issuecomment-618022488
2020-04-23 11:23:54 +04:30
3e686d2459
[kern] Refactoring.
2020-04-22 18:04:52 -07:00
f4cd99f28e
Reordering fails when GDEF table is absent #2140
...
Preserve glyph class if there's no GDEF and no guess.
Fixes https://github.com/harfbuzz/harfbuzz/issues/2140
2020-04-22 14:45:57 -07:00
c7afb6d7b8
[docs] Fix broken link
2020-04-22 15:19:37 +02:00
bd8aa1b043
Minor
2020-04-21 22:19:46 -07:00
b22f61d86a
Fix bug
2020-04-21 16:51:55 -07:00
1cd14b40e7
minor, update ragel generated hb-number-parser.hh
2020-04-21 14:42:20 +04:30
6d5e8e5ee4
minor
...
following to c37100e7d
2020-04-21 14:38:09 +04:30
750bb73e32
[meson] Add an experimental-api option
2020-04-21 01:26:08 +04:30
262eced2ad
[subset] FeatureVariations subsetting is wrong
...
Never drop FeatureVariationRecord for now.
Fixes https://github.com/harfbuzz/harfbuzz/issues/2334
2020-04-21 01:23:07 +04:30
2be859d289
minor, replace nullptr checks with implicit ones
2020-04-21 00:30:34 +04:30
2dda6dd744
minor, tweak spacing
...
turn 8 spaces to tab, add space before Null/Crap
2020-04-20 16:18:29 +04:30
0133cb55e2
Minor, use hb_sorted_array::bsearch where possible
2020-04-19 23:18:36 +04:30
fb3acdbcb6
meson: only install gobject/icu headers if the features are enabled
2020-04-19 18:49:43 +04:30
ad5dcda0b5
meson: install hb-icu.h header
2020-04-19 18:49:43 +04:30
2cc85281c2
[serializer] Make snapshot()/revert() revert current object links
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/2325
2020-04-18 17:31:32 -07:00
6f6e78a26e
Fix float-to-double warnings
...
./hb-ot-glyf-table.hh:978:37: warning: implicit conversion increases floating-point precision: 'float' to 'double' [-Wdouble-promotion]
2020-04-18 16:12:18 -07:00
c37100e7d9
Clean up math.h and float.h includes
2020-04-18 16:02:55 -07:00
c6b3f73b09
[meson] Make harfbuzz-icu separate module optout-able
2020-04-19 02:06:01 +04:30
8ae06c9489
meson: build a separate library for harfbuzz-icu
...
This adds a seperate library like with autotools.
This also fixes the ico feature option which was just set to required:false
when disabled instead of really disabling it.
Disabling is still broken with msvc because it then tries to find the library
another way, but that's broken for all other deps as well so I left it as is.
For tests only test-unicode.c is using icu specific functions so split it out
into its own category which depends on harfbuzz-icu.
Fixes #2338
2020-04-18 23:34:31 +04:30
c1228990b9
autotools: Add fix_get_types.py to EXTRA_DIST
...
So it ends up in the release tarball and can be used in the meson build.
Fixes #2337
2020-04-18 18:03:58 +04:30
dced2fbee9
meson: complete introspection build config
...
Pass the same config to gobject-introspection as with cmake/autotools.
This makes sure the c-include and package name is included in the gir
and also fixes the build because of the missing HB_AAT_H* defines.
Fixes #2336
2020-04-18 17:24:53 +04:30
22f7c61acf
implement SID to glyph ID mapping with predefined Charset
...
Also fixes oss-fuzz 21769
2020-04-18 15:42:30 +04:30
f9bc373381
2.6.5
2020-04-17 23:49:56 +04:30
a8455292f4
[layout] minor on doc
2020-04-17 22:50:48 +04:30
29c903223b
Move hb_ot_layout_closure_{features,lookups} behind EXPERIMENTAL flag
2020-04-17 22:25:45 +04:30
9b7fb5c23f
Move hb_font_get_var_coords_design behind HB_EXPERIMENTAL_API
2020-04-17 20:29:04 +04:30
41c671e701
[build] Adjust check-symbols for -flto
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/2328
2020-04-17 08:37:25 -07:00
8f6d0f8401
[os2] minor, fix font_page_t enum naming
...
As https://github.com/harfbuzz/harfbuzz/pull/986#pullrequestreview-395052800
2020-04-17 11:30:27 +04:30
818f109bde
Use float in avar calculation instead ints and checking their overflows
2020-04-17 00:53:39 +04:30
9ffa50fe5d
Add an appropriate fallback to hb_int_mul_overflows
2020-04-17 00:38:38 +04:30
573b6bf826
Handle non-exclusive features when mapping OpenType tags to AAT feature type/selector pairs.
...
Fixes #2290 .
2020-04-16 01:33:01 +04:30
b57b904242
Add detail to hb_ft_font_create inline comments
...
Providing lengthier explanation for how the destroy function works on the hb_font_t but that destroying the FT_Face (and not destroying it too early) remains the client's responsibility.
2020-04-15 18:46:31 +01:00
1bca2be256
Rewrite hb_ft_font_set_funcs inline explanation
2020-04-15 18:30:47 +01:00
80c01d7687
Update hb-ft.cc
2020-04-15 18:08:55 +01:00
9b91669cb4
Update hb-ft.cc
2020-04-13 16:40:15 +01:00
fd59cc700a
Update src/hb-glib.cc
...
Co-Authored-By: Khaled Hosny <dr.khaled.hosny@gmail.com>
2020-04-13 15:15:00 +01:00
fb9d106797
Update src/hb-graphite2.cc
...
Co-Authored-By: Khaled Hosny <dr.khaled.hosny@gmail.com>
2020-04-13 15:14:42 +01:00
a199eab20e
Update src/hb-graphite2.cc
...
Co-Authored-By: Khaled Hosny <dr.khaled.hosny@gmail.com>
2020-04-13 15:14:28 +01:00
aff21795b2
Update src/hb-icu.cc
...
Co-Authored-By: Khaled Hosny <dr.khaled.hosny@gmail.com>
2020-04-13 15:14:06 +01:00
ccc2356983
Update src/hb-graphite2.h
...
Co-Authored-By: Khaled Hosny <dr.khaled.hosny@gmail.com>
2020-04-13 15:13:56 +01:00
0d5695983e
[subset] fixes dangling object_t issue in FeatureVariationRecord
...
Fixes https://crbug.com/oss-fuzz/21560
revert () does not clean up useless object_t. Adjust the order of
subsetting substitutions and conditions to avoid dangling object_t.
2020-04-06 13:41:33 +04:30
57b7de032f
[subset] Fail ClassDefFormat1 serialization if no space available
...
Fixes https://crbug.com/oss-fuzz/21580
2020-04-05 17:38:04 +04:30
c8cc1e378d
fix issues in ClassDefFormat1 serialize:
...
glyph ids in Iterator may be non-consecutive,
so the number in classValue might be larger than length of the Iterator
2020-04-03 12:31:48 -07:00
75cae46dc2
[aat] minor spacing
2020-04-03 20:04:16 +04:30
3737776384
[aat] add the bug link, minor
2020-04-03 20:03:20 +04:30
1faf0caae1
Special-case 'smcp' when checking for exposed AAT features.
...
This may be implemented by selectors under either LETTER_CASE or LOWER_CASE feature types
in AAT, so we need to check for the presence of either one.
Fixes #2307 .
2020-04-03 19:57:43 +04:30
b87cf6e8d4
Fix sense of comparsion in hb_aat_map_builder_t::feature_info_t.
...
This makes bsearch actually work for the features array.
Fixes #2305 .
2020-04-03 19:20:48 +04:30
b027cb518d
Set sequence number when adding feature to aat map builder, to support stable sort.
...
Fixes #2288 .
2020-04-03 03:22:06 +04:30
89fa70f511
[aat] minor over previous feat related changes
2020-04-03 01:08:01 +04:30
b1c0b9da2f
[AAT] Don't map OT tags to AAT feature types that are not exposed.
...
If an AAT feature type is not exposed in the 'feat' table, we assume it is not intended
to be user-controllable and so we should not map any OT feature tag requests to it.
Fixes #2285 .
2020-04-02 23:58:32 +04:30
e0c3979af1
typo fix
2020-04-02 12:05:57 +04:30
65f4136303
minor; fixes #2292
2020-04-01 19:49:18 -07:00
014e038b2c
[subset] Bail out of context lookup expansion once the lookup limit is encountered.
2020-04-01 11:14:41 +04:30
5d345d0cd1
[subset] Limit the number of lookup indices processed subsetting Feature.
...
> Also, remove two unnessecary full iterations of the lookup index iterator during serialization of the index array. Fixes fuzzer found timeout.
2020-04-01 11:13:05 +04:30
1b64b73080
Revert "Add messages for GPOS/GSUB phases"
...
This reverts commit b07714d6b5
2020-03-30 16:49:23 +02:00
2e1bf61dd5
[gsubgpos] Use FeatureVariations::NOT_FOUND_INDEX instead Index::
...
As noted by https://github.com/harfbuzz/harfbuzz/issues/2280#issuecomment-604386389
Added on b143e342571891Closes #2280
2020-03-26 22:59:28 +04:30
96d792ae80
[avar] Prevent mul overflow
...
Fixes https://crbug.com/oss-fuzz/21350
2020-03-26 15:01:14 +00:00
18fc9197e2
[meson] Run check-symbols.sh and check-static-inits.sh correctly
...
* Search src/ build directory for objects in check-static-inits.sh
* Find .def files in src/ build directory in src/check-symbols.sh
* Pass builddir also in autotools also, we may just remove libs passing after autotools removal
* Move harfbuzz_subset_def target so can be referenced as a check-static-inits.sh dependency
2020-03-26 09:40:14 +00:00
9c2c9553eb
[test] Check -subset also doesn't link to lib[std]c++
2020-03-26 09:40:14 +00:00
25718913d4
[gsubgpos] minor build fix
2020-03-26 14:04:37 +04:30
b143e34ee1
[gsubgpos] Initialize variation index on HB_NO_VAR
...
hb_shape_plan_key_t::equal expects hb_ot_shape_plan_key_t be initialized by
hb_ot_layout_table_find_feature_variations calls but it won't get initialized
when HB_NO_VAR build config is used.
Related to https://github.com/harfbuzz/harfbuzz/issues/2280
2020-03-26 12:06:12 +04:30
071e2e345f
minor
2020-03-26 12:03:07 +04:30
cc977b6e5c
[gsubgpos] Minor simplification
...
Just changed the order, no functional change
2020-03-26 11:19:43 +04:30
1a48278511
[gsubgpos] Minor style improve
2020-03-26 11:15:09 +04:30
4ad686b9c0
[subset] fix fuzzer timeout in layout closure
...
Bail out of chain context lookup expansion once the lookup limit is encountered.
2020-03-26 06:32:28 +00:00
f0ce56bbd0
[meson] Don't compile test-bimap on msvc either
...
MSVC doens't like its NullPool,
test-bimap.cc.obj : error LNK2019: unresolved external symbol "unsigned __int64 const * const _hb_NullPool" (?_hb_NullPool@@3QB_KB) referenced in function
2020-03-24 19:06:09 +00:00
22f311e100
[meson] Don't compile noinst_programs in msvc for now
2020-03-24 19:06:09 +00:00
7054b12206
[meson] Mark rest of non-install executables explicitly
2020-03-24 19:06:09 +00:00
e8808c1c20
[meson] Minor, replace tabs with spaces
2020-03-24 19:06:09 +00:00
2db8279162
[meson] Don't compile test-{algs,iter,meta} on msvc
2020-03-24 19:06:09 +00:00
3385afacd3
[meson] Don't run check-includes if is amalgam build
2020-03-24 19:06:09 +00:00
6a8a1dc5bb
[meson] Port src/ binary artifacts to meson
2020-03-24 19:06:09 +00:00
4738dff18e
[make] minor move on Makefile.am
2020-03-24 19:06:09 +00:00
b07714d6b5
Add messages for GPOS/GSUB phases
2020-03-23 22:02:44 +02:00
748e1cf898
[subset] Avoid linking to libstdc++ in libharfbuzz-subset.so
...
Just like other targets (except harfbuzz-icu) avoid linking to libstdc++
2020-03-23 18:06:02 +00:00
a0c58be371
[tools] Remove py2 remains
2020-03-18 23:41:20 +03:30
93b3e30215
[meson] fix icu-related linking errors in test with amalgam build
...
test-unicode.c:960: undefined reference to `hb_icu_get_unicode_funcs'
test-unicode.c:961: undefined reference to `hb_icu_get_unicode_funcs'
For now add the icu sources to libharfbuzz also for the amalgam
build, later we need to have a separate harfbuzz-icu module and
link against that, and/or generate harfbuzz.cc.
2020-03-14 15:16:00 +03:30
2f556c38c0
[subset] Fix crash when serializer runs out of room during gpos subsetting.
2020-03-14 00:55:47 +03:30
838346c54a
meson: Support GDI integration
...
...and supersede the configuration option uniscribe with gdi, as Uniscribe is
tightly tied to GDI. This means that enabling GDI would also mean enabling
Uniscribe.
2020-03-13 14:30:17 +03:30
4b4d5c295d
src/meson.build: Some cleanups for Visual Studio builds
...
We don't actually need the .def files (vs_module_defs) entry when we are
building DLLs with Visual Studio as long as we have HB_DLL_EXPORT defined.
Plus, to maintain compatibility with the CMake builds, for Visual Studio builds
we do not prefix the libraries with 'lib', nor have a '-0' suffix for the DLL
file name.
2020-03-13 14:30:17 +03:30
91ca17e1fd
src/hb-gobject-enums.cc.tmpl: Replace © with (C)
...
This was, we also avoid Visual Studio compiler warnings C4828 as that sign is
not favored when /utf-8 is enabled, which is the norm nowadays as Visual Studio
2015 or later is required to build harfbuzz nowadays.
2020-03-13 14:30:17 +03:30
62fb6738d5
Fix gen-def for harefbuzz-gobject
...
The © sign is causing issues for the script, so replace those with (C)
2020-03-13 14:30:17 +03:30
8d425ed446
meson: Fix harfbuzz-gobject builds without introspection
...
Make the `sources:` field reflect the items depending on whether introspection
is being built
2020-03-13 14:30:17 +03:30
3341d5346e
meson: Don't apply -DHB_DLL_EXPORT to all targets
...
Only have it apply to the libraries when they are not built statically on
Visual Studio
2020-03-13 14:30:17 +03:30
a224f4179f
Turn more of simple dagger chains to foreach
...
Less noise, as was agreed before and applied 385741d
2020-03-13 08:33:34 +03:30
755a77d660
Move outline draw API behind HB_EXPERIMENTAL_API directive
2020-03-13 08:25:53 +03:30
1dd3896688
[meson] Make it work on autotools dist
2020-03-12 14:49:40 +03:30
834a224a50
[subset] Put a limit on the number of lookup indices that can be visited during closures
...
Fixes https://crbug.com/oss-fuzz/21025
2020-03-12 13:32:36 +03:30
f8c8be0564
[meson] Add amalgam build option
2020-03-12 00:25:48 +03:30
68f982415b
meson: update to latest master
2020-03-11 19:18:57 +03:30
535186fd84
meson: provide a harfbuzz-config for use from CMake
...
See #822 and #1437 .
2020-03-11 19:18:57 +03:30
7eaf3754dc
meson: update for changes in master
...
And remove header files from sources list, Meson figures
out header dependencies by itself (via the compiler).
2020-03-11 19:18:57 +03:30
04438554c8
meson: Update build files after rebase
2020-03-11 19:18:57 +03:30
618584e923
meson: rename incbase to incconfig
...
Makes it clearer what it's for: config.h. See #4 .
2020-03-11 19:18:57 +03:30
14b5c774c2
meson: Fix include directory when used as subproject
...
HarfBuzz headers are under src/ not the root directory, without using
incsrc no headers will be found by the dependent project. I think
incbase is superfluous, it should be replaced by incsrc or dropped.
2020-03-11 19:18:57 +03:30
6abe7983ed
meson: add g-i introspection
2020-03-11 19:18:57 +03:30
d230a02048
meson: generate .def file for MSVC symbol export on the fly
...
Fix symbol export with MSVC when features are disabled,
such as GLib. We need to generate the list of exported
symbols on the fly to make sure we only export symbols
that are actually available.
Needs some minor modifications to the gen-def.py script:
- accept header list also via command line args; we can't
pass things to a configure_file() command via the environment
in Meson.
- strip any leading 'src/' from library filename. This might
be there because in Meson the script might be called from
the top-level directory and not the current source directory.
Remove .def files again which had been checked in for earlier
versions of the Meson port.
2020-03-11 19:18:57 +03:30
4840c8237e
meson: add option and build system plumbing for CoreText on macOS/iOS
...
Untested though.
2020-03-11 19:18:57 +03:30
83ebbe4ade
meson: add option and build system plumbing for DirectWrite on Windows
...
Untested though.
2020-03-11 19:18:57 +03:30
Ebrahim Byagowi
Evgeniy Reizner
Behdad Esfahbod
Khaled Hosny
ckitagawa
Christoph Reiter
ariza
Jonathan Kew
n8willis
Qunxin Liu
Garret Rieger
Simon Cozens
Tim-Philipp Müller
Chun-wei Fan
Aaron Boxer