3bf27a9f0e
[Indic] Disable conjuncts when a ZWJ happens
...
Not that the code makes any difference since the presence of ZWJ itself
causes the ligature to fail to match anyway.
2012-05-11 11:17:23 +02:00
c6d904d67d
[Indic] Fix bitops typo!
...
Another 1000 down!
2012-05-11 11:07:40 +02:00
55fe2cf79b
Make APPLY debug output print current index and codepoint
...
Yay!
2012-05-11 03:56:33 +02:00
7bd2b04fea
Minor
2012-05-11 03:40:58 +02:00
cf26510dbb
Some more...
...
Done. I promise.
2012-05-11 03:35:08 +02:00
9659523ca3
More beauty in debug output!
2012-05-11 03:33:36 +02:00
cf26e88a5a
Finish off debug output beautification
2012-05-11 03:16:57 +02:00
d7bba01a35
Only print class name in debug output if there's one available
2012-05-11 02:46:26 +02:00
85f73fa8da
Only printout class name in tracing, if one is available
...
Makes debug output much more pleasant.
2012-05-11 02:40:42 +02:00
98619ce4fa
Minor
2012-05-11 02:34:06 +02:00
acea183e98
Add return annotation for APPLY
2012-05-11 02:33:11 +02:00
5ccfe8e215
/Minor/
2012-05-11 02:19:41 +02:00
0ab8c86217
Annotate SANITIZE return values
...
More to come, for APPLY, CLOSURE, etc.
2012-05-11 02:11:52 +02:00
829e814ff3
Minor
2012-05-11 00:52:16 +02:00
6eec6f406d
Code reshuffling
2012-05-11 00:50:38 +02:00
1e08830b4f
Beautify debug output
2012-05-11 00:43:57 +02:00
6f45538017
More massaging trace messaging
2012-05-10 23:24:43 +02:00
b5fa37cb69
Minor
2012-05-10 23:09:48 +02:00
208109703c
Better trace message support infrastructure
...
We have varargs in the trace interface now. To be used soon...
2012-05-10 23:06:58 +02:00
02b2922fbf
[Indic] Towards better Reph positioning
...
Fixed for Deva cases with two full-form consonants. Failures **way** down.
Not much left to go :-).
2012-05-10 21:44:50 +02:00
74e54cf446
[Indic] Add Ra back for scripts without Reph
...
We now check that the 'rphp' table exists before forming Reph, so
we don't need to comment out Ra for those scripts.
2012-05-10 21:22:58 +02:00
2b70df5cc0
[Indic] Add note re Uniscribe clusters
2012-05-10 18:38:22 +02:00
21d2803133
[Indic] Do clustering like Uniscribe does
...
Hindi Wikipedia failures down to 6639 (0.938381%)!
2012-05-10 18:34:34 +02:00
8df5636968
[Indic] Reorder Reph to before the Halant after Matras
...
Uniscribe doesn't do it, but we want to do as it gives the Reph the
opportunity to interact with the Matras. Test with mangal for example.
Sequence: <0930,094d,0915,094b,094d>
In test suite already.
2012-05-10 15:41:04 +02:00
daf3234bdc
[Indic] Don't clear the mask for Reph
...
This was removing the mandatory global 1 bit in the mask and hence
disabling GPOS for Reph!
2012-05-10 15:28:27 +02:00
7708ee23cb
[Indic] Improve Left Matra repositioning
...
Move its dependents too.
2012-05-10 14:48:25 +02:00
dbb105883c
[Indic] Do Reph repositioning in final reordering like the spec says
...
This introduced a failure, which we tracked down to a test case like this:
U+092E,U+094B,U+094D,U+0930
The final character is a Ra that should be put in a syllable of it's
own. And we do. But it will interact with the Halant before it. So
now we finally are convinced that we have to limit features to syllable
boundaries. That's coming after lunch!
2012-05-10 13:45:52 +02:00
4705a70269
Minor
2012-05-10 13:09:08 +02:00
4ac9e98d9d
[Indic] Reorder left matras to be closer to base
2012-05-10 12:53:53 +02:00
1a1fa8c655
[Indic] Treat the standalone cluster case reusing the consonant logic
2012-05-10 12:21:30 +02:00
190eb31a16
[Indic] Minor
2012-05-10 12:21:30 +02:00
c5306b6861
[Indic] Handle Vowel syllables
...
Reusing the consonant logic!
2012-05-10 12:21:30 +02:00
6d8e0cb74c
[Indic] Simplify Reph logic
2012-05-10 11:41:51 +02:00
3d25079f8d
[Indic] Don't form Reph is Ra is the only consonant in the syllable
2012-05-10 11:37:42 +02:00
b99d63ae11
[Indic] Increase max syllable length
...
20 was way too low, one could hit a syllable with 7ish consonants with it.
2012-05-10 11:32:52 +02:00
a391ff50b9
[Indic] Adjust base after sorting
2012-05-10 11:31:20 +02:00
d3637edb24
[Indic] Don't return for long syllables. Just not sort.
2012-05-10 10:51:38 +02:00
dfa0cade7f
Fix Uniscribe clusters with multiple items
2012-05-09 19:10:07 +02:00
86e5dd386a
[Indic] Don't give up syllable parsing upon junk
2012-05-09 18:57:37 +02:00
ef24cc8c8e
[Indic] Towards multi-cluster syllables and final reordering
2012-05-09 18:10:20 +02:00
a9844d41c6
Combine lig_id and lig_comp into one byte, to free up one for Indic
2012-05-09 17:53:13 +02:00
92332e5116
Minor
2012-05-09 17:40:00 +02:00
dbccf87eef
[Indic] Make room for more reordering positions
2012-05-09 17:24:39 +02:00
d4480ace7f
[Indic] Improve matra vs consonant ordering
...
Another 1.5% down.
2012-05-09 15:59:47 +02:00
33c92e7695
[Indic] Categorize Anudatta
2012-05-09 15:41:51 +02:00
19d984edaa
[Indic] Make sure Reph jumps over all matras to the right
...
Another 12 thousand failures gone! (78 to go)
2012-05-09 15:21:13 +02:00
9034641333
[Indic] Keep Vedic signs at the right too
2012-05-09 15:04:58 +02:00
d1deaa2f5b
Replace zerowidth invisible chars with a zero-advance space glyph
...
Like Uniscribe does.
2012-05-09 15:04:13 +02:00
49e5da1591
[indic] Keep the syllable modifier marks to the right
...
Shaping failures on Hindi Wikipedia go down from 25% to 14%!
2012-05-09 13:23:27 +02:00
5b12609093
Minor
2012-05-09 12:37:27 +02:00
9ce939232b
Minor
2012-05-09 12:03:09 +02:00
76b3409de6
[indic] Better Reph matching
2012-05-09 11:52:32 +02:00
df6d45c693
Minor
2012-05-09 11:38:31 +02:00
412b91889d
[indic] Apply Indic features in order
2012-05-09 11:07:18 +02:00
1ac075b227
[indic] Apply rakaar forms
...
Fixes 10% of the failures against all of Hindi Wikipedia!
2012-05-09 11:06:47 +02:00
1a2a4a0078
Fix warning and build issues
...
As reported by Jonathan Kew on the list.
2012-05-05 22:38:20 +02:00
a5e39fed85
Minor
2012-04-25 00:14:46 -04:00
1827dc208c
Add hb_ot_shape_glyphs_closure()
...
Experimental API for now.
2012-04-24 16:56:37 -04:00
bb09f0ec10
Minor
2012-04-24 16:02:12 -04:00
29a7e306e3
Minor
2012-04-24 16:01:30 -04:00
6c6ccaf575
Add a few more set operations
...
TODO: Tests for hb_set_t.
2012-04-24 14:23:01 -04:00
5caece67ab
Make closure() return void
2012-04-23 23:03:12 -04:00
0b08adb353
Add hb_set_t
2012-04-23 22:44:59 -04:00
5b93e8d94f
Update copyright headers
2012-04-23 22:26:27 -04:00
6a9be5bd35
Rename hb_glyph_map_t to hb_set_t
2012-04-23 22:23:17 -04:00
a4385f0b0a
Improve clustering
2012-04-23 22:20:14 -04:00
8e3715f8a1
Minor
2012-04-23 22:18:54 -04:00
d2984a241e
Add map->substitute_closure()
2012-04-23 17:21:14 -04:00
31081f7390
Implement closure() for Context and ChainContext lookups
2012-04-23 16:54:58 -04:00
c64ddab3c3
Flesh out closure() for GSUB
...
The GSUBGPOS part still missing.
2012-04-23 15:28:35 -04:00
0da132bde4
Fix Coverage iters
2012-04-23 14:21:33 -04:00
3e32cd9570
Minor
2012-04-23 13:22:50 -04:00
650ac00da3
Minor refactoring
2012-04-23 13:17:09 -04:00
f94b0aa646
Add "closure" operation stubs to GSUB
...
Filling in.
2012-04-23 13:04:38 -04:00
7d50d50263
Add Coverage iterators
2012-04-23 13:04:05 -04:00
3ed4634ec3
Add Indic inspection tool
2012-04-19 22:35:01 -04:00
a06411ecf9
Minor matra renumbering
...
Should have no visible effect.
2012-04-19 22:28:25 -04:00
36608941f3
Add GSUB "would_apply" API
...
To be used in the Indic shaper later. Unused for now.
2012-04-19 22:21:38 -04:00
a5e40542ab
Make font immutable in hb_shape()
2012-04-17 12:37:19 -04:00
3cde23664f
Minor note re Graphite
2012-04-17 11:44:49 -04:00
4dc2449d92
Fix leak in graphite
2012-04-17 11:39:48 -04:00
9ceca3aeb1
Fix ragel regexp in vowel-based syllable
...
As reported by datao zhang on the mailing list.
2012-04-16 21:05:51 -04:00
b870afcd1b
Rewrite ragel expression to better match the one on MS spec
...
https://www.microsoft.com/typography/otfntdev/devanot/shaping.aspx
2012-04-16 21:05:11 -04:00
a5f1834f57
Apply 'liga' for vertical writing mode too
...
Apparently that's what Kazuraki uses to form vertical ligatures,
which suggests that it's what Adobe does.
2012-04-16 15:55:13 -04:00
e74616b889
Add comment
2012-04-15 14:12:13 -04:00
683b503f30
Minor
2012-04-14 20:47:14 -04:00
b9f199c8e3
Move code around
2012-04-14 20:25:37 -04:00
38a83019e6
Minor
2012-04-14 19:40:18 -04:00
d4adade217
Add assert
2012-04-14 19:23:17 -04:00
fe28b997fb
Add HB_DIRECTION_IS_VALID
2012-04-14 19:19:26 -04:00
5e88aa6682
Remove public enum names again
...
As was reported to me, glib-mkenum does not understand named enums,
so remove for now.
2012-04-14 18:51:50 -04:00
4bf90f6483
Make HB_DIRECTION_INVALID be zero
...
This changes all the HB_DIRECTION_* enum member values, but is
nicer, in preparation for making hb_segment_properties_t public.
2012-04-12 17:38:23 -04:00
6bd9b479b8
Hide backend-specific shape functions
...
Also remove shaper_options argument to hb_shape_full(). That was
unused and for "future". Let it go.
More shaper API coming in preparation for plan/planned API.
2012-04-12 14:53:53 -04:00
c6035cf802
Add names to enums
...
gdb was showing <anonymous enum> instead of useful stuff, so name
all our enums.
2012-04-12 13:23:59 -04:00
d1c9eb458c
Make it an error to include non-top-level headers
...
Users should #include <hb.h> (or hb-ft.h, hb-glib.h, etc), but
never things like hb-shape.h directly. This makes it easier to
refactor headers later on without breaking compatibility.
2012-04-12 13:17:44 -04:00
323190c27b
Minor
2012-04-12 12:29:10 -04:00
0e3361464b
Fix bug with not setting Unicode props of the first character
...
Fixes Mongolian shaping issue:
https://bugs.freedesktop.org/show_bug.cgi?id=45695
2012-04-12 10:06:52 -04:00
c65662b71e
Fix left-matra positioning in Indic
...
Fixes 200 failures out of previous 4290 cases in the OO.o Indic
dictionary (of ~16000 entries).
2012-04-12 09:31:55 -04:00
029a82d81d
[hangul] Apply *jmo features to all Hangul chars
...
This is what old HB does. Morever, fixes rendering with Win8 malgun
font. The Win7 version doesn't compose with either Uniscribe nor HB,
but Win8 version works as expected, like Uniscribe, with this change.
Lets call Hangul done for now.
2012-04-11 22:00:46 -04:00
41ae674f68
Don't create hb_apply_context_t per glyph!
...
I couldn't measure significant performance gains out of this; maybe
about 5% (with one million Malayalam strings). Still, not bad.
But reminds me that optimizing this codebase without profiling first
is simply not going to work. Oh well...
2012-04-11 17:13:50 -04:00
4a1e02ef79
Fix shape to presentation forms font check
...
As reported by Jonathan Kew on the list.
2012-04-11 14:37:53 -04:00
6062f5f014
Fix build with some compilers
...
As reported by Jonathan Kew on the list.
2012-04-11 14:19:55 -04:00
acd88e659f
In Arabic fallback shaping, check that the font has glyph for new char
2012-04-10 18:02:20 -04:00
7752aa73e7
Minor
2012-04-10 17:22:14 -04:00
939c010211
Implement Arabic fallback shaping mandatory ligatures
2012-04-10 17:20:05 -04:00
b7d04eb606
Do Arabic fallback shaping
2012-04-10 16:44:38 -04:00
ae4a2b9365
Generate fallback Arabic shaping table
...
Not hooked up yet.
2012-04-10 16:25:08 -04:00
3b26f96ebe
Add Thai shaper that does SARA AM decomposition / reordering
...
That's not in the OpenType spec, but it's what MS and Adobe do.
2012-04-10 10:52:07 -04:00
d4cc44716c
Move code around, in prep for Thai/Lao shaper
2012-04-07 21:52:28 -04:00
c9a841f445
Add simple Hangul shaper that recomposes Jamo when feasible
...
Previously, we were NOT actually recomposing Hangul Jamo. We do now.
The two lines in:
test/shaping/texts/in-tree/shaper-default/script-hangul/misc/misc.txt
Now render the same with the UnDotum.ttf font. Previously the second
linle was rendering boxes.
We can also start applying OpenType Jamo features later. At this time,
I have no idea how the 'ljmo', 'vjmo', 'tjmo' features are supposed to
work. Maybe someone can explain them to me?
2012-04-07 15:06:55 -04:00
9683184553
Implement normalization mode HB_OT_SHAPE_NORMALIZATION_MODE_COMPOSED_FULL
...
In this mode we try composing CCC=0 with CCC=0 characters. Useful for
Hangul.
2012-04-07 15:06:47 -04:00
bec2ac4fde
Bring normalization algorithm closer to the spec
...
No logical difference so far.
2012-04-07 14:51:17 -04:00
e02d925786
Flip logic around
2012-04-07 14:49:13 -04:00
11138ccff7
Add normalize mode
...
In preparation for Hangul shaper.
2012-04-05 17:25:19 -04:00
6769f21d57
More moving code around
2012-04-05 16:46:46 -04:00
2db2a56682
Move code around
2012-04-05 16:40:37 -04:00
cad3821f3d
More sorting by Unicode version
...
This is the most convenient way to browse scripts.
2012-03-07 17:13:25 -05:00
317b9504d7
Minor
2012-03-07 16:51:29 -05:00
fa2673c1ee
More Unicode script age annotation, and a couple more RTL scripts
...
Cross-checked with Mark Davis's spreadsheet at http://goo.gl/x9ilM
2012-03-07 15:52:02 -05:00
6d4016f1ba
Make src tests pass again
2012-03-07 15:33:14 -05:00
7da435f08c
Separate Unicode 3.1 and Unicode 3.2 additions
2012-03-07 15:20:20 -05:00
f91136cb52
Route three Unicode 6.1 scripts through Indic shaper
2012-03-07 12:56:22 -05:00
f32c0012ad
Add Unicode 6.1.0 scripts
2012-03-07 12:53:34 -05:00
50e810cd0e
Lydian and Kharoshthi are right-to-left
2012-03-07 12:49:08 -05:00
a52835635e
Whitespace
2012-03-07 12:38:39 -05:00
183224684a
Use generic shaper for Buhid
...
As requested by Jonathan Kew.
We need to devise a better mechanism to choose which scripts to
pass through the Indic shaper. Moreover, currently we are storing
data for some scripts in the Indic shaper that are not even going
through that shaper. Need to find a better way...
2012-03-07 12:21:28 -05:00
cdc8b491a8
Update Indic table to Unicode 6.1 data
2012-03-07 12:08:33 -05:00
e3b2e077f5
Typo
2012-03-07 10:21:24 -05:00
c346671b6b
Minor doc fixes
2012-03-06 20:47:50 -05:00
461b9b6347
Fix cluster formation in Indic
...
Makes number of failures against Uniscribe with hi_IN dictionary from
OO.o to go down from 6334 to 4290. Not bad for a one-line change!
Mozilla Bug 729626 - ASAN: heap-buffer-overflow HTML
2012-03-01 18:11:19 -08:00
bc71ad4973
Fix atomic-int op on Apple
...
The OSAtomicAdd32Barrier operator returns the new value, we want the
old value.
2012-03-01 17:30:29 -08:00
a1970d9afc
Add support for atomic int and mutex on Apple systems
...
So, apparently there's no atomic int 'get' method on Apple. You have to
add(0) to get. And that's not const-friendly. So switch inert-object
checking to a non-atomic get. This, however, is safe, and a negligible
performance boost too.
2012-02-24 16:19:52 -05:00
8004429102
Remove unused hb_atomic_int_set()
...
Apparently it can't be implemented on OS X. We weren't using it anyway.
2012-02-24 16:19:52 -05:00
45227c10e4
Add hb-warning.cc. Oops!
2012-02-23 19:47:43 -05:00
bd7ff1dec5
Allow disabling multi-threaded support
...
By defining HB_NO_MT.
Also, only warn once per missing MT feature support.
Mozilla Bug 666661 - gfx/harfbuzz/src/hb-prive.h - compiler warnings on mac
2012-02-23 15:06:16 -05:00
634c9e3423
Minor
2012-02-22 16:43:21 -05:00
514b6f8866
Followup: Reorder Hebrew combining classes for better rendering
...
Patch from Jonathan Kew.
Bug 662055 - advanced Hebrew diacritics are shown correctly only in
particular order.
2012-02-22 16:34:37 -05:00
6e78607ea7
Reorder Hebrew combining classes for better rendering
...
Patch from Jonathan Kew.
Bug 662055 - advanced Hebrew diacritics are shown correctly only in particular order
2012-02-22 16:31:15 -05:00
134aa7bc7e
Make checks more OS X friendly
2012-01-27 02:23:22 -05:00
6152199368
Fix check-header-guards on OS X
2012-01-27 02:23:22 -05:00
71632c96da
Fallback to Latin script if the font has no other usable scripts
...
Patch and description from Jonathan Kew:
It turns out that some legacy Thai fonts provide OpenType substitution
features to implement mark positioning, but (incorrectly) put those
features/lookups under the 'latn' script tag instead of using 'thai' (or
possibly 'DFLT'). See
https://bugzilla.mozilla.org/show_bug.cgi?id=719366 for an example and
more detailed description.
Although this is really a font bug, I suggest that we could improve the
rendering of such fonts by looking for the 'latn' as a fallback if
neither the requested script nor "default" is found in
hb_ot_layout_table_choose_script. Suggested patch against harfbuzz
master is attached.
This does _not_ affect the other kind of legacy Thai font, where custom
code to support vendor-specific PUA codepoints would be needed. I'm not
keen to go down that path; IMO, such fonts should be ruthlessly stamped
out in favour of standards-based solutions. :)
JK
2012-01-22 15:31:44 -05:00
7a4a848db2
Minor
2012-01-19 15:15:21 -05:00
3b5c22c39b
Remove src/test.cc
...
Not really useful.
2012-01-19 14:28:11 -05:00
889caa52fa
[icu] Use U_FAILURE
2012-01-18 22:32:52 -05:00
36a4f4a482
Replace u_strlen() with u_countChar32()
...
The latter is what I meant.
2012-01-18 22:16:49 -05:00
c521e793bd
Fix OOB in replace_glyph()
...
Patch from Kenichi Ishibashi.
2012-01-18 21:51:05 -05:00
03408ce73d
Fix more possible buffer overruns
...
I have this function, but can't clean up it to my satisfaction.
2012-01-18 21:28:34 -05:00
7d479900cd
Refactor the two remaining uses of _hb_ot_layout_skip_mark()
2012-01-18 21:19:32 -05:00
506ffeb8e7
Further mark skippy fixes from Jonathan Kew
...
We should be in good shape now.
2012-01-18 16:07:53 -05:00
a4a48fe6d4
Fix mark skipping regression
...
Ouch!
2012-01-17 18:08:41 -05:00
Behdad Esfahbod