1bcfa06d11
[OTLayout] Don't recurse in collect_glyphs() for GPOS
2012-12-04 16:58:09 -05:00
e75943de80
[OTLayout] Fix collect_glyphs() recursion in ContextFormat3
2012-11-30 08:38:24 +02:00
f18ff5a84d
[OTLayout] Return correct value from recursion
...
Commit 4c4e8f0e75
2012-11-30 08:07:06 +02:00
2dc1141d7d
[OTLayout] Remove operator() from ClassDef
2012-11-24 19:16:34 -05:00
b67881b171
[OTLayout] Remove operator() from Coverage
2012-11-24 19:13:55 -05:00
1ea375da44
[OTLayout] Only collect output glyphs during recursion in collect_glyphs()
2012-11-24 02:05:52 -05:00
f1b12781d2
[OTLayout] Implement ChainContext collect_glyphs()
...
All of collect_glyphs() complete and untested now.
2012-11-24 02:02:01 -05:00
4c4e8f0e75
[OTLayout] Reuse apply context for recursion
2012-11-24 01:13:20 -05:00
53a69f49e5
[OTLayout] Remove unused members
2012-11-24 01:03:05 -05:00
d0a5233785
[OTLayout] Implement Context::collect_glyphs()
2012-11-23 18:54:59 -05:00
26514d51b6
[OTLayout] More collect_glyphs()
2012-11-23 18:13:48 -05:00
9b34677f36
[OTLayout] Clean up closure() a bit
2012-11-23 17:55:40 -05:00
2c53bd3c3e
[OTLayout] Start porting sanitize() to process()
2012-11-23 17:29:05 -05:00
f48ec0e834
[OTLayout] Add process() tracing
2012-11-23 17:23:41 -05:00
ed2e135944
[OTLayout] More Extension templatizing
2012-11-23 17:10:40 -05:00
7dddd4e72b
[OTLayout] More templatizing Extension
2012-11-23 17:04:55 -05:00
653eeb2645
Make Extension a template
2012-11-23 16:57:36 -05:00
a1733db1c6
[OTLayout] Start adding process() tracing
2012-11-23 16:40:04 -05:00
73c18ae1b9
Cleanup
2012-11-23 15:34:11 -05:00
be218c688c
Pass this object to trace macros
2012-11-23 15:32:14 -05:00
902cc8aca0
[OTLayout] Start unbreaking tracing
2012-11-23 15:23:30 -05:00
dabe698fcb
Minor
2012-11-23 14:21:35 -05:00
c779d82b2f
Fix warnings
2012-11-23 14:09:21 -05:00
81822528ef
Minor
2012-11-23 13:27:16 -05:00
1d67ef980f
Move code around
2012-11-22 16:47:53 -05:00
ec35a72a44
[OTLayout] Port apply() operator to process() template
2012-11-22 16:33:46 -05:00
2005fa5340
[OTLayout] Port would_apply() and get_coverage() to process() templates
2012-11-22 16:33:46 -05:00
44fc237b53
[OTLayout] Port closure() to process() template
2012-11-22 16:33:46 -05:00
e8cfdd7fa8
Start implementing collect_glyphs() operation
...
Not functional yet.
2012-11-16 19:07:06 -08:00
7d52e6601f
Whitespace
2012-11-16 18:49:54 -08:00
5a08ecf920
Implement hb_ot_layout_get_glyph_class()
2012-11-16 13:34:29 -08:00
2616689d15
More tracing fixups
2012-10-29 21:51:56 -07:00
bc513add79
Add missing TRACE_RETURN
2012-10-29 19:03:55 -07:00
2bd9fe3598
Refactor
2012-09-04 15:15:19 -04:00
a5ddd9e31c
[OT] Really fix possible NULL dereference this time
2012-09-04 14:55:00 -04:00
f8fa2b5cf6
Fix possible NULL dereference
...
As reported by Kenichi Ishibashi.
2012-09-03 20:19:46 -04:00
2fcbbdb41a
Port Arabic fallback ligating to share code with GSUB
...
This will eventually allow us to skip marks, as well as (fallback)
attach marks to ligature components of fallback-shaped Arabic.
That would be pretty cool. I kludged GDEF props in, so mark-skipping
works, but the produced ligature id/components will be cleared later
by substitute_start() et al.
Perhaps using a synthetic table for Arabic fallback shaping was a better
idea. The current approach has way too many layering violations...
2012-08-29 14:01:22 -04:00
5e399a8a45
Minor
2012-08-29 10:40:49 -04:00
a177d027d1
[GSUB] Move ligation logic over
2012-08-28 23:18:22 -04:00
191fa885d9
[GSUB] Merge Ligature and context input matching
...
Looks better now...
2012-08-28 22:58:55 -04:00
93814ca7dc
Start converging Ligature and match_input
2012-08-28 22:39:10 -04:00
7c8e844d92
Use namespace for OpenType tables
...
Avoids USHORT, SHORT, ULONG, LONG clashes with Windows API.
2012-08-28 17:57:49 -04:00
d9b204d3d2
[GSUB] Allow non-zero-context matching in would_apply()
...
To be used in the next patch.
2012-08-23 16:22:28 -04:00
1f2bb172fe
Revert "[Indic/GSUB] Ignore context when matching would_apply()"
...
This reverts commit 24dd4e5674
2012-08-23 16:10:37 -04:00
24dd4e5674
[Indic/GSUB] Ignore context when matching would_apply()
...
The MS Indic specs say "...all classifications are determined ... using
context-free substitutions." However, testing shows that MS's Malayalam
shapers (both old and new), "match" even if there is no zero-context rule.
We follow.
Fixes below-base La (eg. Pa,H,La) with AnjaliNewLipi.ttf (old spec).
Moreover, test suite Malayalam failures are down to 312 from 875! No
change in other scripts.
Current numbers:
BENGALI: 353996 out of 354285 tests passed. 289 failed (0.0815727%)
DEVANAGARI: 707339 out of 707394 tests passed. 55 failed (0.00777502%)
GUJARATI: 366489 out of 366506 tests passed. 17 failed (0.0046384%)
GURMUKHI: 60769 out of 60809 tests passed. 40 failed (0.0657797%)
KANNADA: 951086 out of 951913 tests passed. 827 failed (0.0868777%)
KHMER: 299106 out of 299124 tests passed. 18 failed (0.00601757%)
LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%)
MALAYALAM: 1047541 out of 1048416 tests passed. 875 failed (0.0834592%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271726 out of 271847 tests passed. 121 failed (0.0445103%)
TAMIL: 1091837 out of 1091837 tests passed. 0 failed (0%)
TELUGU: 970558 out of 970573 tests passed. 15 failed (0.00154548%)
TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
2012-08-23 15:47:10 -04:00
2eaf482b37
Revert "[GSUB/GPOS] Reject Context/ChainContext lookups with zero input"
...
This reverts commit 0981068b75
2012-08-09 18:30:05 -04:00
472f229a63
[GSUB] Generalize would_apply()
...
Fixes logic also, where before we were always matching if glyphs_len==1
and a ligature started with the glyph.
2012-08-07 22:25:24 -04:00
afbcc24be0
[GSUB] Wire the font, not just the face, down to substitute()
...
We need the font for glyph lookup during GSUB pauses in Indic shaper.
Could perhaps be avoided, but at this point, we don't mean to support
separate substitute()/position() entry points (anymore), so there is
no point in not providing the font to GSUB.
2012-08-02 08:36:40 -04:00
305246744e
Minor
2012-08-02 08:08:04 -04:00
22148b8c4a
Use Coverage digests in would_apply
2012-08-02 03:51:51 -04:00
6c459c8fef
Minor
2012-08-02 03:45:53 -04:00
1336ecdf8e
[GSUB/GPOS] Use Coverage digests as gatekeeper
...
Gives me a good 10% speedup for the Devanagari test case. Less so
for less lookup-intensive tests.
For the Devanagari test case, the false positive rate of the GSUB digest
is 4%.
2012-08-01 21:46:36 -04:00
c2e42c3db6
Minor
2012-07-30 19:54:50 -04:00
03f67bc012
More refactoring glyph class access
2012-07-30 19:47:53 -04:00
300c7307eb
[OT] Don't crash if no GDEF available
2012-07-30 19:37:44 -04:00
05bd1b6342
[GSUB/GPOS] Move glyph props matching around
2012-07-30 19:30:01 -04:00
2fca1426ca
[GSUB] Don't erase glyph classes if GDEF does not have glyph classes
2012-07-30 18:46:41 -04:00
7fbbf86efe
[GSUB] Minor
2012-07-30 18:36:42 -04:00
fe20c0f84f
[GSUB] Fix mark component stuff when ligatures form ligatures!
...
See comments.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=437633
2012-07-30 00:00:59 -04:00
e6f7479fe3
[GSUB] Simplify would-apply
2012-07-28 18:34:58 -04:00
0b99429ead
[GSUB/GPOS] Add get_coverage() and use it to speed up main loop
...
And use it to speed up the hotspot by checking coverage directly in
the main loop, not 10 functions deep in.
Gives me a solid 20% boost with Indic test suite. Less so for less
lookup-intensive scenarios.
Remove the "fast_path" hack from before.
2012-07-28 17:46:35 -04:00
0981068b75
[GSUB/GPOS] Reject Context/ChainContext lookups with zero input
2012-07-28 17:01:59 -04:00
ec8d249469
Make data members of various OpenType structs protected instead of private
...
Should fix warnings generated when building with -Wunused-private-field.
Based on patch from Jonathan Kew.
2012-07-24 15:40:37 -04:00
49c5ec5144
Minor refactoring
2012-07-23 20:14:13 -04:00
c3e6fdc379
[Indic] Improve check on ligatures
...
Only skip actual ligatures, not marks in-between ligature components.
2012-07-23 20:11:42 -04:00
d1af9e82e5
[GSUB/GPOS] Const correctness
2012-07-23 19:55:35 -04:00
8932858123
Minor
2012-07-19 21:02:38 -04:00
e72b360ac6
Refactor / finish would_apply() operation
...
Untested.
2012-07-19 14:44:46 -04:00
60da763dfa
[GSUB/GDEF] Guess glyph classes after substitution only if no GDEF
...
Brings down Khmer failures with Daun Penh font from 36% to 20%.
2012-07-16 16:14:40 -04:00
6d08c7f1b3
Revert "Towards templatizing common Lookup types"
...
This reverts commit 727135f3a9
2012-07-11 18:01:27 -04:00
727135f3a9
Towards templatizing common Lookup types
2012-07-11 18:00:28 -04:00
b12e2549cb
Minor
2012-06-09 03:05:20 -04:00
f19e0b0099
Match input before backtrack
...
Makes more sense, optimization-wise.
2012-06-09 02:26:57 -04:00
ce47613889
Micro-optimize
...
I know...
2012-06-09 01:43:15 -04:00
7b84c536c1
In MarkBase attachment, only attach to first of a MultipleSubst sequence
...
This is apparently what Uniscribe does. Test case is:
SEEN FATHA TEH ALEF
with Arabic Typesetting. Originally reported by Khaled Hosny.
2012-06-08 22:04:23 -04:00
e085fcf7ca
Remove unused buffer->replace_glyphs_be16
2012-06-08 21:45:00 -04:00
3ec77d6ae0
Don't use replace_glyphs_be for MultipleSubst
2012-06-08 21:44:06 -04:00
4b7192125f
Minor
2012-06-08 21:41:46 -04:00
68b76121f8
Fix regressions introduced by sed. Ouch!
...
Introduced in 99c2695759
2012-06-08 10:47:00 -04:00
2a3d911fe0
Fix alignment-requirement missmatch
...
Detected by clang and lots of cmdline options.
2012-06-07 17:31:46 -04:00
ed2f1363a3
Fix substitution glyph class propagation
...
The old code was doing nothing.
Still got to find an example font+string that makes this matter, but
need this for fixing synthetic GDEF anyway.
2012-05-22 22:12:22 -04:00
99c2695759
Add accessort to buffer for current info, current pos, and prev info
2012-05-13 15:45:18 +02:00
6736f3c5b0
Minor
2012-05-13 15:21:06 +02:00
5df809b655
[GSUB/GPOS] Remove context_length
...
The spec doesn't say contextual matching should be done this way,
and AOTS doesn't do it either. It was inherited from old HarfBuzz.
Remove it.
2012-05-13 15:17:51 +02:00
28b9d502bb
Minor
2012-05-13 15:04:00 +02:00
5f131d3226
[GSUB/GPOS/Indic] Apply GSUB/GPOS within syllables only
...
This does not apply to the context matchings.
This regresses tests right now. And we are not sure whether this is
the right thing to do for GPOS. But we'll figure out.
2012-05-11 17:29:40 +02:00
8fd83aaf6e
[GSUB/GPOS] Fix wrong buffer access in backward skippy mask matching
2012-05-11 17:18:37 +02:00
203d71069c
[GSUB/GPOS] Check all glyph masks when matching input
2012-05-11 16:01:44 +02:00
cee7187447
[Indic] Move syllable tracking from Indic to generic layer
...
This is to incorporate it into GSUB/GPOS processing.
2012-05-11 11:41:39 +02:00
55fe2cf79b
Make APPLY debug output print current index and codepoint
...
Yay!
2012-05-11 03:56:33 +02:00
98619ce4fa
Minor
2012-05-11 02:34:06 +02:00
acea183e98
Add return annotation for APPLY
2012-05-11 02:33:11 +02:00
0ab8c86217
Annotate SANITIZE return values
...
More to come, for APPLY, CLOSURE, etc.
2012-05-11 02:11:52 +02:00
6f45538017
More massaging trace messaging
2012-05-10 23:24:43 +02:00
208109703c
Better trace message support infrastructure
...
We have varargs in the trace interface now. To be used soon...
2012-05-10 23:06:58 +02:00
a9844d41c6
Combine lig_id and lig_comp into one byte, to free up one for Indic
2012-05-09 17:53:13 +02:00
5caece67ab
Make closure() return void
2012-04-23 23:03:12 -04:00
5b93e8d94f
Update copyright headers
2012-04-23 22:26:27 -04:00
6a9be5bd35
Rename hb_glyph_map_t to hb_set_t
2012-04-23 22:23:17 -04:00
31081f7390
Implement closure() for Context and ChainContext lookups
2012-04-23 16:54:58 -04:00
Behdad Esfahbod