From 3c60c1c7f1e354dc62f81147be7d5dbea26314c5 Mon Sep 17 00:00:00 2001
From: Takase <20792268+takase1121@users.noreply.github.com>
Date: Sun, 16 Apr 2023 21:18:40 +0800
Subject: [PATCH] Build releases with Ubuntu 18.04 container (#1460)

* ci(release): try using lite-xl-build-box

* ci(build): test with my own fork

* ci(build): do not install python via actions

* ci(build): disable package updates

* fix(scripts/appimage.sh): add workaround for non-FUSE environments

* ci(build): document why the actions are disabled

* ci(release): fix typo
---
 .github/workflows/release.yml | 11 +++++++++++
 scripts/appimage.sh           |  2 +-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 206931c7..581b6469 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -50,6 +50,7 @@ jobs:
     name: Linux
     needs: release
     runs-on: ubuntu-latest
+    container: ghcr.io/takase1121/lite-xl-build-box:latest
     env:
       CC: gcc
       CXX: g++
@@ -59,16 +60,26 @@ jobs:
           echo "$HOME/.local/bin" >> "$GITHUB_PATH"
           echo "INSTALL_REF=${{ needs.release.outputs.version }}" >> "$GITHUB_ENV"
       - uses: actions/checkout@v3
+
+      # disabled because this will break our own Python install
       - name: Python Setup
+        if: false
         uses: actions/setup-python@v4
         with:
           python-version: 3.9
+
+      # disabled because the container has up-to-date packages
       - name: Update Packages
+        if: false
         run: sudo apt-get update
+
+      # disabled as the dependencies are already installed
       - name: Install Dependencies
+        if: false
         run: |
           bash scripts/install-dependencies.sh --debug
           sudo apt-get install -y ccache
+
       - name: Build Portable
         run: |
           bash --version
diff --git a/scripts/appimage.sh b/scripts/appimage.sh
index 03de616c..17551a48 100644
--- a/scripts/appimage.sh
+++ b/scripts/appimage.sh
@@ -181,7 +181,7 @@ generate_appimage() {
     version="${version}-addons"
   fi
 
-  ./appimagetool LiteXL.AppDir LiteXL${version}-${ARCH}.AppImage
+  ./appimagetool --appimage-extract-and-run LiteXL.AppDir LiteXL${version}-${ARCH}.AppImage
 }
 
 setup_appimagetool