walkero
/
lite-xl
1
0
Fork 0
Code Issues 7 Pull Requests Projects Releases 14 Wiki Activity

fix(dirmonitor): avoid calling the change callback multiple times in the same notification (#1824)

This commit is contained in:
Guldoman 2024-06-22 22:36:27 +02:00 committed by GitHub
parent 1a045e5e86
commit face6af0da
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/api/dirmonitor.c
View File

@ -26,7 +26,19 @@ int get_mode_dirmonitor();
static int f_check_dir_callback(int watch_id, const char* path, void* L) {
// using absolute indices from f_dirmonitor_check (2: callback, 3: error_callback)
// using absolute indices from f_dirmonitor_check (2: callback, 3: error_callback, 4: watch_id notified table)
// Check if we already notified about this watch
lua_rawgeti(L, 4, watch_id);
bool skip = !lua_isnoneornil(L, -1);
lua_pop(L, 1);
if (skip) return 0;
// Set watch as notified
lua_pushboolean(L, true);
lua_rawseti(L, 4, watch_id);
// Prepare callback call
lua_pushvalue(L, 2);
if (path)
lua_pushlstring(L, path, watch_id);
@ -117,6 +129,9 @@ static int f_dirmonitor_check(lua_State* L) {
if (monitor->length < 0)
lua_pushnil(L);
else if (monitor->length > 0) {
// Create a table for keeping track of what watch ids were notified in this check,
// so that we avoid notifying multiple times.
lua_newtable(L);
if (translate_changes_dirmonitor(monitor->internal, monitor->buffer, monitor->length, f_check_dir_callback, L) == 0)
monitor->length = 0;
lua_pushboolean(L, 1);