From 02a7182ebd0013344d7f6f8cf86f4a9aed6ca0b8 Mon Sep 17 00:00:00 2001
From: Tatsuhiro Tsujikawa <tatsuhiro.t@gmail.com>
Date: Sat, 10 Aug 2013 00:42:11 +0900
Subject: [PATCH] src: Create strframetype to handle unknown frame types

---
 src/app_helper.cc | 39 ++++++++++++++++++++++++++-------------
 1 file changed, 26 insertions(+), 13 deletions(-)

diff --git a/src/app_helper.cc b/src/app_helper.cc
index 4e27040a..6564449e 100644
--- a/src/app_helper.cc
+++ b/src/app_helper.cc
@@ -91,17 +91,30 @@ const char* strsettingsid(int32_t id)
 } // namespace
 
 namespace {
-const char *frame_names[] = {
-  "DATA",
-  "HEADERS",
-  "PRIORITY",
-  "RST_STREAM",
-  "SETTINGS",
-  "PUSH_PROMISE",
-  "PING",
-  "GOAWAY",
-  "UNKNOWN",
-  "WINDOW_UPDATE"
+const char* strframetype(uint8_t type)
+{
+  switch(type) {
+  case NGHTTP2_DATA:
+    return "DATA";
+  case NGHTTP2_HEADERS:
+    return "HEADERS";
+  case NGHTTP2_PRIORITY:
+    return "PRIORITY";
+  case NGHTTP2_RST_STREAM:
+    return "RST_STREAM";
+  case NGHTTP2_SETTINGS:
+    return "SETTINGS";
+  case NGHTTP2_PUSH_PROMISE:
+    return "PUSH_PROMISE";
+  case NGHTTP2_PING:
+    return "PING";
+  case NGHTTP2_GOAWAY:
+    return "GOAWAY";
+  case NGHTTP2_WINDOW_UPDATE:
+    return "WINDOW_UPDATE";
+  default:
+    return "UNKNOWN";
+  }
 };
 } // namespace
 
@@ -231,7 +244,7 @@ void print_frame(print_type ptype, nghttp2_frame *frame)
 {
   printf("%s%s%s frame ",
          frame_name_ansi_esc(ptype),
-         frame_names[frame->hd.type],
+         strframetype(frame->hd.type),
          ansi_escend());
   print_frame_hd(frame->hd);
   if(frame->hd.flags) {
@@ -357,7 +370,7 @@ void on_frame_recv_parse_error_callback(nghttp2_session *session,
   print_timer();
   printf(" [PARSE_ERROR] recv %s%s%s frame\n",
          frame_name_ansi_esc(PRINT_RECV),
-         frame_names[type],
+         strframetype(type),
          ansi_escend());
   print_frame_attr_indent();
   printf("Error: %s\n", nghttp2_strerror(error_code));