From 0b48448270bc7440f278fdedfd998d2a0fb55a38 Mon Sep 17 00:00:00 2001 From: Tatsuhiro Tsujikawa Date: Sun, 25 Jan 2015 22:46:12 +0900 Subject: [PATCH] nghttpx: RST_STREAM for invalid request header values --- src/shrpx_http2_upstream.cc | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/shrpx_http2_upstream.cc b/src/shrpx_http2_upstream.cc index 4261e910..b49920af 100644 --- a/src/shrpx_http2_upstream.cc +++ b/src/shrpx_http2_upstream.cc @@ -179,19 +179,10 @@ int on_header_callback(nghttp2_session *session, const nghttp2_frame *frame, return 0; } - if (!nghttp2_check_header_name(name, namelen)) { - // we are not forgiving for malformed header field name in - // request. + if (!http2::check_nv(name, namelen, value, valuelen)) { upstream->rst_stream(downstream, NGHTTP2_PROTOCOL_ERROR); return NGHTTP2_ERR_TEMPORAL_CALLBACK_FAILURE; } - if (!nghttp2_check_header_value(value, valuelen)) { - return 0; - } - if (!http2::check_nv(name, namelen, value, valuelen)) { - // Simply discard name/value, as if it never happen. - return 0; - } auto token = http2::lookup_token(name, namelen);