walkero
/
nghttp2
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fix compiling static lib on Windows with MSVC 

On Windows, the DLL will create nghttp2.lib AND nghttp2.dll. Then the
static lib also tries to build nghttp2.lib, but that fails because it
already exists.

The nghttp2.lib created for the DLL cannot be used without the DLL. This
compiles the static nghttp2.lib into a separate directory, which works
around the above issue.

Signed-off-by: Matthew Horan <mhoran@pivotal.io>
This commit is contained in:
Sam Smith 2018-07-12 15:38:01 -04:00 committed by Matthew Horan
parent e5b3f9addd
commit 17df41def0
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/CMakeLists.txt
View File

@ -56,6 +56,7 @@ if(HAVE_CUNIT OR ENABLE_STATIC_LIB)
COMPILE_FLAGS "${WARNCFLAGS}" COMPILE_FLAGS "${WARNCFLAGS}"
VERSION ${LT_VERSION} SOVERSION ${LT_SOVERSION} VERSION ${LT_VERSION} SOVERSION ${LT_SOVERSION}
ARCHIVE_OUTPUT_NAME nghttp2 ARCHIVE_OUTPUT_NAME nghttp2
ARCHIVE_OUTPUT_DIRECTORY static
) )
target_compile_definitions(nghttp2_static PUBLIC "-DNGHTTP2_STATICLIB") target_compile_definitions(nghttp2_static PUBLIC "-DNGHTTP2_STATICLIB")
if(ENABLE_STATIC_LIB) if(ENABLE_STATIC_LIB)