walkero
/
nghttp2
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fix warnings 

modified:   url_parser.c

url_parser.c:589:17: warning: implicit conversion turns string literal into bool: 'const char [17]' to '_Bool' [-Wstring-conversion]⏎
        assert(!"Unexpected state");⏎
               ~^~~~~~~~~~~~~~~~~~⏎
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'⏎
    (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)⏎
                        ^⏎
url_parser.c:627:17: warning: declaration shadows a local variable [-Wshadow]⏎
    const char* p;⏎
                ^⏎
url_parser.c:536:15: note: previous declaration is here⏎
  const char *p;⏎
              ^⏎
url_parser.c:640:15: warning: implicit conversion changes signedness: 'int' to 'unsigned long' [-Wsign-conversion]⏎
      v += *p - '0';⏎
        ~~ ~~~^~~~~⏎
3 warnings generated.
This commit is contained in:
Andrew Kistler 2022-09-08 10:16:28 -04:00
parent 9f5bf5c7dd
commit 441de58f8e
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
third-party/url-parser/url_parser.c vendored
View File

@ -586,7 +586,7 @@ http_parser_parse_url(const char *buf, size_t buflen, int is_connect,
break; break;
default: default:
assert(!"Unexpected state"); assert("Unexpected state" != NULL);
return 1; return 1;
} }
@ -624,9 +624,8 @@ http_parser_parse_url(const char *buf, size_t buflen, int is_connect,
if (u->field_set & (1 << UF_PORT)) { if (u->field_set & (1 << UF_PORT)) {
uint16_t off; uint16_t off;
uint16_t len; uint16_t len;
const char* p;
const char* end; const char* end;
unsigned long v; signed long v;
off = u->field_data[UF_PORT].off; off = u->field_data[UF_PORT].off;
len = u->field_data[UF_PORT].len; len = u->field_data[UF_PORT].len;