walkero
/
nghttp2
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

nghttpx: Fix resource leak

This commit is contained in:
Tatsuhiro Tsujikawa 2013-09-07 01:46:46 +09:00
parent 92a6549f78
commit 56f7debad6
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/shrpx_spdy_downstream_connection.cc
View File

@ -236,7 +236,7 @@ int SpdyDownstreamConnection::push_request_headers()
// 10 means :method, :scheme, :path and possible via and // 10 means :method, :scheme, :path and possible via and
// x-forwarded-for header fields. We rename host header field as // x-forwarded-for header fields. We rename host header field as
// :host. // :host.
const char **nv = new const char*[nheader * 2 + 10 + 1]; auto nv = util::make_unique<const char*[]>(nheader * 2 + 10 + 1);
size_t hdidx = 0; size_t hdidx = 0;
std::string via_value; std::string via_value;
std::string xff_value; std::string xff_value;
@ -363,11 +363,10 @@ int SpdyDownstreamConnection::push_request_headers()
nghttp2_data_provider data_prd; nghttp2_data_provider data_prd;
data_prd.source.ptr = this; data_prd.source.ptr = this;
data_prd.read_callback = spdy_data_read_callback; data_prd.read_callback = spdy_data_read_callback;
rv = spdy_->submit_request(this, 0, nv, &data_prd); rv = spdy_->submit_request(this, 0, nv.get(), &data_prd);
} else { } else {
rv = spdy_->submit_request(this, 0, nv, 0); rv = spdy_->submit_request(this, 0, nv.get(), 0);
} }
delete [] nv;
if(rv != 0) { if(rv != 0) {
DCLOG(FATAL, this) << "nghttp2_submit_request() failed"; DCLOG(FATAL, this) << "nghttp2_submit_request() failed";
return -1; return -1;