From 5d7b7a169133e6a5bc38fed7d3196a38ccfac9ff Mon Sep 17 00:00:00 2001
From: Tatsuhiro Tsujikawa <tatsuhiro.t@gmail.com>
Date: Sun, 25 Aug 2013 23:21:07 +0900
Subject: [PATCH] nghttpx: Stream error if mandatory HTTP/2 request header
 field is missing

---
 src/shrpx_http2_upstream.cc | 32 ++++++++++++--------------------
 1 file changed, 12 insertions(+), 20 deletions(-)

diff --git a/src/shrpx_http2_upstream.cc b/src/shrpx_http2_upstream.cc
index d5bc9607..d545150b 100644
--- a/src/shrpx_http2_upstream.cc
+++ b/src/shrpx_http2_upstream.cc
@@ -252,19 +252,17 @@ void on_frame_recv_callback
             break;
           }
         }
-        if(!bad_req &&
-           !util::strieq("CONNECT",
-                         nva[req_hdidx[1]].value,
-                         nva[req_hdidx[1]].valuelen) &&
-           (frame->hd.flags & NGHTTP2_FLAG_END_STREAM) == 0 &&
-           req_hdidx[4] == -1) {
-          // If content-length is missing,
-          // Downstream::push_upload_data_chunk will fail and
-          // RST_STREAM will be sent. Therefore, error reply in
-          // HEADERS may not be sent. So just issue RST_STREAM here.
-          upstream->rst_stream(downstream, NGHTTP2_PROTOCOL_ERROR);
-          return;
-        }
+      }
+      if(!bad_req &&
+         !util::strieq("CONNECT",
+                       nva[req_hdidx[1]].value,
+                       nva[req_hdidx[1]].valuelen) &&
+         (frame->hd.flags & NGHTTP2_FLAG_END_STREAM) == 0 &&
+         req_hdidx[4] == -1) {
+        // If content-length is missing,
+        // Downstream::push_upload_data_chunk will fail and
+        // RST_STREAM will be sent.
+        bad_req = true;
       }
       if(!bad_req) {
         for(; i < frame->headers.nvlen; ++i) {
@@ -279,13 +277,7 @@ void on_frame_recv_callback
       }
     }
     if(bad_req) {
-      downstream->set_request_state(Downstream::HEADER_COMPLETE);
-      if(frame->hd.flags & NGHTTP2_FLAG_END_STREAM) {
-        downstream->set_request_state(Downstream::MSG_COMPLETE);
-      }
-      if(upstream->error_reply(downstream, 400) != 0) {
-        upstream->rst_stream(downstream, NGHTTP2_PROTOCOL_ERROR);
-      }
+      upstream->rst_stream(downstream, NGHTTP2_PROTOCOL_ERROR);
       return;
     }