walkero
/
nghttp2
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

nghttpx: Fail if :status is not digits on http2 downstream

This commit is contained in:
Tatsuhiro Tsujikawa 2014-08-08 23:08:24 +09:00
parent e217e789de
commit 704bbbfcaa
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/shrpx_http2_session.cc
View File

@ -921,7 +921,11 @@ int on_response_headers(Http2Session *http2session,
} }
auto status = http2::get_unique_header(nva, ":status"); auto status = http2::get_unique_header(nva, ":status");
if(!status || http2::value_lws(status)) { int status_code;
if(!status || http2::value_lws(status) ||
(status_code = http2::parse_http_status_code(status->value)) == -1) {
http2session->submit_rst_stream(frame->hd.stream_id, http2session->submit_rst_stream(frame->hd.stream_id,
NGHTTP2_PROTOCOL_ERROR); NGHTTP2_PROTOCOL_ERROR);
downstream->set_response_state(Downstream::MSG_RESET); downstream->set_response_state(Downstream::MSG_RESET);
@ -930,8 +934,7 @@ int on_response_headers(Http2Session *http2session,
return 0; return 0;
} }
downstream->set_response_http_status(strtoul(status->value.c_str(), downstream->set_response_http_status(status_code);
nullptr, 10));
downstream->set_response_major(2); downstream->set_response_major(2);
downstream->set_response_minor(0); downstream->set_response_minor(0);