walkero
/
nghttp2
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

nghttp2_submit: fix Parameter 'flags' is always rewritten in function body before being used found by PVS Studio (V763)

This commit is contained in:
Alexis La Goutte 2017-01-03 21:35:49 +01:00
parent 3933280d29
commit 87d1692e27
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/nghttp2_submit.c
View File

@ -365,7 +365,7 @@ int32_t nghttp2_submit_push_promise(nghttp2_session *session, uint8_t flags _U_,
return promised_stream_id; return promised_stream_id;
} }
int nghttp2_submit_window_update(nghttp2_session *session, uint8_t flags, int nghttp2_submit_window_update(nghttp2_session *session, uint8_t flags _U_,
int32_t stream_id, int32_t stream_id,
int32_t window_size_increment) { int32_t window_size_increment) {
int rv; int rv;
@ -373,7 +373,6 @@ int nghttp2_submit_window_update(nghttp2_session *session, uint8_t flags,
if (window_size_increment == 0) { if (window_size_increment == 0) {
return 0; return 0;
} }
flags = 0;
if (stream_id == 0) { if (stream_id == 0) {
rv = nghttp2_adjust_local_window_size( rv = nghttp2_adjust_local_window_size(
&session->local_window_size, &session->recv_window_size, &session->local_window_size, &session->recv_window_size,
@ -404,14 +403,14 @@ int nghttp2_submit_window_update(nghttp2_session *session, uint8_t flags,
nghttp2_max(0, stream->consumed_size - window_size_increment); nghttp2_max(0, stream->consumed_size - window_size_increment);
} }
return nghttp2_session_add_window_update(session, flags, stream_id, return nghttp2_session_add_window_update(session, 0, stream_id,
window_size_increment); window_size_increment);
} }
return 0; return 0;
} }
int nghttp2_session_set_local_window_size(nghttp2_session *session, int nghttp2_session_set_local_window_size(nghttp2_session *session,
uint8_t flags, int32_t stream_id, uint8_t flags _U_, int32_t stream_id,
int32_t window_size) { int32_t window_size) {
int32_t window_size_increment; int32_t window_size_increment;
nghttp2_stream *stream; nghttp2_stream *stream;
@ -421,8 +420,6 @@ int nghttp2_session_set_local_window_size(nghttp2_session *session,
return NGHTTP2_ERR_INVALID_ARGUMENT; return NGHTTP2_ERR_INVALID_ARGUMENT;
} }
flags = 0;
if (stream_id == 0) { if (stream_id == 0) {
window_size_increment = window_size - session->local_window_size; window_size_increment = window_size - session->local_window_size;
@ -472,7 +469,7 @@ int nghttp2_session_set_local_window_size(nghttp2_session *session,
} }
if (window_size_increment > 0) { if (window_size_increment > 0) {
return nghttp2_session_add_window_update(session, flags, stream_id, return nghttp2_session_add_window_update(session, 0, stream_id,
window_size_increment); window_size_increment);
} }