From 89291e401029e3e252989e2d02e6babec8ba550a Mon Sep 17 00:00:00 2001
From: Tatsuhiro Tsujikawa <tatsuhiro.t@gmail.com>
Date: Tue, 23 Dec 2014 17:38:03 +0900
Subject: [PATCH] nghttpx: Improve priority handling in http2 upstream

---
 src/shrpx_http2_upstream.cc | 42 ++++++++++++++++++++++++++++++++-----
 src/shrpx_http2_upstream.h  |  5 +++++
 2 files changed, 42 insertions(+), 5 deletions(-)

diff --git a/src/shrpx_http2_upstream.cc b/src/shrpx_http2_upstream.cc
index 6b251701..4f6a9d12 100644
--- a/src/shrpx_http2_upstream.cc
+++ b/src/shrpx_http2_upstream.cc
@@ -46,7 +46,6 @@ using namespace nghttp2;
 namespace shrpx {
 
 namespace {
-const size_t OUTBUF_MAX_THRES = 16 * 1024;
 const size_t INBUF_MAX_THRES = 16 * 1024;
 } // namespace
 
@@ -598,11 +597,19 @@ uint32_t infer_upstream_rst_stream_error_code(uint32_t downstream_error_code) {
 }
 } // namespace
 
+namespace {
+void write_notify_cb(evutil_socket_t fd, short what, void *arg) {
+  auto upstream = static_cast<Http2Upstream *>(arg);
+  upstream->perform_send();
+}
+} // namespace
+
 Http2Upstream::Http2Upstream(ClientHandler *handler)
     : downstream_queue_(get_config()->http2_proxy
                             ? get_config()->downstream_connections_per_host
                             : 0),
-      handler_(handler), session_(nullptr), settings_timerev_(nullptr) {
+      handler_(handler), session_(nullptr), settings_timerev_(nullptr),
+      write_notifyev_(nullptr), deferred_(false) {
   reset_timeouts();
 
   int rv;
@@ -691,6 +698,8 @@ Http2Upstream::Http2Upstream(ClientHandler *handler)
       }
     }
   }
+
+  write_notifyev_ = evtimer_new(handler_->get_evbase(), write_notify_cb, this);
 }
 
 Http2Upstream::~Http2Upstream() {
@@ -698,6 +707,9 @@ Http2Upstream::~Http2Upstream() {
   if (settings_timerev_) {
     event_free(settings_timerev_);
   }
+  if (write_notifyev_) {
+    event_free(write_notifyev_);
+  }
 }
 
 int Http2Upstream::on_read() {
@@ -732,8 +744,17 @@ int Http2Upstream::on_read() {
 
 int Http2Upstream::on_write() { return send(); }
 
-// After this function call, downstream may be deleted.
 int Http2Upstream::send() {
+  if (write_notifyev_ == nullptr) {
+    return -1;
+  }
+  event_active(write_notifyev_, 0, 0);
+
+  return 0;
+}
+
+// After this function call, downstream may be deleted.
+int Http2Upstream::perform_send() {
   int rv;
   uint8_t buf[16384];
   auto bev = handler_->get_bev();
@@ -742,8 +763,7 @@ int Http2Upstream::send() {
   sendbuf.reset(output, buf, sizeof(buf), handler_->get_write_limit());
   for (;;) {
     // Check buffer length and break if it is large enough.
-    if (handler_->get_outbuf_length() + sendbuf.get_buflen() >=
-        OUTBUF_MAX_THRES) {
+    if (handler_->get_outbuf_length() > 0) {
       break;
     }
 
@@ -763,8 +783,13 @@ int Http2Upstream::send() {
       ULOG(FATAL, this) << "evbuffer_add() failed";
       return -1;
     }
+    if (deferred_) {
+      break;
+    }
   }
 
+  deferred_ = false;
+
   rv = sendbuf.flush();
   if (rv != 0) {
     ULOG(FATAL, this) << "evbuffer_add() failed";
@@ -1076,6 +1101,11 @@ ssize_t downstream_data_read_callback(nghttp2_session *session,
   }
 
   if (nread == 0 && ((*data_flags) & NGHTTP2_DATA_FLAG_EOF) == 0) {
+    // Higher priority stream is likely to be handled first and if it
+    // has no data to send, we'd better to break here, so that we have
+    // a chance to read another incoming data from backend to this
+    // stream.
+    upstream->set_deferred(true);
     return NGHTTP2_ERR_DEFERRED;
   }
 
@@ -1431,4 +1461,6 @@ int Http2Upstream::on_downstream_reset() {
   return 0;
 }
 
+void Http2Upstream::set_deferred(bool f) { deferred_ = f; }
+
 } // namespace shrpx
diff --git a/src/shrpx_http2_upstream.h b/src/shrpx_http2_upstream.h
index 11993dcf..3cea0119 100644
--- a/src/shrpx_http2_upstream.h
+++ b/src/shrpx_http2_upstream.h
@@ -51,6 +51,7 @@ public:
   virtual int on_downstream_abort_request(Downstream *downstream,
                                           unsigned int status_code);
   int send();
+  int perform_send();
   virtual ClientHandler *get_client_handler() const;
   virtual bufferevent_data_cb get_downstream_readcb();
   virtual bufferevent_data_cb get_downstream_writecb();
@@ -92,6 +93,8 @@ public:
   void start_downstream(Downstream *downstream);
   void initiate_downstream(std::unique_ptr<Downstream> downstream);
 
+  void set_deferred(bool f);
+
   nghttp2::util::EvbufferBuffer sendbuf;
 
 private:
@@ -100,7 +103,9 @@ private:
   ClientHandler *handler_;
   nghttp2_session *session_;
   event *settings_timerev_;
+  event *write_notifyev_;
   bool flow_control_;
+  bool deferred_;
 };
 
 } // namespace shrpx