walkero
/
nghttp2
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Update doc

This commit is contained in:
Tatsuhiro Tsujikawa 2015-11-23 21:05:25 +09:00
parent 2fee05242e
commit 8f970dec0e
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/nghttp2_session.c
View File

@ -661,6 +661,13 @@ int nghttp2_session_reprioritize_stream(
} }
if (dep_stream == stream->dep_prev && !pri_spec->exclusive) { if (dep_stream == stream->dep_prev && !pri_spec->exclusive) {
/* This is minor optimization when just weight is changed.
Currently, we don't reschedule stream in this case, since we
don't retain enough information to do that
(descendant_last_cycle we used to schedule it). This means new
weight is only applied in the next scheduling, and if weight is
drastically increased, library is not responding very quickly.
If this is really an issue, we will do workaround for this. */
dep_stream->sum_dep_weight += pri_spec->weight - stream->weight; dep_stream->sum_dep_weight += pri_spec->weight - stream->weight;
stream->weight = pri_spec->weight; stream->weight = pri_spec->weight;
return 0; return 0;

5
lib/nghttp2_stream.c
View File

@ -207,6 +207,11 @@ void nghttp2_stream_reschedule(nghttp2_stream *stream) {
dep_stream->descendant_last_cycle = 0; dep_stream->descendant_last_cycle = 0;
stream->cycle = 0; stream->cycle = 0;
} else { } else {
/* We update descendant_last_cycle here, and we don't do it when
no data is written for stream. This effectively means that
we treat these streams as if they are not scheduled at all.
This does not cause disruption in scheduling machinery. It
just makes new streams scheduled a bit early. */
dep_stream->descendant_last_cycle = stream->cycle; dep_stream->descendant_last_cycle = stream->cycle;
stream->cycle = stream->cycle =