From b7d16101413276884d7f51c64f989f5f61abecb8 Mon Sep 17 00:00:00 2001 From: Tatsuhiro Tsujikawa Date: Tue, 21 Apr 2020 22:10:15 +0900 Subject: [PATCH] Add missing connection error handling --- lib/nghttp2_session.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/nghttp2_session.c b/lib/nghttp2_session.c index 563ccd7d..2efcfc69 100644 --- a/lib/nghttp2_session.c +++ b/lib/nghttp2_session.c @@ -4698,7 +4698,12 @@ int nghttp2_session_on_ping_received(nghttp2_session *session, rv = nghttp2_session_add_ping(session, NGHTTP2_FLAG_ACK, frame->ping.opaque_data); if (rv != 0) { - return rv; + if (nghttp2_is_fatal(rv)) { + return rv; + } + + return session_handle_invalid_connection(session, frame, + NGHTTP2_ERR_INTERNAL, NULL); } } return session_call_on_frame_received(session, frame);