From bacea078dab53a68746637d030b27991ce942eec Mon Sep 17 00:00:00 2001
From: Tatsuhiro Tsujikawa <tatsuhiro.t@gmail.com>
Date: Sun, 19 Jan 2014 17:42:31 +0900
Subject: [PATCH] nghttpx: Take into account both frontend buffer and body
 buffer length

---
 src/shrpx_http2_upstream.cc | 11 ++++++++---
 src/shrpx_spdy_upstream.cc  | 16 ++++++++++++++--
 2 files changed, 22 insertions(+), 5 deletions(-)

diff --git a/src/shrpx_http2_upstream.cc b/src/shrpx_http2_upstream.cc
index 22f2afdf..227c501c 100644
--- a/src/shrpx_http2_upstream.cc
+++ b/src/shrpx_http2_upstream.cc
@@ -882,6 +882,7 @@ ssize_t downstream_data_read_callback(nghttp2_session *session,
 {
   auto downstream = reinterpret_cast<Downstream*>(source->ptr);
   auto upstream = reinterpret_cast<Http2Upstream*>(downstream->get_upstream());
+  auto handler = upstream->get_client_handler();
   auto body = downstream->get_response_body_buf();
   assert(body);
   int nread = evbuffer_remove(body, buf, length);
@@ -906,7 +907,8 @@ ssize_t downstream_data_read_callback(nghttp2_session *session,
   // Send WINDOW_UPDATE before buffer is empty to avoid delay because
   // of RTT.
   if(*eof != 1 &&
-     evbuffer_get_length(body) < SHRPX_HTTP2_UPSTREAM_OUTPUT_UPPER_THRES) {
+     handler->get_pending_write_length() + evbuffer_get_length(body) <
+     SHRPX_HTTP2_UPSTREAM_OUTPUT_UPPER_THRES) {
     if(downstream->resume_read(SHRPX_NO_BUFFER) != 0) {
       return NGHTTP2_ERR_CALLBACK_FAILURE;
     }
@@ -1074,6 +1076,8 @@ int Http2Upstream::on_downstream_header_complete(Downstream *downstream)
 int Http2Upstream::on_downstream_body(Downstream *downstream,
                                       const uint8_t *data, size_t len)
 {
+  auto upstream = downstream->get_upstream();
+  auto handler = upstream->get_client_handler();
   auto body = downstream->get_response_body_buf();
   int rv = evbuffer_add(body, data, len);
   if(rv != 0) {
@@ -1082,8 +1086,9 @@ int Http2Upstream::on_downstream_body(Downstream *downstream,
   }
   nghttp2_session_resume_data(session_, downstream->get_stream_id());
 
-  size_t bodylen = evbuffer_get_length(body);
-  if(bodylen > SHRPX_HTTP2_UPSTREAM_OUTPUT_UPPER_THRES) {
+  auto outbuflen = handler->get_pending_write_length() +
+    evbuffer_get_length(body);
+  if(outbuflen > SHRPX_HTTP2_UPSTREAM_OUTPUT_UPPER_THRES) {
     downstream->pause_read(SHRPX_NO_BUFFER);
   }
 
diff --git a/src/shrpx_spdy_upstream.cc b/src/shrpx_spdy_upstream.cc
index 0a632d2e..121849ae 100644
--- a/src/shrpx_spdy_upstream.cc
+++ b/src/shrpx_spdy_upstream.cc
@@ -726,6 +726,7 @@ ssize_t spdy_data_read_callback(spdylay_session *session,
 {
   auto downstream = reinterpret_cast<Downstream*>(source->ptr);
   auto upstream = reinterpret_cast<SpdyUpstream*>(downstream->get_upstream());
+  auto handler = upstream->get_client_handler();
   auto body = downstream->get_response_body_buf();
   assert(body);
   int nread = evbuffer_remove(body, buf, length);
@@ -747,6 +748,15 @@ ssize_t spdy_data_read_callback(spdylay_session *session,
                            (downstream->get_response_rst_stream_error_code()));
     }
   }
+  // Send WINDOW_UPDATE before buffer is empty to avoid delay because
+  // of RTT.
+  if(*eof != 1 &&
+     handler->get_pending_write_length() + evbuffer_get_length(body) <
+     SHRPX_SPDY_UPSTREAM_OUTPUT_UPPER_THRES) {
+    if(downstream->resume_read(SHRPX_NO_BUFFER) != 0) {
+      return SPDYLAY_ERR_CALLBACK_FAILURE;
+    }
+  }
   if(nread == 0 && *eof != 1) {
     return SPDYLAY_ERR_DEFERRED;
   }
@@ -912,6 +922,7 @@ int SpdyUpstream::on_downstream_header_complete(Downstream *downstream)
 int SpdyUpstream::on_downstream_body(Downstream *downstream,
                                      const uint8_t *data, size_t len)
 {
+  auto upstream = downstream->get_upstream();
   auto body = downstream->get_response_body_buf();
   int rv = evbuffer_add(body, data, len);
   if(rv != 0) {
@@ -920,8 +931,9 @@ int SpdyUpstream::on_downstream_body(Downstream *downstream,
   }
   spdylay_session_resume_data(session_, downstream->get_stream_id());
 
-  size_t bodylen = evbuffer_get_length(body);
-  if(bodylen > SHRPX_SPDY_UPSTREAM_OUTPUT_UPPER_THRES) {
+  auto outbuflen = upstream->get_client_handler()->get_pending_write_length() +
+    evbuffer_get_length(body);
+  if(outbuflen > SHRPX_SPDY_UPSTREAM_OUTPUT_UPPER_THRES) {
     downstream->pause_read(SHRPX_NO_BUFFER);
   }