Workaround stream treated inferior when it hits connection window limit

This commit is contained in:
Tatsuhiro Tsujikawa 2015-01-31 15:49:10 +09:00
parent f1049a66e2
commit bbc34904c1
1 changed files with 8 additions and 2 deletions

View File

@ -2523,8 +2523,14 @@ static int session_after_frame_sent2(nghttp2_session *session) {
assert(stream); assert(stream);
next_item = nghttp2_session_get_next_ob_item(session); next_item = nghttp2_session_get_next_ob_item(session);
/* Imagine we hit connection window size limit while sending DATA
frame. If we decrement weight here, its stream might get
inferior share because the other streams' weight is not
decremented because of flow control. */
if (session->remote_window_size > 0 || stream->remote_window_size <= 0) {
session_outbound_item_cycle_weight(session, aob->item, session_outbound_item_cycle_weight(session, aob->item,
stream->effective_weight); stream->effective_weight);
}
/* If priority of this stream is higher or equal to other stream /* If priority of this stream is higher or equal to other stream
waiting at the top of the queue, we continue to send this waiting at the top of the queue, we continue to send this