walkero
/
nghttp2
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Check upstream header length only in Downstream::INITIAL state.

This commit is contained in:
Tatsuhiro Tsujikawa 2012-06-10 00:30:44 +09:00
parent 9d19e2bfe9
commit bff22fd1e9
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
examples/shrpx_https_upstream.cc
View File

@ -239,8 +239,8 @@ int HttpsUpstream::on_read()
// Well, actually header length + some body bytes // Well, actually header length + some body bytes
current_header_length_ += nread; current_header_length_ += nread;
htpparse_error htperr = htparser_get_error(htp_); htpparse_error htperr = htparser_get_error(htp_);
if(htperr == htparse_error_user) {
Downstream *downstream = get_top_downstream(); Downstream *downstream = get_top_downstream();
if(htperr == htparse_error_user) {
if(downstream->get_request_state() == Downstream::CONNECT_FAIL) { if(downstream->get_request_state() == Downstream::CONNECT_FAIL) {
get_client_handler()->set_should_close_after_write(true); get_client_handler()->set_should_close_after_write(true);
error_reply(503); error_reply(503);
@ -257,7 +257,9 @@ int HttpsUpstream::on_read()
} }
} }
} else if(htperr == htparse_error_none) { } else if(htperr == htparse_error_none) {
if(current_header_length_ > SHRPX_HTTPS_MAX_HEADER_LENGTH) { // downstream can be NULL here.
if(downstream && downstream->get_request_state() == Downstream::INITIAL &&
current_header_length_ > SHRPX_HTTPS_MAX_HEADER_LENGTH) {
LOG(WARNING) << "Request Header too long:" << current_header_length_ LOG(WARNING) << "Request Header too long:" << current_header_length_
<< " bytes"; << " bytes";
get_client_handler()->set_should_close_after_write(true); get_client_handler()->set_should_close_after_write(true);