walkero
/
openjpeg
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

jp3d/jpwl convert: fix write stack buffer overflow 

Missing buffer length formatter in fscanf call might lead to write
stack buffer overflow.

fixes #1044 (CVE-2017-17480)
This commit is contained in:
Hugo Lefeuvre 2018-10-22 16:59:41 +02:00
parent 0e6a5553cf
commit 0bc90e4062
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/bin/jp3d/convert.c
View File

@ -297,8 +297,8 @@ opj_volume_t* pgxtovolume(char *relpath, opj_cparameters_t *parameters)
fprintf(stdout, "[INFO] Loading %s \n", pgxfiles[pos]); fprintf(stdout, "[INFO] Loading %s \n", pgxfiles[pos]);
fseek(f, 0, SEEK_SET); fseek(f, 0, SEEK_SET);
fscanf(f, "PG%[ \t]%c%c%[ \t+-]%d%[ \t]%d%[ \t]%d", temp, &endian1, &endian2, fscanf(f, "PG%31[ \t]%c%c%31[ \t+-]%d%31[ \t]%d%31[ \t]%d", temp, &endian1,
signtmp, &prec, temp, &w, temp, &h); &endian2, signtmp, &prec, temp, &w, temp, &h);
i = 0; i = 0;
sign = '+'; sign = '+';

2
src/bin/jpwl/convert.c
View File

@ -1349,7 +1349,7 @@ opj_image_t* pgxtoimage(const char *filename, opj_cparameters_t *parameters)
} }
fseek(f, 0, SEEK_SET); fseek(f, 0, SEEK_SET);
if (fscanf(f, "PG%[ \t]%c%c%[ \t+-]%d%[ \t]%d%[ \t]%d", temp, &endian1, if (fscanf(f, "PG%31[ \t]%c%c%31[ \t+-]%d%31[ \t]%d%31[ \t]%d", temp, &endian1,
&endian2, signtmp, &prec, temp, &w, temp, &h) != 9) { &endian2, signtmp, &prec, temp, &w, temp, &h) != 9) {
fprintf(stderr, fprintf(stderr,
"ERROR: Failed to read the right number of element from the fscanf() function!\n"); "ERROR: Failed to read the right number of element from the fscanf() function!\n");