From 27b894dd3fd6d67dacf6c263587d789d96172116 Mon Sep 17 00:00:00 2001 From: Antonin Descampe Date: Thu, 14 Apr 2011 10:13:25 +0000 Subject: [PATCH] fixed applications/codec/CMakeLists.txt that prevented JPWL executables to be built with JPWL functionalities ; changed make all behaviour : DOC target removed from ALL --- CHANGES | 4 ++++ CMakeLists.txt | 7 ++----- INSTALL | 5 ++++- applications/codec/CMakeLists.txt | 14 ++++++++++++-- doc/CMakeLists.txt | 5 +---- 5 files changed, 23 insertions(+), 12 deletions(-) diff --git a/CHANGES b/CHANGES index 119c1f3c..d5e3dfd1 100644 --- a/CHANGES +++ b/CHANGES @@ -5,6 +5,10 @@ What's New for OpenJPEG ! : changed + : added +April 14, 2011 +* [antonin] fixed applications/codec/CMakeLists.txt that prevented JPWL executables to be built with JPWL functionalities. +! [antonin] changed make all behaviour : DOC target removed from ALL. + April 13, 2011 ! [antonin] changed the directory hierarchy of the whole project. See README files for details. ! [antonin] moved "openjpeg3d" directory from the trunk to the branches directory. diff --git a/CMakeLists.txt b/CMakeLists.txt index 474a5f02..c4297e70 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -218,11 +218,8 @@ ADD_SUBDIRECTORY(applications) OPTION(BUILD_JPWL "Build the JPWL library and executables" OFF) #----------------------------------------------------------------------------- -# Build DOCUMENTATION -OPTION(BUILD_DOC "Build the doxygen documentation" OFF) -IF(BUILD_DOC) - ADD_SUBDIRECTORY(doc) -ENDIF(BUILD_DOC) +# Build DOCUMENTATION (not in ALL target and only if Doxygen is found) +ADD_SUBDIRECTORY(doc) #----------------------------------------------------------------------------- # CDash+CMake : to be updated diff --git a/INSTALL b/INSTALL index bc26d76f..a3d97475 100644 --- a/INSTALL +++ b/INSTALL @@ -53,6 +53,10 @@ If you are root: else: sudo make install make clean + +To build the Doxygen documentation (Doxygen needs to be found on the system): +(A 'html' directory is generated in the 'doc' directory) + make doc Binaries are located in the 'bin' directory. @@ -64,7 +68,6 @@ Main available cmake flags: * To build the MJ2 executables: '-DBUILD_MJ2:bool=on' (default: 'OFF') * To build the JPWL executables and JPWL library: '-DBUILD_JPWL:bool=on' (default: 'OFF') * [WIN32 ONLY] To build the INDEXER_JPIP executable: '-DBUILD_INDEXER_JPIP:bool=on' (default: 'OFF') -* To build the doxygen documentation: '-DBUILD_DOC:bool=on' (default: 'OFF') * To enable testing (and automatic result upload to http://my.cdash.org/index.php?project=OPENJPEG): cmake . -DBUILD_TESTING:BOOL=ON -DJPEG2000_CONFORMANCE_DATA_ROOT:PATH=/path/to/your/JPEG2000/test/files make diff --git a/applications/codec/CMakeLists.txt b/applications/codec/CMakeLists.txt index 02d90fc5..37c8bb5d 100644 --- a/applications/codec/CMakeLists.txt +++ b/applications/codec/CMakeLists.txt @@ -66,10 +66,15 @@ IF(BUILD_JPWL) j2k_to_image.c ${common_SRCS} ) + + SET_PROPERTY( + TARGET JPWL_j2k_to_image + APPEND PROPERTY COMPILE_DEFINITIONS USE_JPWL + ) TARGET_LINK_LIBRARIES(JPWL_j2k_to_image ${OPENJPEG_LIBRARY_NAME}_JPWL ${LCMS_LIBNAME} ${Z_LIBNAME} ${PNG_LIBNAME} ${TIFF_LIBNAME}) - # + IF(UNIX) TARGET_LINK_LIBRARIES(JPWL_j2k_to_image m) ENDIF(UNIX) @@ -78,10 +83,15 @@ IF(BUILD_JPWL) image_to_j2k.c ${common_SRCS} ) + + SET_PROPERTY( + TARGET JPWL_image_to_j2k + APPEND PROPERTY COMPILE_DEFINITIONS USE_JPWL + ) TARGET_LINK_LIBRARIES(JPWL_image_to_j2k ${OPENJPEG_LIBRARY_NAME}_JPWL ${LCMS_LIBNAME} ${Z_LIBNAME} ${PNG_LIBNAME} ${TIFF_LIBNAME}) - # + IF(UNIX) TARGET_LINK_LIBRARIES(JPWL_image_to_j2k m) ENDIF(UNIX) diff --git a/doc/CMakeLists.txt b/doc/CMakeLists.txt index aadbadba..08741c64 100644 --- a/doc/CMakeLists.txt +++ b/doc/CMakeLists.txt @@ -3,10 +3,7 @@ FIND_PACKAGE(Doxygen) IF(DOXYGEN_EXECUTABLE) # The Doxyfile.dox is poorly defined and produce output # in the source dir -ADD_CUSTOM_TARGET(doxygen -# By default doxygen target is added to the 'all' target. Project is small -# thus running doxygen is not too time consuming - ALL +ADD_CUSTOM_TARGET(doc ${DOXYGEN} ${CMAKE_CURRENT_SOURCE_DIR}/Doxyfile.dox WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}