ENH: Fix unitialized read in img_fol (we may need a smarter initialize than memset)

This commit is contained in:
Mathieu Malaterre 2007-09-06 16:49:15 +00:00
parent 8ac5e7023c
commit 53471a76f1
4 changed files with 7 additions and 1 deletions

View File

@ -14,6 +14,7 @@ September 6, 2007
+ [Mathieu Malaterre] CMake: Add doxygen output + [Mathieu Malaterre] CMake: Add doxygen output
+ [GB] One more field in the codestream_info struct for recording the number of packets per tile part; JPWL now distributes the EPBs in all the tile part headers + [GB] One more field in the codestream_info struct for recording the number of packets per tile part; JPWL now distributes the EPBs in all the tile part headers
+ [Mathieu Malaterre] CMake: Add very simple tests (simply run command line with no option) + [Mathieu Malaterre] CMake: Add very simple tests (simply run command line with no option)
* [Mathieu Malaterre] Fix unitialized read in img_fol (we may need a smarter initialize than memset)
September 4, 2007 September 4, 2007
+ [GB] Added some fields in the codestream_info structure: they are used to record the position of single tile parts. Changed also the write_index function in the codec, to reflect the presence of this new information. + [GB] Added some fields in the codestream_info structure: they are used to record the position of single tile parts. Changed also the write_index function in the codec, to reflect the presence of this new information.

View File

@ -42,7 +42,7 @@ FIND_PACKAGE(TIFF REQUIRED)
FOREACH(exe j2k_to_image image_to_j2k) FOREACH(exe j2k_to_image image_to_j2k)
ADD_EXECUTABLE(${exe} ${exe}.c ${common_SRCS}) ADD_EXECUTABLE(${exe} ${exe}.c ${common_SRCS})
TARGET_LINK_LIBRARIES(${exe} ${OPJ_PREFIX}openjpeg ${TIFF_LIBRARIES}) TARGET_LINK_LIBRARIES(${exe} ${OPJ_PREFIX}openjpeg ${TIFF_LIBRARIES})
ADD_TEST(${exe} ${exe}) ADD_TEST(${exe} ${EXECUTABLE_OUTPUT_PATH}/${exe})
# On unix you need to link to the math library: # On unix you need to link to the math library:
IF(UNIX) IF(UNIX)
TARGET_LINK_LIBRARIES(${exe} m) TARGET_LINK_LIBRARIES(${exe} m)

View File

@ -1745,6 +1745,9 @@ int main(int argc, char **argv) {
/* set encoding parameters to default values */ /* set encoding parameters to default values */
opj_set_default_encoder_parameters(&parameters); opj_set_default_encoder_parameters(&parameters);
/* need to initialize img_fol since parameters will be read in parse_cmdline_decoder */
memset(&img_fol,0,sizeof(img_fol_t));
/* parse input and get user encoding parameters */ /* parse input and get user encoding parameters */
if(parse_cmdline_encoder(argc, argv, &parameters,&img_fol, &raw_cp) == 1) { if(parse_cmdline_encoder(argc, argv, &parameters,&img_fol, &raw_cp) == 1) {
return 0; return 0;

View File

@ -517,6 +517,8 @@ int main(int argc, char **argv) {
/* set decoding parameters to default values */ /* set decoding parameters to default values */
opj_set_default_decoder_parameters(&parameters); opj_set_default_decoder_parameters(&parameters);
/* need to initialize img_fol since parameters will be read in parse_cmdline_decoder */
memset(&img_fol,0,sizeof(img_fol_t));
/* parse input and get user encoding parameters */ /* parse input and get user encoding parameters */
if(parse_cmdline_decoder(argc, argv, &parameters,&img_fol) == 1) { if(parse_cmdline_decoder(argc, argv, &parameters,&img_fol) == 1) {