Ignore ctest return code

ctest behavior is not consistent across versions.
Ignore return code & parse logs

tools/travis-ci/run.sh

@@ -121,21 +121,59 @@ export OPJ_SOURCE_DIR=${OPJ_SOURCE_DIR}
 export OPJ_BUILD_CONFIGURATION=${OPJ_CI_BUILD_CONFIGURATION}
 export OPJ_DO_SUBMIT=${OPJ_DO_SUBMIT}
 
-ctest -S ${OPJ_SOURCE_DIR}/tools/ctest_scripts/travis-ci.cmake -V
+ctest -S ${OPJ_SOURCE_DIR}/tools/ctest_scripts/travis-ci.cmake -V || true
-
+# ctest will exit with various error codes depending on version.
-# ctest will exit with error code 0 even if tests failed
+# ignore ctest exit code & parse this ourselves
-# let's parse discarding known failure
 set +x
+
+# let's parse configure/build/tests for failure
+
 echo "
-Parsing logs for new/unknown failures
+Parsing logs for failures
 "
 OPJ_CI_RESULT=0
 
-OPJ_HAS_TESTS=$(find build -path 'build/Testing/Temporary*' -name 'LastTestsFailed*' | wc -l)
+# 1st configure step
-OPJ_HAS_TESTS=$(echo $OPJ_HAS_TESTS) #macos wc workaround
+OPJ_CONFIGURE_XML=$(find build -path 'build/Testing/*' -name 'Configure.xml')
+if [ ! -f "${OPJ_CONFIGURE_XML}" ]; then
+	echo "No configure log found"
+	OPJ_CI_RESULT=1
+else
+	if ! grep '<ConfigureStatus>0</ConfigureStatus>' ${OPJ_CONFIGURE_XML} &> /dev/null; then
+		echo "Errors were found in configure log"
+		OPJ_CI_RESULT=1
+	fi
+fi
 
-if [ $OPJ_HAS_TESTS -ne 0 ]; then
+# 2nd build step
-	awk -F: '{ print $2 }' build/Testing/Temporary/LastTestsFailed_*.log > failures.txt
+# We must have one Build.xml file
+OPJ_BUILD_XML=$(find build -path 'build/Testing/*' -name 'Build.xml')
+if [ ! -f "${OPJ_BUILD_XML}" ]; then
+	echo "No build log found"
+	OPJ_CI_RESULT=1
+else
+	if grep '<Error>' ${OPJ_BUILD_XML} &> /dev/null; then
+		echo "Errors were found in build log"
+		OPJ_CI_RESULT=1
+	fi
+fi
+
+if [ ${OPJ_CI_RESULT} -ne 0 ]; then
+	# Don't trash output with failing tests when there are configure/build errors
+	exit ${OPJ_CI_RESULT}
+fi
+
+if [ "${OPJ_CI_SKIP_TESTS:-}" != "1" ]; then
+	OPJ_TEST_XML=$(find build -path 'build/Testing/*' -name 'Test.xml')
+	if [ ! -f "${OPJ_TEST_XML}" ]; then
+		echo "No test log found"
+		OPJ_CI_RESULT=1
+	else
+		echo "Parsing tests for new/unknown failures"
+		# 3rd test step
+		OPJ_FAILEDTEST_LOG=$(find build -path 'build/Testing/Temporary/*' -name 'LastTestsFailed_*.log')
+		if [ -f "${OPJ_FAILEDTEST_LOG}" ]; then
+			awk -F: '{ print $2 }' ${OPJ_FAILEDTEST_LOG} > failures.txt
 			while read FAILEDTEST; do
 				# Start with common errors
 				if grep -x "${FAILEDTEST}" ${OPJ_SOURCE_DIR}/tools/travis-ci/knownfailures-all.txt > /dev/null; then
@@ -149,16 +187,22 @@ if [ $OPJ_HAS_TESTS -ne 0 ]; then
 				echo "${FAILEDTEST}"
 				OPJ_CI_RESULT=1
 			done < failures.txt
-fi
+		fi
+	fi
 
-# TODO parse memcheck
+	# 4th memcheck step
+	OPJ_MEMCHECK_XML=$(find build -path 'build/Testing/*' -name 'MemCheck.xml')
+	if [ -f "${OPJ_MEMCHECK_XML}" ]; then
+		echo "TODO parse MemCheck.xml"
+	fi
 
-if [ ${OPJ_CI_RESULT} -eq 0 ]; then
+	if [ ${OPJ_CI_RESULT} -eq 0 ]; then
-	echo "No new/unknown failure found"
+		echo "No new/unknown test failure found"
-else
+	else
 		echo "
-New/unknown failures found!!!
+New/unknown test failure found!!!
-"
+	"
+	fi
 fi
 
 exit ${OPJ_CI_RESULT}