walkero
/
openjpeg
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

[trunk] Partially rework r2506, original patch from issue 171 was totally bogus (untested?) and did break most of the test (eg. p1_04 family) 

convert.c duplicate a lot of code, this patch only adresses the PGX codec section of the code.
Update issue 171
Update issue 264
This commit is contained in:
Mathieu Malaterre 2014-02-28 17:29:28 +00:00
parent 978de6fb97
commit ec593a2549
1 changed files with 82 additions and 71 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

151
src/bin/jp2/convert.c
View File

@ -1416,90 +1416,101 @@ opj_image_t* pgxtoimage(const char *filename, opj_cparameters_t *parameters) {
return image; return image;
} }
#define CLAMP(x,a,b) x < a ? a : (x > b ? b : x)
static inline int clamp( const int value, const int prec, const int sgnd )
{
if( sgnd )
{
if (prec <= 8) return CLAMP(value,-128,127);
else if (prec <= 16) return CLAMP(value,-32768,32767);
else return CLAMP(value,-2147483648,2147483647);
}
else
{
if (prec <= 8) return CLAMP(value,0,255);
else if (prec <= 16) return CLAMP(value,0,65535);
else return CLAMP(value,0,4294967295);
}
}
int imagetopgx(opj_image_t * image, const char *outfile) int imagetopgx(opj_image_t * image, const char *outfile)
{ {
int w, h; int w, h;
int i, j, compno, fails; int i, j, compno, fails = 1;
FILE *fdest = NULL; FILE *fdest = NULL;
for (compno = 0; compno < image->numcomps; compno++) for (compno = 0; compno < image->numcomps; compno++)
{ {
opj_image_comp_t *comp = &image->comps[compno]; opj_image_comp_t *comp = &image->comps[compno];
char bname[256]; /* buffer for name */ char bname[256]; /* buffer for name */
char *name = bname; /* pointer */ char *name = bname; /* pointer */
int nbytes = 0; int nbytes = 0;
size_t res; size_t res;
const size_t olen = strlen(outfile); const size_t olen = strlen(outfile);
const size_t dotpos = olen - 4; const size_t dotpos = olen - 4;
const size_t total = dotpos + 1 + 1 + 4; /* '-' + '[1-3]' + '.pgx' */ const size_t total = dotpos + 1 + 1 + 4; /* '-' + '[1-3]' + '.pgx' */
if( outfile[dotpos] != '.' ) if( outfile[dotpos] != '.' )
{ {
/* `pgx` was recognized but there is no dot at expected position */ /* `pgx` was recognized but there is no dot at expected position */
fprintf(stderr, "ERROR -> Impossible happen." ); fprintf(stderr, "ERROR -> Impossible happen." );
return 1; goto fin;
} }
if( total > 256 ) if( total > 256 )
{ {
name = (char*)malloc(total+1); name = (char*)malloc(total+1);
} }
strncpy(name, outfile, dotpos); strncpy(name, outfile, dotpos);
/*if (image->numcomps > 1) {*/ sprintf(name+dotpos, "_%d.pgx", compno);
sprintf(name+dotpos, "_%d.pgx", compno); fdest = fopen(name, "wb");
/*} else { /* dont need name anymore */
strcpy(name+dotpos, ".pgx"); if( total > 256 ) free(name);
}*/ if (!fdest)
fdest = fopen(name, "wb"); {
if (!fdest) fprintf(stderr, "ERROR -> failed to open %s for writing\n", name);
{ goto fin;
fprintf(stderr, "ERROR -> failed to open %s for writing\n", name); }
return 1;
}
/* dont need name anymore */
if( total > 256 )
free(name);
fails = 1; w = image->comps[compno].w;
w = image->comps[compno].w; h = image->comps[compno].h;
h = image->comps[compno].h;
fprintf(fdest, "PG ML %c %d %d %d\n", comp->sgnd ? '-' : '+', fprintf(fdest, "PG ML %c %d %d %d\n", comp->sgnd ? '-' : '+', comp->prec,
comp->prec, w, h); w, h);
if (comp->prec <= 8) if (comp->prec <= 8)
nbytes = 1; nbytes = 1;
else else if (comp->prec <= 16)
if (comp->prec <= 16) nbytes = 2;
nbytes = 2; else
else nbytes = 4;
nbytes = 4;
for (i = 0; i < w * h; i++) for (i = 0; i < w * h; i++)
{ {
int v, val = image->comps[compno].data[i]; /* FIXME: clamp func is being called within a loop */
unsigned char byte; const int val = clamp(image->comps[compno].data[i],
comp->prec, comp->sgnd);
for (j = nbytes - 1; j >= 0; j--) for (j = nbytes - 1; j >= 0; j--)
{ {
v = (int)(val >> (j * 8)); int v = (int)(val >> (j * 8));
if(v > 255) v = 255; else if(v < 0) v = 0; unsigned char byte = (unsigned char)v;
byte = (unsigned char)v; res = fwrite(&byte, 1, 1, fdest);
res = fwrite(&byte, 1, 1, fdest);
if( res < 1 ) if( res < 1 )
{ {
fprintf(stderr, "failed to write 1 byte for %s\n", name); fprintf(stderr, "failed to write 1 byte for %s\n", name);
goto fin; goto fin;
} }
} }
} }
fclose(fdest); fdest = NULL; fclose(fdest); fdest = NULL;
} }
fails = 0; fails = 0;
fin: fin:
if(fdest) fclose(fdest); if(fdest) fclose(fdest);
return fails; return fails;
} }
/* -->> -->> -->> -->> /* -->> -->> -->> -->>