walkero
/
openjpeg
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

opj_t1_clbl_decode_processor(): avoid undefined behaviour if roishift >= 31. Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=2506. Credit to OSS Fuzz

This commit is contained in:
Even Rouault 2017-07-29 16:29:11 +02:00
parent 9906fbf737
commit f6551f822f
1 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/lib/openjp2/t1.c
View File

@ -1685,14 +1685,22 @@ static void opj_t1_clbl_decode_processor(void* user_data, opj_tls_t* tls)
cblk_h = t1->h; cblk_h = t1->h;
if (tccp->roishift) { if (tccp->roishift) {
OPJ_INT32 thresh = 1 << tccp->roishift; if (tccp->roishift >= 31) {
for (j = 0; j < cblk_h; ++j) { for (j = 0; j < cblk_h; ++j) {
for (i = 0; i < cblk_w; ++i) { for (i = 0; i < cblk_w; ++i) {
OPJ_INT32 val = datap[(j * cblk_w) + i]; datap[(j * cblk_w) + i] = 0;
OPJ_INT32 mag = abs(val); }
if (mag >= thresh) { }
mag >>= tccp->roishift; } else {
datap[(j * cblk_w) + i] = val < 0 ? -mag : mag; OPJ_INT32 thresh = 1 << tccp->roishift;
for (j = 0; j < cblk_h; ++j) {
for (i = 0; i < cblk_w; ++i) {
OPJ_INT32 val = datap[(j * cblk_w) + i];
OPJ_INT32 mag = abs(val);
if (mag >= thresh) {
mag >>= tccp->roishift;
datap[(j * cblk_w) + i] = val < 0 ? -mag : mag;
}
} }
} }
} }