From 80c57b59f61add88f789b269b99ed50b852ea102 Mon Sep 17 00:00:00 2001 From: "Philip.Hazel" Date: Thu, 6 Sep 2018 15:59:11 +0000 Subject: [PATCH] Minor code fix to avoid static analyzer complaint. --- ChangeLog | 4 ++++ src/pcre2_jit_compile.c | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 780f60c..9394aaf 100644 --- a/ChangeLog +++ b/ChangeLog @@ -185,6 +185,10 @@ repeated conditional subpattern, and can be found to be anchored if the minimum quantifier is one or more. I can't see much use for a repeated anchored pattern, but the behaviour is now consistent. +41. Minor addition to pcre2_jit_compile.c to avoid static analyzer complaint +(for an event that could never occur but you had to have external information +to know that). + Version 10.31 12-February-2018 ------------------------------ diff --git a/src/pcre2_jit_compile.c b/src/pcre2_jit_compile.c index 4bb24e9..32e985b 100644 --- a/src/pcre2_jit_compile.c +++ b/src/pcre2_jit_compile.c @@ -7,7 +7,7 @@ and semantics are as close as possible to those of the Perl 5 language. Written by Philip Hazel Original API code Copyright (c) 1997-2012 University of Cambridge - New API code Copyright (c) 2016-2017 University of Cambridge + New API code Copyright (c) 2016-2018 University of Cambridge ----------------------------------------------------------------------------- Redistribution and use in source and binary forms, with or without @@ -5901,6 +5901,8 @@ for (i = 0; i < 32; i++) } } +if (len == 0) return FALSE; /* Should never occur, but stops analyzers complaining. */ + i = 0; j = 0;